Commit graph

29 commits

Author SHA1 Message Date
David Lynch 87145e818a Edit check: stop an error on save if no reference-needing content added
saveProcessDeferred will only exist if content was actually added. This
wasn't causing any functional issues, just an error in the console after
you save.

This issue was introduced via I1dccc3c.

Bug: T344382
Change-Id: Icb0c29b64d960308343ddbb3f9d2ee641552b814
2023-10-07 17:47:53 +00:00
Ed Sanders 70c116a17a Edit check: Simplify "experience" config to "maximumEditcount"
There's no product need for anything other than an upper limit
on edit count. If one arises in the future we can adjust accordingly,
but better to keep the JSON, and any UI implementation, simple
for now.

Change-Id: I892847ad78b19695f0f0f664002d3c566f7806de
2023-10-03 16:20:51 +01:00
Ed Sanders cba0bf6da1 Edit check: Clean up when VE is deactivated
* Remove the vetags save field handler
* Reject the save process deferred

Bug: T344382
Change-Id: I1dccc3cedcd5bca14f83ea16fdcad567bd641136
2023-09-12 11:37:34 +01:00
David Lynch 80f3ef9531 Edit check config: account-state and experience
Bug: T330112
Change-Id: If713a7edcb71a5ea8123da27a3b1bffc45992ad0
2023-09-11 15:56:42 -05:00
David Lynch 8c47e0ecb0 Update edit check decline reasons and record tags for them
Bug: T329593
Change-Id: Ib8f465c31a6c601545d55bd58a6c1fa78139757a
2023-09-08 15:49:09 +01:00
David Lynch 81ab55407c Instrumentation for edit check features
Also alters the context/inspector names to be reference-specific.

Bug: T324735
Change-Id: I3cc943aa559f622899a8a5d2fbd42265ffe810a8
2023-09-08 15:47:19 +01:00
jenkins-bot 947210e29f Merge "Only trigger edit check when inserted text is in a new paragraph" 2023-09-08 00:08:11 +00:00
jenkins-bot 1711d09374 Merge "Comment edit check logic for pure insertion check" 2023-09-07 17:45:08 +00:00
Ed Sanders 7c403b2c98 Edit check: Turn on when ecenable=1 is set
Bug: T345297
Change-Id: Ie41258dbf87ef9ae00cdf830bf8cb84ed848d0a7
2023-09-05 14:34:20 +01:00
Ed Sanders f2fb29ddbe Only trigger edit check when inserted text is in a new paragraph
Bug: T345121
Change-Id: Iee954045bb2ccf4d177e1b0b3ea0049be3c5c1af
2023-09-01 14:32:07 +01:00
Ed Sanders 80cbe6bf3b Comment edit check logic for pure insertion check
Change-Id: Ie07aef5326eea3018686da6d872360e29712418e
2023-09-01 13:42:57 +01:00
Ed Sanders a59335fac6 Rename config.references to config.addReference
Change-Id: I5e4b70d8bff1e9b26ca78f9f6f8c9ac8d5f7297b
2023-09-01 13:41:52 +01:00
David Lynch cd43f126d1 Edit check configuration system
This creates a message called `editcheck-config.json` which will be
loaded and sent to the `modules/editcheck/config.json` packageFile.

Bug: T330112
Change-Id: Idc58ddf1045fcc0491701a739f3778c8cf4dd955
2023-09-01 13:41:52 +01:00
Ed Sanders 975dc2c237 Add editcheck-references-activated when UI is shown
Bug: T342462
Change-Id: If6303df1a3dde8d6bb288ed04f40f7d43c4b90ae
2023-08-16 17:19:28 +01:00
Ed Sanders 3ece481e71 Implement add a reference edit check
Change-Id: I4cebc5bbaa34300d1c5bb5fde8277269b14779c9
2023-08-16 17:19:28 +01:00
Ed Sanders 4c69113ed8 Edit check: Reduce scope of try block
Change-Id: Ife185999d3a0e084720a7aac4d360d65db08a131
2023-08-16 15:58:27 +01:00
Ed Sanders 3d92231cd1 Edit check: Guard against completeHistory being empty
When the document store has no entries (e.g. an empty page)
we don't initialise completeHistory with a retain transaction.

Bug: T333710
Change-Id: I5cc4ab3ea5f63a7eab804831df62d5c7ce2447e9
2023-08-16 15:57:54 +01:00
jenkins-bot 0f5eedc26f Merge "Only trigger editcheck on pure insertion (remove.length === 0)" 2023-07-07 15:00:34 +00:00
Esanders b33bb734af Revert "Revert "Add tag when reference added to the page""
This reverts commit 235e5aca00.

Reason for revert: Re-applying with fixes

Change-Id: I9dc5a77045ea5f15c90cf84a15815e13dffd5739
2023-07-06 17:50:08 +01:00
Bartosz Dziewoński 235e5aca00 Revert "Add tag when reference added to the page"
This reverts commit d4460219bd.

Bug: T341202
Change-Id: I8e608a5a34a3bb18d1994d5c182c3918e6d6f89d
2023-07-06 11:35:50 +00:00
Ed Sanders d4460219bd Add tag when reference added to the page
Bug: T325713
Change-Id: Ia4abe256c7ffffa749ad6cdb537dd26091ea07da
2023-07-03 15:09:12 +00:00
Ed Sanders d7d344035c Add tag when content added, according to EditCheck heuristic
Bug: T333714
Change-Id: Id806e6d4d856aead4af98d43078c534d4d46c7f0
2023-07-03 14:43:14 +01:00
Ed Sanders fc41331470 EditCheck: Exclude nodes that aren't at the document root (i.e. image captions, table cells)
Bug: T340086
Change-Id: I8f5343f908efb3d39f20be97d132b146115910f9
2023-07-03 14:40:21 +01:00
David Chan 99f7df7702 Only trigger editcheck on pure insertion (remove.length === 0)
Bug: T340088
Change-Id: I3d8fc2a3e7e6df908ca445af85a14c87a73e0ad3
2023-06-22 09:33:58 +08:00
David Chan 418994d4be EditCheck: Filter ranges to CBN interiors
Change-Id: Id3759acd41513ed63ef3370583c111e8b168dd9e
2023-06-08 16:27:01 +01:00
Bartosz Dziewoński f3b792f16f Log TransactionSquasher errors, in case any still occur
Bug: T333710
Change-Id: I49a0b22245307bb94de60776b5786732be72bf54
2023-04-22 10:16:12 +02:00
David Lynch 9d3c048785 EditCheck: catch errors from TransactionSquasher
Bug: T324733
Change-Id: I5076db530fa8af72a336916f8284e6f3348cfd38
2023-04-03 13:12:57 -05:00
Ed Sanders 9bf7e65cd0 Only run edit check on main namespace
Bug: T324730
Change-Id: I1a267c00b5a333c809e81f6000c734c66cd1a803
2023-03-28 19:11:15 +00:00
Ed Sanders 6e77f963e4 Initial edit check tagging
Bug: T324730
Change-Id: I112015809e55da802e3840fdfeaf16a72e090cb3
2023-03-27 22:47:40 +00:00