Commit graph

6278 commits

Author SHA1 Message Date
Alex Monk b9ad2fb406 Don't allow document save if we're already tearing down the surface
Otherwise you get "Uncaught TypeError: Cannot read property 'messages' of null"
if you press the save button late enough in the saving process. The bug refers
to a different error which I have not been able to reproduce.

Bug: 68073
Change-Id: Ia8fa325f1450329b6e0e4ee9af5302aa4857d637
2014-07-16 17:52:00 +01:00
jenkins-bot 97d286aa0f Merge "[BrowserTest] update links test" 2014-07-16 15:27:24 +00:00
Cmcmahon a8c33dfdd7 [BrowserTest] update links test
This may not be the last update, I want to see how this works in
the Jenkins build

Change-Id: Ib2123d030bc13e84099601a858a5f69aee3a03a4
2014-07-16 08:24:22 -07:00
Cmcmahon 8d39658d6c [BrowserTest] update media test for new UI
Change-Id: I35f75b8cb0fac27167d4f949069c48baac499b02
2014-07-16 07:37:36 -07:00
jenkins-bot 726fae1cc8 Merge "Rename "test" folder to "tests"" 2014-07-16 01:06:02 +00:00
Željko Filipin f850ddf73b Rename "test" folder to "tests"
All other repositories have tests in “tests” folder. For more
information see:

http://lists.wikimedia.org/pipermail/qa/2014-July/001663.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001667.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001672.html

Change-Id: Ib1e4fa4b7203bd8217615db1ceac23a329c081f1
2014-07-15 18:00:32 -07:00
jenkins-bot 1c099f4184 Merge "Always initialize data before use" 2014-07-16 00:52:09 +00:00
Cmcmahon 2786af8625 [BrowserTest] Update edit test for new UI
Change-Id: Ib126e2f429695d812bc2af566e21b2934b0f0fe9
2014-07-15 17:21:49 -07:00
Cmcmahon c9646604b0 [BrowserTest] Update bullets test for new UI design
Change-Id: I2dd9076bea844116ca5cb30f7d290081102ed859
2014-07-15 15:54:54 -07:00
Trevor Parscal f30336bc2e Always initialize data before use
LinkNodeInspector was broken when you clicked away/pressed escape, because data was not set.

Normalizing on data being initialized at the top of get*Process methods if used.

Change-Id: I89728ac558545a6f2c325014b6f457ec6bef17b8
2014-07-15 15:49:51 -07:00
jenkins-bot 6f54034e68 Merge "MWImageModel unit tests" 2014-07-15 22:12:13 +00:00
jenkins-bot a9b757a174 Merge "MWTitleInputWidget: Remove prefixColon option and use relative title instead" 2014-07-15 22:10:42 +00:00
jenkins-bot a7f9e955c6 Merge "ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview" 2014-07-15 22:09:10 +00:00
jenkins-bot a5e1cfcf78 Merge "ve.ui.MWExtensionInspector: Prevent from setting impossible content" 2014-07-15 22:09:06 +00:00
Translation updater bot b37a947f78 Localisation updates from https://translatewiki.net.
Change-Id: Ie46b8801476574031135d86cfda2d75e811111be
2014-07-15 22:08:39 +02:00
jenkins-bot 5a367aec52 Merge "Simplify visualeditor-help-title and visualeditor-timeout" 2014-07-15 18:31:31 +00:00
jenkins-bot 74786a31cb Merge "[BrowserTest] Added support for page elements in iframe" 2014-07-15 13:30:43 +00:00
vikassy e3ecff4dcb [BrowserTest] Added support for page elements in iframe
Bug: 62737
Change-Id: Id60c7268dd6e3e4e755bdc53fef7e7d714d4ab0b
2014-07-15 13:26:09 +00:00
Moriel Schottlender 537e751abe MWImageModel unit tests
Change-Id: I87d1383b383e2a7cd6cb38ed51710cc36a59f63e
2014-07-15 12:47:32 +01:00
Trevor Parscal 8ebea5a75b Close the citation dialog after the apply changes button is clicked
Change-Id: If3976389f0a1574fce993f5b79b9b18067a88878
2014-07-14 17:09:24 -07:00
Federico Leva 760fc0e6ca Simplify visualeditor-help-title and visualeditor-timeout
The less repetition and the less undefined concepts where possible,
the more clarity. Suggestions thanks to James' explanations at
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-timeout/en
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-help-title/en

Change-Id: I05857e5287f5f15f0206a8faa46922e7aa7c3c1b
2014-07-15 00:00:59 +00:00
James D. Forrester fbdff76263 Update VE core submodule to master (f2277ea)
New changes:
56de6f5 Localisation updates from https://translatewiki.net.
f8bda64 Widgetise demo menu
6ac48d8 Localisation updates from https://translatewiki.net.
365e131 builderloader: Omit value for boolean "disabled" attribute per HTML5
706e4b3 Prevent double counting of DM nodes in getNodeAndOffset
b141a7d Update OOjs UI to v0.1.0-pre (d2451ac748)
c5b3921 Localisation updates from https://translatewiki.net.
1606983 Update reference to ConfirmationDialog to use MessageDialog

Deletions:
* Styles for ve.ui.MWBetaWelcomeDialog - not needed anymore because
  OO.ui.MessageDialog provides them
* Styles for ve.ui.MWGalleryInspector - not needed anymore because
  ve.ui.MWExtensionInspector provides part of them and the rest are being
  replaced by programatic sizing

Modifications:
* ve.ui.MWLinkTargetInputWidget - Added support for validation and href
  getter
* Split message between tool and dialog title for ve.ui.MWEditModeTool
  and ve.ui.MWWikitextSwitchConfirmDialog

General changes:
* Updated inheritance.
* Added manager param to constructors of dialogs and inspectors.
* Updated use of show/hide with toggle.
* Added meaningful descriptions of dialog and inspector classes.
* Configured dialog and inspector sizes statically.
* Configured dialog action buttons statically.
* Interfaced with OO.ui.ActionSet to control action buttons.
* Moved applyChanges code into getActionProcess methods.
* Always using .next in setup/ready process getters and .first in
  hold/teardown process getters.

Change-Id: Ia74732e6e32c0808eee021f0a26225b9e6c3f971
2014-07-14 23:24:45 +00:00
Translation updater bot 73beda2c10 Localisation updates from https://translatewiki.net.
Change-Id: I1f6a557082525ae68b261079a3b7a890be0e26b2
2014-07-14 22:03:53 +02:00
jenkins-bot 5e5e3680df Merge "[BrowserTest] Fixed language screenshot upload script" 2014-07-14 10:00:32 +00:00
vikassy 7ca18bacb2 [BrowserTest] Fixed language screenshot upload script
Bug: 62737
Change-Id: I7be433f711b422c156da863dbcbd30e089cc67c7
2014-07-14 11:58:07 +02:00
Translation updater bot 1ed589eccd Localisation updates from https://translatewiki.net.
Change-Id: I106d07e16120881cafcd59a0c3cbcd30d44a0e96
2014-07-13 22:25:27 +02:00
Translation updater bot ba3ccd46f8 Localisation updates from https://translatewiki.net.
Change-Id: Ia0436f75950d914826f2bb14b82b4a2e6a8a2d6d
2014-07-12 23:25:05 +02:00
Translation updater bot 9524a58bea Localisation updates from https://translatewiki.net.
Change-Id: I33438e5fb2f431d5d48f2ee78efdb55819db57da
2014-07-11 21:58:18 +02:00
jenkins-bot 8b25cb9717 Merge "generateContents -> generatedContents" 2014-07-10 21:58:42 +00:00
Ed Sanders b1fb9c1b82 generateContents -> generatedContents
Change-Id: Idfe609d0830ba2b29901211f56dd355ddf8ab96e
2014-07-10 22:47:48 +01:00
Alex Monk 3acca7cdf5 Fix cite/template dialogs
I1a7fc7f2 broke cite/template dialog - onDescriptionClick is not defined.
I can't find it anywhere in the VE-MW or OOUI source.
Before my change, it was simply a no-op. But now we try to bind it in a way
that breaks everything. This commit just removes that line since it was
apparently not doing anything.

Bug: 67814
Change-Id: I0b9c3318b3de8530e0ba9e355cd73eb7f70a6b5a
2014-07-10 21:37:07 +01:00
Amir E. Aharoni 8e3b544479 [BrowserTest] Rename *langauge* to *language*
Change-Id: I29886571ae9a0a81f977e75a4c1ae4f4ec69dc7b
2014-07-10 15:15:41 +00:00
jenkins-bot 6d8e900d57 Merge "Replace ve.bind( fn, ... ) calls with fn.bind( ... )" 2014-07-10 14:11:43 +00:00
Alex Monk 5054ee94f8 mw.ViewPageTarget: Remove vesection from URL on save/cancel
Bug: 66237
Change-Id: I1cc34176322cb768d1cb9711407ecdf91b3ca767
2014-07-10 14:02:44 +00:00
jenkins-bot f3d183ddfa Merge "MWTemplatePage: Account for template.title being null" 2014-07-10 13:59:01 +00:00
Alex Monk 51142e8b11 Replace ve.bind( fn, ... ) calls with fn.bind( ... )
Bug: 62762
Change-Id: I1a7fc7f27fa737d17f5c6b3d084ef4a35e4bebc0
2014-07-10 13:54:07 +00:00
Timo Tijhof fd83cafa4b MWTemplatePage: Account for template.title being null
Example:
* Transclusion with html comment in target
  {{ Unsigned <!-- ignored -->  |Example}}.
* Transclusion with wikitext expression as target
  {{ {{echo|Unsigned}} <!-- ignored -->  |Example}}.

The first case was handled already (Parsoid strips the comment
when it normalises the target title). The second case, however,
is not handled and ends in template.title being null.

This was already documented (MWTemplateModel#getTitle returns
{string|null}), but not used correctly.

The title of the dialog is unaffected as it fallsback to
displaying target.wt instead of target.title.

Bug: 66724
Change-Id: Ib6696ac3538f6cb9e93da2f6f8666f373247eeb4
2014-07-10 13:49:41 +00:00
Amir E. Aharoni c970f03b1a [BrowserTest] Add screenshots to .gitignore
It's a directory that is created by the language screenshots scenarios.

Change-Id: Iae7dad5836f0abf22bf7f5f947268295aadddfbd
2014-07-10 13:45:50 +00:00
Translation updater bot 9e26fdf0f7 Localisation updates from https://translatewiki.net.
Change-Id: I06a869c905e84dcd41877a370dd98b0f7ca7843c
2014-07-09 20:37:22 +00:00
jenkins-bot 70d0e1487d Merge "Rephrase visualeditor-parameter-search-more" 2014-07-09 16:58:53 +00:00
Amir E. Aharoni 566a5deddf Rephrase visualeditor-parameter-search-more
"More" is usually used in such context and not "other".

Change-Id: I21f70961761e22bef8dce9f58a2f3b0f88c84b28
2014-07-09 09:49:48 -07:00
jenkins-bot b15f090675 Merge "[BrowserTest] Added support for uploading the language screenshots" 2014-07-09 08:58:03 +00:00
vikassy c41b631348 [BrowserTest] Added support for uploading the language screenshots
To use this script:

*Create an environment variable MEDIAWIKI_API_UPLOAD_URL having API URL
of the site where the images are to be uploaded. (Eg: http://commons.wikimedia.beta.wmflabs.org/wiki/api.php)

*LANGUAGE_SCREENSHOT_CODE environment variable should be set.

Run the upload script by: bundle exec ruby upload.rb

Bug: 62737
Change-Id: I1937aa5f02e3bf587ac65d8d11c3ebbb8b1d0528
2014-07-09 14:22:11 +05:30
Translation updater bot 95fe019286 Localisation updates from https://translatewiki.net.
Change-Id: I816d64f9f3d8aee0beb65387c12381f246744c17
2014-07-08 21:03:07 +00:00
Moriel Schottlender c2c046620b Apply 'original size' to images and enable apply button in ve-MW
Depends on core change I243cff5a2d56db48882c343a8bb91153edd96a43

Bug: 66863
Change-Id: If7914c254b70f4b2b9e2788f5755550eb020b21c
2014-07-08 13:11:07 -04:00
Alex Monk 2669f12289 MWTitleInputWidget: Remove prefixColon option and use relative title instead
See Ie554adef which implements this as a method on mw.Title instead.

Bug: 67386
Change-Id: I0d768fac338aed04fd2c0e4e8da8d556f94a4287
2014-07-07 21:59:12 +00:00
Translation updater bot f30c4d6e8d Localisation updates from https://translatewiki.net.
Change-Id: I3e9a17ff64db4c67ce7de914aedb7933c7a04bf6
2014-07-07 20:22:35 +00:00
jenkins-bot b65d6f5e85 Merge "Clearer test message, as used in core" 2014-07-07 16:48:06 +00:00
Željko Filipin cc6176e57d [BrowserTest] Change interface language with environment variable
Paired with: Vikas Yaligar
Bug: 62737

Change-Id: I3ba97a8b4ab5c881b9fb9bbc24411b6c371320e5
2014-07-07 11:04:37 +02:00
Translation updater bot 1aa6ca1dc2 Localisation updates from https://translatewiki.net.
Change-Id: Ia9ec82e0eb5d0d6fe29fa3e90a7696512286782c
2014-07-06 19:56:16 +00:00