wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 04:06:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
11369 commits 153 branches 1 tag 185 MiB
Commit graph

4588 commits

Author SHA1 Message Date
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net. 
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
 2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method 
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
 2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net. 
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
 2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl 
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
 2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message 
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
 2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net. 
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
 2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00
James D. Forrester d8769edd01 MWWelcomeDialog: Let the user switch editors 
Change-Id: If88942d866278f3012dae7972d464a3d2a6a4f82
 2016-01-27 00:14:07 +00:00
jenkins-bot fc43d61ec5 Merge "MWTargetWidget: Add missing indent commands to blacklists" 2016-01-26 23:53:51 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists 
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
 2016-01-26 23:46:12 +00:00
James D. Forrester 2c76dc5b50 MWEditingTabDialog: Use 'small' size 
Change-Id: Icb30d4fbea21653cf2fb6c782a4314be97a3e0a2
 2016-01-26 14:51:55 -08:00
jenkins-bot 75b0a8de63 Merge "Don't try to load VE over the top of the wikitext editor we just switched to" 2016-01-26 17:01:24 +00:00
Alex Monk 589437a772 Don't try to load VE over the top of the wikitext editor we just switched to 
(if we discarded changes)

Bug: T124316
Change-Id: Ic5e6ee8f4b6e75c3ae877021bcb29733b881e6d2
 2016-01-26 16:49:50 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. 
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
 2016-01-26 16:47:26 +00:00
Alex Monk bfa15c44a5 Check user preferences before loading VE on-load on action=edit/submit etc. 
Bug: T124743
Change-Id: I2e8a19014464a2b7fb76de08676e7cb808e06956
 2016-01-26 02:48:27 +00:00
Translation updater bot 71c0473094 Localisation updates from https://translatewiki.net. 
Change-Id: I159863f04ee8af735dde305b24d8f5cd0a5c8b2b
 2016-01-25 22:33:02 +01:00
jenkins-bot 6666bfcaea Merge "MWTableNode: Mixin ve.ce.ClassAttributeNode" 2016-01-25 20:54:15 +00:00
Ed Sanders ba0b084813 MWTableNode: Mixin ve.ce.ClassAttributeNode 
The DM side already had the mixin, the CE side was still using custom
logic that has since been moved to ce.ClassAttributeNode.

This fixes the issue of tables not getting the wikitable class in VE
as it was only applied on attribute change previously, which never happened.

Change-Id: I197347762fc9228034f7664484539e5888722bcf
 2016-01-25 16:35:49 +00:00
Translation updater bot 8e5a9e71a9 Localisation updates from https://translatewiki.net. 
Change-Id: I401186574b88f3c5c810644799b55f2af5740f8c
 2016-01-24 21:22:34 +01:00
Translation updater bot d246540ccf Localisation updates from https://translatewiki.net. 
Change-Id: Ie90b5f4eb9a6303d4374b99c98c0dfeb8e595fbc
 2016-01-23 22:30:32 +01:00
jenkins-bot d29524c8b3 Merge "When loading VE from action=edit/submit, replace the title shown" 2016-01-22 20:43:02 +00:00
Alex Monk 38180b5d4d When loading VE from action=edit/submit, replace the title shown 
Bug: T117643
Change-Id: Ice21389d02ea10adc668c5b0a64ba2b0b9cf5744
 2016-01-22 20:27:01 +00:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste 
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
 2016-01-22 20:13:26 +00:00
jenkins-bot e6c61052a0 Merge "MWTableNode: Apply wikitable class to pasted tables" 2016-01-22 19:10:41 +00:00
Ed Sanders bf50e2a570 MWTableNode: Apply wikitable class to pasted tables 
Bug: T85577
Change-Id: I9714cf3e8ccc165f91af939481c845c3ec9c5f6b
 2016-01-22 18:43:47 +00:00
Thalia 16330ac05d Add method for setting minimum number of rows in Ace editor widget 
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
 2016-01-22 17:05:35 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net. 
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
 2016-01-21 21:56:24 +01:00
Translation updater bot 27261322b4 Localisation updates from https://translatewiki.net. 
Change-Id: I6f9e970a0cb80e33849c67d1a850ce019cdcd76e
 2016-01-20 21:09:24 +01:00
jenkins-bot 3bc62ba61d Merge "SaveDialog: Fix alignment of checkboxes" 2016-01-20 18:36:46 +00:00
Translation updater bot 5b95d6c1e6 Localisation updates from https://translatewiki.net. 
Change-Id: I5b3ed86498fcc81cb448d056d32b53cb9a15a579
 2016-01-19 21:22:21 +01:00
Ed Sanders 74e4450c92 SaveDialog: Fix alignment of checkboxes 
Change-Id: Ia7718e7cebe7c533a76533dc82bcf93f8da49d15
 2016-01-19 16:40:32 +00:00
jenkins-bot ee70cc5c44 Merge "Single Edit Tab: simplify logic; make 'prefer-wt' just disabled" 2016-01-18 21:28:26 +00:00
Translation updater bot 9b0ba61924 Localisation updates from https://translatewiki.net. 
Change-Id: I45ba38e70875a2e7783144aa0756f4bc8989c835
 2016-01-18 21:38:20 +01:00
James D. Forrester aa08d34318 Single Edit Tab: simplify logic; make 'prefer-wt' just disabled 
Change-Id: I090375933656f29636c355c4d2ce358dd7f7f074
 2016-01-18 11:23:59 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links 
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
 2016-01-18 03:06:33 +00:00
Translation updater bot f0b2ce2ded Localisation updates from https://translatewiki.net. 
Change-Id: If3cb31818a635b6f5b4ac4796fced777f5517dd0
 2016-01-17 22:35:39 +01:00
Translation updater bot 81a33e1ddc Localisation updates from https://translatewiki.net. 
Change-Id: If2e5f3a07d289d3575ada8cc712b80ed11e2f532
 2016-01-16 21:59:41 +01:00
Translation updater bot 5a8b1c294e Localisation updates from https://translatewiki.net. 
Change-Id: I1653aca5124b19dbd879d82196ec381070ccce13
 2016-01-14 22:26:26 +01:00
Translation updater bot 6606c25902 Localisation updates from https://translatewiki.net. 
Change-Id: I913124a4a85545e9abc179a225ec3ee5746bda11
 2016-01-13 23:32:14 +01:00
Translation updater bot cec85b9e3c Localisation updates from https://translatewiki.net. 
Change-Id: I76a506a5fb58dee87fd3459d557b29190ad7e777
 2016-01-12 22:49:13 +01:00
Translation updater bot c37fbf1f70 Localisation updates from https://translatewiki.net. 
Change-Id: Ie52c778d1291121d3d78dcae9ae8a5d23d5c27b8
 2016-01-11 22:55:11 +01:00
Translation updater bot 946163d758 Localisation updates from https://translatewiki.net. 
Change-Id: Ib5d617cc8a22b6c5e5248c3a374d10d08cd3434f
 2016-01-10 23:15:09 +01:00
Translation updater bot f26501b4f6 Localisation updates from https://translatewiki.net. 
Change-Id: I6c324c98c20cc8d4b7b1b51f7eec5b5a608eee2b
 2016-01-08 22:22:26 +01:00
Translation updater bot d1386ae5b8 Localisation updates from https://translatewiki.net. 
Change-Id: Icf5edd18f9fa08c0ff63808c750b2f64698066bf
 2016-01-07 23:39:13 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests 
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
 2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references 
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
 2016-01-06 17:07:35 -08:00
Translation updater bot 739b4c796d Localisation updates from https://translatewiki.net. 
Change-Id: I406227f147f21b4deed2a5a6e9f556e84cd32a65
 2016-01-06 21:56:55 +01:00
Translation updater bot 94126edb04 Localisation updates from https://translatewiki.net. 
Change-Id: I1d7295d5aee0dd72a7469c6467b12177187988dc
 2016-01-05 22:31:09 +01:00
Translation updater bot b3a11a9325 Localisation updates from https://translatewiki.net. 
Change-Id: I79bdcd360cf4c879b8344f75af927fdfac89dcd2
 2016-01-04 22:38:41 +01:00
jenkins-bot 3591a0e63d Merge "Education popups: Only show for DesktopArticleTarget" 2016-01-04 20:00:58 +00:00
Ed Sanders e7ee5c20c6 Education popups: Only show for DesktopArticleTarget 
For now they are not well supported by other targets
(e.g. Flow and Mobile).

Change-Id: Ibd1f3c8994611661b52c0cf36438b41f623b9451
 2016-01-04 10:43:43 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
jenkins-bot e59e36e225 Merge "Refactor MediaResources(Provider/Queue)" 2016-01-03 22:55:39 +00:00
James D. Forrester 4a781a3a16 EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name 
Change-Id: Idd5f373d9fef364318efddcc98ea2de5e91860a8
 2016-01-03 13:44:54 -08:00
Translation updater bot 93b4a43b18 Localisation updates from https://translatewiki.net. 
Change-Id: I26cf69fe5f4593ca22c9a170fd16fb02549b187e
 2016-01-03 21:45:19 +01:00
Alex Monk 85bb085418 DesktopArticleTarget: Preserve oldid when switching from WTE into VE 
Change-Id: I8682a2a2b90ae2e42f1a8e01e16d0f9f3d66a2d5
 2016-01-03 10:59:21 -08:00
jenkins-bot 26e3c0ad1d Merge "Preserve oldid when switching from VE into WTE" 2016-01-03 06:35:58 +00:00
Translation updater bot f80e0c7482 Localisation updates from https://translatewiki.net. 
Change-Id: I58460ed4632db989f00464d0401a7bba5cd072da
 2016-01-01 20:07:11 +01:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net. 
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
 2015-12-30 21:46:23 +01:00
Željko Filipin 2cfaa9528c [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version 
Bug: T114241
Change-Id: Ic6cf69516a1e36173fbbf6b86494e845721a19d0
 2015-12-30 11:46:23 +00:00
Translation updater bot 8eca31d729 Localisation updates from https://translatewiki.net. 
Change-Id: I8c80187c5efb9b45b2a0df338a778a6074d467ac
 2015-12-28 21:05:28 +01:00
Translation updater bot 7dcba8dbf4 Localisation updates from https://translatewiki.net. 
Change-Id: I03f05bd052a77b75d731994fb8b247d21dff1077
 2015-12-27 20:38:22 +01:00
Translation updater bot ac555fd695 Localisation updates from https://translatewiki.net. 
Change-Id: If3e7e7050a93934732703d239b76c3b7c31069cb
 2015-12-26 21:12:39 +01:00
Translation updater bot 97dd3ee12d Localisation updates from https://translatewiki.net. 
Change-Id: I491b5cdaa05e954fffc5c11e6db6e12629064893
 2015-12-25 21:55:54 +01:00
jenkins-bot 3231220774 Merge "SET: Don't try to do any client-side section link magic if we're not supposed to." 2015-12-23 23:18:57 +00:00
Alex Monk 76cb69ecec SET: Don't try to do any client-side section link magic if we're not supposed to. 
Ugh.

Bug: T121599
Change-Id: I47a93d5dbedc5ae989a2973fb793ac99edfb139a
 2015-12-23 22:10:20 +00:00
Translation updater bot fa66daef6c Localisation updates from https://translatewiki.net. 
Change-Id: Ie2040e33f23c85fc0f6a2a66773c67c30aa6ac83
 2015-12-23 22:08:06 +01:00
Ed Sanders 2afd7c903d DesktopArticleTarget: Improve teardown sequence 
* Ensure activating classes are removed by rejecting activatedDeferred
  as soon as teardown starts.
* Try to teardown surfaces is surfaces exist, not just if the target is active.
* Remove noop teardownDebugBar. The debugbar lives inside the surface now.
* Ensure progress bar is always reset, even if target setup is aborted.

Bug: T99139
Change-Id: I16a071c0d4bc8bbc6af2e03e63ee0ffc18d55c75
 2015-12-23 12:13:50 +00:00
Translation updater bot 9cc9b8f1a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia72cf64c778cf9ab82f24700ec90e404bd0f9432
 2015-12-22 22:12:49 +01:00
Ed Sanders 93f0e8b30c Refactor MediaResources(Provider/Queue) 
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.

Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
 2015-12-22 14:00:10 +00:00
Translation updater bot dd85041a29 Localisation updates from https://translatewiki.net. 
Change-Id: I66a72ca80277579be5674cbeb0794a70c7093345
 2015-12-21 22:07:16 +01:00
Translation updater bot 39d762e844 Localisation updates from https://translatewiki.net. 
Change-Id: I9de2feb735f9c722d941e7fdac53f4ee241ad9ad
 2015-12-20 22:36:27 +01:00
jenkins-bot 7c1660c933 Merge "Make Ace Editor adjustSize method chainable" 2015-12-20 12:56:03 +00:00
jenkins-bot 7da9dc409f Merge "ReferenceEducationPopup: Don't flip the numbers in the RTL image" 2015-12-19 15:06:24 +00:00
Florian 5627701cb1 Fix inheritance of ve.ui.MWTransclusionDialogTool 
From the description of the commit message[1] for WindowTool and
FragmentWindowTool, the ve.ui.MWTransclusionDialogTool should be
a FragmentWindowTool, and not a WindowTool.

In fact, the bug is caused by the missing isCompatibleWith method
in WindowTool.

[1] I3a0e761f0d6e942d503ec

Follow up: I676af9c50b09ef007926240eb2327d1a0fdd80f5

Bug: T121596
Change-Id: I9a47e5d67fcd7a94155b7cf77c734c94b0ed69e1
 2015-12-19 11:52:44 +00:00
Thalia f8fbbdf66d Make Ace Editor adjustSize method chainable 
Change-Id: I48307bd9184bb238a553d178c0d66084244e9ebf
 2015-12-19 10:57:04 +00:00
Translation updater bot c747c06759 Localisation updates from https://translatewiki.net. 
Change-Id: I6ee493d00d8fd9ad8ea4fc4efbf7513be9765d07
 2015-12-18 23:39:12 +01:00
Alex Monk c10236cc58 Preserve oldid when switching from VE into WTE 
Bug: T120898
Change-Id: I51774fd7ca5be7373d8aec55cb420a874bc7d531
 2015-12-18 00:47:03 +00:00
Translation updater bot a9637adf2d Localisation updates from https://translatewiki.net. 
Change-Id: Ic62f7e83d426f1e5872cd0597d54458d851490ad
 2015-12-17 22:46:49 +01:00
Translation updater bot 4e2d06605e Localisation updates from https://translatewiki.net. 
Change-Id: If7ed2349bec27df44a387cfca605de7e1f75873d
 2015-12-16 22:37:19 +01:00
jenkins-bot 607878e2ba Merge "MWTarget: Only add ve-init-mw-target-surface to the main target surface" 2015-12-16 20:06:33 +00:00
jenkins-bot 6b7fc00f68 Merge "DesktopArticleTarget: Change tab text on server side when possible" 2015-12-16 19:51:03 +00:00
Ed Sanders a689caa762 MWTarget: Only add ve-init-mw-target-surface to the main target surface 
Avoid adding it to TargetWidget surfaces.

Bug: T121450
Change-Id: I7c43b07c5bade3a778ad423e39b25616e03aa888
 2015-12-16 14:36:06 +00:00
jenkins-bot 46c2cafdf6 Merge "ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing" 2015-12-16 06:44:45 +00:00
Translation updater bot b02b68626a Localisation updates from https://translatewiki.net. 
Change-Id: I2bcafc960dedf619d0c81163a7a75253b377a79d
 2015-12-15 22:25:56 +01:00
Alex Monk c99a5b627e DesktopArticleTarget: Change tab text on server side when possible 
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.

Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
 2015-12-15 10:49:45 -08:00
Alex Monk 76a12f2f9b Try to actually resolve visualeditor-editor preference setting when switching editors 
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743.

Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
 2015-12-15 17:35:22 +00:00
Ed Sanders f87d92a167 ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing 
Otherwise temporary changes to the previewNode will pollute the original
doc's model tree.

Bug: T121488
Change-Id: I6a6b3d904061b0ce6e0c513ad424aabc3c4472b5
 2015-12-15 14:40:07 +00:00
jenkins-bot b08c8bd682 Merge "Fix up "Simplify some SET logic"" 2015-12-15 02:56:45 +00:00
Alex Monk 39af893c75 Fix up "Simplify some SET logic" 
By 'simplifying', I broke stuff.

This reverts commit b7227f96fe.

Change-Id: I46fdcf336f556680fa72df0893447b6850cc4b1d
 2015-12-15 02:50:15 +00:00
jenkins-bot d3d851f394 Merge "Simplify some SET logic" 2015-12-14 21:17:15 +00:00
Alex Monk b7227f96fe Simplify some SET logic 
Change-Id: Ie89260607f0253dd7d749af7426702985a0340f4
 2015-12-14 21:11:15 +00:00
Translation updater bot 0200bbf328 Localisation updates from https://translatewiki.net. 
Change-Id: I43deefad46e60797eda66e10c37eed67a61c141b
 2015-12-14 22:06:23 +01:00
jenkins-bot 33cbf199f1 Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"" 2015-12-14 20:53:28 +00:00
Jforrester 40807a0743 Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 
This reverts commit 5b083a7272.

Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
 2015-12-14 20:46:08 +00:00
Bartosz Dziewoński ca81362afd ve.ui.MWMediaDialog: Make the dialog higher (600px) 
Avoids a scrollbar for option 4 of the A/B test from T120867.

Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
 2015-12-14 20:53:32 +01:00
jenkins-bot d750417545 Merge "Take pageCanLoadVE into account when figuring out whether VE will load in-page or not" 2015-12-14 17:14:41 +00:00
jenkins-bot 04d8089db6 Merge "Fix setEditorPreference call" 2015-12-14 17:08:42 +00:00
Alex Monk 774034b553 Take pageCanLoadVE into account when figuring out whether VE will load in-page or not 
Bug: T121342
Change-Id: I84ade6e2ab062597fbfd859a90a864c7607547da
 2015-12-14 16:58:26 +00:00
Alex Monk a3148a1559 Fix setEditorPreference call 
Added brokenly in I82e39752

Bug: T121343
Change-Id: Ie7b228e94458b17d6ec7c23be264144dec9563be
 2015-12-14 16:49:28 +00:00
jenkins-bot 51d493918b Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 2015-12-14 16:46:02 +00:00
jenkins-bot 648457ca4c Merge "Switch numbered link context to "delete" instead of "clear"" 2015-12-14 01:19:22 +00:00
Translation updater bot a6bab3aeff Localisation updates from https://translatewiki.net. 
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
 2015-12-13 22:24:39 +01:00
James D. Forrester 5b083a7272 DesktopArticleTarget: Don't abort in SET mode if veswitched is set 
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
 2015-12-11 18:15:25 -08:00
James D. Forrester 2368171fb7 DesktopArticleTarget: Consolidate editor preference setting code 
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
 2015-12-11 17:12:28 -08:00
Alex Monk 0774bdf924 Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks 
To use
	.then( function ( opened ) { return opened; } )
	.then( function ( closing ) { return closing; } )
	.then( function ( data ) {
etc. instead of nesting them in .done functions

Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
 2015-12-11 23:43:13 +00:00
Alex Monk 155d0240a4 Remember switching into VE from WT when discarding changes 
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
 2015-12-11 23:35:59 +00:00
Alex Monk 9e5a01aa6b Check that we really want VE before loading it for section edits 
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
 2015-12-11 23:19:07 +00:00
Translation updater bot e71f1d67d6 Localisation updates from https://translatewiki.net. 
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
 2015-12-11 23:56:38 +01:00
jenkins-bot e24e2ed7cf Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class" 2015-12-11 18:16:22 +00:00
jenkins-bot 2e6719c0d7 Merge "Use upstreamed actionGroups functionality" 2015-12-11 18:09:50 +00:00
Ed Sanders aa2e0af348 Update VE core submodule to master (19e50b7) 
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets

Local changes:
* Refactor tools for the breaking change

Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
 2015-12-11 10:03:02 -08:00
Ed Sanders fbb05fb8ed Use upstreamed actionGroups functionality 
Depends on I272175dff3 in ve core.

Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
 2015-12-11 16:43:48 +00:00
Ed Sanders 21d5856000 [BREAKING CHANGE] Create ve.init.mw.Target base class 
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).

Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.

Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
  to our own events.
* Rename onReady to documentReady. onReady is not a listener.

Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
 2015-12-11 16:41:47 +00:00
Ed Sanders 672c91f41b DesktopArticleTarget: Fix signature of editNotices 
Also ensure it is always an array.

Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
 2015-12-11 16:41:47 +00:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up 
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
 2015-12-10 23:13:25 +00:00
jenkins-bot 69778a65e5 Merge "Let the feedback tool be configured for a remote wiki" 2015-12-10 22:04:23 +00:00
Translation updater bot 46b901e640 Merge "Localisation updates from https://translatewiki.net." 2015-12-10 22:02:32 +00:00
Translation updater bot 536ff00e5a Localisation updates from https://translatewiki.net. 
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
 2015-12-10 23:01:35 +01:00
jenkins-bot 3db4f22ecf Merge "MWSaveDialog: De-flag the 'return to save' button on diffs" 2015-12-10 21:51:01 +00:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki 
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
 2015-12-10 12:12:59 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget 
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
 2015-12-10 16:26:20 +00:00
Alex Monk 128901866a Don't check editor preferences etc. if user wants veaction=edit 
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
 2015-12-09 23:04:02 +00:00
jenkins-bot 212300af1f Merge "Avoid useless jQuery.click shortcut" 2015-12-09 22:18:12 +00:00
Translation updater bot d08da2d62f Localisation updates from https://translatewiki.net. 
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
 2015-12-09 21:43:17 +01:00
David Lynch e9fbb38818 Switch numbered link context to "delete" instead of "clear" 
Bug: T120705
Change-Id: I305a0469df8ca3fd75bcd371cf9b9f8894c09f7e
 2015-12-09 12:42:20 -06:00
Ed Sanders e7ccc77000 Edit mode switching: Tell VE if the wikitext was modified 
Currently we assume that any document state from WE is modified
but that is not necessarily the case.

Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
 2015-12-09 17:44:43 +00:00
Ed Sanders e9250d87fd Avoid useless jQuery.click shortcut 
Why have one event API when you can have ten...

Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
 2015-12-09 17:34:00 +00:00
jenkins-bot a9894809f6 Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode" 2015-12-09 17:16:12 +00:00
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode 
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
 2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos 
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
 2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node 
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
 2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's 
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
 2015-12-09 15:56:08 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo 
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
 2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs 
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
 2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net. 
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
 2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links 
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
 2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net. 
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
 2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there 
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
 2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00
Ed Sanders a917871505 GalleryInspector: Use namespace id constant 
Change-Id: Ia51634e84cf984d8ed4ecdab87590111bf12478f
 2015-12-07 18:49:53 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget 
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
 2015-12-07 14:12:56 +00:00
Translation updater bot 83620175ca Localisation updates from https://translatewiki.net. 
Change-Id: I3d109b133ee6d709a937013bb9eb825800c98775
 2015-12-06 21:45:56 +01:00
Translation updater bot db13a4d43a Localisation updates from https://translatewiki.net. 
Change-Id: I0d6dede3ef71b7729db66646875c308d50296d81
 2015-12-05 23:16:10 +01:00
Ed Sanders 63184600d4 Use wgNamespaceIds constants instead of hard-coded numbers 
Change-Id: I71b80e59a5e24d63e68637a1ae8422974643bd3a
 2015-12-04 19:57:56 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net. 
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
 2015-12-03 23:17:58 +01:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox 
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
 2015-12-02 18:28:18 -08:00
Translation updater bot 7e50ac1ab6 Localisation updates from https://translatewiki.net. 
Change-Id: I2180bc4edca07261381b2790af6ebc29e0fde97f
 2015-12-02 22:01:03 +01:00
Translation updater bot d924ded91e Localisation updates from https://translatewiki.net. 
Change-Id: Ia694075416ebb62d351441419089d2570943ccf8
 2015-12-01 21:37:34 +01:00
Translation updater bot 3772e473d5 Localisation updates from https://translatewiki.net. 
Change-Id: I4133263c6d9228e867cb54be4b706e8f21a2bbc1
 2015-11-30 21:38:08 +01:00
jenkins-bot e24eaea22c Merge "Avoid embedding Git metadata in ext.visualEditor.data" 2015-11-30 11:48:28 +00:00
Ori Livneh b1db8349fe Avoid embedding Git metadata in ext.visualEditor.data 
Partially reverts "Expose version information in the client" (a72099af66 / I7836e1d40).
The Git data oscillates between two values due to differences between the
staging and production environments. Each change causes the module version to
change also, leading to cache churn.

Instead fetch version information with an API call the first
time the help popup is opened.

Bug: T119750
Change-Id: Ib9c45e60d3164cfa85eb1ef247cc91cf0d8bf954
 2015-11-30 12:34:56 +01:00
Translation updater bot 24046cb548 Localisation updates from https://translatewiki.net. 
Change-Id: I24ccb4b7af6241ed77eb47970d821262454ac26e
 2015-11-28 21:49:42 +01:00
Translation updater bot 1b176cba81 Localisation updates from https://translatewiki.net. 
Change-Id: I459d7ee237ffa2ba146bbd82059e5e22f92234b5
 2015-11-27 22:48:54 +01:00
Translation updater bot b367964ad6 Localisation updates from https://translatewiki.net. 
Change-Id: I57f93b07e2179ec7cbb75866094dd98f64b54f9c
 2015-11-26 22:06:32 +01:00
jenkins-bot 2a46cc7873 Merge "Add autocomplete options to AceEditorWidget config options" 2015-11-25 03:48:38 +00:00
Thalia 3d98b1d291 Add autocomplete options to AceEditorWidget config options 
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
 2015-11-24 19:44:41 -08:00
jenkins-bot 4655ba4c5c Merge "MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one" 2015-11-25 02:53:36 +00:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one 
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
 2015-11-24 18:40:13 -08:00
Translation updater bot 0bfa4b7001 Localisation updates from https://translatewiki.net. 
Change-Id: I4894709e82769d5161cf39a6488ae1666d5690d6
 2015-11-24 23:12:39 +01:00
Ed Sanders bbdb48abdf Create MWPreviewElement which adds the mw-body-content class 
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).

Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
 2015-11-23 14:28:57 -08:00
Translation updater bot 23270f87f9 Localisation updates from https://translatewiki.net. 
Change-Id: I045fa54ee959371101a2fc62238d8b10ccb348b0
 2015-11-23 22:36:41 +01:00
jenkins-bot 22a8c76d09 Merge "When adding a label to a numbered link, force the selection" 2015-11-23 19:02:04 +00:00
jenkins-bot 5649256ceb Merge "Re-fix in-page loading" 2015-11-23 17:00:13 +00:00
jenkins-bot 4616696e0d Merge "Prevent switching from unedited section directly into VE" 2015-11-23 17:00:08 +00:00
Translation updater bot 7698beb14e Localisation updates from https://translatewiki.net. 
Change-Id: I8bde2353b3bb3f950a329f033b87602b107bd722
 2015-11-22 20:48:25 +01:00
David Lynch 50759e2064 When adding a label to a numbered link, force the selection 
Otherwise the selection will/won't contain the opening node of the
link, depending on where in the paragraph it is. This makes the
experience of starting to type unpredictable to the user. By forcing
it to always have the contents of the node selected, typing always
just updates the label.

Bug: T114643
Depends-On: I7c46a917d9752145174919f41066b4841b203218
Change-Id: Ic1c573c2c28ced49f685ec6082506cb20d5163cd
 2015-11-20 18:36:44 -06:00
Ed Sanders 0e30e328ba Update VE core submodule to master (e8c6f7d) 
New changes:
b44ef6d [BREAKING CHANGE] Fix WhitespacePreservingTextInputWidget API
96e4034 Localisation updates from https://translatewiki.net.

Local changes:
* Use new WhitespacePreservingTextInputWidget API

Change-Id: I9920a3b5c8c3e8a241dcfdd1bde20f4ea1cf78b6
 2015-11-20 15:44:49 -08:00
jenkins-bot 5dbe119699 Merge "MW Examples: Fix test message" 2015-11-20 23:38:56 +00:00
jenkins-bot 77f605d2a5 Merge "Add tests for RESTBase ID comparison" 2015-11-20 23:38:53 +00:00
jenkins-bot 8200cffac5 Merge "Improve tests of data-parsoid annotation comparisons" 2015-11-20 23:37:50 +00:00
Translation updater bot 3523279808 Localisation updates from https://translatewiki.net. 
Change-Id: I8658191225f986b896358ebdd98fdefacb143ca0
 2015-11-20 22:59:51 +01:00
Ed Sanders 68755b212e MW Examples: Fix test message 
Change-Id: I4a0b9bb92fa45fca82391943b86a43fec8f2e3a1
 2015-11-20 20:34:18 +00:00
Ed Sanders 287436ae25 Add tests for RESTBase ID comparison 
Depends on I8323bbf34 in core.

Change-Id: I4043322361cdbbfd211133191c062eae42269ca4
 2015-11-20 20:34:12 +00:00
Ed Sanders 3d7d363e9c Improve tests of data-parsoid annotation comparisons 
So that it actually fails if you remove the key feature.

Depends on Iff15190e in core.

Change-Id: I1557f683241193aa4a97e04af0b4daf244a8b121
 2015-11-20 12:32:29 -08:00
Ed Sanders bbfcbeb79d Use ES5 trim instead of jQuery 
Change-Id: I6e8b958176385cb672380454fcc3b4970261caa9
 2015-11-20 11:48:55 -08:00
James D. Forrester 285eb85eb8 ReferenceEducationPopup: Don't flip the numbers in the RTL image 
Bug: T117949
Change-Id: Ia4164773a9c4f1510b8795efb4c93260a3abe672
 2015-11-19 19:31:21 -08:00
Alex Monk a0462d69d4 Re-fix in-page loading 
Probably broken by Ie808bcaa
Partially reverts Icad04dac, hopefully without any regressions

Change-Id: I4589bde7eac58b54027a6b9dbe6ecddf79780599
 2015-11-20 01:57:24 +00:00
Alex Monk 67a51aee9b Prevent switching from unedited section directly into VE 
Bug: T117713
Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
 2015-11-20 00:10:38 +00:00
Translation updater bot 360cdacd4b Localisation updates from https://translatewiki.net. 
Change-Id: Iabd0b1ea673697111e28cd959bdf1bca32f72ad6
 2015-11-19 21:41:49 +01:00
jenkins-bot 8fae033411 Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs" 2015-11-19 16:47:13 +00:00
Ed Sanders dbdae59128 AceEditorWidget: Ensure loadingPromise is set when setupEditor runs 
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
 2015-11-18 23:11:10 -08:00
jenkins-bot 9f1aedbefc Merge "Make selectRange method of AceEditorWidget focus the input" 2015-11-19 03:28:44 +00:00
Thalia 18448bb42b Make selectRange method of AceEditorWidget focus the input 
The selectRange method does this in TextInputWidget, so it
should here too.

Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
 2015-11-18 19:14:50 -08:00
jenkins-bot 718e06cf1b Merge "Add method to toggle the AceEditorWidget print margin" 2015-11-18 21:46:44 +00:00
Thalia 21fd89ba3c Add method to toggle the AceEditorWidget print margin 
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
 2015-11-18 13:38:41 -08:00
Translation updater bot a09b6e3a20 Localisation updates from https://translatewiki.net. 
Change-Id: I2affa2a7543343d7f5899b5b55e1cb7e0a954c92
 2015-11-18 22:01:07 +01:00
jenkins-bot 52f151193a Merge "Make focus method of AceEditorWidget chainable" 2015-11-18 20:29:48 +00:00
Thalia 88d466ba23 Make focus method of AceEditorWidget chainable 
The focus method of InputWidget and other descendants
of InputWidget is already chainable

Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
 2015-11-18 12:21:44 -08:00
Ed Sanders bd40f62c17 Introduce MWExtensionPreviewDialog 
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.

Depends on Icd622e15cd7 in VE core.

Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
 2015-11-18 19:33:32 +00:00
jenkins-bot d5562830fd Merge "MWSignatureTool: Restrict command to linear selections" 2015-11-18 06:17:56 +00:00
Ed Sanders 259ec31ece MWSignatureTool: Restrict command to linear selections 
Change-Id: If6109c2ef2a18eccaccf18bd1d76c272a1dc3cd5
 2015-11-17 22:08:23 -08:00
jenkins-bot 761ecc96f4 Merge "AceEditorWidget: Implement getRange" 2015-11-18 06:04:27 +00:00
jenkins-bot 2104ee1590 Merge "Wikitext paste: Fail if result has no visible content" 2015-11-18 03:39:52 +00:00
jenkins-bot df9b4b05b9 Merge "Edit mode switching: Auto-close jQuery.UI dialogs before switching" 2015-11-18 03:36:31 +00:00
Ed Sanders f9ca524ef9 Wikitext paste: Fail if result has no visible content 
For example if '[[category:foo]]' is pasted.

Bug: T118191
Change-Id: I9c51846414dd6b885b33f1dc9076edadbc6464c4
 2015-11-18 03:33:14 +00:00
Ed Sanders a5d700807a AceEditorWidget: Implement getRange 
Depends on I109a666679 in OOUI.

Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
 2015-11-18 03:32:54 +00:00
Ed Sanders e1d14099e0 Image/gallery icons: Rename and use new upstream versions 
Depends on oojs-ui > 0.13.2.

Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
 2015-11-18 01:49:31 +00:00
Ed Sanders 19034b0416 Edit mode switching: Auto-close jQuery.UI dialogs before switching 
Bug: T118282
Change-Id: I7960e4f71dd8b710f2ec2430f2946679af07012b
 2015-11-17 17:26:01 -08:00
jenkins-bot 370a060ffc Merge "AceEditorWidget: Implement selectRange" 2015-11-17 23:49:46 +00:00
jenkins-bot 4785177791 Merge "Make dependencies of jquery.uls.data more specific" 2015-11-17 23:44:07 +00:00
jenkins-bot a40c0082b0 Merge "Make 'moment' a dependency of just 'mwimage', not all of VE-MW" 2015-11-17 23:42:36 +00:00
Ed Sanders 5e96050b48 AceEditorWidget: Implement selectRange 
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.

Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
 2015-11-17 23:39:33 +00:00
Ed Sanders d1da56a6cb Make dependencies of jquery.uls.data more specific 
Change-Id: I135defffc71d8aa61dc74bb871da96737a3eeb0c
 2015-11-17 15:34:23 -08:00
Ed Sanders b5c16ac95c Make 'moment' a dependency of just 'mwimage', not all of VE-MW 
Change-Id: I23c193bfb34203aa6f2ef1d3633c208e5c692c97
 2015-11-17 14:55:10 -08:00
Translation updater bot b4f2194085 Localisation updates from https://translatewiki.net. 
Change-Id: I15540a448677ac4e4b6a0eba024e230ce4846b22
 2015-11-17 21:55:40 +01:00
Alex Monk 889358f24c Ensure we always catch the wikiEditor-toolbar-doneInitialSections event 
Don't wait for module loading. Before, this was only actually working half the
time.

Change-Id: I7fb284a800927672642c59231a322982b613f16b
 2015-11-17 02:23:25 +00:00
jenkins-bot 2fcbc18dff Merge "Provide a tool to insert a signature in namespaces that need it" 2015-11-17 00:16:42 +00:00
jenkins-bot 3e9d040a79 Merge "AceEditorWidget: Allow users to force an Ace editor refresh" 2015-11-16 22:46:24 +00:00
Translation updater bot 64d8e394ce Localisation updates from https://translatewiki.net. 
Change-Id: Iaf8fb457fd0b835d5b8819f5dab015c4a59e0a78
 2015-11-16 22:19:07 +01:00
Ed Sanders 35c44db988 AceEditorWidget: Allow users to force an Ace editor refresh 
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.

Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
 2015-11-16 12:12:10 -08:00
Ed Sanders 470a4a551b AceEditorWidget: Refactor to ensure setValue runs synchronously 
Also ensure setEditorWidget is only called once when
loadingPromise resolves.

Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
 2015-11-16 11:36:08 -08:00
Bartosz Dziewoński 9be5c85db4 Provide a tool to insert a signature in namespaces that need it 
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.

This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.

Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.

Changes include:
* The tool is now always visible if the wiki allows signatures in any
  VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.

Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).

Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb

Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
 2015-11-16 18:06:32 +01:00
Translation updater bot 9d01677f75 Localisation updates from https://translatewiki.net. 
Change-Id: I2e18f18c1614e74a5681ea7e8faf0ce71c1b5db1
 2015-11-15 22:22:40 +01:00
jenkins-bot f44e127eb5 Merge "AceEditorWidget: Emit resize event at end of cycle" 2015-11-15 02:38:22 +00:00
Translation updater bot 8a456d3e31 Localisation updates from https://translatewiki.net. 
Change-Id: I1eb678891af629bf935f2837e76ba5b856d5f9fd
 2015-11-14 22:19:35 +01:00
Ed Sanders b21b939a67 AceEditorWidget: Emit resize event at end of cycle 
Ensures the widget has taken its new size before emitting the event.

Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
 2015-11-13 18:48:35 -08:00
C. Scott Ananian 236fad19b6 Ensure magic link nodes inherit the annotations of their text 
If you create an autolink in the middle of bolded text, the magic link
should also be bolded.  Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.

Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
 2015-11-13 13:48:18 -08:00
Translation updater bot 73918e0e1e Localisation updates from https://translatewiki.net. 
Change-Id: I63a0e4185c61a42cf0d142d520fdc1e7c7f9000f
 2015-11-13 21:35:36 +01:00
Translation updater bot a284d335a8 Localisation updates from https://translatewiki.net. 
Change-Id: I7f7dba15312b3fda8e9a737428f4bc191604ac4f
 2015-11-12 23:02:52 +01:00
jenkins-bot c6aeff4ba9 Merge "Edit mode switching: Separate styles" 2015-11-11 22:33:35 +00:00
jenkins-bot 96f91758f6 Merge "Update VE core submodule to master (77d786a)" 2015-11-11 22:10:08 +00:00
Translation updater bot c1ac8806c6 Localisation updates from https://translatewiki.net. 
Change-Id: I7f3c0dfe04074271159b7f22032c587374f72836
 2015-11-11 21:57:36 +01:00
Ed Sanders 9bcc61e195 Update VE core submodule to master (77d786a) 
New changes:
95589a6 test: Add a Rakefile for new CI requirement
1a4497e ve.ui.DialogTool: Do not require that a command is set
cbf1bff ve.ui.Tool: Fix documentation for getCommandName
530022d Localisation updates from https://translatewiki.net.
9529093 Update OOjs UI to v0.13.2
b8d6c15 Add icon: Rename 'insert' to 'add'
2f3015b Update OOjs to v1.1.10
78ceb18 Fix deletion inside a structural node at start/end of document
ce3e9a4 ve.utils: Use binarySearch from OOjs

Local change:
* MW test cases for new structural deletion logic

Bug: T52250
Change-Id: I643449c1fa08ea12c8c3aa13f4a4b97d8876990d
 2015-11-11 12:35:53 -08:00
Ed Sanders 86a1d1bfa3 Edit mode switching: Separate styles 
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.

Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
 2015-11-11 18:50:55 +00:00
jenkins-bot c815c3242d Merge "Edit mode switching: Only show WE toolbar button once module is loaded" 2015-11-11 02:21:04 +00:00
jenkins-bot 53dbf3ac2f Merge "Replace 'source' icon with OOUI's 'wikiText' one" 2015-11-11 01:42:00 +00:00
jenkins-bot 1f2905c39f Merge "DesktopTarget: Fix opacity of #siteSub and #contentSub" 2015-11-10 23:39:03 +00:00
Translation updater bot 7bb161d5f7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia25e40a77c416e2dde09b7e68d6e836baf9b3adc
 2015-11-10 22:36:30 +01:00
Ed Sanders cfe3d9b561 Edit mode switching: Only show WE toolbar button once module is loaded 
No point showing the icon if we don't have the functionality to
make it do anything. Also this reduces the number of RL requests
made as we never fetch OOUI separately.

Change-Id: Iac9aa6f34c485223e73981b3377c7d0cfd31dae9
 2015-11-10 10:43:33 -08:00
Alex Monk 6213c23db1 Fix updating of display title upon save 
Bug: T117643
Change-Id: Ibd3d4f056a2d175e52b60b6e3a4c0ece04f26f50
 2015-11-10 13:50:00 +00:00
Alex Monk 87affb5ca4 Restructure education popup code to work without overriding onSelect 
That code was breaking on mobile which uses a subclass of the normal
link inspector.

Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
 2015-11-09 23:18:01 +00:00
Alex Monk 5f162522eb Merge "ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work" 2015-11-09 22:42:34 +00:00
Translation updater bot e87b56b53e Localisation updates from https://translatewiki.net. 
Change-Id: Ie37b9b551d0af53d2420af4a798a26c1954ecf0b
 2015-11-09 21:50:10 +01:00
Bartosz Dziewoński 7d69e86265 ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work 
Work around RESTBase problem that causes errors if we try to switch to
VE when the wikitext is empty. This would prevent non-power-users from
opening VE entirely.

This only solves the issue for new empty pages, and not when the user
intentionally empties the edit box. In that case, though, they get a
dialog where they can choose to "keep" or "discard" changes, and
discarding lets you open the editor.

Bug: T118152
Change-Id: Ie808bcaa9826deacac392dd6cbc90a9446602b79
 2015-11-09 18:55:21 +01:00
jenkins-bot b966333009 Merge "Unset 'action' query parameter from veEditUri, which should always point to VE" 2015-11-09 15:26:18 +00:00
Translation updater bot 280b68b183 Localisation updates from https://translatewiki.net. 
Change-Id: I96650b4066bf3a33e0b31e53ddefa15dac49d5b7
 2015-11-08 22:14:22 +01:00
Alex Monk 1e4889bbc7 Unset 'action' query parameter from veEditUri, which should always point to VE 
Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
 2015-11-08 20:32:28 +00:00
Translation updater bot a8dbf5f828 Localisation updates from https://translatewiki.net. 
Change-Id: I37ec76d17c9c7f24c6691d8cb85faf7422f28633
 2015-11-07 22:45:38 +01:00
Alex Monk 3e23d3b96d Only load switching module (depending on OOUI etc.) on edit pages 
This wasn't as bad as T112401 (that was blocking render), but we
still shouldn't be loading the module on page views.

Bug: T118088
Change-Id: If86701ed7ff4e8d6defb1c682aa9a38c211be0fa
 2015-11-07 19:08:29 +00:00
jenkins-bot 69bce26579 Merge "Drop any beforeunload handlers when loading from existing wikitext" 2015-11-07 16:09:50 +00:00
Alex Monk 6247a2f430 WikiEditor integration: Fix dependencies for switch button 
Change-Id: Ic8fb607e8c467e89c0b9af0a9baab84e59b19ba8
 2015-11-07 04:15:14 +00:00
Alex Monk 2910cd2384 Drop any beforeunload handlers when loading from existing wikitext 
Bug: T117769
Change-Id: I823737b17e5af8ed15bc2b62db61a31886e8d418
 2015-11-07 03:57:19 +00:00