.set() should not overwrite existing deferreds; instead,
it should resolve the existing deferred if it's pending.
This is necessary because .set() is used by processResult().
Without this, passing .get() a title that no information
is known for results in a promise that is never resolved,
because the associated deferred is overwritten as soon
as the API response arrives.
Still make .set() a no-op if data has already been set,
by checking if the deferred is pending. For .resolve() this
doesn't matter, but for modifying this.cacheValues it does.
Bug: T107212
Change-Id: I70e8c5450f23062db214ccc5c585624d41de6509
Usage:
In a skin, that needs this offset, e.g. because it has a fixed header, it should add
this config var somewhere before the hook BeforeOutputPage is called:
$wgVisualEditorSkinToolbarScrollOffset['vector'] = 60;
(if 60px is the offset to use)
Depends on: I2e10c12df8277c84d948e48c6a132c03d6324693
Bug: T95528
Change-Id: Iaa86c2f68afa6403fcc4f5b7c655704512beead4
New changes:
adaa490 Localisation updates from https://translatewiki.net.
3e9e89c Localisation updates from https://translatewiki.net.
e166731 Localisation updates from https://translatewiki.net.
cb14f66 ContextItem: Update documentation, code to show that model is optional
Change-Id: If6072bc1b72c9676d3c8a74b9ecba4c8aaf58f50
Depends on I1ba8978dd in core.
Bonus: remove not-allowed-cursor & highlight title (which was
broken) now that we can display this information properly.
Bug: T106810
Change-Id: I1800490ba1b8e10ff54b26372a8a78661c1c7d68
Instead of using the removed 'select' event submission on SearchWidget.
Rename event fired by MWParameterSearchWidget to reflect the new re-
emissioned choose event.
Follow up: I7fa97f208da0b3b185f1b09b87fef9c9afaee2f1
Bug: T106696
Change-Id: I1d954a7243649d7834373537d70bfadf68f52c9d
New changes:
71c6553 Comment*: Use the same icon for the CE and UI renderings
34935a7 Strip data related attributes from paste context
8f5d2c3 Update OOjs to v1.1.8
Change-Id: I000a0973daf84ec9251791e934c7e047e6f1d77f
New changes:
0889d17 Localisation updates from https://translatewiki.net.
17dbe2f Follow up I7ec81feb: Fix icon for AlignableContextItem
528223f Localisation updates from https://translatewiki.net.
c20938c Localisation updates from https://translatewiki.net.
aeaad4e Make ve.SelectionState#flip return an actual SelectionState
Change-Id: Ibc779743985a254cea02d28e50329e8fe26e6744
Prevent typing newlines by pressing the 'Enter' key on the keyboard,
like in a single-line <input type=text />; and filter newlines from
pasted / IME'd text.
Also:
* Use 'classes' config rather than .$element.addClass()
* Remove no-op 'tabIndex' setting (this is the default already)
Bug: T106325
Change-Id: I42d18f51f5ca989818577d6f045f6a516bb5b121
New changes:
bf38d31 Provide a command whitelist feature for targets
d6ee41f Always prevent default on commands which trigger native CE behaviour
Change-Id: Ic3423e817765e96ff2b2458f4a8f49604259abc7
