Commit graph

19382 commits

Author SHA1 Message Date
Translation updater bot b3306567e9 Localisation updates from https://translatewiki.net.
Change-Id: I210d73dbdf5f20030b152175873c1d68f603497c
2022-07-12 08:15:57 +02:00
Translation updater bot 1e580da334 Localisation updates from https://translatewiki.net.
Change-Id: I3aff596dc6bb3cc20576f18d815d9a5d018cbc5c
2022-07-11 09:50:54 +02:00
jenkins-bot a305571b23 Merge "Add grey background when buttons are in focus" 2022-07-09 07:15:16 +00:00
jenkins-bot 086a73804f Merge "Use rgba instead of hex to highlight identical styling" 2022-07-09 07:15:13 +00:00
jenkins-bot 479732f516 Merge "Take parameter list out of tab navigation when empty" 2022-07-08 13:13:26 +00:00
jenkins-bot 47a3e46272 Merge "Lessy-fying OutlineParameterWidget rules" 2022-07-08 12:21:06 +00:00
jenkins-bot ff411966b1 Merge "Lessy-fying OutlineTemplateWidget rules" 2022-07-08 12:21:04 +00:00
jenkins-bot cb7c6e32ee Merge "Fix CSS regression" 2022-07-08 12:19:54 +00:00
Adam Wight fb81938c74 Take parameter list out of tab navigation when empty
This prevents an invisible and unactionable focus target when the
parameter search field doesn't match anything.

Bug: T312547
Change-Id: Ib29913a547cd68649d29e28d921c4c1358bad7b8
2022-07-08 13:59:37 +02:00
WMDE-Fisch 970ab136da Add grey background when buttons are in focus
Bug: T311204
Change-Id: Ife5ed2dc2e772b8a94cbc04cad591acf9f8ebd6e
2022-07-08 13:40:43 +02:00
WMDE-Fisch d3bf14806a Use rgba instead of hex to highlight identical styling
This way it might be a bit more clear that this is actually the
same.

Change-Id: Ifbdfd66f476bf30408685a4af9989bb9ac969b21
2022-07-08 13:39:44 +02:00
WMDE-Fisch ef77373fda Lessy-fying OutlineParameterWidget rules
Change-Id: I9b72752269abd064c859b313ddb1f43ec04f9b71
2022-07-08 13:38:52 +02:00
WMDE-Fisch 0850a205df Lessy-fying OutlineTemplateWidget rules
Also renaming one class for convenience.

Change-Id: I0ef079ca40d061f5f2cde0eafdd04737d63c370f
2022-07-08 13:33:23 +02:00
Adam Wight c1ebaf989c Fix CSS regression
The last checkbox in the entire sidebar should get the extra bottom
margin, but not the last checkbox in each template group.

Follow-up on I1edc5db98d16a4c0de8abd7f705776fb9eb65b97

Change-Id: I4ffade9c053191ce202340edadbd032c67bb39a4
2022-07-08 13:31:22 +02:00
jenkins-bot 55cc3af23d Merge "Don't refocus content pane after removals" 2022-07-08 11:16:25 +00:00
jenkins-bot af77140266 Merge "Lessy-fying OutlinePartWidget and OutlineButtonWidget rules" 2022-07-08 10:48:28 +00:00
jenkins-bot 17f4c84055 Merge "Move obvious Outline related CSS into own file" 2022-07-08 10:48:25 +00:00
Adam Wight 352dcc6177 Don't refocus content pane after removals
Causes problems when we remove a parameter using the spacebar, for
example.

This partially reverts Id3843b2c7ad6.

Bug: T312524
Bug: T312205
Change-Id: I65d834bc0d2cc649803b536ecc65bdd1fa166a32
2022-07-08 12:23:36 +02:00
WMDE-Fisch ab7bc03b18 Lessy-fying OutlinePartWidget and OutlineButtonWidget rules
Using a certain amount of depth to make sure to override OOUI
specificity.

More can be done in follow ups.

Change-Id: I1edc5db98d16a4c0de8abd7f705776fb9eb65b97
2022-07-08 10:29:57 +02:00
Translation updater bot 106c550c83 Localisation updates from https://translatewiki.net.
Change-Id: I734076267445eeed4ba011faa6ac3d9d5e6bfb35
2022-07-08 08:53:20 +02:00
Bartosz Dziewoński 2ed2fd7489 Update VE core submodule to master (71e970992)
New changes:
ce9a03c54 Fix middle click to paste behaviour
129debcdd Allow middle-click pasting to happen next to the current selection
3934a89a6 Don't create selection when middle-click pasting into empty paragraph
71e970992 Insert content at click coords when middle click pasting to a blurred surface

Bug: T311701
Bug: T311723
Bug: T311733
Change-Id: I6659825fa77e518169c7c97e34d7996bed44c97c
2022-07-07 23:16:27 +02:00
WMDE-Fisch 83c30099ec Move obvious Outline related CSS into own file
Should be a noop. Also moving one rule further up to the set of
similar selectors.

Removing one rule that was disabled for some time now.

Optimizations follow.

Change-Id: I8da70a52c13afd8ac1c3ff43bae63a203c3bf86a
2022-07-07 22:05:09 +02:00
jenkins-bot e635e70cca Merge "No highlight for selected template names" 2022-07-07 15:39:46 +00:00
jenkins-bot 768e8517f8 Merge "Revert "Restore selection after keyboard parameter navigation"" 2022-07-07 15:14:31 +00:00
Andrew Kostka 079a1ce6ff Remove highlighting when typing in a search field
Bug: T311204
Change-Id: I583c02df3def6cfeb347e9b63045b62e1d735e24
2022-07-07 13:40:42 +00:00
Adam Wight a83d37d864 Revert "Restore selection after keyboard parameter navigation"
We don't want to restore selection.  Instead, we'll remove all
parameter selections onFocus, in a later patch.

This reverts commit 787d44af66.

Bug: T312017
Change-Id: Ia1dc8061dfd1813a58befff5adc5c3882b54d8e2
2022-07-07 15:24:11 +02:00
jenkins-bot fd86b7f38d Merge "Autofocus template input field on dialog open" 2022-07-07 13:18:53 +00:00
jenkins-bot e6737b55af Merge "Drop StackLayout" 2022-07-07 13:17:08 +00:00
Andrew Kostka 3f8387af17 Autofocus template input field on dialog open
Bug: T312205
Change-Id: Id3843b2c7ad6b3eb4a11e0c6d288dd69804973f8
2022-07-07 14:26:17 +02:00
Adam Wight 483528affe Drop StackLayout
Gets rid of some unused behaviors that we've already disconnected.
Brings the remaining styling into VE files.

Bug: T312524
Change-Id: Ie94472019ba41124831621c45713861297219594
2022-07-07 13:06:24 +02:00
Svantje Lilienthal e286e11a6c No highlight for selected template names
Bug: T311204
Change-Id: I949ede551b122c365954ef5315103e0749353288
2022-07-07 09:16:05 +00:00
jenkins-bot ab8fba0f2a Merge "Remove dead code when adding parameters" 2022-07-07 07:26:05 +00:00
Translation updater bot b0937f243d Localisation updates from https://translatewiki.net.
Change-Id: I60354d290905322952297de3a7c0fb7654b14a86
2022-07-07 08:51:17 +02:00
jenkins-bot 1548904bc4 Merge "Update styling for the floating help button" 2022-07-06 16:16:22 +00:00
WMDE-Fisch be05a524d1 Remove dead code when adding parameters
Both parts are not relevant anymore:
- The first part is about focusing parameter placeholder pages.
  These are added after load only when using the keyboard shortcut.
  Focus will be done separately in that case.
- The second part is dead code since some time now. Also it is not
  needed here. Scrolling to newly added parameters is done via the
  setPage() method in the layout.

Bug: T289043
Change-Id: I928afef01b9e62a9da91db10340d9df78717e125
2022-07-06 15:54:29 +00:00
jenkins-bot 9754f8fd8f Merge "Focus the input after switching to the content pane" 2022-07-06 14:19:41 +00:00
Andrew Kostka d097a83c54 Update styling for the floating help button
Bug: T310762
Change-Id: I2f8d668caad224b51e095ba423a761014a5a994e
2022-07-06 15:43:13 +02:00
Adam Wight f93527e00f Scroll even if sidebar selection hasn't changed
This should be safe because selection is only set from use cases
in which we do want the sidebar scrolled to the matching item.

Bug: T290975
Change-Id: Ib0c66bb048768d633d0f638c775eba24cd652db8
2022-07-06 14:58:55 +02:00
Adam Wight b20b5dbe9d Focus the input after switching to the content pane
... except on mobile because the keyboard will expand.

Need to disable a spurious focus when the element isn't visible,
because this was making it impossible to focus later once it becomes
visible.

Bug: T290975
Change-Id: I0e6057d1cfbef24324a287e50e4988f935720c61
2022-07-06 14:47:50 +02:00
Adam Wight d9e56ef69a Remove unused autofocus code
Two-pane layout setPage no longer does any focusing, so this variable
is not respected anyway.

Change-Id: I1ddb06e11b68be300013a92b2dd05b90583ddc2a
2022-07-06 14:12:35 +02:00
jenkins-bot ddd56ff542 Merge "Use "Add template" label in the sidebar and as the header" 2022-07-06 11:40:48 +00:00
Andrew Kostka d5b8107902 Use "Add template" label in the sidebar and as the header
Bug: T311107
Change-Id: Ib85c08c5d72e621a7687dc393b2f8d9443f13b06
2022-07-06 10:55:43 +00:00
Thiemo Kreuz 217885013a Refine height calculation of template parameter docs
Instead of using a potentially weird fractional value like 3.2 lets
use the floor(ed) value, e.g. 3. Reasoning: These fractions are not
from text lines but optional margins between some of the lines. These
margins should not be counted.

Also increase the cut point from >=3 to >3. This is much closer to
the original specification that talked about "2 lines plus x
characters". See T273426. These "x characters" are the 3rd line.

Bug: T310775
Change-Id: Ib5d1642d7967593dd5f13e556c6244fc44677af4
2022-07-06 10:40:51 +00:00
Andrew Kostka 08e8581944 Use full dialog width for add template input on mobile
Bug: T311109
Change-Id: I5b6beced37d569689470d19361420bead38d18cb
2022-07-06 11:52:49 +02:00
Translation updater bot 3117f9a535 Localisation updates from https://translatewiki.net.
Change-Id: I35f351704c7683843fd5893b805667ae75044cff
2022-07-06 10:18:52 +02:00
jenkins-bot 4730987f2c Merge "Remove selection when selected parameter is unchecked" 2022-07-06 08:11:01 +00:00
WMDE-Fisch bc4fcfa04a Remove selection when selected parameter is unchecked
Adjusting some methods to support the usecase.

Bug: T312085
Change-Id: I4b97ab912f9ac0046f72167c3b573ee8e14e58d9
2022-07-05 19:22:36 +02:00
jenkins-bot ea21d8eacc Merge "Restore selection after keyboard parameter navigation" 2022-07-05 13:39:22 +00:00
jenkins-bot a5b9538a6b Merge "Drop unused active state" 2022-07-05 13:16:18 +00:00
jenkins-bot 9fb599949e Merge "Remove max-width limitation on inputs for mobile skin" 2022-07-05 13:12:11 +00:00