wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-23 19:43:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
1849 commits 15 branches 17 tags 192 MiB
Commit graph

394 commits

Author SHA1 Message Date
Trevor Parscal 429225fb57 Whitespace fixes (jshint was tweaking out) 
Change-Id: Id75a097ae4958029caf0a0315343c2fab9c99b89
 2012-06-13 16:06:21 -07:00
Trevor Parscal 56c0f597cd Fixed use of "pre", "preformatted" is the correct symbolic name 
Change-Id: Ifc7e8e3291b8dd29a7fa4c42529bb4fd36a6ed9a
 2012-06-13 15:15:05 -07:00
Trevor Parscal 84ce839ce5 Removed context menus on tear down of surface 
There needs to be a proper tear down system for ve at some point

Change-Id: I6454423ab96a15932695fbc5429d9e731acc9071
 2012-06-13 15:00:13 -07:00
Trevor Parscal 1628038bdb Using wikiLink instead of internal to match actual documents 
Change-Id: I24b9c0a5f27ed8f4a7861090ab4049c4614cea78
 2012-06-13 14:48:29 -07:00
Trevor Parscal 95c601c8e9 Make save dialog initially hidden 
Change-Id: I8fc4bd67f16266d9355fe639487728ad91ad6ede
 2012-06-13 14:44:39 -07:00
Trevor Parscal 169b7e754d Cleaned up toolbar annotation updates 
Change-Id: I8cefd6c871ed6d1ad71f64eb66236de1b8b719b5
 2012-06-13 14:31:46 -07:00
Rob Moen 26e0f6ed5f Real cross browser fix for invisible iframe bug. 
Change-Id: Ia2d3c83562542aaaddf0b81dfeaef9aa408aaed3
 2012-06-13 13:29:18 -07:00
Rob Moen a991cefbe7 Fix inspector close bug where iframe was blocking editor below 
Fix Inspector bug which prevented applying a link annotation to data
already containing annotations.

Change-Id: I6f315d50805c8c71f2155f955ea5674a7ce98656
 2012-06-12 13:52:42 -07:00
Rob Moen b843762d9e rewrite comment 
Change-Id: Ibc8aab4843ecc0211149aa673d312384e9bd668e
 2012-06-12 13:29:13 -07:00
Rob Moen 75e9b2cb2d On transact, redraw selection 
Change-Id: Ia2f82dd1516113a3c6e77377fec19047fcbd32d0
 2012-06-12 13:27:23 -07:00
Rob Moen bf5b682809 Fix clearButtonTool 
Change-Id: I92e55efb9c82f4d2ef55a71bea318cdc7495c2ea
 2012-06-12 11:43:56 -07:00
Rob Moen bf08347922 Fix js error 
Change-Id: I3424f205649345a97a7f4d28c4c040c3c3bb6aa7
 2012-06-12 11:17:46 -07:00
Rob Moen 2ea1030ab4 Rewrite document annotation getters to return collection objects 
vs arrays

Change-Id: Ib48a39fff501cdb769f5b9b9fc7717805b74236e
 2012-06-12 11:10:29 -07:00
Rob Moen da3e366758 Updating tools on transactions. Working towards finishing clear 
button

Change-Id: I7b6f8cae04fc181b7c8c61d4977e42480e608829
 2012-06-12 10:44:58 -07:00
Trevor Parscal 722c30466d Got rid of wrapping whitespace (like \n and \t) in a span that made text white 
This was causing some issues when you started typing there, and it's not clear that the white text is really the best way to go anyways

Change-Id: I8a9d6571ea204603729e96b7ff77184279a31a95
 2012-06-12 10:40:44 -07:00
Trevor Parscal 9b9dcca6e2 Made save page button only work when an edit is made 
Also added confirmation dialog for abandoning unsaved changes

Change-Id: I3388a8f7def9bee5eda32b97ef78e9565a7e33ea
 2012-06-12 10:32:19 -07:00
Trevor Parscal cd3cf1d856 Changed use of getSurfaceModel to getModel and surfaceModel to model 
Also cleaned up other stuff that was a little wonky

Change-Id: I6769b0cb53adb9fd4a9411937084efb03a6e3029
 2012-06-12 10:32:18 -07:00
Christian Williams 05ee4e7dac Binding to 'before paste' for IE only 
Change-Id: I3e3125d2faf75ea79e7f4c4d86fa1ccd666074b6
 2012-06-12 10:23:58 -07:00
Christian Williams 1e4c52237c Enter key handling 
Change-Id: I1b5f901a542328c3ae7c19a5cd816112dcac4042
 2012-06-11 19:40:09 -07:00
Trevor Parscal 70234d2507 Fixed missing arg, kept stuff from saving 
Change-Id: I6c02b2a009f03b2d9e293591166819743fe7ee24
 2012-06-11 18:35:24 -07:00
Trevor Parscal 4cc88b9850 Fixed some minor-ish UI stuff 
Change-Id: Ibc3fa2fb7ce9193703263ab708ce18f6aefe5b09
 2012-06-11 18:21:41 -07:00
Trevor Parscal f0ef6bda70 Fixed drop-down arrow placement 
Change-Id: Ia9ce735a7938c2db0bad28b44384cf7d206a2023
 2012-06-11 18:21:40 -07:00
Catrope 92d715df92 Fix some comment typos 
Change-Id: I58e21bb4cb75580369b89a10cf324c100ed15724
 2012-06-11 18:19:12 -07:00
Catrope 44af6bdb18 Factor out redundant getNodeFromOffset() call 
Change-Id: Ie01282447fab589466554f7c637515289cf570af
 2012-06-11 18:10:09 -07:00
Catrope ab0c37def9 Rip out the offset map 
The offset map was broken from the start because it wasn't updated when
adjusting the length of a text node, and if we fix that bug it's
doubtful whether the costs of updating the offset map outweigh the
benefits, especially considering that adjusting the length of a text
node is something we do for almost every keypress. If it turns out
having an offset map does make sense, we can always reintroduce it
later.

Change-Id: I59e8bc154f7d07aa1bab2f473c13ff466d0e463f
 2012-06-11 18:10:08 -07:00
Catrope 407ea15373 Make the LinkAnnotation code a bit more robust 
Change-Id: I42603788cf112541df67811858bd8854dd224b24
 2012-06-11 18:10:06 -07:00
Catrope 48abc8e30a Terrible hacks to work around Parsoid bugs 
This makes my test document round-trip cleanly though, yay!
 2012-06-11 17:32:58 -07:00
Rob Moen dcf104428f Clear button tool now properly clearning selection annotations. 
Create method to return matched annotations button tool pattern.

Change-Id: I5ba2369f1ec81a74570bcfeb1ee86bb7ef07e691
 2012-06-11 16:29:09 -07:00
Rob Moen 810ba6df89 Modify FormatDropDownTool to use new transaction builder 
newFromContentBranchConversion

Change-Id: Ifcec60ed57c7c92a5c08219d5f046e904300d5c2
 2012-06-11 16:20:14 -07:00
Trevor Parscal 59f9bdf22f Made use of ve.proxy instead of surface having it's own implementation 
Other cleanup as well

Change-Id: I5de5c048e341dd3dc3ef222ae5686c49e51a32a5
 2012-06-11 16:11:49 -07:00
Trevor Parscal 7d7fd74d29 Renamed EditPageTarget to ViewPageTarget (since it's targeting view pages, not edit pages, duh...) 
Change-Id: I810de87940e0d061c59d32de6654f1f2431f8d82
 2012-06-11 16:06:35 -07:00
Trevor Parscal c8c4ed8f99 Added ve.dm.Transaction.newFromContentBranchConversion 
Change-Id: I0e272b24dddae028e44d4c693297b1875000ef57
 2012-06-11 15:58:44 -07:00
Trevor Parscal 2c393d4cad Added normalization to ranges given to selectNodes 
Change-Id: I11b7d9b4f8359ab60c1a2f0443dea209a3735711
 2012-06-11 15:58:44 -07:00
Trevor Parscal 9891adf116 Added getRange and getOuterRange to ve.dm.Node 
Change-Id: If1b226d7944335e9b78d59433e322faf5d48382e
 2012-06-11 15:58:44 -07:00
Inez Korczynski a609afe52f Port static method addAnnotationsToData from ve to ve2 2012-06-11 15:31:55 -07:00
Catrope dcdc1737ca Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-11 14:53:28 -07:00
Rob Moen 542131e080 Properly clearing link annotations now 
Change-Id: I2342ad496566e6d7f6e39a30f70af1f886398069
 2012-06-11 14:50:52 -07:00
Catrope b26649a2e8 Guard against passing undefined into ve.compareObjects(), was causing errors 2012-06-11 14:48:46 -07:00
Trevor Parscal 82c409ca18 Changed loading graphic, added focus on load 
Change-Id: I2d91c25edc7b759f07fe1581953fa0e5baecb51c
 2012-06-11 13:24:35 -07:00
Rob Moen 29c76e6dd4 Fix link annotation from inspector by changing link type to wikiLink 
Change-Id: I5b3497755c6a13e2767f59cc5c95b3e4b43b3be7
 2012-06-11 12:56:18 -07:00
Trevor Parscal a0d5cbd42a Animated the margin of the first heading and fixed animation of save dialog 
Change-Id: If4a37aa9e35d9d507577643e4bd40ea4fa3dfad8
 2012-06-11 12:28:31 -07:00
Trevor Parscal 17fff0d163 Fixed dependency on mw, now demo works again 
Change-Id: I26599e065a521cf08a16f5a65e36960a692421e9
 2012-06-11 12:11:07 -07:00
Trevor Parscal 21ff108c28 Bring link converter in line with Parsoid 
Parsoid outputs rel="mw:wikiLink" or rel="mw:extLink", so we convert that to link/wikiLink and wiki/extLink respectively.

Also preserve the data-mw attribute; we probably need to do this more generally but this'll do for now.

Change-Id: I32e570bffa5a73a733a120d52cfd8b75d3191e02
 2012-06-11 00:36:20 -07:00
Trevor Parscal c40dd953ca Remove stray debugger statement 
Change-Id: Ie7c37e658d6d6bc15d5d7c24b2f5cd13945c5243
 2012-06-11 00:33:13 -07:00
Trevor Parscal ce8efd6b15 Refactored veCore class into ve.init and ve.init.EditPageTarget 
Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
 2012-06-10 23:54:41 -07:00
Rob Moen 38e64418b5 Move inspectors into iframe loaded in contextView. 
TODO- needs cleanup

Change-Id: I62d86260b48ef570ce18833dee3390ec9fff47e1
 2012-06-08 17:17:11 -07:00
Trevor Parscal 2e1b304a48 Cleaned up styles for editor in both demo and sandbox/integration 
Change-Id: I9b4a3727fd04b3c3ff3f297c6656db2592856173
 2012-06-08 16:20:37 -07:00
Christian Williams 80194260f3 Undo and Redo 
Change-Id: I2d7c1bfd164a42e5d52001054e52e47ca245ad18
 2012-06-08 16:21:47 -07:00
Trevor Parscal 89b2260bfc Revert "Support for basic text insertion - typing" 
This reverts commit 21056ff5ec.

Change-Id: I86bb28d868b2c931f4b6e18ba5023a8a75b40231
 2012-06-08 15:54:05 -07:00
Inez Korczynski 21056ff5ec Support for basic text insertion - typing 2012-06-08 15:31:29 -07:00
Trevor Parscal d61045085a Fixed link conversions to match parser 
Change-Id: I67838a8c05729e4d32e6e2dfca53c7d457143ce3
 2012-06-08 15:17:18 -07:00
Trevor Parscal 20d1c290d4 Fixed multi-auto-wrapping issue and added tests to track regressions 
Roan mostly wrote this

Change-Id: Id292c84a4da97d6608aa7c17ab6a4cf5a2e3f409
 2012-06-08 15:16:55 -07:00
Trevor Parscal 402d6dc53a Added rendering for link/unknown 
Change-Id: I47cdc8679c533f15059b290bf30ae74518dce724
 2012-06-08 15:15:43 -07:00
Trevor Parscal 5969f55550 Delete HTMLConverter and update demo&sandbox 
Also update the demo and sandbox for ve.{dm,ce}.TableSectionNode

Change-Id: I5a73a8250d283e8666b93561ce9e9374739936a5
 2012-06-08 12:40:43 -07:00
Trevor Parscal 2e0d4ef094 Make tableCell represent both <td> and <th> 
Adding a 'style' attribute which is set to either 'data' or 'header'

This breaks even more tests because of missing style attributes

Change-Id: I0a75d8c1578b4414eeae8c484f6c4d6f8a59472a
 2012-06-08 12:27:22 -07:00
Trevor Parscal c614d3391b Add ve.dm.TableSectionNode and ve.ce.TableSectionNode 
Yes, this breaks a bunch of tests, because tableRows are now required to be inside tableSections

Change-Id: Idb52d988df69173647c85f7602344650456e078e
 2012-06-08 12:26:45 -07:00
Trevor Parscal 5e6713eae5 Throw an exception when attempting to annotate a closing element 
Change-Id: Ifd4e49ee05e74db8bec754a6c1f79c969c1f2eac
 2012-06-08 12:23:59 -07:00
Trevor Parscal 5aa6f4b342 Fix bug in fixupInsertion() 
When a text node was closed (either by encountering a non-text node or by reaching the end of the document), the fixupStack would not be processed. This led to attributes being dropped when nodes were split because of text being inserted into them

Change-Id: I41f6d20e0c1bfc8d8689b7e6325e724dd8156ab1
 2012-06-08 12:23:58 -07:00
Trevor Parscal acdd5679ec Finish implementing ve.dm.Converter and document it 
* Add code to handle elements and annotations
* Drop support for aliens from getDomElementFromDataElement() and move it into getDomFromData()
* Implement getDomElementFromDataAnnotation()
* Document a few functions

Change-Id: Ic6a418cbf9d7d1ad96299d7d3633970a876c6103
 2012-06-07 21:58:56 -07:00
Trevor Parscal cc0c490502 Fix typo in LinkAnnotation 
Change-Id: Idfb969a73c59aef1acf54edd61d555cdc295534c
 2012-06-07 21:16:55 -07:00
Trevor Parscal f2b3df8027 Cleaned up some useless/unused functions 
Change-Id: I6aa5d0ed3d21993ed653ee64b4928ef98874db2d
 2012-06-07 15:02:40 -07:00
Rob Moen e1b8f9422d Fix bug in getAnnotationsFromRange where if the range length was 0 
it would return no annotations.

Change-Id: Iec33366b2a1249122a21617d6681ae039557c2fe
 2012-06-07 14:53:30 -07:00
Christian Williams 244551ff96 Updating model selection after cut and paste 
Change-Id: Iefaec5a3d705c6caae76941bc05810152d870bb8
 2012-06-07 14:48:46 -07:00
Trevor Parscal 453bec4555 Fixed alienInline and alienBlock conversion (was missing closings) 
Change-Id: Ie8e51eb8d9a452c656aebf341071da5627dd80b5
 2012-06-07 14:30:06 -07:00
Trevor Parscal fa9fe8b08a Added support for alienInline nodes 
Change-Id: I15b9cbcdb66b966dca28edcb26bf5d54a4f17be6
 2012-06-07 14:16:19 -07:00
Rob Moen 9fe6658a0e Put getSelectionRect method back in surface view. 
Change-Id: Iaec899bec157ef39810d391b2ed51d4f8fe3be9d
 2012-06-07 14:13:55 -07:00
Rob Moen 4b940c3b19 Init rangy in case of Toshiba 
Annotate button redraws selection after annotation
Added contextView hooks to select listener in toolbar.

Change-Id: I598fe715dd84976862eed63e4f55cb6bc6e75b18
 2012-06-07 14:04:39 -07:00
Christian Williams 1f86885d47 Fixing copy and paste 
Change-Id: I57ead6a6d831aa739df49960f97cb2f91f672730
 2012-06-07 14:03:48 -07:00
Catrope 9cab267911 Fix some JS errors in the ve.ui code 
Change-Id: I57057369f56dc20b56231ed4bbe34816c3c718d7
 2012-06-07 13:29:14 -07:00
Catrope 3c1de3dc4f Add ve.dm.Document.getBalancedData() 
Change-Id: I2420ef5369b9eae053962898b64dd7324e714bbd
 2012-06-07 13:17:57 -07:00
Catrope feac2f6069 Factor out element cloning into a getClonedElement() function 
Change-Id: Id6024c15d4d9c9141bc4e1afa39fce29992b8647
 2012-06-07 13:17:57 -07:00
Inez Korczynski 6704b01e30 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-07 11:44:35 -07:00
Inez Korczynski 5c41fa2fb8 Define min-height for P and HX tags - needed when those tags are empty. 
Change-Id: I0ba1c950cc06b3ff040c208c1b9a4970b2f73493
 2012-06-07 11:44:05 -07:00
Trevor Parscal 18461387c0 Roan officially does not owe the team lunch (at this precise moment) 
Change-Id: I90a6198da97ea90f60d9668c21d7386984a03ff0
 2012-06-07 11:33:58 -07:00
Inez Korczynski 02f913a7db Added accidently removed registrations for events handling. 
Change-Id: I6e5df649909b025f7e7aeb35ff9e8ff0b7fcd5f9
 2012-06-07 11:10:08 -07:00
Inez Korczynski 97001e1301 Improvements to selection mechanism. 
Change-Id: I031dd3493832034c985b15bf213cafe2c4813136
 2012-06-07 11:03:22 -07:00
Inez Korczynski 95297a2c73 Delete from ce.BranchNode code that is not needed anymore. 
Change-Id: I64f869a9fd54d089d2c6a31d827ddaccb9ece900
 2012-06-07 11:02:59 -07:00
Inez Korczynski f711d78d4d Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-07 10:58:42 -07:00
Christian Williams 51aa317df3 Undo and Redo support 
Change-Id: Icdbebccefe3cc162b9ff6c0d978d5e4fc1f2c561
 2012-06-06 20:28:06 -07:00
Inez Korczynski d96db8dce7 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-06 18:50:02 -07:00
Catrope d8359da409 Change calls to getElementType() (which doesn't exist) to getType() 
Change-Id: I894835a0178beddce480c48917700090b31c80b2
 2012-06-06 18:03:55 -07:00
Rob Moen 232f2c58f7 Fix linkInspector tool 
Change-Id: I89fa17b1a72c3f45bce5a11b49aa5445c5990f68
 2012-06-06 17:50:01 -07:00
Trevor Parscal b62beed2e2 Added implementation for ve.dm.Converter.getDataFromDom 
Change-Id: I8561d4a00ba630b86fb7bcd3e347fe2c6c2f6aa3
 2012-06-06 17:47:27 -07:00
Rob Moen 8db70ed263 Annotation buttons now working 
Created new document method to determine if a specific annotation
object is inside an annotation array.

Change-Id: Id645929cbf31030b8b0fcacb8dfb36e61aaad129
 2012-06-06 17:06:37 -07:00
Christian Williams 77d5cae575 Consecutive spaces 
Change-Id: I3f51ce0a2ee0a78e56c55de94bd45796b400680d
 2012-06-06 16:29:02 -07:00
Catrope 5e47bdc57f Maintain a transaction-wide offset adjustment 
This fixes a bug where the second replace operation in a transaction
would cause the rebuild of the wrong range, or the adjustment of the
wrong text node.

Change-Id: I9b1c68d84999d538fe10bb193f4dfdd694121d2a
 2012-06-06 15:34:55 -07:00
Catrope 02b19f337f Add zero-length text nodes to empty content nodes 
This is needed to make the results of certain transactions' tree sync
round-trip cleanly through the ve.dm.Document constructor

Change-Id: I2ab0758ec6bd7afba5b6645c7330f9fa2d45205d
 2012-06-06 15:33:42 -07:00
Catrope ae3d31d447 Shallow-copy annotation objects in HTMLConverter 
This fixes an annotation contamination issue that was causing Rob's
tests to throw exceptions

Change-Id: Ic5171d600b0b2ff97cc569e1e6f9488fab177c7c
 2012-06-06 12:21:01 -07:00
Catrope e524152319 Fix typo in variable name 
Change-Id: I6772555da86a186ec2421d01f82de14463061362
 2012-06-06 12:20:05 -07:00
Rob Moen 337e9b8eee Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-06 12:02:22 -07:00
Rob Moen 21ee17a192 Fix up some tools to not break on selection, added some test selection 
stuff to sandbox

Change-Id: Ic97144e634111c489507814c6634c66831726191
 2012-06-06 11:51:19 -07:00
Catrope 1429a3da59 Rewrite newFromRemoval() using 'covered' mode 
Change-Id: If0736aff6d194ec09c2a109f046dd6362ddc64fb
 2012-06-06 11:47:35 -07:00
Catrope 1566306937 Add 'covered' mode in selectNodes 
Change-Id: I4d24c011ce7a94bc75508dea410fb0ed9ebce6a1
 2012-06-06 11:47:35 -07:00
Catrope 244349aedb Fix stupid typo in selectNodes() 
Change-Id: I1e308c9f3a6e6eb8fe7fe8ae3c6abf7cc3a84d09
 2012-06-06 11:47:35 -07:00
Catrope d39fb9dd1c Make pushReplace([], []) do nothing 
Change-Id: Ifa8df99f376ce22add9d06e76831e8b661e6ddbf
 2012-06-06 11:47:35 -07:00
Rob Moen 2439c0149a Created secondary method for getMatchingAnnotations 
new static method looks for annotation in annotation object.
ve2 Cleanup on annotate method and surface model.
Partially revive UI tools by exchaning old method usage
for ve2 methods.

Change-Id: Id0ac58330292d76801bbcf1d71a919b493f8ab9e
 2012-06-06 11:27:23 -07:00
Trevor Parscal 5d20f45120 Added getHtmlElementFromDataElement and getDataElementFromHtmlElement 
Change-Id: Ie5f4fd86612b5a6c34b5843d1e9a521edc626a63
 2012-06-06 10:17:51 -07:00
Catrope d378182bff Reapply typo fixes from c0e1991 , were undone in b0f6f64 
Change-Id: If84e13b91781ed96d3bd9e94171e16020c65ea42
 2012-06-05 06:54:35 -07:00
Catrope 528728558b Fix bug in selectNodes's logic for traversing back up the tree 
Change-Id: I0fc5a2ad2c9a8d162e8ddbf3cc6d31684d364928
 2012-06-05 06:50:09 -07:00
Trevor Parscal b0f6f64d90 Made pushRetain do nothing if you give it 0 and throw an exception if you give it a negative length 
Change-Id: Ib9955660b05a04503325ddb20f9e9a525b4d6832
 2012-06-04 16:27:33 -07:00