Commit graph

9552 commits

Author SHA1 Message Date
Željko Filipin 273995058e [BrowserTest] Use Cucumber tag to specify which scenario to run
By adding this tag we were able to delete VisualEditor JJB builder and reuse
browsertest-website builder. See the task in Phabricator (linked below) for
more information.

Bug: T90423
Change-Id: I206d512adcb304b6e8823cc9e05acfcf3880c6c8
2015-03-04 09:03:42 +00:00
Ed Sanders 94fe054257 Update VE core submodule to master (a65ad7c)
New changes:
a65ad7c Move special character inserter to toolbar dialog manager

… and add it to the toolbar as a terminal option.

Change-Id: I35834d866a13c5dea7f5a520c63b8a99451fcf6d
2015-03-03 18:20:13 -08:00
James D. Forrester 13945462ce Update VE core submodule to master (b90965c)
New changes:
a9c35d6 build: Add disconnect tolerance to karma config
d468b00 Work around Array.prototype.splice being broken in Safari
9d63353 Make annotation inspector getMode method trim
4acd774 Only store selections which yield a valid context position
245062f Fix desktop context positioning (again)

Change-Id: I8f2f58c955221d1366de2ce9d69283694e78b473
2015-03-03 17:40:42 -08:00
James D. Forrester 0096c37fae VisualEditor.php: Warn people to use extension.json instead
Change-Id: I28f06581fae91d950c08c9bfc63779df6d60d4ad
2015-03-03 13:32:12 -08:00
Moriel Schottlender ae72184c8f Work with the new mw.Feedback and add UserAgent checkbox
Add the new feature for user agent checkbox for the mw.Feedback
dialog. This bumps our MediaWiki dependency to 1.25wmf20.

Change-Id: I741ded83de4f575777a15cb20735e351039dc81f
2015-03-03 10:58:34 -08:00
jenkins-bot 536c72097e Merge "Update VE core submodule to master (0cb3b6f)" 2015-03-03 16:52:22 +00:00
Timo Tijhof 46369a2969 Update VE core submodule to master (0cb3b6f)
New changes:
e6554e8 Localisation updates from https://translatewiki.net.
397a53d Localisation updates from https://translatewiki.net.
56c5937 Provide isAlignable checks for alignable nodes
2431396 ce.ContentBranchNode: Don't compare new rendering with old on first render
0131fe8 ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow
89f66fc Fix documentation lies about rewrap event
fb42667 Add insert/edit modes to FragmentInspector
511e0a7 Make ce.BranchNode#updateTagName do what its documentation says
626936d Localisation updates from https://translatewiki.net.
0cb3b6f build: Rename JSDuck config standard jsduck.json

Change-Id: I58d210a549ea5faa2142f716ad37c2fad9be94f5
2015-03-03 17:09:18 +01:00
Roan Kattouw ea3fccccaa Reduce complexity around onbeforeunload handler
We used to attempt to not break Firefox's bfcache, but this
didn't really work very well, and it's not clear that avoiding
bfcache breakage is even a good idea. It's more sensible and
consistent to deliberately break bfcache while VE is active.
On top of that, the Firefox people believe that our trick
shouldn't even have worked to begin with:
https://bugzilla.mozilla.org/show_bug.cgi?id=1102664

Because the onbeforeunload handler is removed when VE
is deactivated, bfcache still works if you first click
Read, then navigate away.

Also clean up the management of the unload handler, using
addEventListener() and removing the return value fallback
code that is needed for beforeunload but not unload.
For beforeunload this is harder to clean up because
the addEventListener()-based API for returning a value
isn't consistent across browsers.

Change-Id: Ie4fe9ea3a59a54ba462733aa5e42bfc0ed5b15eb
2015-03-03 16:36:22 +01:00
Alex Monk 6f1b6c85a5 Send abort event on unload
Still misses some preinit aborts because we need to figure out
a way to attach the unload handler early enough to catch these.

Change-Id: I0ce721e24e69c31318064c6b443c1bfe01077546
2015-03-03 15:25:57 +00:00
jenkins-bot 4b840ab725 Merge "Promote the Language tool Beta Feature to always-on status" 2015-03-02 23:58:27 +00:00
jenkins-bot 58a685386b Merge "Fix transfer of reference contents from removed reference" 2015-03-02 21:39:21 +00:00
Roan Kattouw f24dbb3435 Fix transfer of reference contents from removed reference
We unconditionally retrieved originalHtml from itemNode,
even if there was no data-mw.body.id, so as long as
the reference itself wasn't edited, we would never overwrite
data-mw. This meant that if the <ref> with the contents
was deleted, the contents wouldn't be transfered to the
first <ref> tag with that name like they're supposed to be.
The solution is to only look at originalHtml from itemNode
if data-mw.body.id is set.

Change-Id: Ib87491b6fa6a77d62384158f8e8f7dcc2a36c23a
2015-03-02 22:26:05 +01:00
Translation updater bot bf51864690 Localisation updates from https://translatewiki.net.
Change-Id: Iaa353f0cfc791baac3e76efd41b675644b5f985b
2015-03-02 22:13:06 +01:00
Roan Kattouw 6642e4f0bc Don't claim all links exist when ParserCache misses
On a ParserCache miss when viewing the current version of a
page, we'd output {missing: [], extant: true} which means
all links are marked blue. That's wrong, instead output
that we don't know anything.

Bug: T91299
Change-Id: Icf66735141a8d2a6579dce0ffd847dd099437029
2015-03-02 21:14:38 +01:00
jenkins-bot 91d0c4ff03 Merge "mw.ViewPageTarget: Use CSS for toolbar transition" 2015-03-02 11:39:13 +00:00
jenkins-bot 78a014ce9f Merge "Show the toolbar as soon as the target has been activated" 2015-03-02 11:32:48 +00:00
James D. Forrester bddd84b1e9 Promote the Language tool Beta Feature to always-on status
No complaints in over nine months. Time to just make this available.

Change-Id: I601699573c0d50384720e5a1f0098c7f780de8cf
2015-03-01 17:15:48 -08:00
Translation updater bot a4c2984332 Localisation updates from https://translatewiki.net.
Change-Id: Idace01361190c048b6df3d374fd008569d669c1d
2015-03-01 22:10:25 +01:00
Translation updater bot cc31f3e8da Localisation updates from https://translatewiki.net.
Change-Id: I331c2fbe67148ee5ef5996ab75ba1a6fd0bab197
2015-02-28 22:10:43 +01:00
jenkins-bot 6c5cb61139 Merge "ImageInfoCache: Don't try to access imageinfo result if it's not set" 2015-02-28 01:40:52 +00:00
Alex Monk 944e7d7a86 ImageInfoCache: Don't try to access imageinfo result if it's not set
Bug: T90916
Change-Id: Iebd393b0cff8016cc8917b86ca277eddf7810d4e
2015-02-28 01:25:12 +00:00
jenkins-bot 757e8d1950 Merge "MWCategoryWidget: Remove entries from this.categories when appropriate" 2015-02-28 01:00:15 +00:00
jenkins-bot 54b9bf76ae Merge "Make generateCitationFeatures() idempotent" 2015-02-28 00:58:43 +00:00
James D. Forrester e283be675b Update VE core submodule to master (7bcf314)
New changes:
8e09b32 Make align widget work when config is undefined
8fd594e Localisation updates from https://translatewiki.net.
d3b8d9f Prevent form submission in FragmentInspector
b87d809 ve.ce.FocusableNode.css: Quieten csslint for Firefox-specific hack
3177599 Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor

Change-Id: I438f5e1ad6322e7c9a3621bb2b50ccf9f5c96dde
2015-02-27 19:53:07 -05:00
Roan Kattouw 2b67617179 Make generateCitationFeatures() idempotent
Add checks so it doesn't generate and register the same
tool twice. This makes it safe to run it multiple times.

Change-Id: I882b51bd0422222f2e80555910c69b059136a503
2015-02-27 16:18:15 -08:00
Trevor Parscal 34da7d56b8 Update VE core submodule to master (2e1a0bb)
New changes:
04a5947 Localisation updates from https://translatewiki.net.
dd4691b Update OOjs to v1.1.5
2e1a0bb Context refactor

Local changes:
Add context item support for references, citations, templates and links

Change-Id: I5d488ecbf9768dc63de6e545505dbfd5eb84cc61
2015-02-27 18:21:13 -05:00
Alex Monk 9246fcd2ff MWCategoryWidget: Remove entries from this.categories when appropriate
So for example MWCategoryWidget#getCategories doesn't return stuff that was removed.

Bug: T89923
Change-Id: Id99ea2e3b7c74e186bacbcf796b6df3a131a37b1
2015-02-27 22:05:58 +00:00
Moriel Schottlender f0f8f52080 Refactor MWMediaResultWidget to resize better
For the masonry view, the result widget resizes itself according to
the rows and other images in the row. Up until now the resize was
a bit buggy, occasionally missing height/width values. This is
mostly due to rounding errors, but also due to a small double
calculation that is now fixed with this code.

Change-Id: If18adc5280e4bdbb9174b7c7e6e4eadf3c1ab26d
2015-02-26 16:42:14 -08:00
Translation updater bot a515c4468b Localisation updates from https://translatewiki.net.
Change-Id: I7dae73e4c3fbe408613e763147e058f079656d50
2015-02-26 21:40:24 +01:00
jenkins-bot 1facc44556 Merge "Follow-up I18162f04: Send uselang parameter with paction=parse request" 2015-02-26 18:26:58 +00:00
jenkins-bot 895ffc241b Merge "Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again" 2015-02-26 12:39:29 +00:00
Amir E. Aharoni 76b50c5b34 [BrowserTest] Update the Edit tab scenario
Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.

Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
2015-02-26 12:59:34 +02:00
jenkins-bot 87de0ed84e Merge "[BrowserTest] Fix VisualEditor_More_Settings scenario" 2015-02-26 10:46:24 +00:00
jenkins-bot fd44d5541a Merge "[BrowserTest] Update the scenario for Cite screenshot" 2015-02-26 10:44:57 +00:00
jenkins-bot f0c9a17fb6 Merge "[BrowserTest] Update Gemfile.lock" 2015-02-26 10:43:16 +00:00
Alex Monk a6dbdb4788 Follow-up I18162f04: Send uselang parameter with paction=parse request
Change-Id: I70c2e6c448c175ebe9d46c2003499e22a79b28b1
2015-02-26 01:45:48 +00:00
Alex Monk ac2242af5f Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again
But not all

Change-Id: If9d88bb8d6c532992e8118e504f2fae45c0ca96a
2015-02-26 01:24:16 +00:00
Moriel Schottlender b85b81c501 Correctly validate a provider for local api
Make sure that the validation method accounts for local api
vs remote api when checking for valid variables.

Bug: T90795
Change-Id: Ia6877ca6ccc4e65d1db053f107e7702721e2da3c
2015-02-25 15:59:05 -08:00
Translation updater bot bc75cf573f Localisation updates from https://translatewiki.net.
Change-Id: I776e632fcb40c2edc6b8b80fc000fe9952516697
2015-02-25 22:59:22 +01:00
James D. Forrester 83e0503895 Update VE core submodule to master (f81b990)
New changes:
8314c74 Localisation updates from https://translatewiki.net.
f81b990 Guess annotations better for complex changes

Change-Id: I2099f07f4e832aaa2da35f9503b9212a16c33f78
2015-02-25 10:50:34 -08:00
jenkins-bot d50935ffe9 Merge "Update VE core submodule to master (31fb72a)" 2015-02-25 18:33:54 +00:00
jenkins-bot b4998f0932 Merge "Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target" 2015-02-25 17:26:27 +00:00
jenkins-bot b167051f15 Merge "Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup" 2015-02-25 16:57:14 +00:00
Alex Monk edd9b68ab1 Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup
Use setSelected rather than setValue, as done in I0b4b8dca for the rest
of the file.

Bug: T89511
Change-Id: I16ff6f7dc872b427373df1634cfa2f1a12da54ba
2015-02-25 16:53:20 +00:00
jenkins-bot 228c0f838b Merge "Check whether template is altered before allowing apply" 2015-02-25 16:27:38 +00:00
jenkins-bot 5a9ff0e1be Merge "Follow-up I5636e744: Only set noeditsection class for no edit checkbox" 2015-02-25 16:26:42 +00:00
Matthew Flaschen 3af3bde7fe VisualEditorDataModule depends on ext.visualEditor.mediaWiki
It uses modules/ve-mw/init/ve.init.mw.Platform.js via addParsedMessages

The missing dependency triggered an error when working on the Flow/VE
integration.

Change-Id: I64347aa6a0cf94fe51dd724432c22d54eea0cfd9
2015-02-24 23:10:27 -05:00
Alex Monk 9611f50fbd Follow-up I5636e744: Only set noeditsection class for no edit checkbox
Change-Id: I0994b38bdfaff2dfb4238e60e44764b7c6fd5c42
2015-02-25 02:37:15 +00:00
Alex Monk 85373bcb9a Check whether template is altered before allowing apply
Again. Originally done in I5a664f86, the crucial part of which was reversed
in I1500f480.

Bug: T89913
Change-Id: I39b0cdcdb5f76fa75f506c874ef6223d8d8d53e6
2015-02-25 02:12:28 +00:00
Alex Monk 8e48f94580 Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target
Bug: T58659
Bug: T89435
Change-Id: I18162f04c50f48606378aed62ee99fccdc3159f6
2015-02-25 01:57:22 +00:00