Commit graph

15549 commits

Author SHA1 Message Date
Bartosz Dziewoński 7ade9938d0 Remove special handling for category and file pages
Previously, we tried to keep the list of category members and the file
thumbnail, history and metadata visible while the editor was open.

I am removing it because:
* It is not very useful, as you can't interact with them (e.g. links
  are unclickable).
* It is inconsistent with the wikitext editor (except for non-existent
  category pages, and I'm proposing to change that behavior in T139191).
* It causes issues when other code doesn't expect the special setup
  for those pages (T194068).

This introduces a minor change to the handling of normal pages: after
the save, instead of replacing all contents of #mw-content-text with
the new page content, we only replace the .mw-parser-output child.
Normally the effect is the same (it's the only child), but this could
theoretically affect interactions with other extensions or gadgets.

Bug: T194068
Change-Id: I26cc82d3e0f0d64e3f18a80d232005fc7ab3b374
2019-02-22 20:59:36 +00:00
jenkins-bot f1b7225336 Merge "Swap the link-rtl.png and link-ltr.png files" 2019-02-22 20:49:11 +00:00
Ed Sanders 23267264ce Load VE in read-only mode on protected pages
Bug: T53547
Depends-On: Ifaa74be266c048d87f94b4ae2df59cafc7aa155f
Change-Id: Ic90a0b86f45696a8782dec8e3d155ca91107b759
2019-02-22 19:09:23 +00:00
Ed Sanders 18907dde5a Implementations for read-only mode
Depends-On: Ifaa74be266c048d87f94b4ae2df59cafc7aa155f
Change-Id: Iedd1bd9ce17750ad8528c1a053293c4a7321c5de
2019-02-22 18:20:51 +00:00
Bartosz Dziewoński d13313097a Update VE core submodule to master (541222565)
New changes:
541222565 Replace surface disable with read-only mode

Bug: T210142
Change-Id: I4ec8805c296accfca8774c95656177f40acfc253
2019-02-22 19:20:03 +01:00
Ed Sanders 1890530b89 ApiVisualEditor: Remove red-link cache warming
Red-link metadata was added to Parsoid 18 months ago.
On long pages evaluating this information is very slow
(hundreds of milliseconds) and completely redundant.

Bug: T64803
Bug: T209078
Change-Id: I5b6c6da588301ed59fb21e1ce930f5b72db48e67
2019-02-22 17:49:11 +00:00
Bartosz Dziewoński 93351892da ve.dm.MWGalleryImageNode: Update for Parsoid changes to "broken" images
Change-Id: I49f4a06de207fbb4dad090f0325068d13bed9810
2019-02-22 18:10:56 +01:00
setian 08e96d7b2e Swap the link-rtl.png and link-ltr.png files
Bug: T216617
Change-Id: I717f36ea94f1c7a016111ce7b32068bf42e05806
2019-02-22 02:38:56 -05:00
Ed Sanders e21d4fab3f Update VE core submodule to master (2951e9378)
New changes:
202adf904 [BREAKING CHANGE] Unify FragmentInspector/Dialog behaviour

Local changes:
* Update dialogs to use common actions & FragmentWindow

Change-Id: Ib744b8996db48d1ee58bc873120400566c490e88
2019-02-22 01:13:36 +01:00
Bartosz Dziewoński edc4fe95f6 Allow page title heading to be selected while editor is active
People enjoy copy-pasting it, or something.

Bug: T214790
Change-Id: I0d133f601d178f1d1f0175a411a9bcd433ba9419
2019-02-21 21:35:58 +00:00
Bartosz Dziewoński 3ce1db9c6d Update VE core submodule to master (2465e0e60)
New changes:
8b1c72c0a eslint: Enable caching
51126638d Track feature-use activity for formatting
161668e4a build: Update eslint-config-wikimedia to 0.11.0
6bbb3ae7b Update OOUI to v0.30.3

Bug: T202148
Change-Id: I38b62006d2d454a19c5e8fea8125192e7b68eebd
2019-02-21 22:35:31 +01:00
Translation updater bot 279706e170 Localisation updates from https://translatewiki.net.
Change-Id: I4ca93978ee92b82ceecc8e3d848448e752a490e9
2019-02-21 22:21:59 +01:00
jenkins-bot 767614f0e1 Merge "ve.init.mw.ArticleTarget: Fix some doc comments" 2019-02-21 12:57:05 +00:00
Bartosz Dziewoński 0b1f445349 ve.init.mw.ArticleTarget: Fix some doc comments
Change-Id: I9d8b2553b40d56cf99bcd304c93d866b2a8ba77e
2019-02-20 22:46:39 +01:00
Ed Sanders 332aa1f3d2 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
2019-02-20 20:23:43 +00:00
jenkins-bot 8846e65e44 Merge "Support only surfacing part of the document" 2019-02-20 19:06:30 +00:00
jenkins-bot 24e295cdee Merge "Improve abstraction around template context description" 2019-02-20 00:33:07 +00:00
Ed Sanders e41fa15dd9 eslint: Enable caching
Makes re-running eslint faster on dev environments.

Change-Id: I15eea5d33ab8000053d96a3f2e11a7db3722772a
2019-02-19 18:53:11 +00:00
Ed Sanders de2a2ca06f Improve abstraction around template context description
* Separate partDescription from partDescription*s* and use Array#map
* Lookup CE node class of current model, instead of using
  ve.ce.MWTransclusionNode hard-coded.

Change-Id: Ief07b865b4c216dc13408b12e8a1354cd2c28dfe
2019-02-19 13:23:14 +00:00
jenkins-bot c06f913e66 Merge "Update VE core submodule to master (6038e6946)" 2019-02-19 07:57:32 +00:00
Bartosz Dziewoński 0a05efe115 Update VE core submodule to master (6038e6946)
New changes:
39b8cf936 Localisation updates from https://translatewiki.net.
38504863c Track feature-use activity for tables
fd614058e Allow document state metadata to be stored without clearing HTML
6038e6946 Localisation updates from https://translatewiki.net.

Bug: T202148
Change-Id: Idd2faf823a8f39507e60efb1bee3e653f9eca70b
2019-02-19 01:41:46 +01:00
Translation updater bot 33955ee615 Localisation updates from https://translatewiki.net.
Change-Id: Id63570e233909efdc90230c30057e6cf041f4ffc
2019-02-18 22:23:31 +01:00
jenkins-bot 557cc0e581 Merge "ve.ui.MWGalleryDialog: Allow normal tools in gallery captions" 2019-02-18 18:47:55 +00:00
Translation updater bot 3245f80f22 Localisation updates from https://translatewiki.net.
Change-Id: I703f03cc56c614dd6cee0112a962a6b28deedcd6
2019-02-17 22:14:49 +01:00
jenkins-bot c1d3f2c365 Merge "build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0" 2019-02-15 21:00:44 +00:00
jenkins-bot 81c16f6b8a Merge "Don't try to set dimensions on an error image" 2019-02-15 19:01:32 +00:00
jenkins-bot 28d4815fa8 Merge "ve.init.mw.ProgressBarWidget: Remove 'filter' property for IE 8 & 9" 2019-02-15 18:45:02 +00:00
Ed Sanders e95ec4e24f Don't try to set dimensions on an error image
Bug: T216267
Change-Id: Icbe8cce3e16b2674cb2400f2381f50c71e32f87c
2019-02-15 18:28:03 +00:00
Bartosz Dziewoński 1998a02b8e ve.init.mw.ProgressBarWidget: Remove 'filter' property for IE 8 & 9
Per I7c083ff57db2fce9a06688d5801149253af6f6da this was only needed
for IE 8 & 9, which we don't support now.

Change-Id: I6e093b8ea6f8304ff296bb74297a465dd7334e07
2019-02-15 17:45:22 +01:00
Translation updater bot 3f2a3cf39d Localisation updates from https://translatewiki.net.
Change-Id: Ief005881cb3599550121f4eeeb030926431792ed
2019-02-14 22:29:37 +01:00
jenkins-bot a4cb1db5d4 Merge "Update VE core submodule to master (1d9e3a217)" 2019-02-13 23:18:25 +00:00
jenkins-bot 3753f392df Merge "tests: Register TestModules via extension.json" 2019-02-13 22:16:46 +00:00
James D. Forrester f6a9dc8d85 tests: Register TestModules via extension.json
The 'ext.visualEditor.test' module is no more.

Change-Id: I25e047ca4de7d9082a5a86efa0ea0d403dc1b0fb
2019-02-13 21:55:41 +00:00
James D. Forrester beb1cbfc01 Update VE core submodule to master (1d9e3a217)
New changes:
5f0d6fd0b Fix updatePlaceholder to use attachedRoot
24365b65e ve.ce.Surface: handles clipboard images with HTML
1d9e3a217 ve.ce.Surface: Add more handleDataTransfer tests

Bug: T208631
Change-Id: I4464011284b8b36a1469a0bd79cdf8e79d586997
2019-02-13 13:53:36 -08:00
Ed Sanders 3269d53632 Support only surfacing part of the document
Bug: T76541
Depends-On: I227a0d704b9b337cff2102d424be9795d6362ed7
Change-Id: Iac71a51c8696434658f24fbb41c8142237bd810e
2019-02-13 19:03:44 +00:00
Ed Sanders bc02c44d36 rootNode/documentNode -> attachedRootNode
Change-Id: I56bb10749cac04e17ace2781b4d693ec5f522e7c
2019-02-13 19:03:36 +00:00
Bartosz Dziewoński 7b2bd6be09 ve.init.mw.MobileArticleTarget: Better match surface top spacing to read mode
Using margin instead of padding allows the surface margins to collapse
with the margins of first/last paragraph inside the surface, like they
do in read mode. This fixes the slight jump seen in T210630#4949865.

Bug: T210630
Change-Id: I69d4d4bd9390a1007bc40cda9e78a6b3e7a1bd1d
2019-02-13 13:37:31 +01:00
Bartosz Dziewoński 7fedb7be07 ve.init.mw.MobileArticleTarget: Change "back" tool icon from "<" to "x"
Icon name changed from 'previous' to 'close'.

This matches MobileFrontend's wikitext editor and other overlays.

Bug: T210630
Change-Id: I5f588c65887dd2247d3f816959807f943215e0c3
2019-02-13 00:29:24 +01:00
Translation updater bot f3768c8c21 Localisation updates from https://translatewiki.net.
Change-Id: I27f3cb6847ede888aab68c135d37a047dea5fe08
2019-02-12 22:25:51 +01:00
Bartosz Dziewoński 1faf0b00fa Filter out duplicate categories in NWE preview
Use them as object keys, which naturally deduplicates the entries.

Bug: T214811
Change-Id: I6159021b95d78b1a163faebb289578d277ff110d
2019-02-12 19:18:09 +01:00
James D. Forrester 5ff1ea4ab0 Update VE core submodule to master (3df16c6ce)
New changes:
3df16c6ce Add back deprecated alias 'root' of 'attachedRoot'

Change-Id: I6074248ddde90ad4feebbbb97c9449bb57be37b0
2019-02-11 14:04:21 -08:00
Translation updater bot 62229b189a Localisation updates from https://translatewiki.net.
Change-Id: I0294452104f584cf5772bfeae09142eae5ce222a
2019-02-11 22:28:28 +01:00
James D. Forrester ade7830f42 Update VE core submodule to master (121f78425)
New changes:
121f78425 Convert if-block to while-block for repeated annotations

Bug: T215741
Change-Id: Iae7ab58f0be8cb0e9c1d209c302bf7325750cf04
2019-02-11 08:29:03 -08:00
Translation updater bot aa0a3b806e Localisation updates from https://translatewiki.net.
Change-Id: Ia3f9b92b0337aa69c186c9c214c07c044debd0fc
2019-02-10 22:19:03 +01:00
James D. Forrester f24f3f0bb4 Update VE core submodule to master (c4d559b29)
New changes:
3ca89325c Support only surfacing part of the document
cbd658090 Return teardownPromise from Target#destroy
1e50283cc Remove teardown hacks
432a07291 Remove surface model disable/enable calls from inspectors
ee056df77 Remove deprecated surface.disable/enable aliases
8c93458d5 Abstract out #isEditable from FragmentInspector#getMode
c4d559b29 Remove duplication of action in AnnotationInspector

Bug: T76541
Change-Id: Iea29e565d7da46d1bc8763ab0b8e549566d19b50
2019-02-09 14:18:47 -08:00
jenkins-bot e965868def Merge "Fix TypeError in MWTocWidget.initFromMetaList" 2019-02-09 18:47:08 +00:00
Chunliang Lyu 4774fbdf5c Fix TypeError in MWTocWidget.initFromMetaList
If a page contains __NOTOC__ magic word, it would break the VisualEditor
with "Uncaught (in promise) TypeError: Right-hand side of 'instanceof' is not
an object at VeUiMWTocWidget.ve.ui.MWTocWidget.initFromMetaList".

The issue seems to be that we removed ve.dm.MWTOCForceMetaItem and
ve.dm.MWTOCDisableMetaItem in commit 57a06a6e75,
but the code in initFromMetaList still refers to them.

Change-Id: I857cddcc7d4aa73375357ef922591ed94d760166
2019-02-09 19:31:27 +01:00
Roan Kattouw b15f819fdf ve.init.mw.Platform: Migrate away from deprecated specialCharacters API
Use require('mediawiki.language.specialCharacters') instead of
mw.language.specialCharacters.

Change-Id: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e
2019-02-08 16:59:25 -08:00
James D. Forrester 3d29156cfe Update VE core submodule to master (a5437289b)
New changes:
6df27402a ve.ce.Surface: Handle all font weights above 700
bfebd5a28 Fix function name
a5437289b Localisation updates from https://translatewiki.net.

Change-Id: I1980a836de0d393f55adbe47b91337fb7ca3cb5f
2019-02-07 16:22:41 -08:00
Translation updater bot 848c0e2375 Localisation updates from https://translatewiki.net.
Change-Id: I91ae3763612f1e44c34435dcfb96d893e5c11b29
2019-02-07 22:28:56 +01:00