Ed Sanders
afbed7c5b3
JSDoc: Fix event documentation and complex return types
...
Change-Id: I5dbce39294a34a999303ccfec88261d8c92b17ca
2024-04-29 19:14:26 +01:00
James D. Forrester
b518e55ef9
docs: Replace JSDuck with JSDoc (and pull-through VE with said change)
...
This is not great, but it's a start (and unblocks other pull-throughs).
New changes:
c401efc98 build: Replace jsduck with jsdoc for documentation
16ba162a0 JSDoc: @mixins -> @mixes
9e0a1f53b JSDoc: Fix complex return types
449b6cc0f Prefer arrow function callbacks
1539af2c8 Remove 'this' bindings in arrow functions
b760f3b14 Use arrow functions in OO.ui.Process steps
57c24109e Use arrow functions in jQuery callbacks
9622ccef9 Convert some remaining functions callbacks to arrow functions
f6c885021 Remove useless local variable
1cd800020 Clear branch node cache when rebuilding tree
Bug: T250843
Bug: T363329
Change-Id: I0f4878ca84b95e3f388b358b943f105637e455f9
2024-04-29 16:16:50 +01:00
Ed Sanders
d42a0772bb
Move verbose copyright message to AUTHORS.txt
...
Avoids having to update the date in every file every year,
which we stopped doing.
Change-Id: I7bf7aa0937eef911e00772470091753a7b06fd3d
2023-12-01 16:07:39 +00:00
Ed Sanders
3966573f02
build: Update ESLint to 0.26.0 and autofix
...
Change-Id: Ia5e15684c1c3dcd69985445a09fc4e4910368b5b
2023-11-28 11:18:09 +00:00
Ed Sanders
f6ea2e3457
Fix resize of MWAceEditorWidget when setting up
...
Bug: T303964
Change-Id: Ic8efbd7df74213fddaec987aff60e733f9550db2
2022-03-18 22:30:54 +00:00
Ed Sanders
1b5550f485
Move var declarations inline
...
Mostly ve-mw/ui and a few left overs.
Change-Id: Idea0c94d974e661c49af8ad4545cd8fd98179ca8
2022-03-01 17:50:24 +00:00
Thiemo Kreuz
bc0a34b0ed
Add and fix default values in parameter documentation
...
Same random finds while working on something else. I carefully
checked and made sure these methods are actually called without the
optional parameter.
Change-Id: Iab36fd130258322985b5d6e7f8e1f7b4ee235ba2
2022-02-21 13:19:21 +00:00
Thiemo Kreuz
c2017f74b2
Remove @param/@return docs that literally repeat the code
...
These don't add any knowledge but make the code harder to read
and maintain, and are an additional source of errors.
Change-Id: Ied57741a3f985e355adfddb4e75378d5c497faa9
2021-06-14 15:44:51 +02:00
Thiemo Kreuz
8f045a7155
Remove/fix a few small pieces of unused code
...
I found these thanks to PHPStorm.
Change-Id: Ieb30a95debb58d3a454ac3c6f0546e5dbbe77ed4
2021-05-21 11:43:45 +00:00
Ed Sanders
3cde92d60e
AceEditorWidget: Fix toggleLineNumbers
...
Change-Id: I1a48e4351b2249b1ccf0af5c9b2fadd9a97d5f04
2021-01-03 00:23:08 +00:00
Ed Sanders
6076708ff3
build: Update eslint-config-wikimedia to 0.16.0
...
Change-Id: I638e0f82949597e2a2e4ea18fc2f0258f225358c
2020-06-02 21:30:00 +01:00
James D. Forrester
2c77e88d2c
doc: Bump copyright year for 2020
...
Change-Id: I30539877543dc2a57bd1428a00d10ac46d8fc294
2020-01-08 09:13:24 -08:00
David Chan
22098d6b16
Convert $.Deferred() to ve.createDeferred(), except in preinit
...
Follow-up to a8e07e026dea4f54241d1dbb6b7bcdbd8c670db2 in core.
Change-Id: I09333adb4876c6e584a4a6b6a1628227c4cd2616
2019-11-02 13:06:28 +08:00
Ed Sanders
0db4ae6e00
eslint: Enable valid-jsdoc
...
Change-Id: Ia0d1e57246a1c567d73022ceca9b8c02850f9bc8
2019-04-17 17:13:39 +01:00
Ed Sanders
18907dde5a
Implementations for read-only mode
...
Depends-On: Ifaa74be266c048d87f94b4ae2df59cafc7aa155f
Change-Id: Iedd1bd9ce17750ad8528c1a053293c4a7321c5de
2019-02-22 18:20:51 +00:00
James D. Forrester
3c293ea00c
doc: Bump copyright year for 2019
...
Change-Id: I8991b97c980d4149f53eb5601036220ef3c0c440
2019-01-01 13:24:23 +00:00
Ed Sanders
ee5b80aeee
Avoid jQuery.parseHTML
...
Bug: T187713
Change-Id: Ic156d6fb670fa2f79cf3c1d5fe0c6272b53b6440
2018-02-19 15:41:20 +00:00
James D. Forrester
0a7a845a42
doc: Bump copyright year
...
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
James D. Forrester
dddd2c0180
build: Bump grunt-jsonlint to latest and make pass
...
grunt-jsonlint 1.0.8 → 1.1.0
Change-Id: I4a5cdd39f6215cc61a1ef530386a87fdcb0c0088
2017-02-17 16:12:12 -08:00
Thalia
fc61fb9be0
Allow AceEditorWidget to accept autocomplete word list
...
Bug: T155107
Change-Id: I2dd752fb55a4d5596dbc8b8dc69eb55083d7ec66
2017-01-11 17:26:16 -08:00
James D. Forrester
122f49b2dd
build: Bump file copyright notices for 2017
...
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
2017-01-03 08:58:33 -08:00
James D. Forrester
f24e34de3c
build: Bump eslint-config-wikimedia to v0.3.0 and make pass
...
Change-Id: I7449c11aa63c50fda667265c32021439cc53471f
2016-11-15 15:05:05 -08:00
Derk-Jan Hartman
406e9f8e9c
Enable conditional loading of ACE language modes
...
require bypasses Ace's internal loadModule() logic which is capable of
on demand loading of Ace modules. Because unloaded modules are not
defined, they cannot be required, and because we don't use RL to preload
all modes (because it's a lot of bytes), currently only very few of the
available language modes were currently available.
Also validate language mode names passed to Ace.
Bug: T148518
Change-Id: I82d278920695be12aa80a79548abf8b8ce5445fd
2016-10-19 02:23:17 +02:00
Derk-Jan Hartman
fbdad82b99
Use slice instead of substring per code conventions
...
Change-Id: I5de8b485d287db097f2ad63a7edf75f86a86822d
2016-09-26 21:34:37 +02:00
Derk-Jan Hartman
148c6b53b4
MWAceEditorWidget: Configure Ace with its base path
...
Configure the basePath for Ace, so that its own loader knows from where
to lazy-load additional resources. This will enable all known modes and
the worker scripts for linting.
Bug: T124419
Change-Id: Ie71518917ab966743e8397b23ffb050ca47e9ff4
2016-09-26 14:54:42 +02:00
James D. Forrester
5ecf40f51e
build: Bump devDependencies to latest and make pass
...
babel-polyfill 6.8.0 → 6.9.1
grunt-jscs 2.8.0 → 3.0.0
grunt-jsonlint 1.0.7 → 1.0.8
grunt-stylelint 0.3.0 → 0.4.0
stylelint-config-wikimedia 0.2.0 → 0.2.2
Change-Id: I4db467c7f2bc291a94e7bab86d18e48a44f6054c
2016-06-07 17:17:02 +01:00
Thalia
003e02efaa
MWAceEditorWidget: Update maxRows and minRows if minRows is changed
...
This was being done correctly in initialize, but not in setMinRows.
Bug: T131009
Change-Id: I57c771720c59ca1d75f0b9bc14e7c834237019d5
2016-03-27 17:42:11 +00:00
Ed Sanders
5d5d5419c6
AceEditorWidget: Use namespaced 'require'
...
The un-namespaced version will soon be removed to fix RL issues.
Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
2016-03-14 16:56:16 +00:00
Thalia
16330ac05d
Add method for setting minimum number of rows in Ace editor widget
...
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
2016-01-22 17:05:35 +00:00
James D. Forrester
ada58df361
build: Bump file copyright notices for 2016
...
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
Thalia
f8fbbdf66d
Make Ace Editor adjustSize method chainable
...
Change-Id: I48307bd9184bb238a553d178c0d66084244e9ebf
2015-12-19 10:57:04 +00:00
Thalia
3d98b1d291
Add autocomplete options to AceEditorWidget config options
...
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
2015-11-24 19:44:41 -08:00
jenkins-bot
8fae033411
Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs"
2015-11-19 16:47:13 +00:00
Ed Sanders
dbdae59128
AceEditorWidget: Ensure loadingPromise is set when setupEditor runs
...
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
2015-11-18 23:11:10 -08:00
jenkins-bot
9f1aedbefc
Merge "Make selectRange method of AceEditorWidget focus the input"
2015-11-19 03:28:44 +00:00
Thalia
18448bb42b
Make selectRange method of AceEditorWidget focus the input
...
The selectRange method does this in TextInputWidget, so it
should here too.
Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
2015-11-18 19:14:50 -08:00
jenkins-bot
718e06cf1b
Merge "Add method to toggle the AceEditorWidget print margin"
2015-11-18 21:46:44 +00:00
Thalia
21fd89ba3c
Add method to toggle the AceEditorWidget print margin
...
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
2015-11-18 13:38:41 -08:00
Thalia
88d466ba23
Make focus method of AceEditorWidget chainable
...
The focus method of InputWidget and other descendants
of InputWidget is already chainable
Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
2015-11-18 12:21:44 -08:00
Ed Sanders
a5d700807a
AceEditorWidget: Implement getRange
...
Depends on I109a666679 in OOUI.
Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
2015-11-18 03:32:54 +00:00
Ed Sanders
5e96050b48
AceEditorWidget: Implement selectRange
...
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.
Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
2015-11-17 23:39:33 +00:00
jenkins-bot
3e9d040a79
Merge "AceEditorWidget: Allow users to force an Ace editor refresh"
2015-11-16 22:46:24 +00:00
Ed Sanders
35c44db988
AceEditorWidget: Allow users to force an Ace editor refresh
...
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.
Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
2015-11-16 12:12:10 -08:00
Ed Sanders
470a4a551b
AceEditorWidget: Refactor to ensure setValue runs synchronously
...
Also ensure setEditorWidget is only called once when
loadingPromise resolves.
Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
2015-11-16 11:36:08 -08:00
Ed Sanders
b21b939a67
AceEditorWidget: Emit resize event at end of cycle
...
Ensures the widget has taken its new size before emitting the event.
Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
2015-11-13 18:48:35 -08:00
Ed Sanders
6dd7576941
AceEditorWidget: Add method to clear undo stack
...
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.
Bonus: Add documentation for the widget.
Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
2015-11-03 13:41:09 -08:00
jenkins-bot
adb0c427ef
Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it"
2015-11-03 01:47:41 +00:00
Ed Sanders
e582fae840
[PULL THROUGH] Remove resize detection now that TextInputWidget implements it
...
This depends on the OOUI release which contains Iaadaf1f9f.
Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
2015-11-03 01:13:26 +00:00
Ed Sanders
bd22be33db
AceEditorWidget: Preserve selection on setValue
...
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.
Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
2015-10-30 16:14:09 +00:00
Ed Sanders
def886b845
AceEditorWidget: Make setters chainable and support invalid flag
...
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
2015-10-27 19:02:17 +00:00
