Commit graph

18817 commits

Author SHA1 Message Date
David Lynch 5ccf0324f0 Improve DiscussionTools a/b test bucket logging
Make sure it works on pages which don't trigger DT, such as full-page
wikitext editing.

Bug: T301497
Change-Id: Id3d46eef319f278ee71fbbedbddd16d5ffd540d8
2022-02-11 15:58:25 -06:00
Translation updater bot 7bde7d1712 Localisation updates from https://translatewiki.net.
Change-Id: I1abe1b21247d82264c4dc2f58265b50cddb930df
2022-02-11 08:42:37 +01:00
Ed Sanders fb8815f658 Fix some behaviour when user aborts VE loading with escape
* Pass 'noPrompt' to #tryTeardown
* #loadFail gets triggered by the data promise being aborted,
  so if 'activating' has been cleared at this point, don't
  prompt about there being load error.
* Retry/cancel dialog assumed you were coming from a wikitext
  editor. Rewrite the logic to handle teardown the target if
  the user is coming from read mode.

Change-Id: If9e5d1fbf00f8359f4d06fe7fc3064cc7e349bc9
2022-02-11 00:15:35 +01:00
Translation updater bot b37d95244b Localisation updates from https://translatewiki.net.
Change-Id: If0e230f40c97fc4d61481b99ec1f549d970027b8
2022-02-10 08:42:22 +01:00
jenkins-bot 0ab24602b6 Merge "Modernize some warnings about account not being registered" 2022-02-09 22:05:07 +00:00
Bartosz Dziewoński 8c0a6bce38 Modernize some warnings about account not being registered
Matching MediaWiki change I7a7046bf9b9765cbb82ec3caa1530de7f05e0da4.

Change-Id: I5b2587f00d00622a5e431d0fd69bdf8979b7bc53
2022-02-09 21:26:18 +01:00
jenkins-bot c3bd77c00f Merge "build: Updating npm dependencies" 2022-02-09 15:38:37 +00:00
jenkins-bot 962d95a51f Merge "Add ctrl/cmd backspace hotkey to delete part" 2022-02-09 12:04:25 +00:00
jenkins-bot d21783c363 Merge "Disable hide unused widget when all are selected" 2022-02-09 11:47:47 +00:00
WMDE-Fisch ce230afa09 Disable hide unused widget when all are selected
I bit more logic was needed to make sure, the state of the widget
resets when all unused fields are added during search.

Bug: T299811
Change-Id: I3006c233fda5490e323bc3a3e631bf0c1199bda3
2022-02-09 09:23:14 +00:00
libraryupgrader aa28b52dc9 build: Updating npm dependencies
* eslint-config-wikimedia: 0.21.0 → 0.22.1
* ansi-regex: 5.0.1 → 5.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* string-width: 4.2.3 → 4.2.3
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* strip-ansi: 6.0.1 → 6.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v

Change-Id: Iad400485f197940efd00dfabaddcae805365d116
2022-02-09 07:52:22 +00:00
Translation updater bot cee6e45730 Localisation updates from https://translatewiki.net.
Change-Id: Idaed10586f81902882d6a13dd344c432a4af67bc
2022-02-09 08:13:20 +01:00
jenkins-bot 25b97b933e Merge "ApiParsoidTrait: Make $title optional as it is not required when $oldid set" 2022-02-08 18:22:29 +00:00
WMDE-Fisch 4b2931276c Add ctrl/cmd backspace hotkey to delete part
Bug: T300971
Change-Id: Ie8752d632fba6a15cbf45176b71b3c77a7171360
2022-02-08 16:17:12 +00:00
WMDE-Fisch 9e5db239af Add hints for translators when the term 'field' is used
Bug: T300641
Change-Id: I05aef0cbbefb6a8d6899b5bff36566028e822259
2022-02-08 16:15:39 +00:00
jenkins-bot 7d297a20e9 Merge "Wire move/delete hotkeys to button functionallity" 2022-02-08 16:09:22 +00:00
jenkins-bot 5634e5e378 Merge "Hide unused paramters by default on multipart" 2022-02-08 15:58:16 +00:00
Ed Sanders ef29801474 ApiParsoidTrait: Make $title optional as it is not required when $oldid set
Change-Id: I307b649bf69e72ee5ca58c394af40e31c860d463
2022-02-08 15:09:28 +00:00
WMDE-Fisch b35ea59de5 Hide unused paramters by default on multipart
Covers the base functionality to hide the parameters. Performance
optimizations could be done in a follow up.

Bug: T300640
Change-Id: Ia99b5da392273f1445e475a0720a656460612dcf
2022-02-08 15:56:40 +01:00
WMDE-Fisch ef87088198 Wire move/delete hotkeys to button functionallity
The behavior is now consistant with what would happen when the
buttons are triggered.

Instead of emitting a button click I directly wired the methods
that will by triggerd by the click. This might make it easier to
remove the old sidbar later.

To avoid movement when the buttons should be disabled, an
additional check was added to the onMove method. It's not identical
to the more complex check in the outlineControlsWidget, but should
be enough for our use case. The onDelete method already just does
nothing if nothing is selected.

Bug: T300971
Change-Id: I8a278c9657c91fd648944b5a8c1204c9fff75b7e
2022-02-08 15:41:01 +01:00
Translation updater bot 99878d3634 Localisation updates from https://translatewiki.net.
Change-Id: I42bb2ccf22d9fe6e1ca587593fda2c9454a420b0
2022-02-08 08:07:16 +00:00
jenkins-bot 098791f6c7 Merge "Add vector-body class to diff/previews" 2022-02-07 23:38:15 +00:00
Translation updater bot 05c4329055 Localisation updates from https://translatewiki.net.
Change-Id: Ibc3fbad894f18d0ea73a220951ff43374b38f10d
2022-02-07 08:23:12 +01:00
jenkins-bot 934af1d42d Merge "ApiParsoidTrait: Add "@return never" for Phan" 2022-02-05 23:43:24 +00:00
jenkins-bot 3355918a30 Merge "Remove redundant Phan annotations" 2022-02-05 23:41:55 +00:00
Ed Sanders 5739da585a Add vector-body class to diff/previews
Bug: T287733
Change-Id: I6a4befb2a29489c767df5896a86ef6a607938685
2022-02-05 22:51:05 +00:00
Bartosz Dziewoński 72c68e9e65 Remove redundant Phan annotations
Change-Id: Ic87fcc132b310191b086ccf7facfdf262a544eb9
2022-02-05 16:55:42 +01:00
Bartosz Dziewoński 9e22d21c8e ApiParsoidTrait: Add "@return never" for Phan
Like in MediaWiki core in I895f70e82b3053a46cd44135b15437e6f82a07b2.

Change-Id: I3cc8f887534897153fdefb78a7f28de42ffdf217
2022-02-05 16:49:40 +01:00
jenkins-bot f4824633bd Merge "selenium: Refactor WebdriverIO tests from sync to async mode" 2022-02-04 17:52:51 +00:00
Translation updater bot a839e3c3b1 Localisation updates from https://translatewiki.net.
Change-Id: Ic40782ee2e5d237e7b396927df55f4e274dc9040
2022-02-04 08:22:44 +01:00
Ed Sanders b0e32c22fa Remove MWDismissibleMessageWidget and use MessageWidget's showClose option instead
This option was added in 0.43.0. Now that the close button is handled,
the remaining functionality (store a flag in local storage, and fixing
link targets) doesn't really justify a separate class, especially as
it's currently only used once.

Change-Id: I0fd81cadccc077dbf957302f9f41409c5a1f4f20
2022-02-03 16:37:52 +00:00
Translation updater bot 29f95e78ef Localisation updates from https://translatewiki.net.
Change-Id: I49ff4f0b18621039883f73bb64edcce3a7e7af71
2022-02-03 08:44:49 +01:00
osamaahmed17 40c5c4fe9e selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki and webdriverio
because async mode needs at least webdriverio v7.9.

Remove npm package: @wdio/sync.

Bug: T299756
Change-Id: I4a09ccddd8049f84232b035b664b42a4e98d7ff0
2022-02-03 10:41:35 +11:00
David Lynch 9707d5e686 New bucket for abtest data
Bug: T291308
Change-Id: I20fb26fe5e294f6c117038bcef6f5ba92b01340b
2022-02-02 15:54:23 -06:00
Translation updater bot ad563c0222 Localisation updates from https://translatewiki.net.
Change-Id: I990290e7553872ce48f6d28ed44caa2609b12595
2022-02-02 08:20:33 +01:00
jenkins-bot b5cb82bc92 Merge "Re-apply "Re-duplicate deduplicated TemplateStyles"" 2022-02-01 23:36:05 +00:00
Ed Sanders 02cfb4bf71 Introduce VisualEditorBeforeEditorHook
Extensions can return false in this hook to disable VE on specific pages.

Bug: T174180
Change-Id: I764843fcfc07149c50ae6af758df43ca454d3296
2022-02-01 17:57:27 +00:00
jenkins-bot 440620ae73 Merge "Show a keyboard shortcut when hovering over a toolbar button" 2022-02-01 12:33:39 +00:00
Translation updater bot 3bc8a1b4db Localisation updates from https://translatewiki.net.
Change-Id: I589bcb60ccec00f5cf8dde3c417a6c0c6a09a26f
2022-02-01 08:27:43 +01:00
libraryupgrader e28310371f build: Updating npm dependencies
* wdio-mediawiki: 1.1.1 → 1.2.0
* ansi-regex: 5.0.0 → 5.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* json-schema: 0.2.3 → 0.4.0
  * https://github.com/advisories/GHSA-896r-f27r-55mw
* jsprim: 1.4.1 → 1.4.2
  * https://github.com/advisories/GHSA-896r-f27r-55mw
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* node-fetch: 2.6.2 → 2.6.7
  * https://github.com/advisories/GHSA-r683-j2x4-v87g
* optipng-bin: 6.0.0 → 6.0.0
  * https://github.com/advisories/GHSA-44c6-4v22-4mhx
* string-width: 4.2.3 → 4.2.3
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* strip-ansi: 6.0.1 → 6.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* sugarss: 2.0.0 → 2.0.0
  * https://github.com/advisories/GHSA-566m-qj78-rww5
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* validator: 13.6.0 → 13.7.0
  * https://github.com/advisories/GHSA-qgmg-gppg-76g5
  * https://github.com/advisories/GHSA-xx4c-jj58-r7x6
* zopflipng-bin: 5.0.0 → 5.0.0
  * https://github.com/advisories/GHSA-44c6-4v22-4mhx

Change-Id: Idee4aef18cbc4d5ec29d28385081fc0c89ecd50c
2022-02-01 06:57:37 +00:00
Bartosz Dziewoński e212ddcac2 Update VE core submodule to master (37ee8ffcd)
New changes:
ec713a57a Localisation updates from https://translatewiki.net.
c2f60cd96 DiffElement: Don't show meaningless spaces inside added block nodes
78ca42ce2 Localisation updates from https://translatewiki.net.
6aa9549d2 Target: Don't create toolbar in scroll handler
de8319584 Fix regex that replaces nothing with nothing
4a8584a7c Add more complex internal list diff test

Bug: T300444
Change-Id: Ic3299038c589f4b980488ea6ec81b6ef4b3d49cc
2022-01-31 18:16:41 +01:00
jenkins-bot fb6332ad5c Merge "Use OOUI 'play' icon for audio placeholder" 2022-01-31 10:19:18 +00:00
Translation updater bot 614f8425c4 Localisation updates from https://translatewiki.net.
Change-Id: I68fe3156fc2e9631fb24856fd8a169a653aa206e
2022-01-31 08:22:50 +01:00
jenkins-bot 23b8ec2f54 Merge "Don't attempt to pin first visible section if firstHeading is visible" 2022-01-28 17:27:06 +00:00
jenkins-bot d63cbf86f7 Merge "Follow naming convention for static methods" 2022-01-28 15:06:24 +00:00
WMDE-Fisch dac7b5206b Allow disabling VE and 2017 wikitext editor from FileImporter
Bug: T298345
Bug: T174180
Change-Id: I80be4648564630b71e6e61d4c5e50538d134ba7a
2022-01-28 08:55:15 +00:00
Bartosz Dziewoński a2390efbf4 Re-apply "Re-duplicate deduplicated TemplateStyles"
Previous attempt in 005a8d24ef,
reverted in 3c1d167b33.

The deduplicateStyles() function lacked a check for fosterable
positions, which caused T299767. This is now fixed.

Also added tests.

Bug: T287675
Bug: T299251
Change-Id: I0d22be9b66d26d09373cee63dd6ce52c1659e62d
2022-01-28 02:08:09 +01:00
Ed Sanders 4af235822b Don't attempt to pin first visible section if firstHeading is visible
This prevents an unwanted scroll when the main edit link is used
and the first section is below the viewport.

Change-Id: Ib99ebe2dc5c105c3fcbd687ef5740166267f5536
2022-01-28 00:02:09 +00:00
Iniquity 427f8ab3ba Use OOUI 'play' icon for audio placeholder
Bug: T299278
Change-Id: I8cc254fdf28cb83d5c4fe310a61a8a3df2d49270
2022-01-27 21:10:51 +00:00
Thiemo Kreuz 7298834211 Follow naming convention for static methods
Change-Id: Ie2d7fb061fcb46765ba8796911425d58218736d1
2022-01-27 09:12:23 +01:00