Commit graph

8115 commits

Author SHA1 Message Date
Ed Sanders adcfb56761 ve.init.mw.Target#save: Bind this#onSave, not #onSave
Change-Id: I62fbb6f31c0ddd17a1179fb4c2d8f13e44e9c9bb
2015-08-03 00:30:06 +00:00
jenkins-bot a15c54f4db Merge "MWSaveDialog: Make a FragmentDialog now that's available" 2015-08-01 22:44:18 +00:00
jenkins-bot b46bd69c49 Merge "Move toolbarSaveButton init to base class" 2015-08-01 22:43:25 +00:00
jenkins-bot c98038d258 Merge "MW target: Make 'static' methods either static or be instance methods" 2015-08-01 22:41:53 +00:00
Ed Sanders dc71b4849b MWSaveDialog: Make a FragmentDialog now that's available
* Make save a FragmentDialog and open with WindowActions so
  the selection is restored automatically.
* Pass in some information in setup data.

Change-Id: I254b71f252adce064b9c2d2bf2cb6c8d0018e31f
2015-08-01 22:41:17 +00:00
Ed Sanders fd2ef3e4cd MW target: Make 'static' methods either static or be instance methods
MW target has 'static' methods, some of which aren't attached
to the static property, the rest of which should be instance methods.

Rename success/fail functions to remove 'on' as that is reserved for
actual event listeners.

Change-Id: I63e68dbe1923906208b180abfc4a9a280b4d098e
2015-08-01 22:38:49 +00:00
Translation updater bot b61ce1bb1b Localisation updates from https://translatewiki.net.
Change-Id: I0c6c26e8530944e904a351bbae82ac7b3e74611a
2015-08-01 21:49:37 +02:00
jenkins-bot 437d69d4a5 Merge "Revert "Only change edit tab text if the current text is as expected"" 2015-08-01 00:32:24 +00:00
Jforrester 37b50a273f Revert "Only change edit tab text if the current text is as expected"
Apparently doesn't work in English.

This reverts commit 8239437a3f.

Change-Id: I03a375c85b32058992d5956b6801605fa997dd7d
2015-08-01 00:29:51 +00:00
jenkins-bot c8ab0003f3 Merge "Stop removal of only template placeholder from transclusion" 2015-07-31 21:58:58 +00:00
Alex Monk 8239437a3f Only change edit tab text if the current text is as expected
Otherwise we end up colliding with other extensions like Translate

Bug: T94386
Change-Id: Ib48ce33b8db9639400415cf778cd42e2d47070f1
2015-07-31 22:41:01 +01:00
Translation updater bot d319952727 Localisation updates from https://translatewiki.net.
Change-Id: I24ab62aea021891835bbc297966502ee574655e6
2015-07-31 21:50:11 +02:00
Ed Sanders e9b7f4c029 Move toolbarSaveButton init to base class
Change-Id: I145c4029f9e1a6e46591134a7756dada1251551b
2015-07-31 12:03:14 +01:00
Translation updater bot 1635ac7c53 Merge "Localisation updates from https://translatewiki.net." 2015-07-30 19:14:52 +00:00
Translation updater bot ba6fca03cd Localisation updates from https://translatewiki.net.
Change-Id: I0de5d945fbf3b21e91be2270166a675e0e3c440c
2015-07-30 21:13:45 +02:00
jenkins-bot 16357376d0 Merge "When saving from review screen, swap to main save screen" 2015-07-30 19:13:23 +00:00
jenkins-bot 1bd8ecf61d Merge "Bring in code from MobileFrontend" 2015-07-30 17:25:14 +00:00
Ed Sanders d2c15e9eb5 Bring in code from MobileFrontend
* Use local edit source tool, and emit event to MF
* Bring in toolbar styles, bonus: remove old desktop style hacks

Bug: T96186
Change-Id: I89351e409aa4e9d626edd7151ae05bdcd58f1cee
2015-07-30 17:13:00 +00:00
Ed Sanders 915a82d2da Remove empty DesktopArticleTarget-shared.css
DesktopArticleTarget.css serves the same purpose and is non-empty.

Change-Id: Ieb2c41cdd774fac09537597b0bf9315aa446020c
2015-07-30 17:58:54 +01:00
Ed Sanders cf191f5fa8 Update VE core submodule to master (8feab4e)
New changes:
11953f7 Localisation updates from https://translatewiki.net.
0dbafb0 Update OOjs UI to v0.12.2
cbd0982 Replace placeholder color with opacity
087365c Support other types of 'empty' document placeholders
7692890 Make scrollIntoView a VE utility function
5a1a159 Localisation updates from https://translatewiki.net.
8edf71e [BREAKING CHANGE] Kill ve.indexOf and thus @until
bb02b02 build: Bump various devDependencies to latest
cb5b2cd Fix scrollIntoView util binding
8feab4e [BREAKING CHANGE] Use config object for Target constructors

Local changes:
* Use config object for Target constructors

Bonus:
* Add CSS classes to MW targets
* Use 'super' calls

Change-Id: Ieb4e4eb3663aab2706c0f3ecc8b82e00555df1d5
2015-07-30 08:28:48 -07:00
Ed Sanders 9921759456 Fix target rename merge conflict in CSS
Change-Id: I4ca015696d51c59a4c533127458bf5453d092bad
2015-07-30 09:47:55 +01:00
Ed Sanders 08a9551c84 MobileArticleTarget: Collapse text style buttons
B/I doesn't fit with link & cite on a iPhone 6

Change-Id: Ib23b2f8540425ee5d8265f369aea250e900a0c5f
2015-07-30 00:25:52 +00:00
jenkins-bot 2c7a42fff9 Merge "Settings dialog: Focus redirect target input when redirect is enabled" 2015-07-30 00:20:21 +00:00
jenkins-bot 9f20acfc9a Merge "[BREAKING CHANGE] Bring in some code from MobileFrontend" 2015-07-29 23:47:07 +00:00
Ed Sanders 3593184f42 [BREAKING CHANGE] Bring in some code from MobileFrontend
* Bring in back button & save button from MobileFrontend
  so they are properly styled OOUI widgets
* Accordingly, move toolbar save button code up into base
  MW target.

Bug: T96186
Change-Id: Ic89dd4efb831fc3b09980da16524276f6568619d
2015-07-29 16:16:39 -07:00
Alex Monk 45325e0db7 Settings dialog: Focus redirect target input when redirect is enabled
Bug: T106616
Change-Id: Ia635552825194908503b8e8eef61f5fa2733a9da
2015-07-29 23:58:43 +01:00
jenkins-bot f616edd310 Merge "DesktopArticleTarget-*.css: Placeholder CSS fixes for skins" 2015-07-29 22:14:05 +00:00
Translation updater bot 7ae8321366 Localisation updates from https://translatewiki.net.
Change-Id: I67fff722b4925649f82e2672f48871fce296d7d7
2015-07-29 21:52:32 +02:00
Ed Sanders 03449dca80 DesktopArticleTarget-*.css: Placeholder CSS fixes for skins
Change-Id: I8c7f98cc083c0811cd847a8b3874a586487658ca
2015-07-29 12:02:09 -07:00
Ed Sanders bb57348a9e DesktopArticleTarget#activate: Rename pageTarget to target
Change-Id: Iae71a050058afb2c1111a99ede5b969afbf5aca6
2015-07-29 17:58:33 +00:00
Ed Sanders fecdc29a38 Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-*
Except in cases where it is only applied to desktop articles.

Change-Id: I40a9dabcd8454138f94affde809afee9c93732a4
2015-07-29 18:26:36 +01:00
Ed Sanders b5de6fa575 [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget
Change-Id: I6a8fa76dc4d70cc04722e30e3fea6a6112d56b40
2015-07-29 18:26:36 +01:00
Alex Monk 7b7219fcb6 When saving from review screen, swap to main save screen
Bug: T107251
Change-Id: I78fb0b8804ffa4b8accd4d2619d7bbd34e2c4f1e
2015-07-29 17:48:43 +01:00
jenkins-bot 85ca7d3e94 Merge "Close the wikitext switch confirmation dialog if serialisation errors" 2015-07-29 00:41:26 +00:00
Roan Kattouw 6d22fd1aa7 Follow-up 8250c8ad54: unbreak ApiResponseCache
.set() should not overwrite existing deferreds; instead,
it should resolve the existing deferred if it's pending.
This is necessary because .set() is used by processResult().
Without this, passing .get() a title that no information
is known for results in a promise that is never resolved,
because the associated deferred is overwritten as soon
as the API response arrives.

Still make .set() a no-op if data has already been set,
by checking if the deferred is pending. For .resolve() this
doesn't matter, but for modifying this.cacheValues it does.

Bug: T107212
Change-Id: I70e8c5450f23062db214ccc5c585624d41de6509
2015-07-28 15:10:21 -07:00
jenkins-bot 12d22fe48a Merge "Allow skin developers to set an offset for toolbar floating" 2015-07-28 20:01:57 +00:00
Translation updater bot d319217d34 Localisation updates from https://translatewiki.net.
Change-Id: I48148623ed24a6dc8b3a366f19850b4ed1875f21
2015-07-28 21:51:17 +02:00
Florianschmidtwelzow 4981a8253d Allow skin developers to set an offset for toolbar floating
Usage:
In a skin, that needs this offset, e.g. because it has a fixed header, it should add
this config var somewhere before the hook BeforeOutputPage is called:

$wgVisualEditorSkinToolbarScrollOffset['vector'] = 60;
(if 60px is the offset to use)

Depends on: I2e10c12df8277c84d948e48c6a132c03d6324693

Bug: T95528
Change-Id: Iaa86c2f68afa6403fcc4f5b7c655704512beead4
2015-07-28 11:18:07 -07:00
Translation updater bot 7b787deb32 Localisation updates from https://translatewiki.net.
Change-Id: Ie1c5ee8e499a7f37f9e6be23b6356cc098a79385
2015-07-27 21:36:51 +02:00
Translation updater bot f4978517d0 Localisation updates from https://translatewiki.net.
Change-Id: I2d39f194ddce159861b20f25aaae39deb9d8741b
2015-07-26 21:42:26 +02:00
jenkins-bot 526d092df6 Merge "Trim external link before validating" 2015-07-25 21:56:04 +00:00
Translation updater bot f787e3491d Localisation updates from https://translatewiki.net.
Change-Id: Iefecfb9b1bd63b695a5c5e32f2867a89146fece0
2015-07-25 21:58:40 +02:00
Alex Monk 5931751771 Trim external link before validating
We already trim it before setting it as the actual annotation href

Bug: T103450
Change-Id: I4c7117d7e1e89c98abbafb999033ab7b5f58bdff
2015-07-25 19:42:33 +01:00
Alex Monk 8ae71e205a Stop removal of only template placeholder from transclusion
Bug: T95252
Change-Id: Ibf0537fd63f8315750e398f72807741187985b19
2015-07-25 14:47:36 +01:00
Alex Monk f76b57f1e6 Close the wikitext switch confirmation dialog if serialisation errors
Bug: T103632
Change-Id: Id9aede04ff4f8919770e578fac24ad4a1178b9a6
2015-07-25 14:32:17 +01:00
jenkins-bot 43eb2acf84 Merge "Change reference context title from 'Basic' to 'Reference'" 2015-07-24 19:22:01 +00:00
jenkins-bot af015c120d Merge "Make missingref references uneditable, not uninspectable" 2015-07-24 19:21:59 +00:00
Translation updater bot 8a17282802 Merge "Localisation updates from https://translatewiki.net." 2015-07-24 19:11:37 +00:00
jenkins-bot 6cbdd4fb47 Merge "ParameterWidget: Connect to Search results widget 'choose' events" 2015-07-24 19:11:17 +00:00
Translation updater bot 55299c5f14 Localisation updates from https://translatewiki.net.
Change-Id: I6dc2d8008f023c02b0eac79f3527b25b9be032ae
2015-07-24 21:10:35 +02:00