wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-12 14:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity
15944 commits 14 branches 17 tags 200 MiB
Commit graph

417 commits

Author SHA1 Message Date
Bartosz Dziewoński 84d548e7b1 Remove redundant @method annotations 
A @method annotation is only necessary when the docblock is not
directly followed by a function declaration (in which case JSDuck
assumes it documents a property), e.g. when defining an abstract
function or referencing a function from another library.

I verified that JSDuck generates exactly the same output before and
after this change (docs/data-<hash>.js files are identical).

Change-Id: I7edf51a8560ab9978b42800ab1026f0b5555c3bf
 2019-08-21 23:33:15 +02:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
 2019-08-02 09:51:07 -07:00
Ed Sanders 89ecd64a55 Make extension body the default description for extension nodes 
Change-Id: Ifada2a6a0279e64a1ba82f49e03884e362516a83
 2019-07-31 16:38:27 +01:00
Ed Sanders 22f43207fe Apply active external link fix to all skins 
Change-Id: Ic66082fca53f803f9ede6c100beb9072b40a0c00
 2019-06-18 15:23:10 +01:00
jenkins-bot a0a1f5422e Merge "Fix inheritance of isResizable" 2019-05-13 18:11:44 +00:00
Ed Sanders 4c8346f822 Fix API request for media dialog preview 
Regressed with upgrade to apiversion 2.

Change-Id: I257c367b8f639a389002fefcd074e2fffe5a3bd4
 2019-05-13 12:51:54 +01:00
Ed Sanders 20f876ca69 Fix inheritance of isResizable 
Bug: T223086
Change-Id: Ib57b9a0173903db438120b94ffa391e734aee614
 2019-05-13 12:00:05 +01:00
Ed Sanders bee8344efe Fix initial rendering of interwiki links 
This does not fix the rendering of new
or modified interwiki links, which will
require an API request.

Bug: T185083
Change-Id: Icb72291e8662456e1a233392bf22d786c7eed1e5
 2019-05-07 14:44:18 -05:00
Ed Sanders 258965c8b2 Improve rendering of audio files 
Use a static image of an audio player.

Also disable resizeable handle.

Bug: T206022
Change-Id: Ic41f381e65c40c3682f470b9993b2c9dbbb506c5
 2019-04-28 23:56:08 +01:00
Ed Sanders 0db4ae6e00 eslint: Enable valid-jsdoc 
Change-Id: Ia0d1e57246a1c567d73022ceca9b8c02850f9bc8
 2019-04-17 17:13:39 +01:00
Ed Sanders 403b1f97b1 TemplateContext: Filter out empty template descriptions 
Change-Id: I1be721c30d92b1da4fc226935a7e0a322f0c4d41
 2019-02-25 23:05:51 +00:00
Ed Sanders 1890530b89 ApiVisualEditor: Remove red-link cache warming 
Red-link metadata was added to Parsoid 18 months ago.
On long pages evaluating this information is very slow
(hundreds of milliseconds) and completely redundant.

Bug: T64803
Bug: T209078
Change-Id: I5b6c6da588301ed59fb21e1ce930f5b72db48e67
 2019-02-22 17:49:11 +00:00
Ed Sanders de2a2ca06f Improve abstraction around template context description 
* Separate partDescription from partDescription*s* and use Array#map
* Lookup CE node class of current model, instead of using
  ve.ce.MWTransclusionNode hard-coded.

Change-Id: Ief07b865b4c216dc13408b12e8a1354cd2c28dfe
 2019-02-19 13:23:14 +00:00
jenkins-bot 81c16f6b8a Merge "Don't try to set dimensions on an error image" 2019-02-15 19:01:32 +00:00
Ed Sanders e95ec4e24f Don't try to set dimensions on an error image 
Bug: T216267
Change-Id: Icbe8cce3e16b2674cb2400f2381f50c71e32f87c
 2019-02-15 18:28:03 +00:00
Ed Sanders bc02c44d36 rootNode/documentNode -> attachedRootNode 
Change-Id: I56bb10749cac04e17ace2781b4d693ec5f522e7c
 2019-02-13 19:03:36 +00:00
jenkins-bot ca03c085a2 Merge "Revert "Don't preserveHtmlAttributes on transclusion nodes"" 2019-01-17 12:54:58 +00:00
Bartosz Dziewoński bdfd4b6d8f Revert "Don't preserveHtmlAttributes on transclusion nodes" 
This reverts commit 48db45df76.

Bug: T213922
Change-Id: I7b0bf081fd5a9ab71db1ede3ce6e149cfb4b675a
 2019-01-17 01:42:15 +00:00
Ed Sanders 5461c56380 stylelint: Enforce class name pattern 
Change-Id: Ia41a08424f840d353eb7fc213815f7992da4a2ef
 2019-01-13 15:14:53 +00:00
Ed Sanders 74f6c4899c build: Update eslint-config-wikimedia to 0.10.0 
Change-Id: I63a0ebf0b31a0d5d4e680a4e2a5a0be4850be165
 2019-01-08 17:00:09 +00:00
jenkins-bot bebbff8bab Merge "Don't preserveHtmlAttributes on transclusion nodes" 2019-01-02 18:58:13 +00:00
Ed Sanders 48db45df76 Don't preserveHtmlAttributes on transclusion nodes 
Bug: T207325
Change-Id: I9c92f18c58c044e7f2257aa6993db227896a1468
 2019-01-02 17:11:31 +00:00
James D. Forrester 3c293ea00c doc: Bump copyright year for 2019 
Change-Id: I8991b97c980d4149f53eb5601036220ef3c0c440
 2019-01-01 13:24:23 +00:00
Ed Sanders f2a9ccd5bd Avoid HTML string parsing 
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12

Change-Id: I138e018fdc037d688e055eacddfdc5bfc2cc5abe
 2018-11-21 18:47:19 +00:00
jenkins-bot add7b4d96f Merge "Change type from 'frame' to 'thumb' when resizing" 2018-09-24 16:07:19 +00:00
jenkins-bot 5a679ed8f4 Merge "Use renamed ve.visibleWhitespaceCharacters utility" 2018-09-24 15:37:03 +00:00
Ed Sanders 985a94777a Change type from 'frame' to 'thumb' when resizing 
Bug: T204185
Change-Id: If40c70a074263b870aee4e5c87c3f4b5e98d0c4b
 2018-09-24 15:31:58 +01:00
Thalia bbed4307d7 Separate node classes into individual files 
Bug: T205231
Change-Id: I84a6f2f7a842ab44e1f7103c0f288deda0451e79
 2018-09-24 12:44:45 +01:00
Ed Sanders a2c04973a2 Use renamed ve.visibleWhitespaceCharacters utility 
Change-Id: I2df52341009cbc715c801accdf59cc5d5ce2e9ff
 2018-09-24 12:41:13 +01:00
Ed Sanders 1703cc6361 Move link styling into overridable method for CX 
Change-Id: I5c349d15ecc0df29827d41c9cc408bb826924447
 2018-08-27 12:26:05 +01:00
David Lynch 26f6429702 TemplateStyles support 
MWTransclusionNode will preserve TemplateData <style> in its generated content.

Disable TemplateStyles stylesheets in the original page content, and reenable
them when the surface deactivates.

Remaining TODO: if multiple copies of a template with deduplicated styles are
on the page, and the one containing the actual <style> is removed, all will
lose their styling.

Bug: T197563
Change-Id: Ibd8939eef7d8eb532719f4ee0ce200600449ef81
Depends-On: Ia9f2afcdba5456238e3ef444c202c9b0c78838bf
 2018-08-22 17:03:27 +00:00
Ed Sanders 4ee09f75af Replace Bugzilla numbers with Phab numbers 
Change-Id: I0e91d63b3872520b8f66002615967b2cfe235bf5
 2018-08-09 15:11:27 +01:00
jenkins-bot db8c585f11 Merge "Apply edit surface jQuery.makeCollapsible overrides to visual diffs too" 2018-07-18 06:36:55 +00:00
Bartosz Dziewoński 55108aaf1b Apply edit surface jQuery.makeCollapsible overrides to visual diffs too 
Bug: T194725
Change-Id: I8667dae42e652ef08910c861d22606f482d8f9cd
 2018-07-05 16:09:13 +00:00
Bartosz Dziewoński a247fd4e90 MWImageNode: Make 'mw' attribute optional again 
It contains some rare options that we don't currently make editable,
and we don't set it when creating new image nodes.

We could change our code to always set it, and consider it required,
but that would theoretically be a break in backwards-compatibility.

Bug: T198660
Change-Id: I6e77cce257f733f0f8f6e896b967177ff01658c6
 2018-07-03 21:03:46 +02:00
jenkins-bot 4c88fc7ef4 Merge "Pass page parameter for multipage file (PDF, DjVu) thumbnails" 2018-06-29 20:08:55 +00:00
jenkins-bot 611ef4ef1c Merge "Pass video thumbtime to thumbnail metadata request" 2018-06-29 20:07:42 +00:00
Ed Sanders 715d67b564 Pass page parameter for multipage file (PDF, DjVu) thumbnails 
Bug: T182392
Change-Id: Ib3bc7b13f24493da27078631a41e9c08bcc6c0f4
 2018-06-29 19:26:42 +00:00
Ed Sanders 5cdbc17899 Pass video thumbtime to thumbnail metadata request 
Bug: T198150
Change-Id: Ic8895c359a92fcc60ac486e3daf86db02599d3ff
 2018-06-28 15:52:50 +01:00
jenkins-bot 17041d3f07 Merge "Don't call Resizable constructor conditionally" 2018-06-27 21:49:31 +00:00
Ed Sanders ac88166da1 Give up on realistic styling of mw-collapsible 
Using display:inline causes the <p> to be destroyed
when empty.

Bug: T197987
Change-Id: Icfcb2ddc91e6793221608fac9f2995c6afeb4313
 2018-06-23 14:17:21 +01:00
Ed Sanders b340f526e3 Use WindowAction to open the wikitext paste dialog 
This adds in missing functionality, such as deactivating
the surface selection while the dialog is open.

Change-Id: I0d8652a989504a35e5c235224b0ef924b6dcbeed
 2018-06-13 13:28:15 +01:00
Ed Sanders 6cad6f603d Don't call Resizable constructor conditionally 
Change-Id: I3b5caf81b691aebcd50d3339a42bbaf4fe880fac
Depends-On: I19e63c89fa54f8f4bf1ad6795b8b281c4ad4576a
 2018-06-12 17:18:12 +01:00
jenkins-bot c04e934361 Merge "Simplify conversion of images" 2018-06-07 20:51:51 +00:00
jenkins-bot 5e45047fe0 Merge "Fix parsing of external links, now Parsoid adds 'external' classes" 2018-06-06 21:28:10 +00:00
Ed Sanders dee50b778c MWTransclusionNode: Remove old createInvisibleIcon override 
Bug: T196479
Change-Id: I99aab2e0eee3274305a6877263414ce21049fa5b
 2018-06-05 18:50:14 +01:00
Ed Sanders b79c98f1e3 Simplify conversion of images 
Assume that images provided by Parsoid will adhere to the DOMspec.

Change-Id: I52eb4f27e6b1e1cd092133c3e27e42021ae83783
 2018-06-05 13:05:40 +01:00
Ed Sanders a7049dacea Update language variant node to use new invisible icon API 
Bug: T195887
Depends-On: I4eab7b9edf04454ef1a62535656b179480c3054b
Change-Id: I655757b13514e8ff89c312dcc2e1147d188a2718
 2018-06-04 17:34:22 +00:00
Ed Sanders cb36c6ded3 Fix parsing of external links, now Parsoid adds 'external' classes 
Bug: T196025
Bug: T188656
Change-Id: I89b8ba378108bde6c8db0144ed306cbc8471111b
 2018-06-01 08:47:46 +00:00
David Lynch 4d263afaa2 ce.MWWikitextSurface: ask on paste about wikitext conversion 
Throw a dialog box up to ask whether to convert something with formatting to
wikitext, or downconvert it to plain text.

This logically depends on Ie9aaaa59e9dfa138d394051fe491573253df1805.

Bug: T190079
Change-Id: I6afbbe303d1506426109e75c95f6be546ec48536
Depends-On: Ie9aaaa59e9dfa138d394051fe491573253df1805
 2018-05-23 08:08:22 -05:00