Commit graph

7570 commits

Author SHA1 Message Date
Timo Tijhof 60672bde01 Update VE core submodule to master (ced9f77)
New changes:
168146b inheritdoc lowercase
dc4173e build: Update jscs and grunt-watch
df29ea9 Pass HTMLDocument to convertToData

Change-Id: I028c2b1222c93114c01fd70f06414e2930a5c513
2014-05-15 18:49:50 +02:00
jenkins-bot f0d19359a6 Merge "Fire hook when VE activates/deactivates" 2014-05-14 23:29:34 +00:00
Krenair 28fb8c8d4c Fire hook when VE activates/deactivates
Bug: 65320
Change-Id: I3658d6cbe6dd81d8d143fce9659f2c8c4e25ba07
2014-05-15 00:26:36 +01:00
jenkins-bot fb4b6f0b0d Merge "Move shortcut keys help from "Page options" dropdown to "Help" popup" 2014-05-14 23:16:48 +00:00
Roan Kattouw 29fc9ea1b0 Remove MWCommandHelpDialogTool
Now unused. Also should have been a subclass of the (also unused)
CommandHelpDialogTool in VE core.

Change-Id: I865317aa41dbf93c98620c0f89b6d7ac92499022
2014-05-14 16:16:26 -07:00
jenkins-bot 95828d4ff1 Merge "If no media is found display a message in media insert dialog" 2014-05-14 23:10:23 +00:00
Moriel Schottlender 8f68e9f497 If no media is found display a message in media insert dialog
Add a message indicating to the user that no image results were
found in the media insert dialog in case no results are found.

Bug: 52463
Change-Id: I93aea897d864298bf891a90c2fb147f7d34df06d
2014-05-14 16:08:11 -07:00
jenkins-bot 0680c02aa7 Merge "Hide PageTriage curation toolbar while VE is open" 2014-05-14 23:04:03 +00:00
Krenair 204554a567 Swap from using native confirm() to using an OOUI dialog when cancelling
Relies on:
* I292fb34d in OOjs UI to add the confirmation dialog
** I67329820 in MediaWiki core to use the messages added in OOjs UI
** I38f5bb63 in VisualEditor core to register the confirmation dialog

Bug: 50955
Change-Id: I98f9a03d780556b360b57c018c05a27cc1b3862e
2014-05-14 23:00:35 +00:00
jenkins-bot 424c4e4764 Merge "Revert "Cache image scalable promises by filename"" 2014-05-14 22:56:39 +00:00
Catrope 582daaeb70 Revert "Cache image scalable promises by filename"
Caused bug 65314.

This reverts commit 97bc12a421.

Bug: 65314
Change-Id: Iaca46e5458fbc44446cc92e7241dd24d7de883d8
2014-05-14 22:54:48 +00:00
Roan Kattouw 2e5e7594a8 Update VE core submodule to master (19be0c1)
Also add OO.ui.ConfirmationDialog things and
update Gruntfile.js for breaking changes in VE core.

New changes:
5f1514b Localisation updates from https://translatewiki.net.
0cde22f Localisation updates from https://translatewiki.net.
ca021d8 Fix desktop dialogs
3503287 Localisation updates from https://translatewiki.net.
f02286b build: [BREAKING CHANGE] Add dependency expression
25fc053 Use message function and correct message key
a097202 Create phantom/shield nodes with methods not templates
1399844 Load dependencies in correct order
5a39c9e build: Simplify building of module dependency list
2a3871f build: Upgrade jscs and jshint
7db9b88 Localisation updates from https://translatewiki.net.
d34b2ae Update OOjs UI to v0.1.0-pre (80f1797a5c)

Change-Id: I0f23042e3cadd4614cd1dcd905287af777dd6ed3
2014-05-14 15:27:46 -07:00
Krenair ddd43b8227 Hide PageTriage curation toolbar while VE is open
Bug: 56731
Change-Id: Iee842d4444ead00587dbfb21f93b65bdec728405
2014-05-14 23:19:39 +01:00
jenkins-bot a323589401 Merge "Only send useful oldid while switching to wikitext editor if it's specifically requested" 2014-05-14 21:33:41 +00:00
Krenair 81801edb50 Only send useful oldid while switching to wikitext editor if it's specifically requested
Usually we can just send 0. Sending anything else makes PostEdit think we're restoring an old revision.

Bug: 65269
Change-Id: I60454a7a4ea3f6c7cef4c707da3016dd0ec29b88
2014-05-14 22:24:47 +01:00
Translation updater bot b71683b880 Localisation updates from https://translatewiki.net.
Change-Id: Icfddb1f9e2b0426026f12c701a27cf9ec39df41a
2014-05-14 19:36:29 +00:00
jenkins-bot 00e5b9ea38 Merge "Changing formatting of Cite drop-down for mobile/tablet interface" 2014-05-14 18:49:53 +00:00
jenkins-bot bfa15be3db Merge "[browser test] Don't rely on existing page for anon edit test" 2014-05-14 17:58:48 +00:00
Ed Sanders af9cf9b2ff inheritdoc lowercase
Change-Id: Ie7a824a4f145d039b45fe60afbc7fe2a382c5e2d
2014-05-14 16:46:16 +01:00
cmcmahon 9db7256fff [browser test] Don't rely on existing page for anon edit test
Change-Id: I43a7d78894ec290faa9e74b085aa2ead15958c62
2014-05-14 08:37:22 -07:00
kaldari e2f29231cb Changing formatting of Cite drop-down for mobile/tablet interface
These changes are to accomodate the design for the mobile/tablet
version of VisualEditor which uses an icon rather than a label
for the drop-down button.

Change-Id: I1086ed4a84ae4061fcc79cc7f587657232c5d5df
2014-05-13 16:49:22 -07:00
Translation updater bot 5a1e66b0a0 Merge "Localisation updates from https://translatewiki.net." 2014-05-13 20:12:02 +00:00
Translation updater bot 841e2f9456 Localisation updates from https://translatewiki.net.
Change-Id: I8a8e62ebc4bc04228301b281d70e2c049fea5bbb
2014-05-13 20:11:13 +00:00
Moriel Schottlender 2731b1ee48 Make sure originalDimensions are available before use
Before applying default size based on originalDimensions, make sure
these are available through the scalable call. The image will be
marked as default size, but the presentation will depend on whether
or not we have the defaultDimensions from the API.

Bug: 65239
Change-Id: I41b30498713e969bd24ef0ad3e9a074c6ffcdc3b
2014-05-13 15:53:30 -04:00
Bartosz Dziewoński 885bf01b7e Whitelist Opera 15+
It's using the Blink engine like Chrome.

Change-Id: Ia1c145ebdac0fb099051d32785a7929c19f5d7d0
2014-05-13 20:57:23 +02:00
vikassy af2fe79f9b [browser test] Testing use of existing reference in Reference User Interface
Change-Id: Ic27711bcef33614fe4706df48dbcd6d0dca038b4
2014-05-13 03:39:10 +05:30
Translation updater bot 2f180887ba Localisation updates from https://translatewiki.net.
Change-Id: I6b33cfdd1f107e40082ca0ea6c0a0a61cbb03673
2014-05-12 20:11:25 +00:00
Bartosz Dziewoński d8de718a5d Move shortcut keys help from "Page options" dropdown to "Help" popup
Obviously it doesn't belong there. I think I'm getting the hang of this. :D

Change-Id: I5933e32bb8a803d004c2e33d55d7900d1b18a44e
2014-05-12 15:28:30 +00:00
Translation updater bot 3f926bc5ae Localisation updates from https://translatewiki.net.
Change-Id: I454a8e66e98bdb5432ada7ae584e7823a56bccdc
2014-05-11 19:10:51 +00:00
jenkins-bot e698c5558e Merge "Update VE core submodule to master (4745b44)" 2014-05-11 08:55:51 +00:00
jenkins-bot 79e6957b3b Merge "Update VE core submodule to master (1fa7b5f)" 2014-05-11 08:55:14 +00:00
James D. Forrester d44df0b004 Update VE core submodule to master (4745b44)
New changes:
3fb1060 Remove ve.ce.Surface#getClickCount
fc52c6c Remove IE nbsp hack
cd2e2c8 Add HTML conversion button to SA demo
e04df70 Fix missing i18n for 'auto' language label

Local change:
* Add auto message to i18n.

Change-Id: I534e27d3578cf9b42b755c91aa1b17122835fb83
2014-05-11 10:16:22 +02:00
jenkins-bot b84bceda7a Merge "Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable" 2014-05-11 07:18:10 +00:00
Bartosz Dziewoński 5e253306d1 Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable
Also, re-alpha-sort the ve-mw i18n files.

Change-Id: Id3fc7894b3774042c5eda877c9edf55ef4941ebf
2014-05-11 09:09:09 +02:00
James D. Forrester 80fc16a57e Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work
Three 'minor' points:

* You have to declare even hidden preferences. Whoops.
* There's no such thing as an "optionsToken", use "editToken".
* You need to POST action=options API calls.

Ahem.

Change-Id: I9c4358107af7bcfca157bd014de49882914e990c
2014-05-10 20:02:40 +00:00
jenkins-bot 20b5c4038b Merge "Make citation tools' compatibility check use normalized titles" 2014-05-10 19:13:32 +00:00
Roan Kattouw a15fa5a17c Make citation tools' compatibility check use normalized titles
Greatly enhance the functionality of ve.dm.MWTransclusionNode#isSingleTemplate
and actually use it places.

Use mw.Title to normalize titles, accounting for case differences and
spaces vs underscores. Also allow an array of template names to
be specified.

Use isSingleTemplate() in the transclusion and citation dialog tools,
which were duplicating this logic. Also document the .static.template
properties.

Without this, the citation tool will appear for a reference using
{{Cite news}}, but not for one using {{cite news}} or {{Cite_news}}.

Change-Id: I18d2bb1b22a5ab269694ad0818b1bb326ef8d1fd
2014-05-10 21:10:09 +02:00
jenkins-bot 83480093d3 Merge "ve.ui.MWTemplatePage: Display template name in text form, not dbkey form" 2014-05-10 18:17:55 +00:00
Bartosz Dziewoński a842801557 ve.ui.MWTemplatePage: Display template name in text form, not dbkey form
Change-Id: I66f0ca431616d932da336f3d05d2500d1cd21ff8
2014-05-10 20:02:52 +02:00
jenkins-bot fabb4f0aec Merge "mw.ViewPageTarget: Hide the welcome dialog via a preference if possible" 2014-05-10 12:06:23 +00:00
James D. Forrester df280e27f9 ve.ui.MWTitleInputWidget: Fix documentation (@cfg not @param)
Change-Id: If76e22754b6e17b6ad98f72d5561929bb42bcab7
2014-05-10 12:02:25 +00:00
James D. Forrester fab7aacc12 mw.ViewPageTarget: Hide the welcome dialog via a preference if possible
For logged-in users, we can a preference instead of a cookie. This way it is
also preserved between browsers and when cookies are cleared.

Keep using cookies for logged-out users, except if the beta welcome dialog
has been suppressed using the one-off GET parameter 'vehidebetadialog'.

Bug: 55551
Change-Id: Ica9e5a92841fec003ce4a21d740a9bc6ff3da9c7
2014-05-10 09:46:45 +02:00
Translation updater bot d26e2004ab Localisation updates from https://translatewiki.net.
Change-Id: I2285b810229adc2ca25576b52bb6ba4c1b571c87
2014-05-09 22:23:57 +00:00
cmcmahon 77ec006d87 [browser test] Remove bogus 10-second sleep...
Replace with a reasonable wait_until clause while the '...'
dialog is still visible.

Change-Id: Ie6395e83eed83ce02349f65b10cecf1dba4fef99
2014-05-09 13:50:13 -07:00
jenkins-bot 61c554e952 Merge "[browser test] Chrome is working correctly now, add tests back" 2014-05-09 20:05:32 +00:00
cmcmahon 8097121957 [browser test] Chrome is working correctly now, add tests back
Change-Id: I3f788bd5b38aff1108e9b8d70308c07c0731f703
2014-05-09 11:04:49 -07:00
cmcmahon e47d02adb1 [browser test] Remove old hooks after refactoring all tests
Change-Id: I5782886fbaed8b520a5af727a5938f670d747c9b
2014-05-09 10:54:23 -07:00
cmcmahon 0ff3cf3436 [browser test] Transclusion test now uses API for test page
Also re-enabled for Chrome

Change-Id: Ibeaa993413178148d1ee6601d27c30e61e82bcb2
2014-05-09 09:48:22 -07:00
James D. Forrester c9c6df0c1b Update VE core submodule to master (1fa7b5f)
New changes:
c79a46e Updating scalable default in MediaSizeWidget
7bf9c7e Cache references in handleDelete
e5f74b7 unicodejs: Update moveBreakOffset to include 'HebrewLetter' category
a5b21b6 Fix watch list
6508e88 Directionality fixes in SA demo
dd71c16 Localisation updates from https://translatewiki.net.
4ed85b9 Localisation updates from https://translatewiki.net.
b6fc28a Special case for deleting the entire document
ddd6372 DebugBar tidy up
6160868 unicodejs: Add tests for hebrew letters in moveBreakOffset
1fa7b5f Update OOjs UI to v0.1.0-pre (7b3672591f)

Change-Id: I2dbcf1d7a9829e165bbd0b14da526638d9a7efd5
2014-05-09 14:20:08 +02:00
Timo Tijhof 7dae6496b3 mw.ViewPageTarget: Get rid of FOUC on edit section brackets
We don't have a FOUC on the appearing of the 'edit' link. That
one is handled quite intelligently:
* Via the stylesheet that is also loaded in noscript mode, its
  (hidden) appearance is already predetermined. So as soon as
  those elements are seen by the browser they style correctly
  for users without JavaScript (display: none).
* This same stylesheet also hides it for users with JavaScript
  but where VE is not available (e.g. due to browser support).
  While ve-not-available is added very early on (before
  document ready), it could in theory cause a short FOUC, but
  that's okay. We simply don't know that VE isn't supported
  until then. We optimise for the common case (JavaScript
  enabled, VE available), while still ensuring that it is
  always hidden in noscript, and is hidden as soon as possible
  when VE turns out not to be available.

For some reason, one small detail (the little bit of whitespace
added inside the brackets), was left out of this and was
implemented by adding the class 'mw-editsection-expanded' to them
from a document ready handler.

* First step, get rid of the script that adds this class and
  use ve-available instead. That means they're styled
  correctly much earlier (we add the class to <html> before
  document ready). This can still cause a brief FOUC, though
  in most cases they're correct from the start.

* Step two, make brackets expand by default for script users,
  and let ve-not-available reset it. This way, like with edit tabs,
  a FOUC will never happen for ve-available. And even for
  ve-not-available, a FOUC is rare since we add it before
  document ready via <html> look-ahead styling.

There was still a brief reflow jump because of negative margins
between two paint events. One was undoing the other at a later
time. These negative margins are a remnant of when we were doing
animations (follows-up I4b9c47fd65a70). They were added to reduce
reflows and content shift, but were now actually causing them.

Removed "padding-right" from mw-editsection, and negative margin
from the brackets.

Also:

* Don't add inline 'style="direction: ltr;"' on every single
  editsection throughout the DOM. This was the only operation we
  were doing unconditionally. While I doubt the need of it in
  general, we can at least allow MediaWiki to do it right, and
  only add the override if needed. This saves quite a few DOM
  operations.

Change-Id: I7a729edc2cd4a66ebc0ad6935ffd02cb9b948bff
2014-05-09 12:20:24 +02:00