Catrope
a7a64abcf5
Add ve.getProp()
...
Change-Id: Iad9f53ae252acbeb2842645e6e66c0dfc7618f9f
2012-10-10 17:50:19 -07:00
Catrope
b630b8a2a6
Support custom hashes in ve.getHash()
...
Change-Id: I9193472773b999b45ce850a609ad5fe141421dbf
2012-10-10 17:31:11 -07:00
Catrope
22c7f16b99
Add ve.getOpeningHtmlTag()
...
Utility function to generate an opening HTML tag. Needed to integrate
the new annotation API with ve.ce.TextNode
Change-Id: I6804bbf6f79346fde1887fa82d29ec5cd0342d60
2012-10-10 17:30:07 -07:00
Catrope
3f4c656275
Add setDOMAttributes()
...
Change-Id: I1406998400c4f7f3d0983a43e3f86afe4ffd29a6
2012-10-10 15:10:31 -07:00
Catrope
ac4c259a19
Add missing return in ve.getDOMAttributes()
...
Change-Id: I659667a0424bf166cee95b743469e716ff11f3d9
2012-10-05 18:18:51 -07:00
Inez Korczyński
1ed7b3f96e
Update ve.ce.Surface to call SurfaceObserver.stop/start/clear instead of stopPolling/startPolling/clearPollData.
...
Change-Id: I164599dd34304a3eaef285859a66428cf839accb
2012-10-05 14:57:42 -07:00
Catrope
f434da5140
Merge "Changed method name to setAutoSelect to avoid collision"
2012-10-05 21:25:51 +00:00
Catrope
ffc34ee15a
Merge "Got tests working again"
2012-10-05 19:01:38 +00:00
Trevor Parscal
51ac385c98
Merge "Created QUnit tests for ve.Document.selectNodes method (mode "branches")"
2012-10-05 18:57:37 +00:00
Trevor Parscal
da2d89ee3a
Changed method name to setAutoSelect to avoid collision
...
Plus, this is more consistent with the rest of the method names
Change-Id: I713f1bfc28d22cc259ce5dba69ea053817fd43f8
2012-10-05 11:07:10 -07:00
Inez Korczyński
2d752fe60c
Small clean-up in ve.ce.Surface constructor.
...
Change-Id: I679511cd0b22192213873ceca5d8410b56d5def9
2012-10-04 17:08:26 -07:00
Inez Korczyński
4ab9d112b7
Created QUnit tests for ve.Document.selectNodes method (mode "branches")
...
Change-Id: Iee243ffe1a71a23a3ad540421a0cbbb973433f58
2012-10-04 15:24:02 -07:00
Inez Korczyński
b2295a2de3
Fix minor bug with incorrect usage of hasSlugAtOffset.
...
Change-Id: I413fc5850cd7bcae9b1d955eb951394e1ed9df36
2012-10-04 14:31:25 -07:00
Inez Korczyński
72eb2825e5
Start using ve.ce.SurfaceObserver inside ve.ce.Surface. Moved methods getOffsetOfSlug, getOffsetFromElementNode, getOffsetFromTextNode and getOffset to ve.ce.js and made them static.
...
Change-Id: If6ce0ae10c494392cc384341cc87b61658d4934a
2012-10-04 14:28:54 -07:00
Inez Korczyński
c4299fd838
Retire ve.ce.Surface.render variable and instead of it use variable "locked" via methods lock(), unlock() and isLocked().
...
Change-Id: Ic476a51e9e7766bd2793c2a7d773734cf9bcd0b6
2012-10-04 14:26:06 -07:00
Inez Korczyński
3b8a5ae4d5
Initial import of ve.ce.SufaceObserver
...
Change-Id: Ifc14a6cc30e46c8ae99c59dcb916795c603329ed
2012-10-04 14:24:12 -07:00
Inez Korczyński
15b151ef58
Setup variable ve.debug to true when ve.debug.js is loaded.
...
Change-Id: I22309ddfda8271456665eb40c4b698c160061de4
2012-10-03 18:02:31 -07:00
Trevor Parscal
2c3142225f
Got tests working again
...
I think what happened here is I added the skeleton code, Kranitor came through and removed the unused arguments, then I merged in my implementations without pulling, then pushed - git merged cleanly, the arguments I thought were there were not there, and tests broke.
Change-Id: I5aa2968fef164c774a10db83a6df1753c93cd2dc
2012-10-03 16:03:33 -07:00
Inez Korczyński
0b135ede31
Add 'branches' mode to ve.Document.selectNodes method. Tests TBD.
...
Change-Id: Id466b9452fd0b515831a2536ccc32caa339ee885
2012-10-03 15:55:54 -07:00
Inez Korczyński
714e29d30f
Created method getSlugAtOffset in ve.ce.Document and ve.ce.BranchNode, refactored the way how slugs are added.
...
Change-Id: I8006c7e6e1dd3c640939bf08f39192615b2e5343
2012-10-03 15:40:44 -07:00
Trevor Parscal
58e37e78a9
Merge "Fix transaction bug with Roans help."
2012-10-03 17:56:33 +00:00
James D. Forrester
03c428155e
Alter the target of the Feedback link to be the right page.
...
Specifically, go to [[mw:VisualEditor/Feedback]] rather than [[mw:Visual editor/
Feedback]], as the primary set of pages on MWwiki have been moved some time ago
and right now we're stranding users' feedback messages at the wrong place.
Change-Id: Ia2ba0dad7d1bf0d1633fe2704a2e8354285c66da
2012-10-02 15:41:18 -07:00
Rob Moen
3a48860602
Fix transaction bug with Roans help.
...
Fixes (Bug 40339)
Change-Id: Ice26bf08071cba5c5500aa9196ade169381a9aea
2012-10-01 16:31:16 -07:00
Trevor Parscal
1ab5fac1aa
Merge "Using getRelativeContentOffset for insertAnnotations"
2012-10-01 21:27:54 +00:00
Trevor Parscal
57ec680d76
Merge "Add utility function to get DOM attributes as a plain object"
2012-10-01 21:27:21 +00:00
Krinkle
5ba4c9694d
Merge "Added surface model lock and unlock events"
2012-10-01 21:25:08 +00:00
Trevor Parscal
903acdfdf2
Added surface model lock and unlock events
...
This allowed me to move ve.ce.Surface particulars (such as the starting, stopping and clearing of polling) out of the UI code.
Also cleaned up some switch statements.
Change-Id: I7b85e42a4e01f8d76237d995e25275f2424541ea
2012-10-01 14:23:11 -07:00
Catrope
7cc8096864
Add utility function to get DOM attributes as a plain object
...
Change-Id: I64abfb7479ae687f95e604f1df48dfe8439176ed
2012-10-01 14:14:52 -07:00
Christian Williams
75c154ef6c
Using getRelativeContentOffset for insertAnnotations
...
Previously, we were looking one offset to the left to load the insertAnnotations. This would fail at the beginning of a document that began with a slug, and probably other cases too. Now using getRelativeContent offset.
Change-Id: I31b24e2ccfa9fda2ce7fb19d1221f8708a96083f
2012-10-01 13:43:27 -07:00
Trevor Parscal
4ae9096632
Merge "Make getDomText() return an empty string for slugs"
2012-10-01 20:06:26 +00:00
Robmoen
8815c3eae4
Merge "Throw an error for bad offsets in getNodeFromOffset()"
2012-10-01 18:46:36 +00:00
Catrope
40b60ebda8
Make getDomText() return an empty string for slugs
...
Slugs aren't represented in the model at all, but in the DOM they do
contain a single character ( or ), so we have to override
the return value of getDomText() to be empty.
Change-Id: Ic93cb694b0632bc81d8d0749149e4d739232ed48
2012-10-01 11:37:39 -07:00
Catrope
7ec1b8d76d
Add exception to getAnnotationsFromOffset() for easier debugging
...
Change-Id: Ief1209267d2d6f91f8572e4fa15a49e886bc0a30
2012-10-01 11:30:53 -07:00
Catrope
9488a38cca
Throw an error for bad offsets in getNodeFromOffset()
...
Will ease debugging of bug 40463
Change-Id: I3fbacb3e6e2f242c1584f51581d2b4e7c4bdd4dc
2012-10-01 11:25:31 -07:00
Robmoen
ff6d0b4a31
Merge "Made save dialog float with toolbar"
2012-09-28 21:04:30 +00:00
Trevor Parscal
bfeb0455d9
Added callout icon
...
Change-Id: I1641c91a2729ada40ccada6b85e9f0e46e1d0c21
2012-09-28 14:00:46 -07:00
Trevor Parscal
57599e1c95
Made save dialog float with toolbar
...
Change-Id: I6c66c3817669adcee6314c16fcf49ef1a8db7b65
2012-09-28 13:44:51 -07:00
Trevor Parscal
0cbec61b73
Merge "Create method ve.Range.isCollapsed() and added some tests for ve.Range class."
2012-09-28 20:35:16 +00:00
Inez Korczyński
15e0c13fa9
Create method ve.Range.isCollapsed() and added some tests for ve.Range class.
...
Change-Id: I866b00db196a768460b32766b82fbdf896a48fdd
2012-09-28 13:32:26 -07:00
Christian Williams
ffefe63063
Insert Annotations
...
Change-Id: Ibc927730a668cdcea9c90fe4fc2cb3db4d20480e
2012-09-28 13:28:47 -07:00
Trevor Parscal
50ddba4d12
Really remove all, not just half
...
Iterating forwards while removing from an array is a good way to get half way there and be confused as hell.
Change-Id: I74db84eee87c73d8e035f6dc8a92be0d0b9b3dad
2012-09-28 12:17:04 -07:00
Trevor Parscal
5f0ccc807a
Removed a single space.
...
Change-Id: Id4f96d980306e00b81a13441c38a3913ae312535
2012-09-27 11:57:50 -07:00
Robmoen
2737b0d0c8
Merge "Icon improvements"
2012-09-26 22:03:53 +00:00
Trevor Parscal
4c9b1d6035
Icon improvements
...
* Added some new icons (to be used soon in the inspector redesign)
* Added right-to-left icons for lists
* Renamed some icons for future RTL use
Change-Id: I10e3e3fcda82786e3064176e7eefe211b88db95c
2012-09-26 14:53:11 -07:00
Robmoen
6d03a58f21
Merge "Fixed ve.OrderedHashSet.filter"
2012-09-26 21:02:14 +00:00
Trevor Parscal
b696e1e84b
Fixed ve.OrderedHashSet.filter
...
Was cloning the original set, then adding to it - resulting in always containing the whole set in any match.
Also using test instead of exec since exec returns a string result, which under strange circumstances could return a falsy result, despite the RegExp finding a match.
Change-Id: I09a7cb264521d58f02d6ff2547edad9a740b23b2
2012-09-26 13:57:19 -07:00
Rob Moen
4613707909
re: AnnotationSet, fix JS error in getFirstLinkAnnotation.
...
Change-Id: I6a3cb4eb2164bf1c4c8f715e42117ac06cccac04
2012-09-24 17:16:10 -07:00
Catrope
5075d79c4b
Merge "Regression fix, clearing only link annotations when creating link."
2012-09-24 22:06:00 +00:00
Rob Moen
d5d44df053
Regression fix, clearing only link annotations when creating link.
...
Clearing only existing selected links when:
1) Creating a link
2) Pressing clear button
Change-Id: I4b1bcd9a3ac177b2f9b4af2d562d4c4fec09d5c5
2012-09-24 15:03:53 -07:00
Catrope
31fc2dc2b4
Merge "re: AnnotationSet, annotationButtonTool properly clears annotation."
2012-09-24 22:00:26 +00:00
