Commit graph

14540 commits

Author SHA1 Message Date
Ed Sanders a7049dacea Update language variant node to use new invisible icon API
Bug: T195887
Depends-On: I4eab7b9edf04454ef1a62535656b179480c3054b
Change-Id: I655757b13514e8ff89c312dcc2e1147d188a2718
2018-06-04 17:34:22 +00:00
James D. Forrester b998e3cae3 Update VE core submodule to master (aca98533e)
New changes:
d62da204c Fix documentation in dm.Surface, remove duplicate dm.Selection.equals
b2ee82d06 Bypass expensive hasRendering calculation for CommentNodes
522959e5c ve.ce.AlienNode: Fix hover highlight opacity in IE/Edge
06e67e2a1 ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker"
d38b994d9 Localisation updates from https://translatewiki.net.
2056626bc Remove unused & untested HashValueStore.filter
49a8fbae4 Upstream comment node's invisble icon with label into focusable node

Bug: T195887
Change-Id: Id2da1f2da4e5e32acb3d604307d0f84f6a82bf39
2018-06-04 09:45:04 -07:00
jenkins-bot 6594055882 Merge "Paste conversion dialog shouldn't be escapable" 2018-06-04 16:44:39 +00:00
David Lynch d3fd979d3b Paste conversion dialog shouldn't be escapable
It doesn't have a "cancel and do nothing" route to fall back on, so pressing
escape does the non-progressive action, which is to paste-as-wikitext rather
than paste-as-plaintext. Neither of these is really an intuitive outcome.

Change-Id: I786b6fc87e3cdf3bb50898a070a15a353a242848
2018-06-04 11:16:19 -05:00
Santhosh Thottingal b049a82e8d
ApiResponseCache: Add a check for data.query before accessing redirects
Follow-up: If4f8c9b6719c123b31d852eb71f06a79cc0f7917
Change-Id: I5f1814f341ce401fcb3926487a2cea276698bca0
2018-06-04 13:50:27 +05:30
Translation updater bot a93d1e6102 Localisation updates from https://translatewiki.net.
Change-Id: I48d83893b5867283ea2835a31f879916f7055665
2018-06-03 22:36:44 +02:00
Translation updater bot 6883aaa323 Localisation updates from https://translatewiki.net.
Change-Id: I6163a444ab187b39bb56fdf3ee84d732dd718790
2018-06-02 22:41:45 +02:00
Translation updater bot c3f567ff02 Localisation updates from https://translatewiki.net.
Change-Id: I1eed9e109e011426386fb251f1a91c849518fb6d
2018-06-01 22:27:51 +02:00
jenkins-bot 22d1cfeecb Merge "Update VE core submodule to master (6847cfba6)" 2018-06-01 08:37:26 +00:00
Translation updater bot 15d048f9a3 Localisation updates from https://translatewiki.net.
Change-Id: I4edd4509605e81cbb80fa3580eead7d62432f9fd
2018-05-31 22:28:48 +02:00
Timo Tijhof 21f526bffe mw.trackSubscriber: Remove action.init.timing value
In Schema:Edit, all action timing durations (ready, loaded, saveAttempt etc.)
are defined as "time since the editor was initialised", which is internally
stored as the timestamp for the "init" action.

The 'init' action itself does not have a timing duratation, but the Edit schema
has a special case for it, definining it as "time since the page was loaded".

In actually, it isn't actually implemented as "time since the page loaded",
and I suspect that as such, this value is probably not used by EventLogging
consumers of the Edit schema. Or, it might be used, but doesn't represent
what the consumers think it does.

Presently, it uses the init time now() - mediaWikiLoadStart, which basically
means the time between the random point at which MediaWiki core JavaScript
finished executing which is quite variable in practice due to the race between
<script async> and browssing parsing/rendering of HTML. That is by design,
and is also why mediaWikiLoadStart is undocumented and internal, and actually
in the process of being removed.

After many iterations on this patch to try and approximate an alternative to
this undocumented variable, I came up with an alternative approach with DLynch
at the Hackathon, which is to simply not record this one timing value, but
preserve the behaviour of all the other timing values exactly as-is.

That is, keep the behaviour of storing `now()` as "init" when the editor
activates, and keep the behaviour of substracting "init" from all other action
times, but only don't report "init" itself to EventLogging (given its value
would be 0, which isn't useful).

Bug: T160315
Change-Id: I778234efe40dde8ff30333339335be1c3910a4e0
2018-05-31 18:27:12 +00:00
James D. Forrester d7dcf6f681 Update VE core submodule to master (6847cfba6)
New changes:
89c8891eb Update OOUI to v0.27.1
d542afe0f Fix OOUI deprecation warning from tests
962cd9f5c Localisation updates from https://translatewiki.net.
40e8a27b0 Add test coverage for preview mode (optionally)

Change-Id: I6dd76c021ffc4f5b4be9e5e12ddda710b4595c12
2018-05-31 10:10:37 -07:00
jenkins-bot 725adb2ae3 Merge "Disconnect surface model history listener when tearing down" 2018-05-31 00:23:37 +00:00
jenkins-bot 47fab2753b Merge "DesktopArticleTarget: Section-scroll as part of restoring the page" 2018-05-30 22:03:49 +00:00
jenkins-bot c9f3f45b9d Merge "ApiVisualEditor: Defensively check that query prop revisions returns arrays" 2018-05-30 22:03:35 +00:00
jenkins-bot fbdb76fd80 Merge "build: Introduce eslint-plugin-qunit" 2018-05-30 21:01:55 +00:00
Translation updater bot 46c0141eb3 Localisation updates from https://translatewiki.net.
Change-Id: Icc1af8332ff11f77790548d2fd43fb2b7a2d903a
2018-05-30 22:24:54 +02:00
Ed Sanders a7f5a76bca build: Introduce eslint-plugin-qunit
Change-Id: I0a169916eaf260500ca6a172e6fb2b0c61f8d422
2018-05-30 21:04:02 +01:00
jenkins-bot 083d2aa588 Merge "ApiResponseCache: Support redirects data processing" 2018-05-30 16:53:07 +00:00
Translation updater bot b687368264 Localisation updates from https://translatewiki.net.
Change-Id: Ic196eaf34d9e2189cc7b01f75bfbd920df8118be
2018-05-29 22:25:22 +02:00
James D. Forrester 8543cd525d Update VE core submodule to master (73e80ba80)
New changes:
15d2625b4 build: Bump devDependencies to latest
d613f4766 build: Introduce eslint-plugin-qunit
1d675a7b2 build: Enable eslint's qunit/literal-compare-order rule, with an exception
591a22590 build: Enable eslint's qunit/no-ok-equality rule
d89243c16 Move QUnit eslint config to tests/ folder
a67715636 Localisation updates from https://translatewiki.net.
4eb5301a0 Refactor diff ready for de-generalisation
a5e433473 Add expanded=false to FragmentInspector's container
ad4556a5e Rename 'Dialog windows' section to 'Window controls'
f5e9be727 annotationsAtFocus: Replace $.parents with $.closest

Bug: T195843
Bug: T195854
Change-Id: I20d39d0da4f88555bcb2ba5f691c51d22e497070
2018-05-29 08:40:20 -07:00
Translation updater bot d8a5f22e0f Localisation updates from https://translatewiki.net.
Change-Id: Id16069d8537e6fd9452451ba38876638ba51475d
2018-05-28 22:42:48 +02:00
Ed Sanders 4f456b143e Disconnect surface model history listener when tearing down
Bug: T195775
Change-Id: I6f6fe654dc190d7d891d3ac346bf3f4b2f426947
2018-05-28 18:30:07 +00:00
Ed Sanders 9386d54be9 Fix template param diff when value is empty string
Bug: T195764
Change-Id: I0bd5fe71996a2ffeaa201e549f8515439c07996d
2018-05-28 14:56:53 +01:00
libraryupgrader 54f9335232 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Idfc004c9439d9b8421f378fdd559990b09ad851c
2018-05-25 23:18:11 +00:00
David Lynch d3824dee76 DesktopArticleTarget: Section-scroll as part of restoring the page
We were scrolling to the edited section when we saved the page, and otherwise
reverting scroll position to the top if we just abandoned the edit. This
unifies these cases, so any section-edit which leaves the editor will scroll
to the section being edited. (If section==new and the edit is abandoned, it'll
scroll to the last section on the page.)

Bug: T194631
Change-Id: Ic2aca68b3127c435545644912b96212bcfa6648d
2018-05-25 16:30:22 -05:00
James D. Forrester d4841abbb6 ApiVisualEditor: Defensively check that query prop revisions returns arrays
I can't see where this would return a string, but users are reporting that
they're getting that at times…

Bug: T193718
Change-Id: I6b635bacdd59431568bc5c679e455f67cb764df0
2018-05-25 21:04:38 +00:00
Translation updater bot 58f2816c70 Localisation updates from https://translatewiki.net.
Change-Id: I6044bc3d04c75626272d5c241d1393fed8160ee5
2018-05-25 22:14:33 +02:00
James D. Forrester 19641b1f96 Update VE core submodule to master (a17837fa6)
New changes:
d8c4fe1a1 ce.Surface cleanup
220978561 Simplify TableLineContextItem styles
83d818983 Make delete row/col buttons destructive
4f5f66703 Localisation updates from https://translatewiki.net.
55e1c1424 Fix try/catch in internal paste with original data
da86b36ff Fix async beforeEach in ve.ce.Surface tests
8b10fdc89 Strip 'about' attributes when comparing alien nodes

Bug: T195344
Bug: T195514
Change-Id: I7222d6378f375a228e9efd328b6a8b9bbf4c6de3
2018-05-25 11:08:02 -07:00
Santhosh Thottingal 27d0634abf
ApiResponseCache: Support redirects data processing
If the mediawiki Api pass redirects as true, the response will have
redirect data. ApiResponseCache ignores it now. This commit adds
support for processing that and set in the cache.

Change-Id: If4f8c9b6719c123b31d852eb71f06a79cc0f7917
2018-05-25 12:06:09 +05:30
Translation updater bot cd63220738 Localisation updates from https://translatewiki.net.
Change-Id: I4c0cd8a20d18e09cd225994739be13067853a9a8
2018-05-24 22:25:06 +02:00
jenkins-bot c52be40555 Merge "MobileArticleTarget: Include placeholder for references" 2018-05-24 17:30:48 +00:00
jenkins-bot 6c90442326 Merge "ce.MWWikitextSurface: ask on paste about wikitext conversion" 2018-05-24 17:21:07 +00:00
David Lynch 4d5fc16a9a MobileArticleTarget: Include placeholder for references
Cite's a08febb0afa2d changed the rules for adding the Cite button to the
toolbar – it now requires a placeholder slot in the toolbar, rather than
finding the link tool and adding itself after that. As ve.init.mw.Target
was updated for this it kept working on desktop, but MobileArticleTarget
completely overrides the toolbar, and was missed.

Bug: T195191
Change-Id: I55c9de9e736bb83f5f05028f2fc07af0ad996050
2018-05-24 17:18:50 +00:00
Translation updater bot 086bde1274 Localisation updates from https://translatewiki.net.
Change-Id: I0ee8371928b7ff271a690a0d892079087bddf066
2018-05-23 22:20:28 +02:00
jenkins-bot f805169fdc Merge "Remove dependencies on deprecated modules 'mediawiki.api.*'" 2018-05-23 19:19:19 +00:00
Ed Sanders 4dc573a0c9 Pass importTitle directly to target, instead of through query string
Change-Id: I2d561c3b2b8992b78412707d70a55ded0f5ad1c9
2018-05-23 17:20:05 +00:00
jenkins-bot 514189b7d1 Merge "Separate save dialog from article target module" 2018-05-23 17:15:49 +00:00
jenkins-bot 7e0ad66a69 Merge "CollabTarget: Pass import promise to setSynchronizer" 2018-05-23 17:13:50 +00:00
jenkins-bot 504f712ebc Merge "Only apply toolbar negative margins on vector" 2018-05-23 17:05:22 +00:00
jenkins-bot c99c96e805 Merge "Allow CollabTarget to load on mobile" 2018-05-23 17:01:57 +00:00
Ed Sanders 86786bc947 CollabTarget: Pass import promise to setSynchronizer
Depends-On: I188e749c315ddbb5f8779db10987178a51d27f5c
Change-Id: I57fe6af459416e039274ea4c360e09a55123b024
2018-05-23 16:59:01 +00:00
jenkins-bot b7bbf68fbe Merge "MWSaveDialog: Fix typo in no-categories branch" 2018-05-23 16:52:32 +00:00
Ed Sanders ab59f3d06f Update VE core submodule to master (d214a66aa)
New changes:
aa8b2d3da rebaser: Clarify document name is optional
eb4955b84 $.isEmptyObject -> ve.isEmptyObject
681fa50e1 Don't use $.isNumeric in DM
0c8483d8a Avoid more jQuery in DM
a9f6bef78 Replace $.extend with ve.extendObject
34eb4311d Initialise socketIO twice to avoid query cache
b70cb7520 Teardown synchronizer
8f829895f Use passive event listeners
f9e84fa8b Localisation updates from https://translatewiki.net.
db24bb81c ve.ce.FocusableNode: Fix minor code issues
ae981404e Rebaser: show connect/disconnect in the server console
0118e89c2 Show progress bar while connecting to rebase server
160bbe5fd Use new name for 'comment' icon, 'speechBubble'
fb549248a Remove unused APIResults* objects
5daa71d7e Remove IE9 support comment

Bug: T178371
Bug: T195111
Depends-On: I186ebd9d63299d828692a745b62fbc4314a4ed4e
Change-Id: Ie0fee3d4cc069383b8cb48e7d6c2ff520fedb590
2018-05-23 09:01:07 -07:00
David Lynch 4d263afaa2 ce.MWWikitextSurface: ask on paste about wikitext conversion
Throw a dialog box up to ask whether to convert something with formatting to
wikitext, or downconvert it to plain text.

This logically depends on Ie9aaaa59e9dfa138d394051fe491573253df1805.

Bug: T190079
Change-Id: I6afbbe303d1506426109e75c95f6be546ec48536
Depends-On: Ie9aaaa59e9dfa138d394051fe491573253df1805
2018-05-23 08:08:22 -05:00
Ed Sanders ccb766e933 MWSaveDialog: Fix typo in no-categories branch
Bug: T195323
Change-Id: I7d22b6cad363a240660563554e4578621f7966d0
2018-05-23 11:18:54 +01:00
Ed Sanders 2cd7abf88b Allow CollabTarget to load on mobile
It's not great, but it works, so allow people to at least
experiment with it.

Change-Id: Iaa54189f7aa63b0bd029dd25a898db54119eff70
2018-05-22 22:39:36 +01:00
Ed Sanders bb0d3471df Only apply toolbar negative margins on vector
This fixes toolbar placement in minerva-desktop.

Change-Id: Ifbd869cb70da9bb4db7c72ad89f696a080d18847
2018-05-22 21:25:33 +01:00
Translation updater bot 5330e42dc7 Localisation updates from https://translatewiki.net.
Change-Id: I3c5d83dd13439f48596e9a4962ef6cba99308632
2018-05-22 22:20:57 +02:00
Translation updater bot b31915aa19 Localisation updates from https://translatewiki.net.
Change-Id: If3f42a0445bbfed268f6cdf229724c5ee4a7b38d
2018-05-21 22:10:45 +02:00