Commit graph

18541 commits

Author SHA1 Message Date
jenkins-bot ed77e22e98 Merge "Update skinStyles with new vector skin key." 2022-01-10 23:11:27 +00:00
jenkins-bot b92f414e23 Merge "Use new wikipage.watchlistChange hook" 2022-01-10 22:42:17 +00:00
Clare Ming 1e1638145b Update skinStyles with new vector skin key.
Bug: T292599
Change-Id: I6a2db3012b37e4164e03f3701dc11fa36f2dbf92
2022-01-10 15:38:48 -07:00
Ed Sanders 3800daf354 Use new wikipage.watchlistChange hook
Bug: T294254
Depends-On: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: I60400124976093060b3b5478c6d7d9e6844cc217
2022-01-10 23:16:41 +01:00
jenkins-bot ccb74dc828 Merge "Enforce formatversion=2 in template search" 2022-01-10 12:57:05 +00:00
Translation updater bot f9bf7d36fa Localisation updates from https://translatewiki.net.
Change-Id: Iec7d3662ebff654a024c55f8cbc4806068c70dd6
2022-01-10 08:11:59 +01:00
jenkins-bot 8886773548 Merge "DiffPage: Only set user pref on 'choose' event" 2022-01-08 01:33:31 +00:00
jenkins-bot 67aad36acb Merge "DiffPage.init: Move and rename some vars" 2022-01-08 01:33:29 +00:00
Bartosz Dziewoński 12cd0fd396 Update VE core submodule to master (bafd926a8)
New changes:
46501f84a Localisation updates from https://translatewiki.net.
2b3f0c029 Update RangeFix to 0.2.10
254a8f359 Tests: Show warning when input to ve.createDocumentFromHtml is unbalanced

Change-Id: I015c6fd980fee754bf907fc6f87f403ca0fa952a
2022-01-08 02:06:39 +01:00
jenkins-bot 451555ac64 Merge "Tests: Fix unbalanced HTML" 2022-01-08 00:26:53 +00:00
Translation updater bot a422bc28a4 Localisation updates from https://translatewiki.net.
Change-Id: I1e0bd111f2038088c893314f1e9af1bf53832f4b
2022-01-07 08:25:40 +01:00
Ed Sanders 40a50cac4a DiffPage: Only set user pref on 'choose' event
This prevents your preference being changed if you just
followed a link with a diffmode parameter.

Change-Id: I755563bde285e95c0367119d49a40e1dd3c5e178
2022-01-06 16:48:02 +00:00
Ed Sanders 302303de46 DiffPage.init: Move and rename some vars
Change-Id: Ibcef23650e6c77d9142055e9e7357ce095ba3b49
2022-01-06 16:47:35 +00:00
Translation updater bot 0521c5e540 Localisation updates from https://translatewiki.net.
Change-Id: I69bb987b0aa7ddb2677f93eb75b22e36c81ce7a3
2022-01-06 08:32:20 +01:00
jenkins-bot 4ceca46c8e Merge "Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete" 2022-01-05 17:23:33 +00:00
Thiemo Kreuz 579cdaa145 Enforce formatversion=2 in template search
This is guaranteed via ve.init.mw.Target.getContentApi(). But the
ContentTranslation extension replaces this, and does not set a
formatversion. See e.g. SectionTranslationTarget.getContentApi().

Bug: T298599
Change-Id: I8768cae3153e9cbc29a8796ec21ef249f80471ed
2022-01-05 12:49:44 +01:00
Translation updater bot 77e6242d85 Localisation updates from https://translatewiki.net.
Change-Id: I7091f85c6babfd867d1d94c2fb4278bd2e652296
2022-01-05 08:16:37 +01:00
mewoph 93d54c701b Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete
In case the save is triggered without the save dialog (for example, when a null edit is made during suggested edits task in GrowthExperiments)

Bug: T298552
Change-Id: Id49b967cfa52d33848e9c911086000fa4501fa7f
2022-01-04 13:35:21 -08:00
Ed Sanders 9e4915d7c3 Tests: Fix unbalanced HTML
Change-Id: I997c68ce33263004b8ae9b686aae7295eec12ea7
2022-01-04 02:01:38 +00:00
Bartosz Dziewoński 3c02dbcc7f Update VE core submodule to master (5b987b34a)
New changes:
6f114fe8c Localisation updates from https://translatewiki.net.
b2dd88142 Localisation updates from https://translatewiki.net.
08d33f872 Localisation updates from https://translatewiki.net.
fb15ab599 DiffElement: Remove unused jlen from loops
5ca7924d5 DiffElement: Remove unused 'doc' argument from compareNodeAttributes
e776c9011 DiffElement tests: Remove wrapper paragraphs from list test input

Change-Id: Ida46a53c566b4b4df085c7e581dc937f2ee2ff75
2022-01-03 19:12:17 +01:00
Translation updater bot 1139a77734 Localisation updates from https://translatewiki.net.
Change-Id: I4d2420846da93f2a8923b9dc5bd3914c71df3bd5
2022-01-03 08:11:54 +01:00
Translation updater bot e2373154d3 Localisation updates from https://translatewiki.net.
Change-Id: I83f3d9c3d4fd3f1395448854c1eeca1914679e43
2021-12-31 09:42:29 +01:00
Translation updater bot 053b3a2b70 Localisation updates from https://translatewiki.net.
Change-Id: I6f8f1f0d1fa9d9fbf5dbb71d8002a1577b43d8df
2021-12-30 09:38:19 +01:00
jenkins-bot a886a5e1b9 Merge "Replace usage of deprecated global function wfReadOnly()" 2021-12-27 13:13:58 +00:00
Translation updater bot 1bf508e2ca Localisation updates from https://translatewiki.net.
Change-Id: Iab9a565ab972b74d2f06fa3c9da1f51e82c679de
2021-12-27 09:31:19 +01:00
Alexander Vorwerk 61e0094574 Replace usage of deprecated global function wfReadOnly()
The global function wfReadOnly() has been deprecated in favor of the
new ReadOnlyMode service. Its usages should be replaced.

Bug: T283978
Change-Id: I26a878f19be5c90dab04e28ce395cb8f6dddebef
2021-12-26 14:23:42 +01:00
Translation updater bot 63dfd2492a Localisation updates from https://translatewiki.net.
Change-Id: Ic393105b2217dda422df819c1c4f276c5225e2fb
2021-12-23 08:38:43 +01:00
Bartosz Dziewoński ea4808552d Update VE core submodule to master (2143a90a7)
New changes:
26ba8a561 Store internal list counter in new document storage and persist
75661d69f Drop support for fallback createDocumentFromHtml methods
2143a90a7 ve.dm.Document: Remove rebuildNodes

Bug: T294918
Bug: T298106
Change-Id: I1da12be2ba952912071d2f7fbde1d0854f82fb6d
2021-12-22 23:51:56 +01:00
Thiemo Kreuz 454dc53126 Give getUniquePartId method a better name
It's not a getter, but a generator. I found the name confusing.
Getters typically don't return something different every time you
call them.

Change-Id: I6eeab8b6a8644e430003f6e1ad77ab4b28e0d8c9
2021-12-22 13:03:01 +01:00
Translation updater bot 435d3727dc Localisation updates from https://translatewiki.net.
Change-Id: I524c34f4a3df5ccfd8bfdece8684caabfa12adc5
2021-12-22 08:34:41 +01:00
Bartosz Dziewoński 8cf9039b9f Update VE core submodule to master (4b2339f6e)
New changes:
8859b6a7c List diff: Improve handling of complex changes
fba7ecd4a List diff: Add descriptions for list item indent/outdent
4b2339f6e List diff: Fix display of list node attribute change (e.g. bullet->numbered)

Local changes:
* Add new localisation messages

Bug: T298002
Bug: T298012
Change-Id: I0a7614b48ebc970233ae72a5404751f07b0e03b0
2021-12-21 20:24:26 +01:00
Bartosz Dziewoński c9d8c6f90b Update VE core submodule to master (9df59571b)
New changes:
abd4e7423 ve.ce.Surface.test: Move var declarations inline
d4e08cb5c Increase specificity of source mode paragraph margin rule
7ca52e3f7 Converter: Cache whitespace regexes
7f7fbc555 Follow-up I0f5a01e3d: Update unicodeJS readme and headers
6567612db Tests: Move var declarations inline

Bug: T287733
Change-Id: I3dabc5db58da23af9fda3a44bebfe669765d19b1
2021-12-20 22:29:07 +00:00
Bartosz Dziewoński 011277f757 ApiVisualEditorEdit: Fix Phan build failure
Caused by cbfcf9e8a8b2d5aaef78d8900c2e373d350eba02 in MediaWiki core.

Change-Id: I251f44faa46376ecde49c87ccff65025f56ab7e8
2021-12-20 23:26:44 +01:00
Ed Sanders 1c6dbf433f Remove more DOM garbage introduced by 'Web of Trust' extension
Bug: T297862
Change-Id: Ib6efe0c4ea68a1b17efd37839cec428dc9ebf6b7
2021-12-20 17:54:20 +00:00
jenkins-bot 7d8e133af1 Merge "Only set diffmode-historical user option when it has changed" 2021-12-20 16:18:32 +00:00
Ed Sanders b57fe3e8ba Only set diffmode-historical user option when it has changed
Bug: T290703
Change-Id: I289e0c20db9235a432f7f49a425328ab617d57f3
2021-12-20 14:27:37 +00:00
Translation updater bot 736d061f21 Localisation updates from https://translatewiki.net.
Change-Id: I1490bdeb7bd3ad7d09581e2bbb970efa9c70bf1a
2021-12-20 08:21:53 +01:00
jenkins-bot 717b5cf534 Merge "Use no-jquery/no-html to warn against writing HTML strings to the DOM" 2021-12-17 16:42:53 +00:00
jenkins-bot c92ea76af8 Merge "eslint: Enable no-jquery/no-append-html" 2021-12-17 16:42:42 +00:00
jenkins-bot 53ad459b27 Merge "ve.ui.MWMediaDialog: Clean up image metadata display" 2021-12-17 16:42:39 +00:00
jenkins-bot 6dc75d8283 Merge "Remove obsolete performance bottleneck from TransclusionModel" 2021-12-17 13:24:19 +00:00
jenkins-bot 26d22ee4bc Merge "Delay initialization of all invisible "add parameter" components" 2021-12-17 11:52:48 +00:00
jenkins-bot 4a1063e87a Merge "Skip bad suggestedvalues and aliases in the template dialog" 2021-12-17 11:16:21 +00:00
Bartosz Dziewoński 84de6bdad2 Update VE core submodule to master (2947b78df)
New changes:
3c1ddf0b0 Localisation updates from https://translatewiki.net.
e1d8bdb93 Localisation updates from https://translatewiki.net.
d125de1da Localisation updates from https://translatewiki.net.
ecd7292fc Tweak paragraph margins in multi-line table cells to match view mode

Local changes:
* Add new file to ResourceLoader module

Bug: T295252
Change-Id: Ie8782324cd33f880d3695e57ae2d8715e14fb77d
2021-12-16 17:08:47 +01:00
Translation updater bot 59fd579cf5 Localisation updates from https://translatewiki.net.
Change-Id: I2c644c5bd450835b4f9fe15c649a273add58e394
2021-12-16 08:30:26 +01:00
Ed Sanders 2098292318 Use no-jquery/no-html to warn against writing HTML strings to the DOM
This forces us to comment when we are doing this deliberately.

Change-Id: Ide1bcb64f6c6076b48e88f1f27045bd93392f8a0
2021-12-16 01:28:42 +00:00
Ed Sanders 4d13a4f4ed eslint: Enable no-jquery/no-append-html
Prevents accidentally treating plain text or user input
as HTML, which could be an XSS vulnerability.

Change-Id: Id4af48447a0907962a57340cb60aca08df9cc505
2021-12-16 02:04:11 +01:00
Bartosz Dziewoński 97be4e21ad ve.ui.MWMediaDialog: Clean up image metadata display
* Fix incorrect use of .append() instead of .text() (which was causing
  some l10n messages to be treated as raw HTML)
* Avoid escaping and parsing HTML several times when plain text was
  intended
* Remove some unused options and variables

Follow-up to 839b64d882.

Change-Id: I124257c73fe09713afefccdec8e90200e6ae433d
2021-12-16 01:52:54 +01:00
sbassett 839b64d882 SECURITY: ve.ui.MWMediaDialog: Escape plaintext image metadata fields
CVE-2021-44855

Bug: T293589
Change-Id: I691b4065e67c53c4276599c8d16c31ab5591db3a
2021-12-15 16:14:35 +00:00
Thiemo Kreuz 7cf10ea474 Delay initialization of all invisible "add parameter" components
The "Add parameter" page always starts collapsed. Even if a template
doesn't contain anything but this. But most of the content isn't
visible, unless the user presses the button. It's not only a lot of
content, it's also rather expensive, including .parseDom(),
LinkCache.styleElement(), and ve.targetLinksToNewWindow(). This adds
up in large multi-part transclusions. In an example with 200 parts
the total blocking time goes down from 2.9s to 2.4s. Which means this
is not a major bottleneck, but still worth it.

Bug: T296335
Change-Id: Ieab9fd35d145142b04d2267d8e5a2e10a4c02784
2021-12-15 08:28:16 +00:00