The checkboxes are actually indented a bit more than the search box
with this change the extra indentation is applied and the hide
button text is alligned accordingly.
Bug: T298259
Change-Id: I5508ab883c23e7285c023dc127529ffa4dbe58c7
From the user's perspective this is the same as before: When a
template doesn't have any parameters, there is no search field. The
moment the first (undocumented) parameter is added the search field
appears.
This is just delayed now. The widgets are only created the moment
they are actually needed.
This saves loading time and memory, especially in a multi-part
transclusion with many zero-parameter templates.
This also makes it a lot easier to change the minimal number of
parameters from 1 to e.g. 4.
Includes reverting the flexible header composition done in
Ib050e30a50ef965c1524e977d3a600c3ff836774
Bug: T298259
Change-Id: Ied7541d8d5c0b478a439dd31ce072e634287f181
New changes:
0c1a95a5d Localisation updates from https://translatewiki.net.
0f31d4996 DiffElement: Add test cases for table merges
89356a90a DiffElement: Improve description of colspan/rowspan changes
0cb95be10 DiffElement: Add more table tests
82b1d170c DiffElement: Move some more var declarations inline
3bf324d84 DiffElement: Handle a node index of 0
429dd0c56 DiffElement: Show whole node when DocList has attribute change
ed551058c Follow-up I1bd7171: Test colspan/rowspan values of 1 being the same as undefined
7a5a14235 DiffElement: Collapse tree diff with no described changes
07ff4af98 Follow-up Ib79a964c: Fix test HTML
3f5bb3be4 Follow-up I9a67730: Pass current list node to appendListItem
83c3e959b Improve AlienNode matching
9fa17d0a3 Alienate when trying to <p>-wrap an annotation where <p> isn't allowed
653dd2d58 DiffElement: Handle AlienBlockNode in list
20902e538 DiffElement: Fix rendering of internal list items with multiple child nodes
Bug: T259957
Bug: T278186
Bug: T299475
Change-Id: I88a1c8ce43e129f2117672d8f7570dca19d6c608
The search field will stay at the top of the window while scrolling a
single template. In multi-part transclusions, the header will also
be sticky.
Hides the template header in single-part transclusions.
Bug: T298618
Change-Id: Ib050e30a50ef965c1524e977d3a600c3ff836774
New changes:
1685748d5 Tests: Add tests for ve.ce.Surface#getViewportRange
d7d777667 getViewportRange: Handle node not being rendered
61ee718b4 ve.ce.Surface: Use selectFirstVisibleContentOffset when focusing a document
Bug: T296910
Change-Id: I3e7dd7095d10d618e0f2c6da8021eadd0ec92da2
New changes:
d90d1fb78 DiffElement: Change order of z-index fixes
bb46539c9 DiffElement: Move more var declarations inline
eb46b62ed DiffElement: Make processQueue a method
12c078f2c DiffElement: Separate processQueue and renderQueue
57e82187b DiffElement: Collapse context to spacers in isDiffedAsDocument nodes
Bug: T188170
Change-Id: Icf1ecd042d8c1da99d665580a4c16c1a55b5b53a
New changes:
67d78e763 Fix type hint in ve.ui.Command
c0a5da784 Use boolean RegExp.test() instead of .match() where possible
2a7c5f994 Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused
c55e24a67 Always convert to wrapper paragraph inside lists
Bug: T297773
Bug: T298609
Change-Id: Ic100641be04c81e17627c820d7dde10cd98ce4d8
New changes:
c138462d7 selectFirstVisibleContentOffset: Only apply line height hack when scrolling
1982be888 ve.dm.example: Build test code for commentNodePreview using a real widget
70c15c80b Update OOUI to v0.43.0
29482de0f getViewportRange: don't error in a no-contentoffsets document
Bug: T296910
Change-Id: I1bb6aa75b28f263543ea069496cf34bdaa5d02e0
Reuse the back button confirmation dialog for the close button. The
condition is slightly different: need confirmation if there are any
manually-entered values for any parameter AND the user has edited
the template in this session.
The "reset" action was synthetic, only used internally and not
connected to buttons or menus. Canonically, action='' is the close
action for OOUI.
Bug: T297792
Change-Id: I4ff644c7ab24ed9ba1a4c27d762563c5d6771cfc
* Find the first section below the top of the viewport
(usually visible) and measure its offset.
* After loading the editor, ensure this heading is still
at the same position on the page.
Bug: T296910
Change-Id: I9a05ea74ba3c19a4a91ddc1bc0afe311851c53e6
Without changing behavior, consolidate the logic for detecting
whether the editor has made changes to the template. This is
responsible for enabling and disabling the "Apply changes" button.
Change-Id: Ic4755b13f30fb738a7cb1eebaddef0435ea61d34
Currently, the insert template dialog includes a back button in the
upper corner. Confirmation of abandoning unsaved changes was
accomplished in an overlay panel. This patch rewrites as a dialog
and updates the on-screen text.
Bug: T297792
Change-Id: Ifa2ff97c9284609ee2a784f455789c56a762ba50
New changes:
22f6db516 Fix getViewportRange when section editing
7d948731c Toolbar: Remove unnecessary unfloat() in detach()
2d14351b9 Toolbar: Set toolbar height from $bar when floating, and updating size when switching surface
f18dab62f Improve getViewportRange behaviour around text wrapping
6eb23a10f Try to select a visible offset when focusing a null-selection surface
Bug: T296910
Change-Id: I1265be30bb11076576a32feea7299303f74b197c
* Use this.getElementWindow
* Use this.surface.padding to avoid race condition
when the toolbar hasn't fully rendered yet.
Change-Id: I055b1d9458d73e435ede6096941a3e72c9c1ce74
New changes:
04bd5c1da Localisation updates from https://translatewiki.net.
4147426da DiffElement: Manually number ordered lists with value attribute
ef3536361 DiffElement refactor: Pass diff objects to renderDiff instead of using state properties
593fe9026 DiffElement refactor: De-duplicate logic inside getNodeElements & wrapNodeData
a7b5eed5f DiffElement refactor: Create an iterateDiff method and unify function signatures
2db326345 Diff some nodes as if they are documents, e.g. <div>s
Bug: T188170
Bug: T298410
Change-Id: I28a048a02c62fb9bb96f29e472767d46c3b45804
