wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-28 12:46:45 +00:00
Code Issues Packages Projects Releases Wiki Activity
1807 commits 153 branches 1 tag 185 MiB
Commit graph

352 commits

Author SHA1 Message Date
Trevor Parscal 21ff108c28 Bring link converter in line with Parsoid 
Parsoid outputs rel="mw:wikiLink" or rel="mw:extLink", so we convert that to link/wikiLink and wiki/extLink respectively.

Also preserve the data-mw attribute; we probably need to do this more generally but this'll do for now.

Change-Id: I32e570bffa5a73a733a120d52cfd8b75d3191e02
 2012-06-11 00:36:20 -07:00
Trevor Parscal c40dd953ca Remove stray debugger statement 
Change-Id: Ie7c37e658d6d6bc15d5d7c24b2f5cd13945c5243
 2012-06-11 00:33:13 -07:00
Trevor Parscal ce8efd6b15 Refactored veCore class into ve.init and ve.init.EditPageTarget 
Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
 2012-06-10 23:54:41 -07:00
Rob Moen 38e64418b5 Move inspectors into iframe loaded in contextView. 
TODO- needs cleanup

Change-Id: I62d86260b48ef570ce18833dee3390ec9fff47e1
 2012-06-08 17:17:11 -07:00
Trevor Parscal 2e1b304a48 Cleaned up styles for editor in both demo and sandbox/integration 
Change-Id: I9b4a3727fd04b3c3ff3f297c6656db2592856173
 2012-06-08 16:20:37 -07:00
Christian Williams 80194260f3 Undo and Redo 
Change-Id: I2d7c1bfd164a42e5d52001054e52e47ca245ad18
 2012-06-08 16:21:47 -07:00
Trevor Parscal 89b2260bfc Revert "Support for basic text insertion - typing" 
This reverts commit 21056ff5ec.

Change-Id: I86bb28d868b2c931f4b6e18ba5023a8a75b40231
 2012-06-08 15:54:05 -07:00
Inez Korczynski 21056ff5ec Support for basic text insertion - typing 2012-06-08 15:31:29 -07:00
Trevor Parscal d61045085a Fixed link conversions to match parser 
Change-Id: I67838a8c05729e4d32e6e2dfca53c7d457143ce3
 2012-06-08 15:17:18 -07:00
Trevor Parscal 20d1c290d4 Fixed multi-auto-wrapping issue and added tests to track regressions 
Roan mostly wrote this

Change-Id: Id292c84a4da97d6608aa7c17ab6a4cf5a2e3f409
 2012-06-08 15:16:55 -07:00
Trevor Parscal 402d6dc53a Added rendering for link/unknown 
Change-Id: I47cdc8679c533f15059b290bf30ae74518dce724
 2012-06-08 15:15:43 -07:00
Trevor Parscal 5969f55550 Delete HTMLConverter and update demo&sandbox 
Also update the demo and sandbox for ve.{dm,ce}.TableSectionNode

Change-Id: I5a73a8250d283e8666b93561ce9e9374739936a5
 2012-06-08 12:40:43 -07:00
Trevor Parscal 2e0d4ef094 Make tableCell represent both <td> and <th> 
Adding a 'style' attribute which is set to either 'data' or 'header'

This breaks even more tests because of missing style attributes

Change-Id: I0a75d8c1578b4414eeae8c484f6c4d6f8a59472a
 2012-06-08 12:27:22 -07:00
Trevor Parscal c614d3391b Add ve.dm.TableSectionNode and ve.ce.TableSectionNode 
Yes, this breaks a bunch of tests, because tableRows are now required to be inside tableSections

Change-Id: Idb52d988df69173647c85f7602344650456e078e
 2012-06-08 12:26:45 -07:00
Trevor Parscal 5e6713eae5 Throw an exception when attempting to annotate a closing element 
Change-Id: Ifd4e49ee05e74db8bec754a6c1f79c969c1f2eac
 2012-06-08 12:23:59 -07:00
Trevor Parscal 5aa6f4b342 Fix bug in fixupInsertion() 
When a text node was closed (either by encountering a non-text node or by reaching the end of the document), the fixupStack would not be processed. This led to attributes being dropped when nodes were split because of text being inserted into them

Change-Id: I41f6d20e0c1bfc8d8689b7e6325e724dd8156ab1
 2012-06-08 12:23:58 -07:00
Trevor Parscal acdd5679ec Finish implementing ve.dm.Converter and document it 
* Add code to handle elements and annotations
* Drop support for aliens from getDomElementFromDataElement() and move it into getDomFromData()
* Implement getDomElementFromDataAnnotation()
* Document a few functions

Change-Id: Ic6a418cbf9d7d1ad96299d7d3633970a876c6103
 2012-06-07 21:58:56 -07:00
Trevor Parscal cc0c490502 Fix typo in LinkAnnotation 
Change-Id: Idfb969a73c59aef1acf54edd61d555cdc295534c
 2012-06-07 21:16:55 -07:00
Trevor Parscal f2b3df8027 Cleaned up some useless/unused functions 
Change-Id: I6aa5d0ed3d21993ed653ee64b4928ef98874db2d
 2012-06-07 15:02:40 -07:00
Rob Moen e1b8f9422d Fix bug in getAnnotationsFromRange where if the range length was 0 
it would return no annotations.

Change-Id: Iec33366b2a1249122a21617d6681ae039557c2fe
 2012-06-07 14:53:30 -07:00
Christian Williams 244551ff96 Updating model selection after cut and paste 
Change-Id: Iefaec5a3d705c6caae76941bc05810152d870bb8
 2012-06-07 14:48:46 -07:00
Trevor Parscal 453bec4555 Fixed alienInline and alienBlock conversion (was missing closings) 
Change-Id: Ie8e51eb8d9a452c656aebf341071da5627dd80b5
 2012-06-07 14:30:06 -07:00
Trevor Parscal fa9fe8b08a Added support for alienInline nodes 
Change-Id: I15b9cbcdb66b966dca28edcb26bf5d54a4f17be6
 2012-06-07 14:16:19 -07:00
Rob Moen 9fe6658a0e Put getSelectionRect method back in surface view. 
Change-Id: Iaec899bec157ef39810d391b2ed51d4f8fe3be9d
 2012-06-07 14:13:55 -07:00
Rob Moen 4b940c3b19 Init rangy in case of Toshiba 
Annotate button redraws selection after annotation
Added contextView hooks to select listener in toolbar.

Change-Id: I598fe715dd84976862eed63e4f55cb6bc6e75b18
 2012-06-07 14:04:39 -07:00
Christian Williams 1f86885d47 Fixing copy and paste 
Change-Id: I57ead6a6d831aa739df49960f97cb2f91f672730
 2012-06-07 14:03:48 -07:00
Catrope 9cab267911 Fix some JS errors in the ve.ui code 
Change-Id: I57057369f56dc20b56231ed4bbe34816c3c718d7
 2012-06-07 13:29:14 -07:00
Catrope 3c1de3dc4f Add ve.dm.Document.getBalancedData() 
Change-Id: I2420ef5369b9eae053962898b64dd7324e714bbd
 2012-06-07 13:17:57 -07:00
Catrope feac2f6069 Factor out element cloning into a getClonedElement() function 
Change-Id: Id6024c15d4d9c9141bc4e1afa39fce29992b8647
 2012-06-07 13:17:57 -07:00
Inez Korczynski 6704b01e30 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-07 11:44:35 -07:00
Inez Korczynski 5c41fa2fb8 Define min-height for P and HX tags - needed when those tags are empty. 
Change-Id: I0ba1c950cc06b3ff040c208c1b9a4970b2f73493
 2012-06-07 11:44:05 -07:00
Trevor Parscal 18461387c0 Roan officially does not owe the team lunch (at this precise moment) 
Change-Id: I90a6198da97ea90f60d9668c21d7386984a03ff0
 2012-06-07 11:33:58 -07:00
Inez Korczynski 02f913a7db Added accidently removed registrations for events handling. 
Change-Id: I6e5df649909b025f7e7aeb35ff9e8ff0b7fcd5f9
 2012-06-07 11:10:08 -07:00
Inez Korczynski 97001e1301 Improvements to selection mechanism. 
Change-Id: I031dd3493832034c985b15bf213cafe2c4813136
 2012-06-07 11:03:22 -07:00
Inez Korczynski 95297a2c73 Delete from ce.BranchNode code that is not needed anymore. 
Change-Id: I64f869a9fd54d089d2c6a31d827ddaccb9ece900
 2012-06-07 11:02:59 -07:00
Inez Korczynski f711d78d4d Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-07 10:58:42 -07:00
Christian Williams 51aa317df3 Undo and Redo support 
Change-Id: Icdbebccefe3cc162b9ff6c0d978d5e4fc1f2c561
 2012-06-06 20:28:06 -07:00
Inez Korczynski d96db8dce7 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-06 18:50:02 -07:00
Catrope d8359da409 Change calls to getElementType() (which doesn't exist) to getType() 
Change-Id: I894835a0178beddce480c48917700090b31c80b2
 2012-06-06 18:03:55 -07:00
Rob Moen 232f2c58f7 Fix linkInspector tool 
Change-Id: I89fa17b1a72c3f45bce5a11b49aa5445c5990f68
 2012-06-06 17:50:01 -07:00
Trevor Parscal b62beed2e2 Added implementation for ve.dm.Converter.getDataFromDom 
Change-Id: I8561d4a00ba630b86fb7bcd3e347fe2c6c2f6aa3
 2012-06-06 17:47:27 -07:00
Rob Moen 8db70ed263 Annotation buttons now working 
Created new document method to determine if a specific annotation
object is inside an annotation array.

Change-Id: Id645929cbf31030b8b0fcacb8dfb36e61aaad129
 2012-06-06 17:06:37 -07:00
Christian Williams 77d5cae575 Consecutive spaces 
Change-Id: I3f51ce0a2ee0a78e56c55de94bd45796b400680d
 2012-06-06 16:29:02 -07:00
Catrope 5e47bdc57f Maintain a transaction-wide offset adjustment 
This fixes a bug where the second replace operation in a transaction
would cause the rebuild of the wrong range, or the adjustment of the
wrong text node.

Change-Id: I9b1c68d84999d538fe10bb193f4dfdd694121d2a
 2012-06-06 15:34:55 -07:00
Catrope 02b19f337f Add zero-length text nodes to empty content nodes 
This is needed to make the results of certain transactions' tree sync
round-trip cleanly through the ve.dm.Document constructor

Change-Id: I2ab0758ec6bd7afba5b6645c7330f9fa2d45205d
 2012-06-06 15:33:42 -07:00
Catrope ae3d31d447 Shallow-copy annotation objects in HTMLConverter 
This fixes an annotation contamination issue that was causing Rob's
tests to throw exceptions

Change-Id: Ic5171d600b0b2ff97cc569e1e6f9488fab177c7c
 2012-06-06 12:21:01 -07:00
Catrope e524152319 Fix typo in variable name 
Change-Id: I6772555da86a186ec2421d01f82de14463061362
 2012-06-06 12:20:05 -07:00
Rob Moen 337e9b8eee Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-06 12:02:22 -07:00
Rob Moen 21ee17a192 Fix up some tools to not break on selection, added some test selection 
stuff to sandbox

Change-Id: Ic97144e634111c489507814c6634c66831726191
 2012-06-06 11:51:19 -07:00
Catrope 1429a3da59 Rewrite newFromRemoval() using 'covered' mode 
Change-Id: If0736aff6d194ec09c2a109f046dd6362ddc64fb
 2012-06-06 11:47:35 -07:00
Catrope 1566306937 Add 'covered' mode in selectNodes 
Change-Id: I4d24c011ce7a94bc75508dea410fb0ed9ebce6a1
 2012-06-06 11:47:35 -07:00
Catrope 244349aedb Fix stupid typo in selectNodes() 
Change-Id: I1e308c9f3a6e6eb8fe7fe8ae3c6abf7cc3a84d09
 2012-06-06 11:47:35 -07:00
Catrope d39fb9dd1c Make pushReplace([], []) do nothing 
Change-Id: Ifa8df99f376ce22add9d06e76831e8b661e6ddbf
 2012-06-06 11:47:35 -07:00
Rob Moen 2439c0149a Created secondary method for getMatchingAnnotations 
new static method looks for annotation in annotation object.
ve2 Cleanup on annotate method and surface model.
Partially revive UI tools by exchaning old method usage
for ve2 methods.

Change-Id: Id0ac58330292d76801bbcf1d71a919b493f8ab9e
 2012-06-06 11:27:23 -07:00
Trevor Parscal 5d20f45120 Added getHtmlElementFromDataElement and getDataElementFromHtmlElement 
Change-Id: Ie5f4fd86612b5a6c34b5843d1e9a521edc626a63
 2012-06-06 10:17:51 -07:00
Catrope d378182bff Reapply typo fixes from c0e1991 , were undone in b0f6f64 
Change-Id: If84e13b91781ed96d3bd9e94171e16020c65ea42
 2012-06-05 06:54:35 -07:00
Catrope 528728558b Fix bug in selectNodes's logic for traversing back up the tree 
Change-Id: I0fc5a2ad2c9a8d162e8ddbf3cc6d31684d364928
 2012-06-05 06:50:09 -07:00
Trevor Parscal b0f6f64d90 Made pushRetain do nothing if you give it 0 and throw an exception if you give it a negative length 
Change-Id: Ib9955660b05a04503325ddb20f9e9a525b4d6832
 2012-06-04 16:27:33 -07:00
Trevor Parscal 9111e34a0b Added nodeOuterRange to selectNodes 
Change-Id: I9ef0c383fbb2515c752d2d3c52e8632aac73d811
 2012-06-04 16:21:29 -07:00
Catrope c0e19915ef Typo fixes and missing 'var' in newFromRemoval() 
Change-Id: Ibb984d862670b5386ff76fc55ef3322f695b6ae1
 2012-06-04 16:07:16 -07:00
Catrope db793009be fixupInsertion() variable documentation and cleanup 
Functional changes (fixes):
* Make writeElement() also update parentNode and parentType for openings
* Also add to fixupStack when opening a wrapper for a text node

Non-functional changes (cleanup&docs):
* Document all variables at the beginning of the function
* Group variables according to where/how they're used
* Move expectedType into writeElement()
* Kill node, duplicates parentNode unnecessarily
* Kill paragraphOpened, was misnamed and unnecessary
* Rename closedElements to reopenElements

Change-Id: Ie5b4e4f30b267943048fdc170accb29139039192
 2012-06-04 16:07:16 -07:00
Catrope f7445b37b8 Retain attributes when reopening closed nodes 
* Push entire elements onto openingStack rather than type strings
* When closing an element, build a clone of the opening and push it onto
  closedElements, then insert that clone when reopening the element

Change-Id: I8b0fb44394aed6c471dc6dacaab03e44c2333733
 2012-06-04 16:07:16 -07:00
Catrope b167453f0d Add ve.dm.Node.getAttributes() to get a reference to the attributes object 
Change-Id: Ic2463d4f7053a5f6defd212f04deb5ea71542843
 2012-06-04 16:01:14 -07:00
Catrope 109624e8b3 fixupInsertion fixes, wrapping content works now 
Change-Id: I1eee6afcffbf09955578b7f0534aa5b7234802df
 2012-06-04 16:01:13 -07:00
Rob Moen fd5eb80dd7 Document annotate method in surface model. 
Comment cleanup

Change-Id: Ifd3eeab9046f376529a827dfafdc28506845ac15
 2012-06-04 15:06:37 -07:00
Rob Moen c338304d33 Rewrite annotate as more low level method in Surface model. 
TODO: follow up with annotate tests

Change-Id: If0e68bd3a09840b1e5f3e8d85fd22a8c10134b58
 2012-06-04 14:29:27 -07:00
Trevor Parscal 73c5dd8f1d Added ve.dm.Node.getOffset 
Change-Id: I4fb99040af44c063ad3b6489f2fd895d843fcf0c
 2012-06-01 17:44:01 -07:00
Christian Williams cf63a2dd36 Support for pasting into a range 
Change-Id: I13e29caba4d912db2477a2c3c4edeca5d21d06b4
 2012-06-01 16:38:27 -07:00
Christian Williams 2bd615c6d2 Cut, copy, and paste now working with images 
Change-Id: Ic3b99d39bd41a8fe39e015ca05d159a5a4ea2b15
 2012-06-01 15:52:51 -07:00
Inez Korczynski a2e7335ed6 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-01 14:37:34 -07:00
Trevor Parscal 386faa5569 Fixed ve.dm.Transaction.newFromRemoval so it supports trimming off extra openings and closings 
Change-Id: Icbcf4129a51aa92d47aa89738facd0d288337cbd
 2012-06-01 14:34:59 -07:00
Inez Korczynski 8a35e6eafe Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-01 13:51:24 -07:00
Trevor Parscal e7f03c6d70 More cleanup, removed ObjectAnnotation (they are inline elements now) 
Change-Id: I2c53c145eed1a801392c954001de7641f928216c
 2012-05-31 17:18:28 -07:00
Trevor Parscal ba8d1b46f2 Cleanup 
Change-Id: Ida9c94d5aa410ee699b706492f444a6449922ede
 2012-05-31 17:11:01 -07:00
Trevor Parscal 294abb0a38 Simplified converters data structures 
Change-Id: I1734bc7e06462595ea2f27715948fbb3d9e552ad
 2012-05-31 17:03:03 -07:00
Trevor Parscal 042ffb4e3b Added foundation for new converter 
* Added converters to all relevant node implementations
* Added new annotation objects with their own factory

Change-Id: I9870d6d5eac45083929d74d2e58917d0939ca917
 2012-05-31 16:50:16 -07:00
Inez Korczynski 9edb38353c Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-31 15:52:01 -07:00
Trevor Parscal f6864b0c04 Changed use of "factory" to "nodeFactory" to make way for other kinds of factories 
Change-Id: I96db0f28bb220f1c3b23990824e9523278cb8f9b
 2012-05-31 15:20:58 -07:00
Trevor Parscal 32bddaf088 Added ve.dm.Transaction.newFromRemoval 
Also:
* Refactored tests
* Added tests for ve.dm.Transaction.newFromInsertion
* Added tests for ve.dm.Transaction.newFromRemoval
* Fixed problems with ve.dm.Transaction.newFromInsertion
* Added ve.dm.Node.canBeMergedWith which is partially a port of ve.Node.getCommonAncestorPaths merged with canMerge from within ve.dm.DocumentNode.prepareRemoval from the old ve codebase

Change-Id: Ibbc3887d08286d8ab33fd6296487802d65b319fa
 2012-05-31 14:39:34 -07:00
Catrope 2f18605a1a Fix buggy replace behavior when inserting content that contains nodes 
Copy-pasting things like "text<IMAGE>moretext" failed spectacularly,
this commit fixes that.

* Check for content rather than structure in the inserted/removed data
* In the content case
** Run selectNodes() over the removal range, rather than just the cursor
*** i.e. no longer assume that content replacements only affect one node
** If there is structure involved, rebuild all affected nodes

Change-Id: I80e40b5b7c514a3fb105d57e4a17770d0fefaaea
 2012-05-31 07:27:36 -07:00
Catrope f6ca37926d Add ve.dm.Document.isContentData() 
Some of the replacement code was assuming that "does not contain
elements" and "is content" were the same. They're not any more, because
we have content nodes (like image) now, so I need a separate function
to distinguish between these cases.

Change-Id: I206ccdf082b7baddf99d382eb3cdd77ea34fb479
 2012-05-31 06:19:34 -07:00
Catrope e92db86046 Fix bug in ve.dm.Document constructor for input ending with text 
If the last element of the input data array was text, the resulting text
node would have length=0 rather than the expected length value.

Change-Id: I3d089a80b8a447a12ba411b2e11c1b84f14f2959
 2012-05-31 06:17:23 -07:00
Inez Korczynski 065494941e Add special handling in getOffset method for a case when cursor is inside slug - required in IE 
Change-Id: I27ae78632e7b28921f5fe4214d2fee658c37b564
 2012-05-30 18:11:23 -07:00
Rob Moen b59d49a80d Restrict edit access to VisualEditor namespace to sysops 
To allow non sysops to save via VE, refactored ve save api
to use doEdit which bypasses namespace protection.
Add edit link in view nav for non sysop so that they may edit
Add View source link in dropdown for non sysops
Add Edit source link in dropdown for sysops
Cleaned up some of the integration core code
UI tweaks

Change-Id: Ib4249bc5fb7ffa6410e4f2d278aafbb871800981
 2012-05-30 17:12:25 -07:00
Inez Korczynski 43a6abec2d Introduce two different types of slugs - inline and block - this is in order to fix bug in IE with placing cursor inside slug by clicking next to it 
Change-Id: Idf31a742ee98067688becf46b357c25cd10ddbc6
 2012-05-30 16:45:06 -07:00
Inez Korczynski f7fb4bee5c Refactoring and performance optmization to method getNodeAndOffset - previously named getDOMNodeAndOffset 
Change-Id: I067331f539bc86779c98be38e6a56ca04137c70f
 2012-05-30 15:19:39 -07:00
Trevor Parscal 46d26b9f22 Added getNodeFromOffset to ce 
WARNING: This is not as fast as the implementation of getNodeFromOffset in dm

Change-Id: I5fbe9b6edc66169b9caaa6751fde1b7b752814d1
NOTE: ve.ce.getNodeFromOffset and ve.dm.getNodeFromOffset should be renamed to getBranchNodeFromOffset to clarify that they only return branch nodes.
 2012-05-30 14:38:18 -07:00
Trevor Parscal 8328fc8786 Removed aliases for node type constants, on the client we have them already in Node 
Change-Id: Id68dd43930a51a857e73af0215fd215c89e9bbbe
 2012-05-30 14:38:18 -07:00
Inez Korczynski 5f9ea545cf Refactoring and performance optimizations to getOffset method in Surface view. 
Change-Id: I8b57c9dc069894c82a6bafc5f282aefda505d061
 2012-05-30 14:06:44 -07:00
Christian Williams e216a6f8ab Fixed scroll jumping when pasting 
Change-Id: I9607dee6d1b0ca1820a9da5f48966310214e5edf
 2012-05-30 13:06:19 -07:00
Christian Williams 11b1bd8884 Using string constants for node types 
Change-Id: I2d18d4f54c776e299bc10206386b655605dae839
 2012-05-30 11:41:31 -07:00
Inez Korczynski 8a52b41076 Working (but dirty) implementation of getOffset, getDOMNodeAndOffset and handlers for keydown/mousedown - to be refactored very soon 
Change-Id: I57923218fc8e5f3e1cdde339cdc1cb5e859cdedf
 2012-05-25 23:52:52 -07:00
Inez Korczynski e5897dffa4 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-25 23:36:54 -07:00
Inez Korczynski e9230968fe Set contenteditable=false for Alien wrappers (both inline and block) 
Change-Id: I5fd8fcfd0b6d98b525a75b3818cc77e3aca833c9
 2012-05-25 23:36:18 -07:00
Christian Williams 8db39d0bb5 Support for plain text paste 
Change-Id: I60846900d61b50138fe06dacee4693166e59651e
 2012-05-25 16:26:46 -07:00
Christian Williams 64b9b33eec IE and its silly events 
Change-Id: I81f46eca20cc5197305cbd355751c4c90e3b670b
 2012-05-25 16:12:58 -07:00
Christian Williams 83e7eddfaf Support for paste 
Change-Id: Id0a3d5d421aef56eb3296a56d00686ef7d07b433
 2012-05-25 15:46:58 -07:00
Inez Korczynski 1e5e14c2c1 Add method hasSlugAtOffset to ve.ce.BranchNode 
Change-Id: Id107bf890710096bb49111ae3d0d60e3315ecb89
 2012-05-25 13:44:12 -07:00
Trevor Parscal 14862a1212 Fixed bug in isStructuralOffset which didn't consider neighboring a non-content leaf to be a structural offset 
This was caused by the fact that a non-structural leaf can not have children, which makes it appear incompatible as a sibling to an arbitrary structural element (like a paragraph) but since it can not contain content we can check that instead.

Change-Id: Ie3c58b4b43f2aa6921f8f82aa82511e231207854
 2012-05-25 13:19:56 -07:00
Rob Moen 7b47af516a Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-25 12:52:46 -07:00