Commit graph

20572 commits

Author SHA1 Message Date
Umherirrender 611b1988cf api: Remove old apihelp i18n description messages
No longer used since 1.33

Automatically removed message keys with "doc-apihelp-description" in qqq

Bug: T340253
Change-Id: Ic3d031da376b78d3ccfec27517ec9a288c54fdc4
2023-06-24 00:46:01 +02:00
Bartosz Dziewoński 5a792b6558 ApiVisualEditorEdit: Allow not returning the new revision content
Sometimes we call this API and then reload the page (or navigate to
another URL), without using the page content it returns. Save some
work and some data transfer and don't generate it in those cases.

Change-Id: Ic5fac61f3ef9b2dfce6ff757f1d414a9f41f217d
2023-06-22 21:08:15 +00:00
jenkins-bot 68265fcd14 Merge "Use new helpers to show the post-edit message" 2023-06-22 15:33:28 +00:00
Ed Sanders 94fb927242 Replace ve-ce-surface-enabled with ve-ce-surface
The former is deprecated, and not required here.

Bug: T340124
Change-Id: I874b40bd8288763aeba8946ce40cecfd27e47c1b
2023-06-22 16:26:47 +01:00
Bartosz Dziewoński dd509c1072 Use new helpers to show the post-edit message
Undo some changes from 95454e710f1b619f7c538bc1dc88f238409719ca,
as this functionality is now provided by the core code.

Depends-On: I1c9020b2efb2785279f5c09539a49208a310ccf7
Depends-On: Ifeffcf214719f0d5c1371dc7d51a410fb313c978
Bug: T338003
Change-Id: I90a618897699c844f9c558bbeb4d1563f8050fe3
2023-06-22 13:51:59 +00:00
Bartosz Dziewoński ac8f8791f1 Don't show edit notices popup after switching VE/NWE
The user has already seen the notices, and getting hit with yet
another popup doesn't feel nice.

Bug: T169179
Change-Id: I421e42d32cb67ea210644b705e9c6e5af74e75ee
2023-06-22 13:42:25 +00:00
David Chan 99f7df7702 Only trigger editcheck on pure insertion (remove.length === 0)
Bug: T340088
Change-Id: I3d8fc2a3e7e6df908ca445af85a14c87a73e0ad3
2023-06-22 09:33:58 +08:00
jenkins-bot bc1a1494c5 Merge "selenium: Disable flaky test" 2023-06-21 21:13:05 +00:00
Kosta Harlan 85c3f13c2c
selenium: Disable flaky test
See https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/43144/consoleFull

Bug: T296187
Change-Id: Iba71488ffb10b85598461c0d85fac99cc491a69e
2023-06-21 22:07:17 +02:00
jenkins-bot 1f76a0e8f7 Merge "Make "add undocumented parameter" hotkey ctrl+shift+d work much better" 2023-06-21 19:52:11 +00:00
Bartosz Dziewoński eedafae69e Support '&editintro=…' etc. on subsequent loads via page tabs
Before this change DesktopArticleTarget's history management was not
working correctly because .currentUrl was not being updated on every
activation, and we worked around this problem by activating it in a
different way on subsequent loads in DesktopArticleTarget.init.

Fix the first bug by updating .currentUrl whenever we activate it,
and remove the guards around the normal way of activating it, which
fixes the parsing of 'editintro' parameter.

Bug: T56029
Change-Id: Ifd6af60cdf1d2c87536017b316ab8da1f5133400
2023-06-21 13:35:43 +00:00
Bartosz Dziewoński bcabb774ab Support '&editintro=…' etc. on back/forward and VE/NWE switch
The edit intro message is now shown again when closing/opening
the editor using the back/forward browser navigation,
and it is preserved when switching between VE and NWE.

Bug: T56029
Change-Id: I12083926341a6d3ba4c7a9f84736cddc7f2ac0fa
2023-06-21 15:35:06 +02:00
Bartosz Dziewoński 2b8c3edab2 Replace the last use of mediawiki.Uri
Depends-On: Ia95a27c7d7ebc9e4779f82598152145f02993b29
Change-Id: I8736111c4ec3cf9a9480df2efbdf080b5d72d514
2023-06-21 15:35:06 +02:00
Bartosz Dziewoński a35698fea5 Fix '&editintro=…' not working on Vector with some settings
In Vector the edit tab links have an extra <span> inside, and so
we couldn't find the parameters in the <a> href, because we were
actually looking at the <span>.

It worked in cases where we override the edit tab labels, since
we trample over the spans, e.g. in multi-tab mode.

Bug: T56029
Change-Id: I96935490418d7c3be4d417aaa71cb6e9608fd77f
2023-06-21 13:08:05 +00:00
Bartosz Dziewoński d8c3d007ff DesktopArticleTarget.init: Remove error logging for URL errors
Detailed logging is no longer needed after T328094 was resolved.

Change-Id: I49fa8598aa442445e12e553ebfd6680d9fe12a1b
2023-06-21 15:07:47 +02:00
Bartosz Dziewoński 3008aaf325 ArticleTarget: Simplify switching to NWE with no changes
This code was identical to what happens if you just call
reloadSurface(), except for some half-hearted error handling.
We already do it this way when switching from NWE to VE.

Change-Id: I8027680b7ca272930b951d0403594679ef308083
2023-06-21 15:07:47 +02:00
Bartosz Dziewoński 99b326286c DesktopArticleTarget.init: Fix bad parameter to activateTarget()
The 4th parameter is a boolean 'modified', not a node. I'm not sure
what this was supposed to do. It looks like the parameter was being
ignored in all cases anyway.

Change-Id: I559ab2bdb02c4a3e39b44487cf36122332d61fd1
2023-06-21 15:07:47 +02:00
jenkins-bot ac4032eff5 Merge "Stop collecting stats per wiki" 2023-06-20 11:39:26 +00:00
Translation updater bot 93f8519c66 Localisation updates from https://translatewiki.net.
Change-Id: I2591b819d7d9e41d0d075ad8042e562df828cae5
2023-06-20 09:51:10 +02:00
daniel 4a2b3b580f Stop collecting stats per wiki
Having per-wiki statistics is neat but expensive. Now that VE has been
switched to not use RESTbase on all wikis, Go back to collecting
all stats under a single key. The relevant dashboards have already been
adjusted accordingly.

Change-Id: I9666bfa3fed547f3f619a9e0c9c24b9240edc359
2023-06-19 21:19:35 +00:00
Translation updater bot 4437dd2fd2 Localisation updates from https://translatewiki.net.
Change-Id: Iec733b7bd761300bf844eeca6993ffca94b82bcf
2023-06-19 11:08:25 +02:00
jenkins-bot d5e4ead3c7 Merge "Revert "Targets: Use align:'after' instead of actionGroups"" 2023-06-15 20:30:32 +00:00
Bartosz Dziewoński e2b5e2a1bb Revert "Targets: Use align:'after' instead of actionGroups"
This reverts commit 45a60e3fb2.

Bug: T339292
Change-Id: Ifefdf36370ff0de87218f390e5e21d2800a81ebd
2023-06-15 20:06:21 +00:00
jenkins-bot ca8399d97c Merge "ApiVisualEditorEdit: Remove unnecessary check" 2023-06-15 18:09:26 +00:00
Ed Sanders b982512605 Unwrap headings in lists (and <blockquote>) when pasting external HTML
Bug: T339155
Change-Id: I8e82b3455c120edd11e993c4fa80a06e3f9bdeee
2023-06-15 16:22:15 +01:00
David Lynch 55b7f4ffea HelpCompletionTool wasn't added to extension.json
Follow-up to ac85050f2d

Bug: T338254
Change-Id: I8f66e5cb2b7237b1d0d63dc664854a66229cd6b5
2023-06-15 14:36:09 +00:00
jenkins-bot 2d9e31e0e5 Merge "Don't try to prefix browser title if a custom message is incompatible" 2023-06-15 05:45:53 +00:00
Bartosz Dziewoński 0da5630040 Update VE core submodule to master (e2cf1e114)
New changes:
c5c0eb3b5 Localisation updates from https://translatewiki.net.
05b265c1d Fix build path of wikimedia theme demo
b803113e4 build: Update devDependencies
1abb8d167 LinearDelete: Add some test cases for deleting next to block elements
e57919c5c LinearDeleteKeyDownHandler: Merge loops for table/focusable-adjacent delete behaviour
24b726711 Delete empty paragraphs when next to block nodes

Bug: T338622
Change-Id: I1f6f7d3a7f9a4ee5ac66770700d2ef2439968f69
2023-06-14 23:10:25 +02:00
Translation updater bot c9afdec94c Localisation updates from https://translatewiki.net.
Change-Id: I7536bbfcaa5b1c62c805b1896fdbc8d8c6fe4700
2023-06-14 13:08:21 +02:00
jenkins-bot 4b6e819440 Merge "Set a JS config var to force VisualEditor to edit the current version" 2023-06-14 01:56:12 +00:00
jenkins-bot 9cbf093d6f Merge "Don't offer visual diffs for page creation" 2023-06-13 23:35:42 +00:00
Ed Sanders 43699fe94c Exclude after-aligned tools when creating target widgets
Bug: T338978
Change-Id: I86d2546926fa58c36d3679a2d6d31b5a89e6364f
2023-06-13 18:06:14 +00:00
jenkins-bot fdb3a79ef5 Merge "jsduck: Add missing categories for MW classes" 2023-06-12 23:51:04 +00:00
jenkins-bot 3e0fc14a8c Merge "Targets: Use align:'after' instead of actionGroups" 2023-06-12 23:51:02 +00:00
Ed Sanders 5499de28fe jsduck: Add missing categories for MW classes
Change-Id: I5e0ce17ed5de47fe4d3079636a0d729cf811fe7a
2023-06-12 19:04:37 +01:00
Bartosz Dziewoński 8573df0233 ApiVisualEditorEdit: Remove unnecessary check
There are no occurrences of the error message in our error logging
data, so it most likely can never happen.

https://superset.wikimedia.org/superset/sqllab/
```
select count(*)
from editattemptstep
where event.save_failure_message = 'visualeditor-docserver'
```

Change-Id: I8172564057418283468c657cbc6d42ce8ddb35f4
2023-06-12 17:56:13 +00:00
Translation updater bot fbd33d63ee Localisation updates from https://translatewiki.net.
Change-Id: I97610873b8e9a1852d2967a44efb84cb41206650
2023-06-12 13:08:34 +02:00
Bartosz Dziewoński 08d7ec3d2d Don't offer visual diffs for page creation
Bug: T338388
Change-Id: Ie59a1a493bce6dd1beb3c332f95a55eb55eeeef2
2023-06-10 16:44:18 +02:00
jenkins-bot b5e3d70f47 Merge "MWImage: Use mw-file-element class in converter methods" 2023-06-09 20:39:57 +00:00
jenkins-bot d4a8467cab Merge "Update CE nodes with mw-file-element/mw-file-description classes" 2023-06-09 17:39:50 +00:00
Ed Sanders 45a60e3fb2 Targets: Use align:'after' instead of actionGroups
Change-Id: I2b2b0c86697e3afde7ea192ce6dc5996998dfa4b
2023-06-09 18:09:27 +01:00
jenkins-bot a8a7dc110a Merge "Update VE core submodule to master (549e36956)" 2023-06-09 16:59:02 +00:00
Bartosz Dziewoński ac85050f2d Update VE core submodule to master (549e36956)
New changes:
2ec47e304 Localisation updates from https://translatewiki.net.
08dea65b1 Reuse overlapping rect logic from ve.ce.FocusableNode
fcde3bed1 Mark Target.static.actionGroups as deprecated
c2a68aa18 CommandHelpDialogTool: Use 'keyboard' icon instead of 'help'
4b048db57 Create a tool to launch help completions from the toolbar

Bug: T338254
Change-Id: Icaef215b9fe025d6ef0d7f766d2efe629c45665f
2023-06-09 18:36:16 +02:00
jenkins-bot 9c4e8c4805 Merge "Always use the strict equality flag when using in_array" 2023-06-09 16:27:03 +00:00
Ed Sanders f1ddd483da Update CE nodes with mw-file-element/mw-file-description classes
Change-Id: I5846e370b2b1897c63fe9728d081b7a406c138ba
2023-06-09 16:52:08 +01:00
Dringsim d27825caa1 Set a JS config var to force VisualEditor to edit the current version
Rename wgFlaggedRevsEditLatestRevision to wgEditLatestRevision (not use 'VisualEditor' - this config may be used by other editors)

Bug: T338312
Change-Id: I6c9c46774fe197ca7775b65f12e62bb3bcbe53b4
2023-06-09 12:45:37 +00:00
Translation updater bot d125506b79 Localisation updates from https://translatewiki.net.
Change-Id: Icf76ef411c9b39dd4069843b4bc37d8350594036
2023-06-09 09:15:11 +02:00
jenkins-bot 550f73468e Merge "Bump requested Parsoid HTML version to 2.8.0" 2023-06-09 03:23:32 +00:00
jenkins-bot b9dc193037 Merge "Ensure a compatible Parsoid output version for direct client" 2023-06-09 03:22:18 +00:00
jenkins-bot 208ea059ca Merge "EditCheck: Filter ranges to CBN interiors" 2023-06-08 15:50:05 +00:00