Commit graph

2391 commits

Author SHA1 Message Date
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
2014-11-03 15:18:44 -07:00
Cmcmahon 6907583418 [BrowserTest] no more iframes
Change-Id: I8090f95ccd1cf2744649084c863e6034db062d87
2014-11-03 14:45:52 -07:00
Cmcmahon fcfb847276 [BrowserTest] no more iframes for Media test
Change-Id: I724e071935f383185fdc44cf1a139931f8ded557
2014-11-03 14:37:59 -07:00
Cmcmahon a51783983f [BrowserTest] no more iframes for Links test
Change-Id: I72c01981b332a32711e929543a61a780de962a2e
2014-11-03 14:18:21 -07:00
jenkins-bot 48cfd29886 Merge "[BrowserTest] click More button, no iframes" 2014-11-03 20:59:37 +00:00
Cmcmahon 61f8cf7ca5 [BrowserTest] click More button, no iframes
Change-Id: I1426f4dcfb65d6e38be5f7e495e9600f98894525
2014-11-03 13:57:29 -07:00
James D. Forrester d0e62e1ab3 MWGalleryInspectorTool: Provide the tool in the toolbar
Now that the toolbar hides extra features by default, we don't need to
use autoAddToGroup and autoAddToCatchall over-rides.

Change-Id: I493f7d46a3f77e7c62af05f8e05ae4dde7147e4b
2014-11-03 11:19:04 -08:00
jenkins-bot 35a7931f10 Merge "[BrowserTest] no more iframes for Cite test" 2014-11-03 19:11:48 +00:00
Cmcmahon 3b57451863 [BrowserTest] no more iframes for Cite test
Change-Id: Ic31521dc8124818df1451a57ae396ca2e9c6beef
2014-11-03 11:57:55 -07:00
jenkins-bot b5e235ea85 Merge "Clean up LookupInputWidget subclasses and use new functionality" 2014-11-03 18:41:48 +00:00
Roan Kattouw a0167c08c7 Clean up LookupInputWidget subclasses and use new functionality
MWCategoryInputWidget:
* Use @inheritdoc
* Don't modify data parameter in getLookupCacheItemFromData()

MWLinkTargetInputWidget:
* Remove this.choosing in favor of setLookupsDisabled()
* Explicitly close menu on choose
* Remove manual emission of change events
** This looks ridiculous, it doesn't seem to be necessary,
   and it causes infinite event loops. But I'm very curious
   why this was added in the first place.
* Remove onLookupInputChange override that is now unnecessary
* Use {} rather than [] for fake empty result
* Prevent programmatic focus from opening the menu

MWTitleInputWidget:
* On choose, close menu and disable lookups while changing value
* Use @inheritdoc
* Remove mentions of "template" from getTitle() documentation

Bug fixed:
* When choosing a suggestion in MWTitleInputWidget,
  new suggestions would be loaded and the menu would reopen

Depends on Iecae9b582 in oojs-ui.

Change-Id: I716f99bb464a5cebd4f17701197f768e4e0e02a9
2014-11-03 10:39:03 -08:00
jenkins-bot e69bc55473 Merge "Pass $overlay to redirectTargetInput in MWSettingsPage" 2014-11-03 18:38:05 +00:00
Cmcmahon 282afbbb2f [BrowserTest] Resume Editing no longer in iframe
Also workaround for Bug 72911

Change-Id: Idbff05837dd97ace534ec732c0ba56b6b523bbe0
2014-11-03 11:02:23 -07:00
Cmcmahon df039a6ee9 [BrowserTest] stuff moved out of the iframe to the main page
step-wise update, probably more changes to come

Change-Id: Ia40c03dd59ab0b28af56176b6da4d30a1e66a195
2014-11-03 10:31:26 -07:00
Translation updater bot 3b3af61679 Localisation updates from https://translatewiki.net.
Change-Id: I13815ef4879f33268d517514dae14d4430340709
2014-11-02 22:00:55 +01:00
Translation updater bot 77454fb02a Localisation updates from https://translatewiki.net.
Change-Id: Ia873b55332f36f07e80bd384e2d10c0b51c183b1
2014-11-01 22:40:04 +01:00
Alex Monk 0dde78bd54 Pass $overlay to redirectTargetInput in MWSettingsPage
So the TOC options don't display over the top of suggestions for it

Bug: 72838
Change-Id: I73f0f9e3a44a9f641b6bed2a42cac2c8293cc5c9
2014-11-01 04:49:36 +00:00
jenkins-bot 8f8613f27b Merge "MWTransclusionDialog: Blur active input when switching modes" 2014-10-31 22:55:24 +00:00
jenkins-bot 1509e318a7 Merge "Add forgotten $overlay pass-through in MWReferenceDialog" 2014-10-31 22:54:15 +00:00
Translation updater bot b33ab8da4b Localisation updates from https://translatewiki.net.
Change-Id: Ice9530a321aba7e64d27c138569c2a7f94ec36a0
2014-10-31 21:47:26 +01:00
jenkins-bot 4df619c813 Merge "Update "page was last modified on date, at time" footer line when saving" 2014-10-31 05:24:58 +00:00
Roan Kattouw c324ed8b9a MWTransclusionDialog: Blur active input when switching modes
When show/hide options is clicked, the inputs in the main pane
move as the outline transitions in or out. This causes any dropdowns
below these inputs to become mispositioned: they don't move
because they're in an overlay.

To work around this problem, blur the active input when show/hide
options is clicked, so any dropdown attached to it is closed.
I tried blurring and immediately refocusing the active input to
force the dropdown to reposition itself, but that looks awkward
because of the transition (we'd have to wait for the transition
to complete before repositioning it, and during the transition
it'll stay open in the wrong place).

Bug: 72789
Change-Id: Ibd963690573af905066839f7276077089fa893c6
2014-10-31 04:19:41 +00:00
Alex Monk b2af92870a Update "page was last modified on date, at time" footer line when saving
Bug: 52403
Change-Id: I11e00066000e927f0551691d05fe11fe2ae125b0
2014-10-31 01:00:04 +00:00
Translation updater bot 7957ffa53c Localisation updates from https://translatewiki.net.
Change-Id: I1c44ba77871aa8807735127d04a7565acf0db6e7
2014-10-30 23:32:21 +01:00
Roan Kattouw 884aa1f243 Add forgotten $overlay pass-through in MWReferenceDialog
We were doing this for the exact same widget in
MWReferenceListDialog, but not here.

Bug: 72785
Change-Id: I4a905b944be44ec1aec5cdba7580283ec18c5c7c
2014-10-30 14:50:10 -07:00
Alex Monk b71bb51171 Remove more references to ve.bind
Seems some of them have crept back in since I1a7fc7f2 (and we missed one somehow)

Bug: 72156
Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
2014-10-30 20:55:44 +00:00
jenkins-bot c83961842c Merge "Preserve original data inside parameter objects too" 2014-10-30 20:47:32 +00:00
jenkins-bot 9a1ed3ce3d Merge "Toolbar: Make styling and insert menus collapsible" 2014-10-30 19:56:08 +00:00
James D. Forrester 6626450419 Toolbar: Make styling and insert menus collapsible
Also re-synchronise toolbar in MWMediaDialog and MWReferenceDialog.

Change-Id: I8cd5f0d9f7e188fa1a7ab8d34a2796340f5e99b7
2014-10-30 12:22:20 -07:00
Roan Kattouw a054a753be Preserve original data inside parameter objects too
Parsoid has added a "key" property to parameter objects,
so now we have to preserve that rather than regenerating
all parameter objects.

Do this by changing the existing use of this.originalData
to a deep extend.

Change-Id: Ib4d31c2e0f7b567da1a148b51c42e688a2590b8e
Bonus: avoid modifying this.originalData
2014-10-30 11:59:42 -07:00
Roan Kattouw 190ba17b74 Also add tableCaption to mwTable parentNodeTypes hack
Change-Id: Ic7e387bdb774699746e6bafb62daf9c843af77b5
2014-10-30 11:38:26 -07:00
jenkins-bot 3806a2838c Merge "Clear selection after tearing down surface to work around Firefox bug" 2014-10-29 23:21:36 +00:00
jenkins-bot 48e40fe3c2 Merge "MWTransclusionModel: Exclude parts serialising to '' from the plain object" 2014-10-29 23:20:48 +00:00
jenkins-bot 51df4d0f05 Merge "Add i18n for API module help" 2014-10-29 22:42:57 +00:00
Roan Kattouw f35d577acb Followup e0981a3: don't pass undefined to getClassAttrFromAttributes()
Change-Id: I987345cd923d1b128573f5669d4d0dd4e82db1c9
2014-10-29 14:50:50 -07:00
Translation updater bot 7ea182fa79 Localisation updates from https://translatewiki.net.
Change-Id: I21dc334f17f93a3c3d89d8d961fafda2ee288180
2014-10-29 22:08:10 +01:00
Brad Jorsch 7d4ecc09c8 Add i18n for API module help
MediaWiki core change I04b1a384 added support for i18n of API module
help. This takes advantage of that while still maintaining backwards
compatibility with earlier versions of MediaWiki.

Once support for MediaWiki before 1.25 is dropped, the methods marked
deprecated in this patch may be removed.

Change-Id: I67395aff48185f3e09da31b51a08aa2541fe6a17
2014-10-29 13:59:41 -07:00
jenkins-bot dcb14bc9bf Merge "Hide page status indicators even if they aren't :visible" 2014-10-29 20:59:00 +00:00
Bartosz Dziewoński 2a55baaef7 Hide page status indicators even if they aren't :visible
The container is zero-height and zero-width, so jQuery doesn't
consider it :visible, and yet it still takes up visual space.

Bug: 72693
Change-Id: I3bed5394a2a64a9f7f0a331f850aa412b5b11b7d
2014-10-29 21:52:38 +01:00
Ed Sanders e0981a327f Create mwTables with wikitable attribute by default
Change-Id: I094b1823248e16dd3b9a0a10ba13104f14798621
2014-10-29 12:52:24 -07:00
James D. Forrester cc8f6970a5 Update VE core submodule to master (f4ff1d6)
New changes:
d845991 Data model implementation for tables
a27c148 ContentEditable implementation for tables
3c47428 Actions and context menus for manipulating tables
543ca54 Support annotation tool on table selections
149cf3d Supporting copy paste of single table cells
25c9eee Table header/data format tools
e557e46 Merge cells tool
afcf2d9 Allow custom type and attributes when creating a table

Local changes:
Add the files and messages for table editing

Change-Id: I6e6c33b96d3089049a0fd5385191caa83df5756b
2014-10-29 11:52:09 -07:00
Ed Sanders cfee8047e4 Use ClassAttributeNode mixin in MWBlockImageNode
This functionality was factored out into core for this purpose.

Depends on I2db6563 in core.

Change-Id: I4fc42e1468a9f0860c7c13e73967204bdf5ad78d
2014-10-29 18:28:33 +00:00
suchetag c6f7f361c2 Introducing isValid() in MWTitileInputWidget
A method isValid() is added to MWTitleInputWidget which would validate the titles given as inputs

Bug: 71249
Change-Id: I7749165652bd3c0bb08ca42289a425fe8e25483d
2014-10-29 11:13:42 -07:00
suchetag 9191465039 Introducing getTitle() in MWTitleInputWidget
A method for getTitle() is added which can return the valid title,
or, it can return null, in case the value isn't a valid title

Bug: 72468
Change-Id: I8a13afc9a66c167fe25010743c0d9e1424133d96
2014-10-29 18:12:04 +00:00
Amir E. Aharoni b4e98c1490 [BrowserTest] Disable two failing scenarios
To allow other screenshots to be created.

Change-Id: I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
2014-10-29 09:44:55 +00:00
Alex Monk a982d2d3fe MWTransclusionModel: Exclude parts serialising to '' from the plain object
So we get rid of empty content nodes

Bug: 63341
Change-Id: I1d49cc709bf92cc53ba064d148a76650c5143935
2014-10-29 01:08:41 +00:00
Roan Kattouw d68eae6c8d Clear selection after tearing down surface to work around Firefox bug
Bug: 71852
Change-Id: I3b4f0f755ece5c9e5444f8abadb1950a3f4ef318
2014-10-28 11:23:06 -07:00
jenkins-bot d73a692f57 Merge "Show warning on reference dialog when editing a reference used in more than one place" 2014-10-28 17:36:07 +00:00
jenkins-bot 538c8769a6 Merge "Move core/MW messages to correct sections" 2014-10-28 17:31:50 +00:00
jenkins-bot 78b2a2885c Merge "Pass $overlay to widgets that need it" 2014-10-28 17:30:57 +00:00