Commit graph

8638 commits

Author SHA1 Message Date
jenkins-bot 7c8931f655 Merge "Update initialHash after getting defaultDimensions in image model" 2014-10-23 20:00:20 +00:00
James D. Forrester 50e59f328a Update VE core submodule to master (27de0c4)
New changes:
016642e Remove crazy space exception from link validity regex
b538834 Remove insertion inspector class
50839f5 Work around *another* browser bug in getBoundingClientRect
e2e916a Increase inspector height by 1 to deal with Chrome opacity bug
9e387da Update OOjs UI to v0.1.0-pre (40de4dabe6)
27de0c4 Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest

Change-Id: If979beb12fe865c0e217b93381769264e2efdc20
2014-10-22 17:14:29 -07:00
Roan Kattouw 36060a2782 Apply pre-save transform to template previews
Because autoValues often involve {{subst:}}

Bug: 71157
Change-Id: I2787f2595f8c4b8838a3e9ac9ba898af0b43b58e
2014-10-22 15:47:51 -07:00
Roan Kattouw 2d3bf973d2 Actually set parameter autoValues as values
The autoValue was displayed in the UI but was never
actually written into the template model, unless you
changed the text input and then undid your change.

Bug: 71157
Change-Id: I08e2ba88c24fdee030104c6fb9baafb558ce8a80
2014-10-22 15:46:20 -07:00
jenkins-bot 5a3c2a9f4c Merge "MWLinkNodeInspector: Provide an open button here too" 2014-10-22 03:04:15 +00:00
jenkins-bot eaa3b222f7 Merge "Open the linkNode inspector when pressing Ctrl+K on a link node" 2014-10-22 03:03:32 +00:00
James D. Forrester 7149cc5279 MWLinkNodeInspector: Provide an open button here too
Also add validation now that we need it for the open button.

Bug: 71904
Change-Id: I50515671bb3ff08da8dc6c247c9959c27957c867
2014-10-21 20:00:27 -07:00
Roan Kattouw 4bc24e795d Open the linkNode inspector when pressing Ctrl+K on a link node
* Introduced MWLinkAction which opens the right link inspector
  based on what is selected.
* Added MWLinkInspectorTool overriding core's 'link' tool that
  executes MWLinkAction
* Removed MWLinkNodeInspectorTool and linkNode command,
  they're unneeded now

Bug: 72150
Change-Id: I03bd6ab1f67f31a6e6cb717cf4298e80e64637b7
2014-10-21 19:47:42 -07:00
James D. Forrester 4d12d6c443 Update VE core submodule to master (5fed7c4)
New changes:
a554ea6 Add button to debug bar to enable input debugging
8480f41 Add 'valid' event to MediaSizeWidget
a1c42b5 Update OOjs UI to v0.1.0-pre (531d497d3b)
3910521 Prevent JS error in getNativeRange()

Change-Id: I5f13b5d5d0a15579ed2027a09e3fc3933346b2f7
2014-10-21 19:19:29 -07:00
jenkins-bot 9d25c2823d Merge "Drop nonexistent &redirect= parameter from API requests" 2014-10-22 01:38:32 +00:00
jenkins-bot d0c794b08d Merge "Disable the reuse citation tool when selection is null" 2014-10-22 01:36:32 +00:00
Roan Kattouw 942440c7df Drop nonexistent &redirect= parameter from API requests
The correct parameter is &redirects=. Which we really don't want
to use anyway, because if Foo->Bar, using &redirects=1 would
cause a search for "Fo" to return "Bar" as a search suggestion
with no explanation why (and "Foo" wouldn't be visible).

This isn't unsurmountable, we could put in handling similar to
how the category widget handles redirects, but what this code
is trying to do by passing this parameter is definitely wrong.

Change-Id: Idd12c03aaef897d7c1dc70b2a7692e7d71980efe
2014-10-21 18:34:27 -07:00
Roan Kattouw ecc4c6e188 Disable the reuse citation tool when selection is null
This was broken when requiresRange was renamed to requiresSelection
and MWUseExistingReferenceDialogTool wasn't updated.

Change-Id: Ia1018520fc253e2f09755d5e85a94a325df80005
2014-10-21 18:33:19 -07:00
jenkins-bot c724bf3e0e Merge "[BrowserTest] Add "Then…" steps to Cite Basic test" 2014-10-22 01:01:59 +00:00
Cmcmahon 0a3ac40288 [BrowserTest] Add "Then…" steps to Cite Basic test
Change-Id: I43b28e8c95d3da0c3b94a8ea12ff3c376eedb1b5
2014-10-22 01:00:08 +00:00
jenkins-bot 827d1fe45b Merge "CategoryPopupWidget: Track popup hiding again so sortkey changes are applied" 2014-10-22 00:13:19 +00:00
Moriel Schottlender 14e1de1009 Update initialHash after getting defaultDimensions in image model
On initialization, the image model has an initial scalable that has
the given currentDimensions from Parsoid; these are usually correct.
However, in cases where the wiki settings do not fit the user settings
and the images appear smaller or bigger in practice than the values
of the wiki-defaults, the initial hash will store the wrong values.

We will only know what the real values for the comparison will be
after we get them from the API and the calculation; only at that
point we can update the image model initial hash.

This is important so that later the dialog can properly understand
whether to enable the "apply" button if a user changed an image
to custom size and then back to default.

Change-Id: If17b50cc4a39993f98a20a3fec3ddf5d8cb400b3
2014-10-22 00:11:43 +00:00
Alex Monk d7a5f4c1ac CategoryPopupWidget: Track popup hiding again so sortkey changes are applied
OOjs UI killed the 'hide' event that was running this code in the dialog refactor
back in July (Id121fc3a), but left it documented (along with 'show').

Just use the 'toggle' event instead.

Bug: 72168
Change-Id: I172fac81c4cbb89505522011aed57db57ccbc52f
2014-10-21 17:10:42 -07:00
Roan Kattouw f5ccaa509e Update VE core submodule to master (1835848)
New changes:
6b5a276 ve.ui.FormatTool: Update heading size CSS for new OOUI version
2dd5e9c Fix getAnnotationsFromRange when starting with an element
d7db9af Localisation updates from https://translatewiki.net.
3aa1c88 Update OOjs UI to v0.1.0-pre (44db8292bf)

Change-Id: Id5a465af1f14f9e0371d7672d04a7430bcea98d6
2014-10-21 15:56:13 -07:00
jenkins-bot e1b20bee65 Merge "Make spinner appear immediately when clicking edit" 2014-10-21 21:53:54 +00:00
suchetag 5c0c117537 Make spinner appear immediately when clicking edit
Moved the spinner code from ViewPageTarget to ViewPageTarget.init to make it appear immediately on clicking edit.
Bonus: also fixes the URL to add the parameter vesection when clicking a section edit link.

Bug: 65453
Change-Id: Ica33de675203cc0f0594b8362731c4e98a644313
2014-10-22 03:20:40 +05:30
Translation updater bot 7501dd9d58 Localisation updates from https://translatewiki.net.
Change-Id: I40092ea7751ae443901e706eaabfa66bdb287dc9
2014-10-21 23:03:05 +02:00
jenkins-bot dee3bc2357 Merge "ve.ui.MWFormatTool: Update heading size CSS for new OOUI version" 2014-10-21 20:30:00 +00:00
jenkins-bot 5e2431a81f Merge "Followup fbc7ecb: make mediawiki.mobile depend on core.mobile, not core" 2014-10-21 20:20:30 +00:00
Cmcmahon bc76c6ea3e [BrowserTest] create simple test for Basic Citation
We can make this more sophisticated later, but right now it
accurately checks that upon clicking Basic citation, the user
sees a true VisualEditor UI

Change-Id: Icea910e2bc1bbd4277a7e8eee08f2b0e49661062
2014-10-21 12:10:19 -07:00
Roan Kattouw 9c84af04f6 Followup fbc7ecb: make mediawiki.mobile depend on core.mobile, not core
Because we also need MobileContext in order to be able to extend it.

I hate our disorganized set of modules. Yes, I said that yesterday too.

Bug: 72282
Change-Id: I7276fc6ee82805f39c47864101ce495a561caa66
2014-10-21 11:19:36 -07:00
Željko Filipin 32736ae679 [BrowserTest] Prepare repository for running RuboCop after every push to Gerrit
For now ignoring all problems.

Bug: 69245
Change-Id: I4f5db441725062c1ea1ad8ba0955f18f49973583
2014-10-21 17:35:04 +02:00
Roan Kattouw fbc7ecbb8d Followup e20b47f: make .mediawiki.mobile depend on .core
This is needed because ve.ui.js is in .core, not in .base.

At some point we should clean up this horrible mess of RL modules.

Bug: 72282
Change-Id: Ief534e1ef4a8154f00a336aa974c14fe91633e90
2014-10-20 15:05:22 -07:00
Translation updater bot 6cd473b761 Merge "Localisation updates from https://translatewiki.net." 2014-10-20 20:28:49 +00:00
Translation updater bot 1db77fffe0 Localisation updates from https://translatewiki.net.
Change-Id: Ia8d13da4a5ed0a8ed0f97b38f06b41b8a2456a81
2014-10-20 22:27:57 +02:00
James D. Forrester e20b47f84b Update VE core submodule to master (db78bdd)
New changes:
69ecc8e Remove MW-specific mobile hack from core
e556440 doc: Use wildcards for Desktop/Mobile …Context and …Surface for simplicity of extension

Local change:
Bring in MobileContext hack to filter out all tools except links and citations from core where
it didn't belong.

Change-Id: Ica837abd45f0ff02b49a44da617bc1fd8e9872d4
2014-10-20 12:43:39 -07:00
James D. Forrester 4fd4367d6a Update VE core submodule to master (f8a563a)
New changes:
e251898 [BREAKING CHANGE] Allow tools to specify which selection types they support

Local changes:
New requiresSelection api for tools

Change-Id: Idc3f62d60bfb5710f786734c342f71b1c73fd4c0
2014-10-20 12:15:29 -07:00
Roan Kattouw 90705118d9 Update VE core submodule to master (51a919d)
New changes:
618a773 Update OOjs UI to v0.1.0-pre (99ec31d9b9)
e651bd9 Update OOjs UI to v0.1.0-pre (0d358b167a)
0918a82 Use better unicorn image data
1eea699 Stage an empty comment node when inserting
e49a185 Fix height calculation in fragment inspector
26c8566 Stage a space when inserting a special character
480472c Localisation updates from https://translatewiki.net.
990e807 Update OOjs UI to v0.1.0-pre (db065e5a9f)
279031d Fix scroll jumping in Firefox when pasting at end of line
5519914 Handle paste events on the paste target

Change-Id: I760e0f31cbd20dc704a4131384d84d671520f339
2014-10-20 11:45:22 -07:00
Translation updater bot 442d498d49 Localisation updates from https://translatewiki.net.
Change-Id: Ibb4d696776239590fd6539ff5e4361d4fcd6b096
2014-10-19 22:11:09 +02:00
Bartosz Dziewoński 2c325fa4f2 ve.ui.MWFormatTool: Update heading size CSS for new OOUI version
* Use .oo-ui-tool-title-text selector rather than .oo-ui-tool-title
  to avoid styling accelerator keys.
* Divide all sizes by 0.8, as we no longer need to match the font-size
  rule on .oo-ui-tool-title.
* Add CSS for heading1 (which differs between Vector and core VE)
  and heading2 (because it looks silly if it's missing).

Change-Id: I12226f0a674037f904149cc10893f5c154767bfc
2014-10-19 21:13:21 +02:00
jenkins-bot 6a12cac9a2 Merge "Use relative positioning for category popups, move out of overlay" 2014-10-17 22:57:35 +00:00
jenkins-bot 8fceff493a Merge "Only validate required template params after blur" 2014-10-17 21:28:20 +00:00
Roan Kattouw d0cc8074c2 Update VE core submodule to master (0190744)
New changes:
a7e4b2f Update OOjs UI to v0.1.0-pre (98cecf304d)
fa38ad1 Update OOjs UI to v0.1.0-pre (1829141230)
0190d46 Prevent observeration during copy and paste
8e300bf Factor out selection of entire pasteTarget
0bdd637 Fix clipboardData API path on copy
0654b4c Localisation updates from https://translatewiki.net.
9a22fe6 Replace calls to ve.bind( fn, ... ) with fn.bind( ... )
447e8de Use local var instead of bind() for inline functions
13f7c0b Get rid of toHashObject from ranges/selection
74fc34a Fix contextChange events from annotations
c750849 Fix broken node change detection
fdbda64 Close inspector on model select
dd8d23f Fix shift-click select on links in Chrome

Change-Id: I163bd8f04cf945bbec41b06b0a631e0a1e1e5eeb
2014-10-17 12:42:38 -07:00
jenkins-bot a0754e25eb Merge "[BrowserTest] Fix class name for ve-ui-contextMenuWidget" 2014-10-17 19:38:18 +00:00
Translation updater bot 22095c45e3 Localisation updates from https://translatewiki.net.
Change-Id: Idda9bd559f794a0e9c5d5e3e11a07b22224d9262
2014-10-17 21:18:43 +02:00
Ed Sanders ecdfeb3892 [BrowserTest] Fix class name for ve-ui-contextMenuWidget
Change-Id: Ia189ee285b5614ada69844b06545847caf21fd77
2014-10-17 19:12:42 +00:00
Alex Monk 55164d4027 Don't try to check page existence of external links in transclusion nodes
Only internal links

See bug 71900 comment 1

Change-Id: I35c9bea4c3735bdcdf8e4eda4f2a24567596e639
2014-10-17 19:49:32 +01:00
Alex Monk d087052ada Only validate required template params after blur
Bug: 72096
Change-Id: Ib699f8d89af02c9109a5711bd2c3ab4ef664d8ea
2014-10-17 17:59:13 +01:00
Translation updater bot af84e6c35b Localisation updates from https://translatewiki.net.
Change-Id: I481f44162954c26600a98c5fce0ff1c35fb5362d
2014-10-16 23:06:50 +02:00
jenkins-bot 38718a9f3e Merge "[BrowserTest] update for autopopulated fields" 2014-10-16 17:48:07 +00:00
jenkins-bot 1a68f45682 Merge "Replacing push.apply in VE-MW with ve.batchPush from VE core" 2014-10-16 17:44:51 +00:00
suchetag e3d185dd90 Replacing push.apply in VE-MW with ve.batchPush from VE core
Bug: 66206
Change-Id: Ifabfd0f28b8133e40ce822ed768442ab6a4d39ad
2014-10-16 23:12:22 +05:30
Cmcmahon ceab7f8f76 [BrowserTest] update for autopopulated fields
Website citation now auto-populates

accessdate = {{CURRENTMONTHNAME}} {{CURRENTYEAR}}

along with whatever the user puts in that field

Change-Id: Id72558f972be1ecc490fb196c941961871c21cf2
2014-10-16 10:09:04 -07:00
Roan Kattouw 7157488e20 Use relative positioning for category popups, move out of overlay
Instead of putting these popups in an overlay, put them
in the category widget. This makes scrolling work more
nicely, and makes things easier to deal with in general.

This requires that the popup position itself using
getRelativePosition(), because it's no longer in an
overlay. This also means these popups should now position
themselves correctly no matter where they are.

Change-Id: I09a1e5891a897d634c41d386a2307fe3df2a9157
2014-10-15 22:58:05 -07:00
Trevor Parscal 77eae16b88 Apply mw-body-content styles to SurfaceWidget
Changes:
* Override ve.ui.SurfaceWidget for use in MW
* Add mw-body-content class to surface view container
* Assert 1em sizing for surface view container to prevent
  mw-body-content from applying its own sizing
* Add new scripts and styles to RL config

Bug: 71652
Change-Id: Iac86facdc0c7a0e48c0f3617e2f6c2e7f001525e
2014-10-15 23:58:46 +00:00