Commit graph

83 commits

Author SHA1 Message Date
Bartosz Dziewoński 51a8541255 Replace references to actionsToolbar
Target#actionsToolbar and Target#toolbar refer to the same object
since change dfaed62d3632d381db9682c603b3ddbeed182292 in VE/VE
(barring bugs like T335469). Once we no longer use the old name,
we'll be able to remove this backwards-compatibility alias.

Bug: T335469
Change-Id: I577e8ae6a857519eb0e8181543ca0a96b515e019
2023-04-27 15:51:35 +02:00
Ed Sanders 60c2239e06 eslint: Lint root files with server rules
Change-Id: I872ab9dd7844eb8885dc30b40a2429875f7591c7
2022-03-17 23:39:53 +00:00
Ed Sanders 47127d290d build: Remove unused eslint overrides
Change-Id: I6f5a0f8e0266c3b8f24be2d99953afd7322bd2e7
2021-11-29 17:05:38 +00:00
Ed Sanders 857014fae9 Support watchlist expiry
Bug: T251348
Change-Id: I017a54784c758c5e97fb640721bd456adc0fbab5
2021-06-08 20:14:45 +00:00
Ed Sanders 7a92aa47cb Run all screenshots in a single test
Makes the test run about 3x faster.

Change-Id: I3fd5f1dde59f2e7122fbfaa27cc064f333b68296
2020-08-25 16:18:55 +01:00
Ed Sanders ef9c124d2e screenshot: Cleanup runner code
Change-Id: I27c35e07d3b6c6e9710c38556869946faac31b2d
2020-08-25 16:18:55 +01:00
Ed Sanders 4545f53245 build: Update eslint-config-wikimedia to 0.17.0
Fix instances of variable shadowing.

Change-Id: I6e2befb020d7d4b506c7b46131eafacd951aa6d1
2020-08-18 13:16:49 +01:00
Ed Sanders 458775cc94 screenshots: Run on Windows 10, try to fix resolution
T141369 still applies apparently, so switch back to Windows 10.

Switching to Linux did fix the screen resolution, so try setting
one manually instead.

Change-Id: I3d42fd972f1dbad4302cac1e7e5f052b6cfdb600
2020-06-27 17:42:41 +01:00
Ed Sanders a6d0ca80cf screenshots: Put try catch inside jimp promise
Change-Id: I3c72f024f740a2af882a7651c77ba017ad2e2e97
2020-06-26 21:44:31 +01:00
Ed Sanders 57faec4353 screenshots: Warp jimp call in try/catch
It seems to very occasionally fail, could be a memory exception.

Change-Id: Id2008783872af59348cc43fae8556e671dce4c43
2020-06-26 17:48:27 +01:00
Ed Sanders 430f32300a screenshots: Use Linux instead of Windows
I suspect this will run faster and be more reliable.

Also hoping it will fix the window size issue.

Change-Id: Iffe7c0d9ef056f98366dfd7f5d0c5e8e32682aa7
2020-06-25 19:04:04 +01:00
Ed Sanders 10a06eb312 screenshots: If setup fails, don't generate a screenshot
Change-Id: I7bd88e3e5d39d92703cdff37cb8e67ecabfb477e
2020-06-25 18:58:46 +01:00
Ed Sanders 56b7844cce screenshots: Remove unused beforeEach arg
Change-Id: I7e12438b030f90eefa29740d21555feb54f795ad
2020-06-25 18:46:29 +01:00
Ed Sanders b559b3adf5 screenshots: Only scale button in citoid button test
Change-Id: I3c41e70053873bc6dd559736e41eb49e735f1749
2020-06-25 18:39:52 +01:00
Ed Sanders 1871ac58ec screenshots: Use windowManager promises for save and specialChars
We already use these for other dialog tests

Change-Id: I24a9a6e5fe2c4cf711b8bc67c8d9bfe23d23041a
2020-06-25 18:36:21 +01:00
Ed Sanders 085d2443d2 screenshots: Suppress welcome dialog with query string
The code approach appears to suffer from a race condition.

Change-Id: I1328907b8fb55265275493b3b0d2a9288afea53c
2020-06-25 16:10:23 +01:00
Ed Sanders a0241f9345 screenshots: Catch get/quit errors and log
Stops the test from crashing.

Also set timeout to 10s as tests are rarely successful
after that long.

Change-Id: I8e74dab9693373914c8947f012c3cdcee1dce9f5
2020-06-24 20:02:29 +01:00
Ed Sanders 6076708ff3 build: Update eslint-config-wikimedia to 0.16.0
Change-Id: I638e0f82949597e2a2e4ea18fc2f0258f225358c
2020-06-02 21:30:00 +01:00
Ed Sanders fbd0f494ec build/: Enforce no-var
Change-Id: Iddae4bb325139a9ff4107702798a3deb9602d6f1
2020-04-24 22:15:01 +01:00
Ed Sanders 3b9ba67889 Separate out client code from screenshots runners
Change-Id: I92a588492169dafaf070477bef9fe22fa1fea5d3
2020-04-17 22:59:11 +01:00
Ed Sanders 651756c4fc eslint: Enable the mediawiki/class-doc rule and make pass
Also minor other adjustments

Change-Id: I9ee48359e3e53799f2f6240e44b53972283ce328
2020-04-17 22:59:11 +01:00
Ed Sanders 5428f5452a screenshots: Fix local test runner
Broke after selenium-webdriver update

Change-Id: I424607c9ba741a88b993d2d279045f30c1d50ab7
2020-02-25 12:45:20 +00:00
Ed Sanders bd848eb386 screenshots: Fix some timing issues
Change-Id: I5cfb4025833699bffd4ade3fb659f41c268b8bb2
2020-02-25 12:45:20 +00:00
Ed Sanders fd43701de2 eslint: Remove unused prefer-template rule; use proper globals values
Change-Id: If98be563304baa46a746d78c94dd8945f94d545c
2019-10-07 17:22:24 +00:00
DannyS712 00a98dd8f2 Fix 'paramter' typo in code and add to typos list, now covering PHP
Bug: T201491
Change-Id: I28d3b3871a2de54e575163bec7c364b68da8d5a6
2019-08-20 12:10:04 +01:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
2019-08-02 09:51:07 -07:00
Ed Sanders 20561e7e10 Remove citefromid alias support
Change-Id: I74d67a2ea5118ee18c462ccfea06a72cc73c627b
2019-06-20 16:06:07 +01:00
Ed Sanders f9330c8564 Replace the save button with a save tool
Now shows correct tooltip for save button (including
the access key).

Bug: T163142
Change-Id: If14a1a5a5829fc215cb79827392173dc05c4bdd7
2019-04-30 19:32:33 +00:00
Ed Sanders d784304ed1 Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: I2d7e389cc01808e41353681dd2448a0385543f2e
2019-04-03 13:19:45 +01:00
Ed Sanders 332aa1f3d2 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
2019-02-20 20:23:43 +00:00
Ed Sanders 375edf0182 Fix uncaught jQuery linting errors
Change-Id: I17482ec84c95e88881ab4bee9b9cadb27b2dc472
2019-01-18 21:03:38 +00:00
Ed Sanders 74f6c4899c build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I63a0ebf0b31a0d5d4e680a4e2a5a0be4850be165
2019-01-08 17:00:09 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
2018-11-21 16:51:20 +00:00
Ed Sanders 1a4158f6d2 Use Tool.$link.focus() for highlighting now OOUI styles :focus
Change-Id: Ia5b4c68cb49e3954aae7de9a8907f1fb9f205e2c
2018-05-02 12:52:17 +01:00
jenkins-bot aca63b6189 Merge "Catch timeout errors in screenshot scripts" 2018-01-13 11:09:25 +00:00
Željko Filipin 4c44340597 ESLint parserOptions is reduntant when env is set to es6
Bug: T184724
Change-Id: If39d3efc6476a94aaeb5956f142d2b12bd9be9bb
2018-01-12 17:04:35 +01:00
Ed Sanders 7c8373106f Catch timeout errors in screenshot scripts
Bug: T184724
Change-Id: Ifbc03b1291c291dcfc862487766e3786f9bd437c
2018-01-11 18:42:22 +01:00
David Lynch 64944c119a Use mw.storage instead of localStorage
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
2018-01-10 11:44:24 -06:00
Ed Sanders ec4053f2da Add screenshot tasks for manual and re-use tabs in Citoid
Bug: T180363
Change-Id: Icf9a370e7b80611b1f5e897e31e0004b656dabac
2017-11-13 17:39:47 +00:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
2017-07-18 12:55:33 +01:00
Ed Sanders 75d583a0d9 Use static parseDocument method
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
2017-06-08 14:35:31 +01:00
jenkins-bot db73a1419c Merge "Run screenshot tests in series" 2017-05-05 15:55:41 +00:00
Ed Sanders a866678c36 build: Update eslint to 0.4.0 and make pass
Change-Id: Id02a26bad70504cfe90bee6aab0fa3ea646b15d7
2017-05-04 21:28:17 +00:00
Ed Sanders 63d711dd48 Run screenshot tests in series
Use one test context, and store language as a property.

Change-Id: I4809c41331c4d70a024eec48f30eef207a09a098
2017-04-28 16:01:22 +01:00
Ed Sanders 08bfe509df Screenshots: Hack the toolbar to display "Article" instead of "Help page"
Change-Id: Iad632a23939712d8d7feb3097b714bfa30d362a1
2017-04-19 13:07:34 +01:00
Željko Filipin ca46a67843 Fix LanguageScreenshotBot by using an existing article
LanguageScreenshotBot failed because it tries to open VisualEditor on a
page that does not exist.

Bug: T162454
Change-Id: I5539c54b7c0ce1f302df0962dad19797d26953da
2017-04-19 12:28:38 +01:00
Ed Sanders c0e188c602 VisualDiff automated screenshots
Change-Id: I422fc459ebc41a98f46e1ff7365a8ccaea2501d2
2017-03-28 22:43:02 +01:00
Ed Sanders e7346f57eb Separate screenshot test runner from specific tests
Change-Id: Ic0eb773086aa7b6078c5095c1ad89ef3f6236019
2017-03-28 18:15:25 +01:00
Ed Sanders 15c986d128 Use var/let in screenshot.js
Change-Id: I70082dd6e4df38616e5c33c2b71f0aaae22bac63
2017-02-03 22:57:47 +00:00