Commit graph

10928 commits

Author SHA1 Message Date
jenkins-bot d7d026425c Merge "Make visual diffs the default in visual mode" 2018-01-27 00:21:24 +00:00
Ed Sanders 35311ad66d NWE: Use internal paste in compatible browsers
Bug: T185730
Change-Id: I9410707e6e491fe1cbe0b367fccb94a29a1b3145
2018-01-25 17:40:26 -08:00
Ed Sanders 624f181592 MW-Rebaser: Disable history commands
Change-Id: I46bb5e92548fe35c3490cd3df36b2a8f1cca520a
2018-01-25 10:21:33 -08:00
jenkins-bot 97fbd5619c Merge "Public API for the tempWikitextEditor" 2018-01-24 00:53:11 +00:00
jenkins-bot a77eea97b3 Merge "Sync tempWikitextEditor just before building target, not on every change" 2018-01-24 00:50:41 +00:00
jenkins-bot 14e557e936 Merge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )" 2018-01-24 00:06:11 +00:00
Ed Sanders 8afe6c5c6d Public API for the tempWikitextEditor
Allows users to know when the widget has been constructed,
and access it (e.g. to set an initial selection)

Bug: T185279
Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
2018-01-23 15:30:51 -08:00
Bartosz Dziewoński a0e2afef8e Use jQuery 3 .catch( fn ) instead of .then( null, fn )
Change-Id: I676eec0acf25690c2b2dd0b9a414be5fee887395
2018-01-23 15:25:15 -08:00
Ed Sanders d294006d7b Sync tempWikitextEditor just before building target, not on every change
Also ensure tempWikitextEditor is always torn down, even if
target setup fails.

Change-Id: Idc30a9dc00491b8c85353d73cb9ff70afea1d51c
2018-01-23 15:13:10 -08:00
jenkins-bot f52ee56a02 Merge "Toolbars: Replace $.height with clientHeight/offsetHeight" 2018-01-23 23:01:37 +00:00
Ed Sanders 154f49e964 Toolbars: Replace $.height with clientHeight/offsetHeight
Bug: T185599
Change-Id: I43fbce8f221553e9ae03f8385f39a19de01e8eb7
2018-01-23 12:32:16 -08:00
jenkins-bot 53cd2346dc Merge "MWWikitextStringTransferHandler: Perform Parsoid cleanup on result" 2018-01-22 23:43:18 +00:00
David Lynch d97b734352 MWWikitextStringTransferHandler: Perform Parsoid cleanup on result
Parsoid markup delivered as a result of a paste was being handled differently.

Bug: T183173
Change-Id: Ic563d2c5cd1f663f35860892b369fb7ba34b9c55
2018-01-22 14:43:19 -08:00
Ed Sanders 3077bbe51c Remove Firefox support comment
This line isn't solely for supporting FF52, that is the order
in which it is called (move after attach, not before),
but that matches all our other widgets, so not sure
it needs commenting.

Change-Id: I6f3cc5687f1e4b995dff700d0765d14de1927d51
2018-01-22 11:27:46 -08:00
jenkins-bot 97b04fbea5 Merge "NWE: Don't attempt to set selection on unattached textarea" 2018-01-22 19:22:11 +00:00
Ed Sanders f2568c8d7d NWE: Don't attempt to set selection on unattached textarea
Prevents an exception being thrown in Firefox <= 52.

Bug: T185304
Change-Id: Ic9a43e3cf12d4cc566cebb328f8e807e464af634
2018-01-22 18:58:26 +00:00
David Chan c7b76329ad Use ve.dm.MetaList without explicitly requiring metadata index
For future compatibility with Ib5174b0dcba1c24f44d889e08140bee31a064011 .

Change-Id: I15f252ce5d36bc0c38c5f5035e5176bf5e6d96e5
2018-01-21 18:33:28 -08:00
David Lynch a52dc16244 Update TitleInput's getTitle to getMWTitle
cb92c72c63274b332dc81edf473b1b3979ab4bdf in MW core changed this.

Bug: T185231
Change-Id: I9084a11bd40e46bddbcd1922ff549703bc90f60f
2018-01-18 11:39:23 -06:00
jenkins-bot d5bf4d41de Merge "Remember preferred diff viewer" 2018-01-18 15:37:35 +00:00
jenkins-bot 31e7006610 Merge "getSelectedItem() -> findSelectedItem()" 2018-01-17 17:29:36 +00:00
Ed Sanders a1e2cb237c Resize link context item after getting description
Descriptions can run to more than two lines.

Bug: T183650
Change-Id: I3d0a5787cab19abc4851340b08fe4a109e7aec31
2018-01-17 16:06:28 +00:00
Ed Sanders 0169701257 getSelectedItem() -> findSelectedItem()
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
2018-01-17 13:39:13 +00:00
Ed Sanders e70fe7c1a1 Make visual diffs the default in visual mode
Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
2018-01-17 13:31:07 +00:00
Ed Sanders 7661081ab9 Remember preferred diff viewer
Separate the preference by surface mode, so you can
use a different preference for NWE.

Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
2018-01-17 13:31:07 +00:00
jenkins-bot 140ec5f2ab Merge "NWE: Show temporary wikitext input widget while loading" 2018-01-16 18:13:47 +00:00
Ed Sanders b1ea5d618a Don't pass wikitext to requestPageData if unmodified
Bug: T184875
Change-Id: I41a72a9c7546fafc834bf837e507d9359872ff11
2018-01-14 16:16:47 +00:00
jenkins-bot 2091b8634a Merge "Use section fragment after-save even if the query is empty" 2018-01-10 21:41:59 +00:00
jenkins-bot 2ea64bdd27 Merge "Change save dialog accesskey to be entirely off the trigger" 2018-01-10 21:30:51 +00:00
Ed Sanders 886faf2adc NWE: Show temporary wikitext input widget while loading
Bug: T184614
Change-Id: I2e4964cb6329660957815dcb9a74d2ad24d5256b
2018-01-10 21:34:53 +01:00
jenkins-bot 9768750cd3 Merge "Use findItemFromData instead getItemFromData" 2018-01-10 19:54:30 +00:00
David Lynch 64944c119a Use mw.storage instead of localStorage
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
2018-01-10 11:44:24 -06:00
David Lynch a89c79dc79 Change save dialog accesskey to be entirely off the trigger
Accesskeys in this situation are unreliable cross-browser. Firefox won't
trigger the accesskey inside the dialog. We can manually simulate it, via the
existing trigger.

Bug: T121183
Change-Id: Ib919d8b9fcd9324a517037bcc6ef93a26d1488b9
2018-01-08 11:52:06 -06:00
Ed Sanders c41fd90a15 MWImageModel: Check selectedNode exists before asking for property
Bug: T180521
Change-Id: I1c10929abd6f5c4afa03a65904bc76fc82f8fcbb
2018-01-08 15:31:13 +00:00
David Lynch 874ba30ce8 Use section fragment after-save even if the query is empty
Bug: T181075
Change-Id: If2d1107982d3f947330c750c635ee221ab71610f
2018-01-05 11:55:38 -06:00
Bartosz Dziewoński 23158de319 Fix context menu for mobile TargetWidgets
Depends on Ica66325a8267d14f25fbc537b956573d1d3cc336 in VE core.

Bug: T157084
Change-Id: I9d9839d7e96eb1ef254e11554acfb955750a2915
2018-01-04 16:53:40 +00:00
jenkins-bot 683ac88fcc Merge "doc: Bump copyright year" 2018-01-03 19:20:07 +00:00
James D. Forrester 0a7a845a42 doc: Bump copyright year
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
jenkins-bot fad1466d84 Merge "Fix editfont size in source mode" 2018-01-03 01:12:25 +00:00
jenkins-bot 75d4300ba6 Merge "ve.ui.MWSettingsPage: Fix doc comment" 2018-01-02 20:11:33 +00:00
Ed Sanders 459ce75cb2 Fix editfont size in source mode
Bug: T182320
Change-Id: I777a1a80cb9887bc473aecb5d7b25fd6454a3d60
2018-01-02 19:20:18 +00:00
Bartosz Dziewoński 4987c07793 Move things that are not modules out of modules/ directory
* Move SpecialCollabPad.php to /.
* Move screenshots for BetaFeatures to images/.
* Move localisation messages to i18n/.

Change-Id: I874ae135a3ac58118c3dea105136c8c8b6fb41bc
2018-01-02 11:05:23 +01:00
Bartosz Dziewoński 5f7e60e938 Remove unused files loading-ltr.gif, loading-rtl.gif
No longer in use since 6d8fbd8221.

Change-Id: If0392c49985fdd5b07c336e17eb5360e0a71770a
2018-01-02 10:47:32 +01:00
Paladox fc03706278 Make isListed public in SpecialCollabPad.php
This was causing Special:SpecialPage to fatal with:

PHP Fatal Error: Access level to SpecialCollabPad::isListed() must be public
(as in class SpecialPage) or weaker

Bug: T183883
Change-Id: Ic7cbdddd3106776898ec7faa4fbaed508a6b1c08
2018-01-02 01:00:23 +00:00
Translation updater bot 93b4371954 Localisation updates from https://translatewiki.net.
Change-Id: I304a6848db09772c9603b19a1dbc386f80f0d109
2018-01-01 09:21:05 +01:00
Umherirrender df29d96c3e build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
Change-Id: I515dc1003bd5ee2352c85ac49e19f54e7036bd5d
2017-12-30 23:29:40 +01:00
Bartosz Dziewoński 578c55b7c1 ve.ui.MWSettingsPage: Fix doc comment
Change-Id: Iff4e8854124340a30081009221cde5b2831c81f3
2017-12-30 03:26:13 +00:00
Translation updater bot 327f3c1219 Localisation updates from https://translatewiki.net.
Change-Id: I809d676bdb78d17f0a6866ca05f021c3e9c64bdf
2017-12-29 10:07:04 +01:00
Translation updater bot f7c0a70b9e Localisation updates from https://translatewiki.net.
Change-Id: I39cb150918eaee64b034e88a4726a31c04f29331
2017-12-28 10:00:15 +01:00
Prateek Saxena ecd663c4a0 Use findItemFromData instead getItemFromData
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I379da96a42c440c7d2d5dc2f3de2773c03546c04
2017-12-28 11:53:29 +05:30
Translation updater bot 6e46084b89 Localisation updates from https://translatewiki.net.
Change-Id: Ife309d8d0cce6332fee9ff23796a92c3d8c6f53b
2017-12-27 10:32:31 +01:00
Translation updater bot 035ccf0d7e Localisation updates from https://translatewiki.net.
Change-Id: Ic3ef5d2e35085be6121a442740ab8c6fd188721d
2017-12-23 22:27:16 +01:00
Translation updater bot 906956aae7 Localisation updates from https://translatewiki.net.
Change-Id: I81e6aa591bec1ac4ca53a4ab0b4f0e3a31af20fb
2017-12-20 23:23:06 +01:00
Translation updater bot 90cdac7b46 Localisation updates from https://translatewiki.net.
Change-Id: I7c7ae2a3327ad676a4db0461d871dd2d276ac86d
2017-12-18 23:07:22 +01:00
jenkins-bot 5457615129 Merge "Add section id to URI fragment on save" 2017-12-18 10:55:35 +00:00
Translation updater bot 99ae04623a Localisation updates from https://translatewiki.net.
Change-Id: I327e05ba73228d31ad373408c93c9b40a6bfe0b0
2017-12-17 22:26:19 +01:00
David Lynch 6f2c829bd9 Add section id to URI fragment on save
Bug: T181075
Change-Id: Iea63112301bfa0860c3d68efc35648a5af7e4ae6
2017-12-15 00:03:52 +00:00
jenkins-bot e99ef1da02 Merge "ArticleTargetEvents: Track editor mode on save events" 2017-12-14 22:51:04 +00:00
David Lynch 5bbda2b8c8 ArticleTargetEvents: Track editor mode on save events
Bug: T182610
Change-Id: I8b58bea8e4444478cde4c1340d13ddf97aab8f01
2017-12-14 16:23:08 -06:00
Translation updater bot dbbbdbd86d Localisation updates from https://translatewiki.net.
Change-Id: Icc0b85cd1433255d8c9be2f098e0bbe861f52444
2017-12-14 23:12:35 +01:00
James D. Forrester af8428e861 trackSubscriber: Add timing data for 'loaded' state
Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
2017-12-13 11:20:09 -08:00
David Lynch e66d58076f trackSubscriber: data isn't required
Editor-fixing caused errors on some events which don't pass data in.

Introduced in 8f612fbe64.

Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
2017-12-13 11:56:35 -06:00
C. Scott Ananian fde0c180aa Interwiki links are a type of external link
Bug: T97093
Change-Id: I13325075deba127dc620adb0ad1d18ef99352ab2
2017-12-13 15:56:58 +00:00
C. Scott Ananian d2d6d23522 Bump Parsoid HTML version to 1.6.0
It's a brave new world.

https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments&oldid=2644817#Tuesday,_Dec._12,_2017_around_11:45_am_PT:_Y_Deployed_741fc5d

Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
2017-12-13 00:10:16 +00:00
Translation updater bot aaabd8d84b Localisation updates from https://translatewiki.net.
Change-Id: I2606d7b77cec575907fe57d540326bf1069f14a1
2017-12-12 22:53:01 +01:00
C. Scott Ananian b85caca493 Strip legacy section IDs from inside headings
We emit <span id="..." typeof="mw:FallbackId"></span> inside headings
when necessary to provide backward compatibility with pre-HTML5
section ids.  These are mostly harmless inside VE --- they become hidden
alienated nodes, which are then safely ignored by Parsoid during html2wt
even if they manage to migrate outside of a heading --- but it's a
little safer to strip them.

Change-Id: I07d0fcf54427ab02d4930cff183d3e5579a99306
2017-12-12 12:15:05 -05:00
jenkins-bot a5a3b0c97a Merge "Enable spellchecking on media caption inputs" 2017-12-12 17:04:38 +00:00
Ed Sanders 8a356b19d7 Enable spellchecking on media caption inputs
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
2017-12-12 16:42:55 +00:00
Translation updater bot 28bc31f58a Localisation updates from https://translatewiki.net.
Change-Id: Ia5bfd03dc41406dc3ea9344c93f73d6a3309dd99
2017-12-11 23:39:09 +01:00
jenkins-bot 84e3cfaa0f Merge "Pass editor mode (visual/source) to tracking code" 2017-12-11 17:51:15 +00:00
jenkins-bot db142d34f8 Merge "Track action=loaded for consistency with WikiEditor" 2017-12-11 17:49:17 +00:00
Translation updater bot db453a74fb Localisation updates from https://translatewiki.net.
Change-Id: I428b0455d4f87c5bd451aac088ccbf68592e5069
2017-12-10 22:33:31 +01:00
Translation updater bot c6476a33fd Localisation updates from https://translatewiki.net.
Change-Id: Iac2cdc9cd52b46e12b166676bce5f5384a53e1ef
2017-12-08 22:37:37 +01:00
Translation updater bot 18f8cd0b1d Localisation updates from https://translatewiki.net.
Change-Id: I1e4452deddf816b6a2a1007d40a64dcb668fb9a0
2017-12-07 23:08:05 +01:00
Ed Sanders 8f612fbe64 Pass editor mode (visual/source) to tracking code
Change-Id: Iba5d3c66ecbd2872d76ea12f795ef3bebaae9d81
2017-12-07 11:14:00 +00:00
David Lynch 7a260ad1b7 Track action=loaded for consistency with WikiEditor
Change-Id: I1b92996e63dd85416755377dc14a5a997aac6657
2017-12-06 11:32:01 -06:00
jenkins-bot 59a57b17a9 Merge "Use rel="noopener" on links targeted at new windows" 2017-12-06 11:18:42 +00:00
jenkins-bot 890d47868c Merge "MWTable: Cleanup events and prevent fire after teardown" 2017-12-05 15:34:05 +00:00
Translation updater bot 3d931296df Localisation updates from https://translatewiki.net.
Change-Id: I456d50609430beaa80ac687259f0807a419b3e91
2017-12-05 09:42:06 +01:00
Ed Sanders 28ed1a6b97 MWTable: Cleanup events and prevent fire after teardown
Bug: T181767
Change-Id: I9b86d810269f3e3e15ba4736d264dbf48c9a0fe3
2017-12-03 14:46:47 +00:00
Translation updater bot 61365625b7 Localisation updates from https://translatewiki.net.
Change-Id: I343fc3f0ae5fb7852bc75d8278f5d39823eec5d4
2017-12-02 22:53:00 +01:00
Translation updater bot 7883f423ac Localisation updates from https://translatewiki.net.
Change-Id: I2037bd6b5a9cae019e13dbf3ceddd62086c5cbce
2017-12-01 00:01:48 +01:00
David Lynch 7777f69e7b Use rel="noopener" on links targeted at new windows
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
2017-11-30 13:15:38 -06:00
jenkins-bot 5dce34ee1c Merge "ui.MWSaveDialog: consistent handling of preview category links" 2017-11-30 15:45:35 +00:00
Translation updater bot 212200f4be Localisation updates from https://translatewiki.net.
Change-Id: If104f2835eee1566891974f24f9d213969a38d32
2017-11-29 22:56:41 +01:00
David Lynch efbfcd8b35 ui.MWSaveDialog: consistent handling of preview category links
Category links weren't being checked for redlink status, and weren't opening
in a new window.

Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
2017-11-29 11:24:32 -06:00
jenkins-bot 7dd9cec01e Merge "DesktopArticleTarget: enable spellcheck on sectionTitle" 2017-11-29 00:38:47 +00:00
David Lynch 396ce6eb6b DesktopArticleTarget: enable spellcheck on sectionTitle
Tell browsers we explicitly want spellchecking on the section title. If
unspecified this is browser-dependent, so it was inconsistent.

This won't actually have an effect until the next OOjs-UI release (v0.24.3),
as this was a new feature added to TextInputWidget.

Bug: T179654
Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304835
Change-Id: I588874efcff91c5be03da2fc03c268f883b718e2
2017-11-29 00:06:20 +00:00
Translation updater bot 085ec49a66 Localisation updates from https://translatewiki.net.
Change-Id: I42b3a5b87ece5c12f42489d98a3ee25aa5c5a332
2017-11-28 22:50:36 +01:00
Ed Sanders 77773df985 Create MW tables with captions by default
Bug: T181173
Change-Id: Ib17331e0e8478ba67c1ecbbee4a284d9993cb552
Depends-On: Ieb668d282f7afa9332cead94c95f19f652102af1
2017-11-27 16:37:24 +00:00
jenkins-bot 65a27b48ce Merge "Fix template rendering" 2017-11-27 15:36:02 +00:00
Ed Sanders 471e40e8bb Fix template rendering
* Look inside first child for autoGenerated (as reflists can be wrapped)
* Unwrap Parsoid sections
* Discard leading and trailing whitespace

Bug: T179618
Change-Id: Ib9ead28173360f0f1d5a4dc66c33a75d70ef34b3
2017-11-27 15:02:31 +00:00
Translation updater bot 7da82260e7 Localisation updates from https://translatewiki.net.
Change-Id: I6e77cc8b6a0e7b7378a70632d59705594a21703e
2017-11-26 22:54:54 +01:00
Translation updater bot 8e1a60e93b Localisation updates from https://translatewiki.net.
Change-Id: I73e2bf2377229edac438917df4ddc638fd01e2d2
2017-11-25 22:58:16 +01:00
Translation updater bot 3c388da5e9 Localisation updates from https://translatewiki.net.
Change-Id: Ie032d167e7d9f30fff049ff3a98af2ca86ba67b0
2017-11-24 23:27:50 +01:00
Translation updater bot 643466f4c2 Localisation updates from https://translatewiki.net.
Change-Id: Iea540f004fe2491cf5e7e7f2f85590fe96b4ffe4
2017-11-23 23:51:47 +01:00
jenkins-bot 861c48db77 Merge "Unwrap Parsoid sections" 2017-11-23 20:02:43 +00:00
Ed Sanders 267d60f61a Unwrap Parsoid sections
Section wrapping will be introduced in I0f4c19f7.

Change-Id: I43ced131d07a20318af37e830318e30db2eb451f
2017-11-23 12:19:57 +00:00
Translation updater bot b33d86d1df Localisation updates from https://translatewiki.net.
Change-Id: I44df9fd1eb29e1a4bf4b160491554e49d28e4774
2017-11-22 22:47:15 +01:00
Prateek Saxena b7541717ff Update colors of betafeatures icon
Grays: Base80, Base70, Base50

Old: https://phabricator.wikimedia.org/F10934877
Old: https://phabricator.wikimedia.org/F10934879
New: https://phabricator.wikimedia.org/F10934876
New: https://phabricator.wikimedia.org/F10934878

Bug: T180427
Change-Id: I1d40411993918e2b060094d7e1e099647d42a6af
2017-11-22 17:21:12 +05:30
Ed Sanders 38dba57e95 Follow-up I80d82ad87: Only add linebreak to non-empty documents
This is the same behaviour as the old editor, and
unbreaks editors that use placeholders.

Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
2017-11-21 17:14:08 +00:00