Commit graph

1057 commits

Author SHA1 Message Date
James D. Forrester 924d7cc81f Update VE core submodule to master (6006b2c6e)
New changes:
69ac0debb Localisation updates from https://translatewiki.net.
d963d023c Localisation updates from https://translatewiki.net.
6575ffc1a Fix CodeMirror overlay alignment on new lines
9599ffd38 Localisation updates from https://translatewiki.net.
987a8ad84 Localisation updates from https://translatewiki.net.
6006b2c6e Localisation updates from https://translatewiki.net.

Bug: T198278
Change-Id: Ib399cb8df6df196e1a29038c78c04f89e1b2059b
2020-01-06 16:06:59 -08:00
Ed Sanders 8e20c1c66b Update VE core submodule to master (6bed6aaa5)
New changes:
06ad0c769 git-build: Fix name of grunt.log.error
6bed6aaa5 CommentAnnotation: Replace 'reply' with 'comment'

Change-Id: If7e298eaafdd7cf9ab07b6314cb9c214a2072229
2019-12-20 16:22:33 +00:00
Ed Sanders f2a5c10dee Update VE core submodule to master (0aa09c12e)
New changes:
0aa09c12e Make CommentAnnotation use replyable threads

Change-Id: Idaadecace168a0c19741a231b887578274902a86
2019-12-20 14:57:14 +00:00
James D. Forrester 1f74985894 Update VE core submodule to master (e032fa161)
New changes:
479b50059 Localisation updates from https://translatewiki.net.
c595d8ab0 Metion task related to Firefox hack
0a160fac2 Don't trust selections from the server
d796f3db5 rebaser: Update dependencies
b097dfaad ve.dm.Transaction: Don't translate offsets inside annotate-only replacements
eadee0343 FragmentWindow: Replace previousSelection with initialFragment
561e88158 Use ve.dm.example.imgSrc everywhere
d1dceab31 DesktopContext: Remove onModelSelect event
85947ac55 Pause synchronizer while staging
9a4dd169d Catch various out-of-bounds exceptions
341114afc Remove CE HTML from DM html test fixture
5d3a673e0 ve.ce.Document test: Add src to test image
182ac338e Evalutate fragment selection after staging
e032fa161 rebaser: Drop document opacity while paused

Change-Id: Id551ee2e6510610b8f2e12cf77ce3c8429700872
2019-12-20 12:15:32 +00:00
James D. Forrester 25268454a2 Update VE core submodule to master (c0fbb063a)
New changes:
69d9cef91 Localisation updates from https://translatewiki.net.
f6dc62913 ve.ui.FragmentInspector: Remove unnecessary Chrome hack

Bug: T126027
Change-Id: Icd3936aa97052aa39877e05c830b6d95261b978f
2019-12-15 19:40:19 +00:00
James D. Forrester 60721584fe Update VE core submodule to master (b1617fdca)
New changes:
d4a21a7e7 Localisation updates from https://translatewiki.net.
0e99d907a Update OOUI to v0.36.0
c422b8313 Localisation updates from https://translatewiki.net.
b1617fdca Update OOUI to v0.36.1

Local changes:
* Rename onLookupMenuItemChoose → onLookupMenuChoose
  (deprecated in OOUI v0.36.0)

Change-Id: If66f3f16c0e882e99b0d768a3cf4170d24e7093e
2019-12-13 18:06:59 +01:00
James D. Forrester 015f796b63 Update VE core submodule to master (3b3dcad84)
New changes:
7017efbce Sanitize HTML on paste

Bug: T239209
Change-Id: I5f59d537d39b64838a222ab0637957429860508f
2019-12-02 17:26:58 -08:00
James D. Forrester 42334f5609 Update VE core submodule to master (5c4b2eec8)
New changes:
3eaba6d96 Localisation updates from https://translatewiki.net.
1324cf759 Localisation updates from https://translatewiki.net.
5c4b2eec8 Localisation updates from https://translatewiki.net.

Change-Id: Icfde040914af973dcd450280379b953907533dff
2019-12-02 11:50:15 -08:00
Bartosz Dziewoński 65f0264bcf Update VE core submodule to master (9d0ef183a)
New changes:
ea3136678 Add vendor prefixes for tab-size
d39e15064 Allow the afterPaste promise to reject

Change-Id: I2ef20357bf622dd9b65e959f708d273dd2304035
2019-11-24 10:36:51 +01:00
James D. Forrester 7f752a14b1 Update VE core submodule to master (c6b5e46fa)
New changes:
b5d900376 ve.ui.TargetWidget: Avoid exception when destroying widgets
b861d5f72 Disable whitespace replacement in source mode
8530f924b ve.ce.TableEnterKeyDownHandler: unit test failing on Mac

Bug: T153434
Bug: T236949
Bug: T238351
Change-Id: I96da18199e858d32026b60c0494c5e23d0cf6cd0
2019-11-20 11:49:10 -05:00
Bartosz Dziewoński 3e93c00a28 Update VE core submodule to master (12422dc27)
New changes:
ce76e95d4 Allow config to be passed to mock surfaces
12e2d2686 tests: Put FragmentInspector test runner in shared util

Change-Id: I426ae2cb96ca8dd126656c018740ec122007c2ff
2019-11-12 21:33:59 +01:00
Ed Sanders 8d818d9ff0 Update VE core submodule to master (5b9ab1cfa)
New changes:
be8235e82 Localisation updates from https://translatewiki.net.
6f43a6c8d Remove MW-specific code for setting up section editing

Local changes:
* Bring in section editing logic from VE core
  Sets attachedRoot iff there is only one SectionNode in the whole document.

Change-Id: I15b5ebf3848482ef6df6d19114d26a1b1d4a3b13
2019-11-11 18:28:14 +00:00
James D. Forrester 58eb936fbd Update VE core submodule to master (a6ef2cc7d)
New changes:
69fc4fdd7 Tweak alignment of frameless button in desktop context further

Bug: T237289
Change-Id: Ia315c96b22ac2ed8728dd2e90d02100655194df3
2019-11-07 17:11:21 -05:00
Ed Sanders 64be4b2a4b Update VE core submodule to master (2d0f0ec1f)
New changes:
18e32c6ed Simplify paste test runner
7d71154bd Properly support middle click paste

Local changes to use simplified paste tests runner

Bug: T157956
Depends-On: Id66bff4e41a36ed967a8cba2f6653bb26e7b4ea1
Change-Id: I0101e8bc079cd050bfbc65577a10e98213d5f00c
2019-11-06 10:31:38 -05:00
James D. Forrester 676c66f0c0 Update VE core submodule to master (8cba52aa6)
New changes:
fdc0d734f Localisation updates from https://translatewiki.net.
1ab9a6349 Fix DM jQuery linting
ed97c7d11 Localisation updates from https://translatewiki.net.
5f0d866a0 Fix alignment of frameless button in desktop context
3a1d641f7 Replace color with WikimediaUI color palette one
fac4d2e72 Remove toolbar borders from mobile
fbeb687c8 Reduce size of PopupToolGroup indicators on mobile

Bug: T231815
Bug: T237289
Change-Id: I4709f1cdc558e4aa4fd6674a5f3bde617cec4614
2019-11-05 14:31:06 -05:00
James D. Forrester 03ef2e0dc8 Update VE core submodule to master (8f850a718)
New changes:
78c94bc49 Localisation updates from https://translatewiki.net.
6bc33d318 FindAndReplace: Remove results = 0 special case

Bug: T226604
Bug: T231245
Change-Id: Ie918f40aa3ca69f227c75e150e6bd9aa330b3fc1
2019-10-30 18:03:04 -07:00
Ed Sanders 4da31e7c9e Update VE core submodule to master (3075d3f8c)
New changes:
4af3f84f7 Mark surface as "showAsDeactivated" when opening a window
79eb0e4e5 ve.ce.Surface: Guard against focusing a un-initialized surface
4124c275e [BREAKING CHANGE] ve.ui.TargetWidget: Construct a real target inside the widget

Local changes:
* Use new target widget
* Remove calls to deprecated methods
* 'surfaceReady' event was upstreamed

Bug: T236400
Change-Id: I765d657c172d96c3b2e2ae5998083e4926a31f15
2019-10-25 17:16:17 +02:00
Bartosz Dziewoński 641fc9cc56 Update VE core submodule to master (ab3e5b918)
New changes:
990a0e959 ve.ui.ToolbarDialog: Update after OOUI changes
ab3e5b918 Localisation updates from https://translatewiki.net.

Change-Id: I54272071507f06042b32a4c9d1563c6ab5c9b371
2019-10-25 16:57:22 +02:00
Ed Sanders b676b2295b Update VE core submodule to master (3fac5f1f2)
New changes:
8cbedc3c8 build: Update linters
a211e9fd8 TargetWidget: Use surface view focus/blur events
57aeb8b38 Separate utilities required for DOM parsing into separate file

Local changes:
* Setup modules for new parsing utils files

Change-Id: Ie4e59650fdb869e7e4148c97cd03d79ce35187dc
2019-10-23 18:34:17 +02:00
James D. Forrester 7c40a7ecd7 Update VE core submodule to master (6c506a6aa)
New changes:
4ae766c0f Grammar fix in doc
5b2dac1aa Use plugin to ensure all message keys are documented
6c506a6aa Localisation updates from https://translatewiki.net.

Bug: T235502
Change-Id: I827d14a3ea78369321c557cca8fb16726a1dc03a
2019-10-22 13:12:39 +01:00
James D. Forrester 618225d4ed Update VE core submodule to master (b2939de73)
New changes:
fe82a8073 Update OOUI to v0.35.1
c9ed3a117 Localisation updates from https://translatewiki.net.
552d703b7 Localisation updates from https://translatewiki.net.
cab4264f1 build: Unbreak language lists, swapping 'szy' language for old 'ais' code
25b446256 Localisation updates from https://translatewiki.net.
0cd49c0c8 Avoid a "wiggle" when inserting a missing table cell
0babef010 Make test names clearer
b2939de73 TreeModifier: Ignore removed nodes properly when normalizing from a text node

Bug: T234108
Bug: T235959
Change-Id: Ifef6a96828a388f38f58ca4440f8ea6d31b1743a
2019-10-21 12:06:57 +01:00
James D. Forrester 8bb02cc454 Update VE core submodule to master (2f2cdd89d)
New changes:
8ff4683d3 libs: Update papaparse to 5.1.0
210518d4a eslint: Remove unused prefer-template rule; use proper globals values
fd8bf7425 Localisation updates from https://translatewiki.net.
f09a8f327 Remove <style> tags from $pasteTarget immediately
0f76791ac lib: Unset the executable bit on the papaparse.js library
8d05203fa TreeCursor: cross ignored nodes properly from the end of a text node

Bug: T234881
Bug: T235068
Change-Id: Icf9e0ca80575e45577ebf51764247da4dd82bdba
2019-10-10 12:02:20 -07:00
Bartosz Dziewoński 621c6f4759 Update VE core submodule to master (2c8e48194)
New changes:
fec3647e7 TreeModifier: return correct position in ensureNotText
2c8e48194 TreeModifier: Ignore more attributes when validating linear data

Bug: T234489
Bug: T234742
Change-Id: Ib83dfa2f2e02a63a8e9774f3383e5796a624cb64
2019-10-07 16:45:56 +02:00
James D. Forrester 052a879c3c Update VE core submodule to master (8347ba91b)
New changes:
7cabb6fd2 build: Update eslint-config-wikimedia
8347ba91b Localisation updates from https://translatewiki.net.

Change-Id: I3260da9afe8f3230c124588419606ddbc42ae277
2019-10-03 14:26:19 -07:00
Ed Sanders 877721fb55 Update VE core submodule to master (191f8c90c)
New changes:
25422cb06 Fix missing table cell "fake slugs"

Bug: T234108
Change-Id: I5de4940e7ee67799f8b60fa4cc5e277c1e3eff55
2019-10-02 00:17:21 +01:00
James D. Forrester 673d2bc657 Update VE core submodule to master (163767591)
New changes:
05306a572 ve.ui.SpecialCharacterPage: Remove unused icon handling
738244b1f Localisation updates from https://translatewiki.net.
7527b151c Upgrade DOMPurify 1.0.10 -> 2.0.0
ff5c1def9 Catch errors when applying initial history

Change-Id: I43c2668ddf1c2a15d724b24532256fc2d222facd
2019-10-01 14:37:01 -07:00
James D. Forrester 3c9a8fe7f5 Update VE core submodule to master (084bdb77e)
New changes:
db8c96bc9 Localisation updates from https://translatewiki.net.
084bdb77e Localisation updates from https://translatewiki.net.

Change-Id: I527846592bc8f36c6e8197d3b861db96a1904ca7
2019-09-30 08:24:05 -07:00
Bartosz Dziewoński 62f1deba4b Update VE core submodule to master (a817f9b0d)
New changes:
a817f9b0d TreeModifier: Never check originalDomElementsHash equality

Change-Id: I4f6a7325711b199e86bd997dcf795c01d569ef16
2019-09-18 19:54:18 +02:00
Bartosz Dziewoński ece13d7e16 Update VE core submodule to master (81e2e57a5)
New changes:
6bbfd9ecc Split TreeModifier into a tree diff generator and tree diff applier
f55f042dd TreeModifier: delete text nodes emptied by moveText operations
d7ccb2442 ve.ui.Surface: Fix check for active virtual keyboard in #adjustVisiblePadding
a9d533280 Localisation updates from https://translatewiki.net.
73a166cb0 build: Upgrade eslint-config-wikimedia from 0.13.1 to 0.14.0
077aaed03 build: Upgrade grunt-banana-checker from 0.7.1 to 0.8.1
81e2e57a5 Unwrap a solitary paragraph from data transfer items

Bug: T215567
Bug: T217769
Bug: T232942
Change-Id: Id943b49dd58a12553ddc19dcf8abcfb8e8a5b712
2019-09-17 20:44:54 +00:00
Bartosz Dziewoński f7cbbc9e81 Update VE core submodule to 509eeaa1
New changes:
e31dae794 Update OOUI to v0.34.1
fa584b5c6 Localisation updates from https://translatewiki.net.
06548e806 ve.ce.Surface: Actually default to showAsActivated=true in #deactivate

Change-Id: I3879dfe180707aad775f6fe45b385e32f7ceed34
2019-09-16 18:31:52 +02:00
Bartosz Dziewoński f8d825838c Update VE core submodule to master (ad919ec0f)
New changes:
79b8dde0b Localisation updates from https://translatewiki.net.
af9512298 Localisation updates from https://translatewiki.net.
564d90dee Test utils: Use current target in mock surface
dff861435 Don't apply surface padding in dialog target widgets

Change-Id: Ia85f5aed91aa3800878d6b470660826ba4ea8f45
2019-09-10 16:44:47 +02:00
James D. Forrester a05f9e4bf4 Update VE core submodule to master (0b17a137b)
New changes:
d4cb2f03e Update OOUI to v0.34.0
b0b481693 jsduck: Stop listing OOjs in upstream, it's using JSDoc now
0b17a137b Update OOjs to v3.0.0

Change-Id: If29a97ce689523763431face5a13929a461735b4
2019-09-05 13:03:41 -07:00
James D. Forrester 87e533d121 Update VE core submodule to master (f2b6e7db9)
New changes:
347e8622e Localisation updates from https://translatewiki.net.
f2b6e7db9 Upstream mobile toolbar flexbox layout

Change-Id: Id38a67050522f33a8a5d3228925b4518a138b2ac
2019-09-03 10:18:47 -07:00
Ed Sanders 7db2a8c537 Update VE core submodule to master (ce4a16063)
New changes:
fc0875b19 WindowAction: fix documentation reference to Promise
6d32154b3 Update (remove) native selection when model selection is null
ce4a16063 ui.FragmentWindow: override action widget config on mobile for done actions

Bug: T228230
Change-Id: Ie42ba84a798c40cc7e2228f2beba23c32f6d7fc8
2019-09-02 19:50:44 +00:00
Bartosz Dziewoński 6295afa92b Update VE core submodule to master (4f3a331f6)
New changes:
4ea2bd352 ve.ui.DesktopContext: Reserve space above anchored inspectors
bb84989b9 Docs: Standardise "messages used" comments
c792023c8 Localisation updates from https://translatewiki.net.
b86d9cfce WindowAction: Expose a promise when opening a window
4f3a331f6 ve.ui.DesktopContext: Check for null viewport first

Bug: T229900
Bug: T230816
Change-Id: I615aaa630cabd61e676f92d6a95f035938cd6864
2019-08-30 00:43:21 +02:00
James D. Forrester 48ae9852a6 Update VE core submodule to master (c4c37f4e0)
New changes:
c5f77d3b3 getNodeAndOffset: Check offset is in document range
c4c37f4e0 Follow-up I196f5bd88: Fix typo (set node=this)

Bug: T231381
Change-Id: Ie721788834b28e5d034b594ddb8ddbe204ff8d37
2019-08-27 14:49:09 -07:00
Ed Sanders 20b1c6d752 Update VE core submodule to master (fe0ca590e)
New changes:
78d5b216d More documentation for ve.dm.VisualDiff#diffTreeNodes
fe0ca590e Link context: Add small spacing between link and label

Change-Id: Ie96de32a9ae6a96fad92781d84a685225bdbc911
2019-08-27 17:29:38 +01:00
Bartosz Dziewoński 21f0f712e4 Update VE core submodule to master (c6d271fa5)
New changes:
c6d271fa5 Link inspector: Change "label" messages to "text"

Bug: T230794
Change-Id: I99809e53ca9ca62804f6a1ed6fbe4d3d62f51507
2019-08-27 17:38:06 +02:00
James D. Forrester b28c4bd31e Update VE core submodule to master (aec8d85c5)
New changes:
aec8d85c5 build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue

Change-Id: Ia2e5f94899fbb6d3ba036d820df95a3149df0a03
2019-08-26 14:35:29 -07:00
Bartosz Dziewoński 02d0936d90 Update VE core submodule to master (3a669b323)
New changes:
13477446b Localisation updates from https://translatewiki.net.
9ef837943 GeneratedContentNode: Re-apply model selection if DOM node count changes
45c37f702 ve.ce.Surface: Don't request offsets that are out of bounds

Bug: T231085
Bug: T231094
Change-Id: Iad370402c5645a0ed4078977155815a95715dab5
2019-08-26 20:29:01 +02:00
James D. Forrester 90eaa75878 Update VE core submodule to master (7c1d4680d)
New changes:
2e37aaea7 Localisation updates from https://translatewiki.net.
85011b54a Utils: Move ve.supportSelectionExtend to client-only utils
077dfaa59 ve.dm.Change: Remove no-longer used doc argument from #deserialize
586a91bc5 ve.dm.Change: Fix serialize to be recursive

Change-Id: Ia70f2a663899972e35ac0b077465f946ebc49ffc
2019-08-23 06:32:49 -07:00
Ed Sanders 042bfdfd9d Update VE core submodule to master (07687721b)
New changes:
77076f828 LinkAnnotationInspector: add a "label" field on mobile

Local changes:
* Updates for mobile link label editing

Bug: T229431
Change-Id: Ib0489f6f59b228ebc4a20f7a0a515be938a8f6d3
2019-08-23 00:25:51 +02:00
Bartosz Dziewoński 54cd987398 Update VE core submodule to master (663b34056)
New changes:
f373fbea1 Remove redundant @method annotations
ca2ea9246 Fix issue URL typo

Change-Id: I04cfc6b9cc98108261237642dae3be119d8a42a6
2019-08-22 21:22:49 +02:00
James D. Forrester bd0bcff6e4 Update VE core submodule to master (3a7bad9c0)
New changes:
92b32ff5e Localisation updates from https://translatewiki.net.
43950656f Rebaser: Listen to surface history event, not document transact event
3847440a4 Localisation updates from https://translatewiki.net.
5e3e913ea Consider focus, not anchor, in ve.ce.RangeState
56378e975 Prevent RangeState tests from hanging QUnit via a huge diff

Bug: T230814
Change-Id: Ib1f238c4800e3acb581122cbb999a8e59dd5b2c5
2019-08-21 14:33:14 +01:00
Ed Sanders 3cbe0a5a20 Update VE core submodule to master (c2c5149f3)
New changes:
62f06382c Localisation updates from https://translatewiki.net.
5fc25c0d9 LinkContextItem: Apply ellipsis directly to link

Local changes to fix link ellipsis styles.

Bug: T230267
Depends-On: I25bb4fa9b7288232b08bab9c88f281817a26d6bb
Change-Id: I8a4b04d45979a1f6c375a7c92a340e3e81d7753c
2019-08-15 10:12:22 +02:00
Ed Sanders 90fc49e18b Update VE core submodule to master (70bf52198)
New changes:
70bf52198 MobileContext: Clear opening timeout when closing

Bug: T229879
Change-Id: I4c13c0e8bc56262f0504dab19847718fe4d60ce6
2019-08-06 15:27:03 +01:00
Ed Sanders d8461241f2 Update VE core submodule to master (aae84a489)
New changes:
1375d1500 Document that toJSON takes a key argument
27056b919 Localisation updates from https://translatewiki.net.
aa52f476f Only create context footer on mobile
ab6d942c5 Deactivate surface during replaceAll
aae84a489 MobileContext: Ensure isVisible returns true while opening

Bug: T229734
Bug: T229879
Change-Id: Ic03c22a785a2e9e8a4d38c17789ea2d4f16ef3ed
2019-08-05 21:13:05 +01:00
James D. Forrester 67087af16d Update VE core submodule to master (0de28ce64)
New changes:
cd5e54f78 MediaSizeWidget: Make methods chainable
1606e2dd5 Localisation updates from https://translatewiki.net.
5a2f5fdb5 ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting
6f2206ee2 Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify
7c78f1db7 Document ve.dm.TransactionProcessor#process better

Bug: T227630
Change-Id: Ic79e8bb8ef9a6288d80b591a83bf43cafc83743d
2019-08-02 10:26:51 -07:00
James D. Forrester dce6efb31e Update VE core submodule to master (a7d95c35b)
New changes:
d6d0ff8ce Localisation updates from https://translatewiki.net.
f57c6344c Move common code from FragmentDialog and FragmentInspector to FragmentWindow
a7d95c35b build: Bump lodash for npm audit

Change-Id: Ide09983d0b8c2006b25ab257fc048416a83b50c6
2019-07-31 18:50:04 -07:00
James D. Forrester e0272fef60 Update VE core submodule to master (fe0f165df)
New changes:
2e14259db ve.ui.FragmentInspector: Fix positioning of additional actions

Change-Id: I1702552df1eba492251c8388710c8b2f194a0991
2019-07-25 13:52:43 -07:00
Ed Sanders 32042d76e8 Update VE core submodule to master (fbbb9c4cb)
New changes:
854a1fa2c Distinguish active link styling

Local changes:
* Pull through active link styling

Bug: T228220
Change-Id: I925f88d32a514a749b96f501a211003bc4c924f0
2019-07-25 20:25:54 +00:00
Ed Sanders 9a1994e47c Update VE core submodule to master (7cb9caca1)
New changes:
28aea2e4d Edit cards v2 design
739017973 Track usage of the new "close context" button

Local changes:
* Edit cards v2 pull through

Bug: T222396
Change-Id: I1ca885e8d8127e7827a059755315ed789a7b9210
2019-07-25 22:24:48 +02:00
Bartosz Dziewoński 473bf1bf94 Update VE core submodule to master (e63fe33b1)
New changes:
e6531ada8 Follow-up 06f1ebb8: Drop deprecated ve.init.Platform methods
65a6870b3 Localisation updates from https://translatewiki.net.
e63fe33b1 Instrument ActionProcess for FragmentDialogs as well

Bug: T221305
Change-Id: I9e4d4249167dae7b8593c0fa88e6227c9714957d
2019-07-25 22:05:45 +02:00
David Lynch 5424a5e6bb Update VE core submodule to master (788d449ae)
New changes:
2d326b1fe Re-enable karma Firefox testing
4d95bdf2c ve.ui.Surface: Update iOS padding on focus/blur/activation
5cf567d34 Generalize the tracking of window opening

Bug: T200347
Bug: T221305
Change-Id: I3da0e81ac906f2426060fcaea4d268aa8b82e82c
2019-07-24 15:04:45 -05:00
Bartosz Dziewoński 2b6857d89a Update VE core submodule to master (6045a533f)
New changes:
5e8865931 Don't hide the context when opening an inspector on mobile

Bug: T228229
Change-Id: I32ff3962cdff332d51f32c5c3fd36e8062c3ac6f
2019-07-23 22:13:39 +00:00
Bartosz Dziewoński 0fb7d5efda Update VE core submodule to 962335a40293cf4b1314c0236788f35f080ae877
New changes:
a06204317 Fix TableNode unit test getOffsetFromCoords failure on Firefox
dfe0eb025 Refactor mobile context logic into ve.ui.MobileContext

Local changes:
* Pull through for edit cards refactor

Bug: T227532
Bug: T228767
Change-Id: I6c043e039fbef62a56f475b0dc365e171ab7bf59
2019-07-23 22:13:27 +00:00
Ed Sanders 393de5985f Update VE core submodule to abf2bfa85e64e67cdf963601fe1da2a11fd9e89a
New changes:
1a7460058 Remove ve.newMobileContext feature flag

Local changes:
* Remove ve.newMobileContext feature flag

Change-Id: Ia8def997b7cba4623866080752b06068d2118cc3
2019-07-23 22:12:48 +00:00
James D. Forrester df0e56a8fc Update VE core submodule to master (d33f296d1)
New changes:
da6d39555 Use collapsed selection for "set label" button on mobile
03d6ccf50 Localisation updates from https://translatewiki.net.
d33f296d1 Update OOUI to v0.33.4

Bug: T228227
Change-Id: I20e39928fb6ca6e0d72c399987d76cc579b4f842
2019-07-23 07:34:03 -07:00
Bartosz Dziewoński c354e17388 Update VE core submodule to master (e2f4b0e96)
New changes:
1f9b02179 ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations
570acddfb Revert "Call handleInsertion on beforeinput"
e2f4b0e96 Localisation updates from https://translatewiki.net.

Bug: T217223
Bug: T227241
Bug: T227852
Change-Id: I439872773aee5a78928cf8af1a44c8eb080a8bf0
2019-07-19 18:09:51 +02:00
James D. Forrester c82238b0b6 Update VE core submodule to master (3d0cc9eac)
New changes:
9171b9afd Update OOUI to v0.33.3
d22e876e0 SurfaceFragment: Fix typo in docs
11b04e1b6 HashValueStore: Shortcut merge if other === this

Change-Id: Ibfe03293675f6484d0758ebc239246713bfa7d95
2019-07-17 14:38:09 -07:00
Bartosz Dziewoński 8aac97cc30 Update VE core submodule to master (311a3dff1)
New changes:
bb8471c98 Edit cards: Don't show keyboard when going from focusable to link
80feb00ae BranchNode: Add comment to internalItem hack
9c2f1241b FocusableNode: Avoid DOM manipulation in setup

Change-Id: Iad906dc3aeff1b777ad11f276a277381a99b4113
2019-07-16 01:06:27 +02:00
James D. Forrester d8b6509d78 Update VE core submodule to master (e16b98e25)
New changes:
616f2c40d Fix some typos in code comments
22c03cc02 Render internal item nodes when requested individually

Bug: T228070
Change-Id: I99ee90f0b88c00455995d165745509121df1b2b0
2019-07-15 14:11:20 -07:00
Ed Sanders b64cd4ced1 Update VE core submodule to master (213b79783)
New changes:
6cd9ba63f Localisation updates from https://translatewiki.net.
c9cebed32 Update OOUI to v0.33.2
65c66b8a6 Localisation updates from https://translatewiki.net.
8d94ad13f Replace unrendered parts of the view tree with a stub node
213b79783 Basic unit tests for attachedRoot functionality

Bug: T215717
Change-Id: I7bd8106a82e4fa7c912ce9f8d4fab86bfb546702
2019-07-14 15:26:28 +01:00
James D. Forrester a0aacd89e1 Update VE core submodule to master (d49575d46)
New changes:
3bc3dfd87 build: Upgrade various devDependencies to latest and make pass
a0165b985 Fix visible whitespace rendering in source mode
261535e2d Avoid jQuery.map
bf1398cc3 Remove unused :visible check

Bug: T226478
Change-Id: I9b6a79ea0fdb1679036372b46b8df3b885ffb135
2019-07-08 11:17:16 -07:00
James D. Forrester 24a017e980 Update VE core submodule to master (89805a657)
New changes:
ee6c423cf Add transition to iOS menu bar hack
f11192b6d Localisation updates from https://translatewiki.net.
22eb0e4ca Replace #serialize methods with #toJSON
1fe8a1afb Provide defaults for ve.dm.Change constructor
ce0123260 Explicitly pass store length argument to pushTransaction
89805a657 Set max width on mobile demo

Change-Id: Ic2de7c5d5ab9f8d416a4de01a5125128533abe64
2019-07-05 15:51:01 -07:00
James D. Forrester 56df3cc4cb Update VE core submodule to master (75510a515)
New changes:
a3d860daf Localisation updates from https://translatewiki.net.
0421bf6f0 Gather annotations from clicked node where possible
2d2491877 Change#squash: Compact multiple transactions into one
dc0e4650e Fix documentation of ve.dm.Change#serialize
a40f8314f Fix contexedAnnotations equality check
ec62ccb34 Use 16px font size on SA mobile demo
57984c072 Update OOUI to v0.33.1

Add lib/ve/src/dm/ve.dm.TransactionSquasher.js to debugScripts.

Bug: T188026
Bug: T226708
Change-Id: I6eb4ab50ef2c6774963f692f600f059662bf0ac3
2019-07-04 00:31:57 +00:00
James D. Forrester 3f38f54a12 Update VE core submodule to master (681aa3fbc)
New changes:
9cbe6ed65 Use 'unLink' icon for unlinking
e6f489f8d Dialogs: Use close flag for close actions
f2260bc47 Update RangeFix 0.2.7 -> 0.2.8

Bug: T225021
Bug: T225725
Change-Id: I36f27fe4b2b7a2fffa319cbff0b160b4435e806b
2019-06-28 13:36:18 -07:00
James D. Forrester 928153f268 Update VE core submodule to master (f93b871a6)
New changes:
33c9871e4 ve.ce.Surface: Clear active annotation highlight when blurring on mobile
24e442efc Enhanced instrumentation for context items and inspectors
17e0a80ea Localisation updates from https://translatewiki.net.
39ba2e196 Update OOUI to v0.33.0

Bug: T221252
Change-Id: I06eb0f99557dbada022bcad44fff48ec0709e004
2019-06-27 10:43:03 -07:00
James D. Forrester 97484d3b7a Update VE core submodule to master (cf99ae2e0)
New changes:
2c8676497 Rename call to deprecated scrollCursorIntoView
f04991f64 Fix missing resize handles in dist

Bug: T182312
Change-Id: I90e3672780356d352f2b08c824c59905e8936b6d
2019-06-26 14:11:06 -07:00
James D. Forrester ddfa58243b Update VE core submodule to master (39b766b3a)
New changes:
7bec2244a Localisation updates from https://translatewiki.net.
61ea6f413 Remove iOS context scroll fix
5b78a078f Move logic for new mobile contexts to mouse down handler
83301862f Check argument to getNodeFromOffset is a number

Bug: T202723
Bug: T226073
Change-Id: Iffa0ccdb40f8f505b460eadf84dc1cefdacdcfa2
2019-06-25 12:03:37 -07:00
James D. Forrester 5b5979cfe2 Update VE core submodule to master (35a2d0629)
New changes:
35a2d0629 ce.LinearSelection: Don't crash when surface is not attached

Bug: T226281
Change-Id: I5a0a3acdabddcea2949f333ff54f5259f770a4c5
2019-06-21 18:41:37 -07:00
James D. Forrester 92a600d5a2 Update VE core submodule to master (599facff7)
New changes:
7f002809d Localisation updates from https://translatewiki.net.
599facff7 Restore inline slugs in source mode for cursoring

Bug: T225546
Change-Id: I28a08113d0c8b3b64b32c06b225b0b4038140758
2019-06-20 15:58:09 -07:00
Ed Sanders 421ef465b9 Update VE core submodule to master (1cf71b3f3)
New changes:
f99a7cd43 Apply desktop contexts' line-wrapping to new mobile contexts
fad2671d3 Localisation updates from https://translatewiki.net.
262c84128 scrollSelectionIntoView: Code simplifications
a13c86033 scrollSelectionIntoView: Fix mobile logic
04774b03c Allow passing a pre-existing HashValueStore to getModelFromDom
1cf71b3f3 Catch errors from getNodeAndOffset

Bug: T202723
Change-Id: I41cf726dad38d4fe6647a1b760d66126fcee393f
2019-06-20 13:39:59 +01:00
Bartosz Dziewoński 01afd73aea Update VE core submodule to master (44556e8fd)
New changes:
ee96c6334 Localisation updates from https://translatewiki.net.
2a9ff2c54 Localisation updates from https://translatewiki.net.
5facf5ef6 Localisation updates from https://translatewiki.net.
afe09ea26 Make annotationsAtModelSelection fail in fewer cases
f6278bba0 Fix clipping on label preview in link context
42717187a ve.ui.AnnotationInspector: Deactivate surface after closing on mobile
44556e8fd Move mobile context to bottom of page

Bug: T199617
Bug: T204733
Bug: T220633
Bug: T225541
Change-Id: Icd6de1d7e380a14444ddba2044553c8c13682706
2019-06-14 22:56:24 +02:00
James D. Forrester 14e747b398 Update VE core submodule to master (e531c251e)
New changes:
7f101ce9a Add new messages for add/edit link
e531c251e Update OOUI to v0.32.1

Change-Id: Ib9fb48c531c8bc787bd2efc3e4f59af8977b1977
2019-06-05 15:38:12 -07:00
James D. Forrester 65edcaf631 Update VE core submodule to master (2da36280a)
New changes:
ca588de0d CommentAnnotation: Make deleteable
02eb9e835 Synchronizer: Fix defaultName config
4101ca058 Add removeEmptyLastChildOnEnter to CheckListNode
080317f9f CheckListNode: Flip margins based on content direction
df1dbd0c4 Localisation updates from https://translatewiki.net.
a55f5d7d9 Make undo concurrency-aware

Bug: T185706
Change-Id: Id2b993eb6efcb0dde0c7d1ea1fc6a6cf91bc0e43
2019-06-04 15:57:46 -07:00
Ed Sanders dbd4dfd727 Update VE core submodule to master (53e69bf14)
New changes:
5810e0cd4 Update UnicodeJS to v12.0.0
145991ded Fix file list on demo page
53e69bf14 SurfaceSynchronizer: Force websocket transport

Bug: T201531
Bug: T201532
Bug: T201533
Bug: T201534
Change-Id: I96beb31df55b41bf1d259f5e6964245008face22
2019-05-30 23:02:27 +01:00
Ed Sanders b1ac5b74d3 Update VE core submodule to master (06f1ebb8e)
New changes:
06f1ebb8e Local/SessionStorage refactor

Local changes:
* Update for core storage refactor

Depends-On: I3cc1d5adfbce794e8345b7f1090c10fb0d42d150
Change-Id: If855ee33b0993788cc159d8c3acf03070e6a9566
2019-05-29 14:49:53 -07:00
James D. Forrester 0e7e88c43e Update VE core submodule to master (d9ece414a)
New changes:
c0799b060 Source mode performance optimizations
d9ece414a ve.dm.MetaItem: Add removable flag

Bug: T96528
Change-Id: Ifc0d3322c0ab0c0384fd179281cb1ed7f3ff6b31
2019-05-29 12:31:24 -07:00
James D. Forrester 0c98fd06c8 Update VE core submodule to master (67f50262e)
New changes:
27a6c1b28 Fix find and replace selection handling
67f50262e Update OOUI to v0.32.0

Bug: T222247
Change-Id: I648a339f4d84967c64e66d76f6828af8031b8b63
2019-05-28 17:58:24 -07:00
James D. Forrester e2d2263540 Update VE core submodule to master (e3715c257)
New changes:
f33944071 Call handleInsertion on beforeinput
fea597f9f Localisation updates from https://translatewiki.net.
33750ce4a Revert "ve.ce.FocusableNode: Prevent native selection from changing on click"

Bug: T217223
Bug: T224042
Change-Id: I3b3b65f002e0d0852eb065338552243e4f1979ae
2019-05-28 10:45:53 -07:00
James D. Forrester 4a7231f3ee Update VE core submodule to master (3c069c39f)
New changes:
c843549bc ve.ui.Surface: Remove unneeded code handling mobile dialogs
9d530f337 Don't show mobile table context on desktop

Bug: T211240
Change-Id: I8975279f4ee29eb290c6b6238a8106077857635f
2019-05-24 09:57:41 -07:00
James D. Forrester 6c368a0303 Update VE core submodule to master (68b031087)
New changes:
68b031087 ve.init.Target: Fix errant call to setSurfacePadding, not setPadding

Bug: T224255
Change-Id: I19db16ec5849968f48658e4149bf7410b58ece5e
2019-05-23 16:45:28 -07:00
James D. Forrester fd7e4e3abd Update VE core submodule to master (c3d8228b8)
New changes:
120c96c94 Replace surface's 'toolbarHeight' with generic 'padding'
c3d8228b8 Localisation updates from https://translatewiki.net.

Bug: T224126
Change-Id: If374b215f942220f157bfedbe481ed79d69e9d85
2019-05-23 10:54:35 -07:00
James D. Forrester 700087e5fe Update VE core submodule to master (d5a7325ef)
New changes:
ae1c9f741 AlignableContextItem: Hide labels on mobile for space
c32f27d63 Localisation updates from https://translatewiki.net.
71f10a10b Remove fullCol/fullRow selection style
d5a7325ef Unify selection scroll code

Bug: T220227
Change-Id: I294b1b63f34530b2b649e15d9f63f6c0e1ae2e96
2019-05-22 09:37:28 -07:00
Ed Sanders a046bacead Update VE core submodule to master (334260638)
New changes:
e01936d72 Tweak table selection rects in Chrome/Firefox
334260638 Localisation updates from https://translatewiki.net.

Change-Id: I70f78c7e98c42be2e171a47cb6a572005c2a8ac5
2019-05-17 14:40:20 +02:00
James D. Forrester 5de26792df Update VE core submodule to master (ad71116fd)
New changes:
a44fb60ae Localisation updates from https://translatewiki.net.
71298d9c7 build: Unbreak language lists, adding new 'bjn' language
ad71116fd build: Upgrade grunt-cssjanus from 0.4.0 to 0.5.0

Change-Id: I63314fd4581a626b6efd44b6c26bd90e6d83a4fb
2019-05-13 16:57:32 +01:00
James D. Forrester 622e77d620 Update VE core submodule to master (6fc2d029c)
New changes:
8df948f5d TableLineContext: add context for the entire table
aae86a822 TableNode: Change mobile behavior so initial tap enters the cell
195d8cb3a Check resizeable node is focused before rendering handles

Bug: T211240
Change-Id: Ib2430c521abb4e59aaa2c5e4f9b26a16437db02e
2019-05-13 13:30:15 +01:00
James D. Forrester 8d2d11cb11 Update VE core submodule to master (7e10b410b)
New changes:
899ceb674 Localisation updates from https://translatewiki.net.
f9a505fc8 build: Upgrade grunt from 1.0.3 to 1.0.4 and re-up for npm audit
b5003d614 build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
047b4b658 TableNode performance: Only change selection when endCell changes
403ac358a Update OOUI to v0.31.6
214553db9 ve.ce.FocusableNode: Prevent native selection from changing on click
7e10b410b Localisation updates from https://translatewiki.net.

Bug: T108013
Bug: T220036
Change-Id: I0ae9d03486c3d45cee66cbf004ef98a406f06a50
2019-05-09 10:39:45 -07:00
James D. Forrester e006803fdf Update VE core submodule to master (36e90285e)
New changes:
ec868af45 Don't allow merging cells that aren't editable
7d611c668 Demo: Set nullSelectionOnBlur when changing page
f9efedaba Remove focus code from LinearContext
690d22d08 WindowAction: Don't re-activate surface until teardown complete
7b2e88166 Update activeAnnotations when applying new annotation

Bug: T221716
Bug: T222039
Change-Id: Icb65c880d8407733192f4cb953899399ecbe87f3
2019-04-29 10:41:54 -07:00
James D. Forrester e437d25be8 Update VE core submodule to master (e1d2a6d8c)
New changes:
fff5c8c1c ve.dm.VisualDiff: Allow sub-trees to be diffed

Bug: T221903
Change-Id: Ie9c9674cb7e1532319a5276a107bcf2c6bd34b65
2019-04-28 08:29:49 -07:00
James D. Forrester f75ee24d05 Update VE core submodule to master (b68520b6d)
New changes:
b68520b6d Check selection is a TableSelection before looking for cells

Bug: T221901
Change-Id: If25bda1c0b970d92b89014c862457a7a417b58cd
2019-04-26 23:26:12 -05:00
James D. Forrester b89221be3b Update VE core submodule to master (b049d6049)
New changes:
c544dfc40 ve.ui.DebugBar: Fix Filibuster button
2009d0427 Remove list-specific logic from LinearEnterKeyDownHandler
1ee05602a Don't reactivate after opening tools/windows on mobile
3538c3870 (De)activate table selection on context menu toggle
39be19b54 Re-use existing table selection when re-activating
59cf5cdbd Add more granular code coverage targets
d0ff41a71 Update OOUI to v0.31.5
b049d6049 ve.ce.TableArrowKeyDownHandler: Movement from merged cells must collapse selection

Bug: T220633
Bug: T221286
Change-Id: I443e665e8831defd098eb410264c404942f3e2ec
2019-04-24 14:34:39 -05:00
James D. Forrester 3320d8ec58 Update VE core submodule to master (ac38ec869)
New changes:
64bad457a Localisation updates from https://translatewiki.net.
a4586f717 toggleMobileGlobalOverlay: check whether the target exists before using it
4d2f18871 Update RangeFix 0.2.6 -> 0.2.7
3433770e0 Restore re-activation hack

Bug: T221291
Bug: T221600
Bug: T221669
Change-Id: I783924aa8ba03a9f5969a9c3fc0c1c381a3f5741
2019-04-23 17:32:22 -05:00
Ed Sanders a7149cc3ee Update VE core submodule to master (7cd15cfe9)
New changes:
9b162a5da Localisation updates from https://translatewiki.net.
10dbdabf4 Remove valid-jsdoc exceptions for @chainable
a424f804d Make blockquote a non-content branch node

Local changes:
* Update stuff for making blockquote a non-content branch node

Bug: T76426
Change-Id: I95ae25f20d3d102da69bf5ffdff55335f6c07635
2019-04-22 12:39:14 +01:00
James D. Forrester 24cb70bae0 Update VE core submodule to master (6afc66096)
New changes:
c2ae612e0 Update OOUI to v0.31.4
4e32f62c3 Re-use previousSelection when re-activating
e1f01b47c Auto-save: Allow an optional document prefix
63192a7f4 ve.ui.ToolbarDialog: Remove unused styles

Bug: T220633
Change-Id: I99a905db6aa5ba91655901a6ea2c821b8603aadf
2019-04-17 14:25:50 -07:00
James D. Forrester 965b1291e5 Update VE core submodule to master (3796a1f91)
New changes:
b1857b4d2 Distinguish between $scrollContainer and $scrollListener
9639db634 Surface read-only tweaks
0e2dc8646 DimensionsWidget: Make setters chainable
3d8f3538b DimensionsWidget: Add read-only support
f1a8a2693 LinkAnnotationWidget: Make setters chainable
3796a1f91 LanguageInputWidget: Fix disabled support, add read-only support

Change-Id: Iaf85be0a29283f26f4cdf9a06b565c419568170f
2019-04-16 08:26:58 -07:00
James D. Forrester 51b68049d1 Update VE core submodule to master (6590e0ac5)
New changes:
6590e0ac5 Create generic command to move focus to context

Change-Id: Iba309ca5f7299f4157a3a43836064e17b5f4d62b
2019-04-15 14:13:42 -07:00
James D. Forrester f7f32c7090 Update VE core submodule to master (33847a3ec)
New changes:
ef34c19ea Make context's contents selectable
bbb39d52e Remove de-emphasis color from comment context
ce43589fe qqq.json: Add clarification to visualeditor-key- messages
5b233d7db Create more methods for finding/selecting current annotations
8fd5ec673 Fix selection behavior of table right-click
f0e7d69cd Localisation updates from https://translatewiki.net.
dd965ecf2 ve.ce.TableNode: Fix right-click to copy code

Bug: T154622
Bug: T154794
Bug: T220090
Change-Id: I483c12881f670fefc19585a2370edada1f9e9083
2019-04-15 10:10:27 -07:00
James D. Forrester cdb4b627e6 Update VE core submodule to master (a3a2c48f7)
New changes:
c058aa83f ve.ce.Selection: Introduce getSelectionFocusRect
6bc19aa1c Localisation updates from https://translatewiki.net.
56636ee43 Firefox Mobile: Prevent scrolling after mousedown

Bug: T196839
Change-Id: If45ddd8ec2e651d636d1665a12d7b38b5c3afd6e
2019-04-12 16:21:29 -07:00