Commit graph

1263 commits

Author SHA1 Message Date
Ed Sanders 97ddc8af2b Add image upload tab to media dialog
Uses the ForeignStructuredUpload BookletLayout.

Bug: T40030
Change-Id: I103044210e714d99350a28a48619beacefb43eaa
2015-10-06 18:40:19 -07:00
Ed Sanders 3f2a885e3e Ensure full error message is shown when inspector is closed
Applying staging doesn't emit an update event on the node, so
forcefully emit one with 'staged' equal to false, so the full
error is rendered (if present).

Logically depends on I8ebb26d4bc in core.

Bug: T114480
Change-Id: I7ba54b67982fc5b10839426cdc216e14c0e33c01
2015-10-05 17:15:40 +00:00
jenkins-bot 4878313bea Merge "Consistently use spaces inside brackets in CSS" 2015-10-05 15:02:25 +00:00
jenkins-bot 7c0f17c2cf Merge "ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons" 2015-10-05 11:55:04 +00:00
jenkins-bot 291065459c Merge "Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest" 2015-10-04 19:54:45 +00:00
Bartosz Dziewoński 205beb2b49 ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
OO.ui.BookletLayout does not respect tabindices when trying to focus
the first focusable element after a page is switched. Remove the need
for manually set tabindices in ve.ui.MWTemplateDialog by using natural
DOM order and absolutely positioning things to keep current design.

Bug: T114562
Change-Id: I7a18a455f9fa80eb3d2ea17bff8139e0194c0fbf
2015-10-04 20:39:16 +02:00
Ed Sanders 1eb0ef2011 Consistently use spaces inside brackets in CSS
Change-Id: Ie63a50cb16cb89dac7060857220485d7d23f2fe3
2015-10-04 18:33:43 +01:00
Thalia 34f6e11a19 Call updatePreview when closing the LiveExtensionInspector
Call updatePreview in insertOrUpdate node, when closing the
inspector. If edits have only been made to attributes that
don't affect the rendering, updatePreview will not have been
called, so the model won't have changed. Therefore
updatePreview should be called every time the inspector is
closed to make sure such edits are applied.

Bug: T113078
Change-Id: I48fb291487f76fc515f122646d205366a60dca62
2015-10-01 15:58:20 +01:00
Ed Sanders f814ea719b MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget
Depends on I335bd912d in MediaWiki core.

Bug: T101169
Change-Id: I2932c9df5444d1363af5af9b438bb905ed298148
2015-09-27 14:03:52 +01:00
Ed Sanders a04d2ff52b MWLinkAnnotationInspector: Update actions when changing tabs
Change-Id: I825531683eeb8b7e21b741f1dc5d338abc9d347a
2015-09-27 14:03:29 +01:00
jenkins-bot 763b9c8058 Merge "Update VE core submodule to master (27fc244)" 2015-09-26 13:38:42 +00:00
jenkins-bot 03d4e08a83 Merge "Allow autolinking ISBN/PMID/RFC inside list items" 2015-09-26 13:38:37 +00:00
jenkins-bot 81282a7769 Merge "Autolink of magic links should create node not annotation" 2015-09-26 13:38:34 +00:00
Ed Sanders 6ed5877c69 Update VE core submodule to master (27fc244)
New changes:
18e46b6 [BREAKING CHANGE] LinkAnnotationWidget: Abstract .text property to getTextInputWidget

Local channges:
* MWLinkAnnotationInspector: Use new getTextInputWidget method

Change-Id: Ia33797d612be7b4521e7212047a38480ee2520df
2015-09-26 12:27:56 +01:00
Alex Monk 3386f66770 Save dialog: Make review/resolve actions work in mobile
Depends on Ic92378b7

Bug: T111894
Change-Id: I5ca5f803642dd12db4e9fb213dc6478701661528
2015-09-26 00:08:31 +01:00
C. Scott Ananian 92bfa93e4e Autolink of magic links should create node not annotation
Depends on: I9679cf0fd550c9b156370fc88953414460c801a4

Bug: T112675
Change-Id: I97a1750b3424c09e181976029f10ee161129b166
2015-09-25 14:21:33 -04:00
Thalia b7bdf2d867 Adjust uses of renamed PreviewWidget to PreviewElement
Depends on I516b87f3be in VE core.

Change-Id: I9ad4bab3fff0bf0fb8a79673dbe67be4a9b2c363
2015-09-25 09:37:34 +00:00
C. Scott Ananian 07f67bdb22 Allow autolinking ISBN/PMID/RFC inside list items
Depends on I18b73514e5a3d967cce02d9706a11e30ede71d9a in ve core.

Bug: T113535
Change-Id: Ifc749951a6e92e19a7eb27ed631f8ba11d88a5cf
2015-09-25 10:35:18 +01:00
Alex Monk 0fb38cc824 Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest
Bug: T113647
Change-Id: I537a235064cf8e95b0e1cde46f3079e0af082e7c
2015-09-24 22:35:38 +01:00
jenkins-bot 8a0ead0940 Merge "Allow pressing 'escape' from all pages of save dialog" 2015-09-21 23:06:49 +00:00
jenkins-bot 9beb40c40e Merge "Make save dialog variable height" 2015-09-21 23:03:42 +00:00
Ed Sanders 7e0d4daf3d Allow pressing 'escape' from all pages of save dialog
Bonus: Add 'Resume editing' button to review changes page

Change-Id: Ief200c8aa2e2c8363bf6c9be3544ec1c56e07ff4
2015-09-21 22:59:21 +01:00
jenkins-bot 14600662b6 Merge "Template placeholder: Don't show delete button if we're the only transclusion part" 2015-09-21 17:27:52 +00:00
Ed Sanders a1147f764b Make save dialog variable height
Change-Id: I90437b3130d08441e5c93b2a34fd9083106a14b3
2015-09-21 17:52:19 +01:00
jenkins-bot 03ef91fade Merge "MWReferenceResultWidget: Remove border from last item" 2015-09-21 06:56:12 +00:00
Ed Sanders d7adf533ca MWReferenceResultWidget: Remove border from last item
Change-Id: I56c16711d6467647b0bb5b9bdf2d89fff1122ef4
2015-09-20 21:50:11 +01:00
Ed Sanders 7d4692a635 Make gallery icon slightly lighter and smaller by thinning borders
Makes the icon more consistent with other VE icons in terms of weight.

Change-Id: I37ad04394e9811c9d44c7c2b3af63e1ae03dd297
2015-09-20 18:23:15 +01:00
jenkins-bot 664e2db006 Merge "MWWelcomeDialog: .html, not .text, as we're inserting HTML" 2015-09-18 21:20:41 +00:00
jenkins-bot 377944f6e9 Merge "Exclude citefromid and cite-(book,journal,...) commands from ref dialog" 2015-09-18 16:05:05 +00:00
Alex Monk 2d46e57709 Template placeholder: Don't show delete button if we're the only transclusion part
Bug: T95252
Change-Id: I62ebe56a2c5d5a0a39a5d806b2fcb348e25f6a17
2015-09-17 00:31:18 +00:00
James D. Forrester 48c849ca5b MWWelcomeDialog: .html, not .text, as we're inserting HTML
Change-Id: I2cc35af4c6ed59ec1b5df991af1568c85c050fae
2015-09-16 14:54:11 -07:00
James D. Forrester 9b0779da9b MWWelcomeDialog: Split text, tweak styling
Change-Id: If15dc9fe4a01e81cf7d85e2670878bbd5899f068
2015-09-16 10:16:44 -07:00
James D. Forrester 004ae8570a MWWelcomeDialog: Switch out graphic for new one
Change-Id: I7ca0625e16535cf287161f66aaf1ce7e8db740aa
2015-09-15 10:50:19 -07:00
Ed Sanders 9ebda54297 WelcomeDialog: Fix vertical spacing
Change-Id: I10667512dff829195af43ea47d51d662836512bf
2015-09-15 11:58:20 +01:00
James D. Forrester e5e1810f02 MWWelcomeDialog: Alter to be welcoming, use a nice image
Drop beta-ness as users don't care and it confuses them. Leaving the preference
alone for now.

Bug: T99963
Bug: T112354
Change-Id: I0e039dec54d528fce24226e76b931b593dd13a9e
2015-09-14 18:29:07 -07:00
jenkins-bot aa7fcf27e6 Merge "MWSaveDialog: Checkbox vertical alignment tweak" 2015-09-14 14:52:48 +00:00
Ed Sanders 2280b0db20 MWSaveDialog: Checkbox vertical alignment tweak
Change-Id: I3741d2d5c9bc5b5500440c053766582cfd298841
2015-09-14 12:14:12 +01:00
jenkins-bot 85bc110774 Merge "Remove command help height hack" 2015-09-11 18:48:19 +00:00
Ed Sanders b68099bcb4 Remove command help height hack
No longer needed, depends on Ia98a91c8a in core.

Change-Id: I3789e629fef7883984bd944d2c44472d4b89199a
2015-09-11 12:46:10 +01:00
Alex Monk 821ceb9920 Order template title results by provided index
This only comes back in results from certain modules, so I'm not entirely
sure whether we want to do this in here or mw.widgets.TitleInputWidget.

Bug: T111598
Change-Id: If2916706db359d520c41c2dec7ded44e0d3a56a9
2015-09-10 20:53:35 +01:00
Ed Sanders b900adfe74 Exclude citefromid and cite-(book,journal,...) commands from ref dialog
So that users can't place references in references.

Change-Id: I7953f8137dc5422ecd0cee648a30e2c181fbb43c
2015-09-09 12:42:39 +01:00
jenkins-bot f6a2e3658c Merge "Abstract mwExtension behaviour into MWExtensionWindow" 2015-09-05 21:26:31 +00:00
Ed Sanders 8815d1397f Abstract mwExtension behaviour into MWExtensionWindow
Allows us to create an MWExtensionDialog base class that shares
the logic.

Change-Id: I53c8f1713a3513d2635cfd736ec8fc3f9616d864
2015-09-05 18:18:24 +01:00
Alex Monk 6d94d060ac Bump Schema:Edit to revision 13457736
* Remove page.length
* Add action.abort.type = switchnochange

Needs to be deployed at the same time as Ib99700ac

Bug: T111420
Change-Id: I7ee245157d4de6c220d7cdf54cd1dd69ff836f15
2015-09-04 00:51:05 +00:00
Alex Monk 7c2f6e1f5f Don't break when you cancel the link inspector
Bug: T111241
Change-Id: Iff96aa4d97fe64a2472a58b3bf782085313899c6
2015-09-02 21:30:51 +01:00
jenkins-bot 38a94dd8d5 Merge "Fix cancelling of extension inspectors" 2015-09-02 11:50:18 +00:00
Alex Monk a02d8573b4 Fix cancelling of extension inspectors
* Don't insert/update/remove nodes on cancel in MWExtensionInspector
* Don't forget to popStaging on cancel in MWLiveExtensionInspector

Bug: T110992
Change-Id: I1e30206595e304eb502c7e745bf5e00d145d12d7
2015-09-02 02:32:11 +01:00
Ed Sanders 471df53aaf MWLinkInspectorTool: Add parent method call to #updateState
Bonus: No need to check if fragment is a SurfaceFragment.

Bug: T111099
Change-Id: Ieaa3ee979477175d0f129e30838853bc04937fad
2015-09-01 21:09:13 +00:00
jenkins-bot 8502d3ea05 Merge "Specialized inspector for ISBN magic links" 2015-09-01 18:34:23 +00:00
C. Scott Ananian 7cc23367f6 Specialized inspector for ISBN magic links
Implement a special node type, context item, and inspector for
ISBN/PMID/RFC magic links.  Add buttons to the link inspectors
to convert back and forth between "simple" links, and magic links.

Depends on I5d000d8b63dafdfe0a2753069d3f0ac5b03b8829 in Parsoid
for clean round-tripping of localized ISBN magic links.

Bug: T63558
Change-Id: Id5b7a2ae3c80b0e5eed598f0bd024d3e94f7e9aa
2015-09-01 14:25:59 -04:00