Commit graph

38 commits

Author SHA1 Message Date
Ed Sanders b6d03da278 Add MW-specific DiffElement tests
Change-Id: If3dfa660b49bceef2da8dc7ec113225aaa7f59f5
Depends-On: Ib4ad16858e4241d33d018830dbcfded63ff703af
2018-06-19 16:04:08 +01:00
jenkins-bot c9f3f45b9d Merge "ApiVisualEditor: Defensively check that query prop revisions returns arrays" 2018-05-30 22:03:35 +00:00
libraryupgrader 54f9335232 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Idfc004c9439d9b8421f378fdd559990b09ad851c
2018-05-25 23:18:11 +00:00
James D. Forrester d4841abbb6 ApiVisualEditor: Defensively check that query prop revisions returns arrays
I can't see where this would return a string, but users are reporting that
they're getting that at times…

Bug: T193718
Change-Id: I6b635bacdd59431568bc5c679e455f67cb764df0
2018-05-25 21:04:38 +00:00
Ed Sanders ab59f3d06f Update VE core submodule to master (d214a66aa)
New changes:
aa8b2d3da rebaser: Clarify document name is optional
eb4955b84 $.isEmptyObject -> ve.isEmptyObject
681fa50e1 Don't use $.isNumeric in DM
0c8483d8a Avoid more jQuery in DM
a9f6bef78 Replace $.extend with ve.extendObject
34eb4311d Initialise socketIO twice to avoid query cache
b70cb7520 Teardown synchronizer
8f829895f Use passive event listeners
f9e84fa8b Localisation updates from https://translatewiki.net.
db24bb81c ve.ce.FocusableNode: Fix minor code issues
ae981404e Rebaser: show connect/disconnect in the server console
0118e89c2 Show progress bar while connecting to rebase server
160bbe5fd Use new name for 'comment' icon, 'speechBubble'
fb549248a Remove unused APIResults* objects
5daa71d7e Remove IE9 support comment

Bug: T178371
Bug: T195111
Depends-On: I186ebd9d63299d828692a745b62fbc4314a4ed4e
Change-Id: Ie0fee3d4cc069383b8cb48e7d6c2ff520fedb590
2018-05-23 09:01:07 -07:00
Ed Sanders 0fe6c53b2e Import button for CollabPad
Change-Id: I1f454fb7914b2de0cb5f393aeed9001b6a5a2e40
2018-05-19 19:42:35 +08:00
Ed Sanders 2fac1cc985 Fix ActionFieldLayout in monobook
Change-Id: Iae2c707c13369f16ee8f55fc12adde4139b3ab09
2018-05-13 20:19:06 +01:00
Ed Sanders c059082a8f Rebase: Use i18n for subpage title
Change-Id: Ibea75035cc1af0c1c215f6038435ca9657c44984
2018-05-01 10:29:51 +01:00
Bartosz Dziewoński 4efc2f876d VisualEditorDataModule: Remove origin restriction
"ORIGIN_USER_SITEWIDE" indicates "sitewide module generated from
user-editable files, like MediaWiki:Common.js". In this case the
JavaScript generated by this module is not directly editably by wiki
users. It includes localisation messages editable by users, but that
is considered safe because we correctly escape them when including
them in the JavaScript code.

Without this change, VisualEditor would no longer load in safe mode
(T185303) because this module would be missing.

Bug: T185303
Change-Id: I6d097ccbf1dc2462843219adcf96bf8313e30289
2018-04-30 21:58:18 +02:00
Ed Sanders 185c94087f Rebaser: Use site language on special page
Change-Id: I3a07083bb64e9b398cd403a1a0458b40f054672b
2018-04-22 22:18:45 +01:00
Fomafix 30f7728a71 Fix typo in comment
Change-Id: If19045e432d6de8e6c8352518b5dacd70eda41ce
2018-04-15 14:30:31 +02:00
jenkins-bot f5b0d655cf Merge "FeedbackTool: Add the ability to vary feedback page for source mode" 2018-04-04 21:24:09 +00:00
James D. Forrester 31730cc5b3 FeedbackTool: Add the ability to vary feedback page for source mode
Wikis with a local link over-ride configured will need to do so here
for the new message `visualeditor-sourcefeedback-link`; wikis with a
remote link configured will need to update their configuration ahead
of this being deployed, setting $wgVisualEditorSourceFeedbackTitle.

Bug: T157953
Change-Id: Iea7ad8328b03f69e01d7c67ca1ddbb7ae7906288
2018-04-04 18:11:10 +00:00
jenkins-bot 459f35924c Merge "DiffPage: Remember chosen diff mode" 2018-04-04 16:34:54 +00:00
jenkins-bot 5904c25e83 Merge "ApiVisualEditor: Remove unused variable and add some type hints" 2018-04-03 19:33:32 +00:00
jenkins-bot 690c7c4280 Merge "doc: Document all public and protected PHP functions" 2018-04-03 19:29:41 +00:00
Kunal Mehta 3d48221600 ApiVisualEditor: Remove unused variable and add some type hints
Change-Id: Ic16d223a6bbdb4b80474d7749f6b4e6c4df8b65b
2018-04-03 11:21:11 -07:00
Kunal Mehta a087e447ae Avoid unnecessary use of RequestContext::getMain()
Change-Id: I4d226a0543e16aa22b28a6a403ce5c6892dc5924
2018-04-02 19:33:25 -07:00
James D. Forrester 31f667ccf7 doc: Document all public and protected PHP functions
Also move the maintenane script to a name that makes
MediaWiki.Files.ClassMatchesFilename.NotMatch not error,
and use the more restrictive licence tag usage for
MediaWiki.Commenting.LicenseComment.InvalidLicenseTag.

Change-Id: Ifa5518cd590ae83c6fd76f1dbb5a2ce40de4b119
2018-03-28 12:50:44 -07:00
Aryeh Gregor 6ebb3dad65 Required API parameters cannot have defaults
It doesn't make sense to have a default action here, per Esanders.

Blocks I4a2505cfc8e86e73e46d40acffbf3cd8803458e2.

Change-Id: I02259a5117f3539593ccd09cfd4c8271e8464388
2018-03-28 16:49:19 +03:00
David Lynch 75af29b57d DiffPage: Remember chosen diff mode
Use a new preference: visualeditor-diffmode-historical.

Bug: T189896
Change-Id: I0575cc0a86dc0683758d24c0f597834e38cf1095
2018-03-22 01:41:14 -05:00
Brad Jorsch 391c30da67 Update for the actor table change
Core change I8d825eb0 begins the process of changing core database
tables from using xx_user and xx_user_text fields to using xx_actor.
This updates the extension to continue to function during and after the
transition.

Bug: T167246
Change-Id: Iccbd9ee2edaae5d779077dddc6fe449ec8428e99
2018-03-21 12:39:26 -07:00
Bartosz Dziewoński faa0bfb0f7 VisualEditorDataModule: Remove 'minoredit' and 'watchthis' messages
These messages are used for the checkboxes when saving the page.
But we don't actually use the data from this module; we get them
from the 'action=visualeditor' API in the 'checkboxesMessages'
property. This is necessary because MediaWiki extensions can add
extra checkboxes (e.g. FlaggedRevs), so a static list won't do.
These are unused since 393807462e
(2013) and it is confusing to keep them here.

Change-Id: Ia4ed2142292c3a22623f498c7f43ce590f167709
2018-03-16 01:33:28 +01:00
jenkins-bot 98d240334d Merge "Use action=compare for wikitext diffs" 2018-03-14 19:19:14 +00:00
James D. Forrester f9ab5fa6fe ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError()
Bug: T189205
Change-Id: Ic75594c0a9388814b4ecc887c4262cbbe858d7f9
2018-03-14 10:21:03 +01:00
Ed Sanders 2b033f6ee0 Use action=compare for wikitext diffs
Diffing in action=query is deprecated since 1.30.

Bug: T189397
Change-Id: Ic1fecd4517a1410e3c8e3593a031ad7b8ffb57d4
2018-03-10 22:32:02 +00:00
James D. Forrester 285254979a Hooks: Don't register beta features if they're enabled for all
Change-Id: I8a618a8ce76f48b143955dd7a5877b68d8e1205d
2018-03-08 14:41:40 +00:00
James D. Forrester d144599cea Update VE core submodule to master (ca771b8bc)
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

Local changes:
Follow-through rename of IndexValueStore->HashValueStore

Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
2018-03-06 12:55:30 +00:00
James D. Forrester 1f38e7f87b Revert "Follow-up e19092240: During the config cut-over, don't graduate 2017WTE"
For Monday.

This reverts commit 89c0fb9d25.

Change-Id: I9140d4bf8113741f08fdfc3ec5de918930468598
2018-02-26 14:58:39 -08:00
James D. Forrester 4dfacbbca7 Follow-up 89c0fb9d2: Consistency, consistency
Change-Id: I4e1efe4570cdd9595c2480309d771e036362bdb9
2018-02-26 14:57:36 -08:00
James D. Forrester 89c0fb9d25 Follow-up e19092240: During the config cut-over, don't graduate 2017WTE
In e19092240 the ability to configure the 2017WTE to be "graduated" out of
beta and available to all. However, for a week of config cut-over, this is
re-using a config switch which previously gated the beta feature, and so
will be immediately available to all users until we put it back under beta
when Ie13215bd is deployed. Oops.

Change-Id: I1bc556849a6eb1e895f03412a9cb78002c8a0aee
2018-02-26 14:00:20 -08:00
James D. Forrester e190922403 Make it possible for wikis to have the 2017 wikitext editor by default
Bug: T150578
Change-Id: I1cb47a044c9c8ee58229d83ee98dbdd1f07af9de
2018-02-26 20:23:14 +00:00
James D. Forrester 4ede488647 Simplify 2017 wikitext editor config when Beta Features is enabled
Depends-On: Id12e08f9dca0a6676488a255480670e9badeb300
Change-Id: Ibe031f0ce5a7b06aa4b8f6d59c2a85b873b8e35b
2018-02-26 12:27:19 +00:00
Ed Sanders ec8208d125 Follow-up Idbcb76f: Only apply /includes folder fix to local path
Also use dirname(__DIR__) instead of appending ../

Change-Id: Ie88fb03617b25a675e1f4af97f8cb7c29c2fb8b3
2018-02-12 21:59:22 +00:00
Jayprakash12345 936dbda876 Update at-ease calls in extensions
Bug: T187037
Change-Id: Ifbba289cc78eb005fa974cdb941b17335974ec78
2018-02-12 19:20:59 +00:00
David Lynch 468c913cb9 ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call
9770c806 missed updating this call; update it to include bodyOnly parameter.

Bug: T186884
Bug: T186934
Change-Id: I616101f6bf3bd0b3af2236207c2ac217988d1724
2018-02-10 17:07:55 +00:00
James D. Forrester 7bd26fb361 Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs
Bug: T186903
Change-Id: Idbcb76f54eb57b0a56b46188526858038d698627
2018-02-09 10:32:41 -08:00
James D. Forrester fa9438e5fa build: Move PHP files to expected paths
Principal code is in includes/*.php with the file named the same as the class it
contains. The maintenance script is moved to maintenance/ for clarity.

Change-Id: Icb4cdffb1bd4716e14f883d667def96671b42992
2018-02-07 12:31:08 -08:00