Commit graph

12409 commits

Author SHA1 Message Date
David Lynch d28819f795 ui.MWLinkAnnotationInspector: skip internal link checking if the value has changed
If the value has changed since the event was fired, we're operating on old
data, *and* another event will have been fired for that change anyway. So
abort this check.

Bug: T146306
Change-Id: Ia6682ec0218fd3fbc573582753d815a56963eb71
2016-09-22 11:23:48 -05:00
jenkins-bot 80618cc629 Merge "dm.MWInternalLinkAnnotation: Fix href normalization for special characters" 2016-09-22 16:19:12 +00:00
Roan Kattouw bb45d984ca dm.MWInternalLinkAnnotation: Fix href normalization for special characters
<a href="Foo%3F"> would dirty-diff to <a href="Foo?"> and also render
as such, pointing to the wrong page.

We also called decodeURIComponent() on the href twice, which can't
have been good.

Move URI decoding and underscore normalization into
getTargetDataFromHref(), and add rawTitle for callers that need it.
Put rawTitle in the origTitle attribute, so that equivalence
comparisons (decode(origTitle) === title) work as intended.

Bug: T145978
Change-Id: I29331a4ab0f8f7ef059c109f6813fa670a2c7390
2016-09-22 09:10:41 -07:00
Matthias Mullie 2b4948b0b6 Change mid-upload 'cancel' button to 'back'
Bug: T114938
Change-Id: I964708e1267223b181630b9bea5b19e2bdf242be
2016-09-22 16:13:57 +02:00
jenkins-bot 6d583291bb Merge "Only unregister WT string handler in WT handler factory" 2016-09-22 04:09:18 +00:00
jenkins-bot a44a4d402e Merge "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" 2016-09-22 03:01:54 +00:00
Kunal Mehta c0cf9c1e75 Don't re-implement EditPage::getCopyrightWarning()
Bug: T144364
Change-Id: I72d6ac9e41211384c8dc777cf42c5fed49358471
2016-09-21 19:07:57 -07:00
Ed Sanders e56ed2274d Only show NWE beta feature if enabled in config
Change-Id: Iaa2e3620ab15ece136fe425e61b72f33c8d2f4b4
2016-09-21 13:24:04 -07:00
Ed Sanders d8fb7b84d3 Only unregister WT string handler in WT handler factory
Bug: T144653
Change-Id: I91528b56ac3905a05e8da51455055537958e026e
2016-09-21 13:08:10 -07:00
David Lynch 5bc54fd036 dm.MWInternalLinkAnnotation: Add some test cases
Change-Id: Ie338d5538959ea2cc296886b623e9dc2cd84fa8f
2016-09-21 09:57:45 -07:00
James D. Forrester 550a685d70 Update VE core submodule to master (e3192e2)
New changes:
05d7673 Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests
4ab9676 Localisation updates from https://translatewiki.net.
f657993 ve.ce.LinkAnnotation: Only set src on nails in Firefox
3ca658e ve.init.Target: Wrap floating toolbar init in rAF
e3192e2 ve.ce.FocusableNode: Wrap updateInvisibleIcon in rAF

Change-Id: I35cb872fee3eb9d3b415e03703876632cf396839
2016-09-21 09:55:58 -07:00
Ed Sanders 4c8a97f9e8 Temporarily override broken toolbar border colour
Will be fixed in the next OOUI release via I91862c2e609.

Change-Id: I741bb8d5396bed256ee1907eaa4ba86e4697f325
2016-09-20 22:51:02 -07:00
Alex Monk 2b8cd0fa13 Pass document to preview through PST
Change-Id: I2712c26c94cf62f8ec8e68a9912e6a557f41f6a4
2016-09-20 18:11:42 -07:00
Alex Monk 8a80b5bbc3 Split isAvailable from visual-specific checks
Not fully tested

Bug: T146182
Change-Id: I5d7ae6e49991660ecdc2daf46b319947f83a1018
2016-09-20 23:53:53 +01:00
jenkins-bot 089e22ff6c Merge "(attempt to) make NWE work with SET" 2016-09-20 22:45:14 +00:00
jenkins-bot f339754102 Merge "Education popup: Put localStorage check inside try/catch" 2016-09-20 21:44:53 +00:00
Alex Monk 63fcefcfcd Education popup: Put localStorage check inside try/catch
Bug: T146139
Change-Id: I5faf5f4fce2f3161ad62d3617d1bb1d750a44728
2016-09-20 22:04:53 +01:00
jenkins-bot 080d0ba8e1 Merge "Remove pre-1.25 API compatibility code" 2016-09-20 20:51:22 +00:00
Translation updater bot 7888fd05e5 Localisation updates from https://translatewiki.net.
Change-Id: I3a2e09923e60fecf9d3b57f01ad00585bd6e7b17
2016-09-20 22:41:42 +02:00
Brad Jorsch d7247efc90 Remove pre-1.25 API compatibility code
Since this extension uses extension.json, it already requires 1.25+ so
no need to keep the old code around.

Change-Id: Iff2eeb2bbfba15c84a4fcec85b6647c28886e9aa
2016-09-20 15:32:23 -04:00
jenkins-bot 42a2a4fd59 Merge "Merge transclusion and transclusion.core RL modules" 2016-09-20 01:00:20 +00:00
jenkins-bot 80e2b62c69 Merge "Simplify and fix category popup widget checks" 2016-09-20 01:00:17 +00:00
jenkins-bot f6b7c64e92 Merge "Open meta dialog to edit categories when user clicks on the category footer" 2016-09-20 00:58:29 +00:00
Volker E ecab9df8bb Update progressive color to WCAG 2.0 level AA compliant color palette
Aligning instances of `progressive` color to WCAG 2.0 level AA compliant
color palette similar to changes in
I6fdb90af8b9dc5e5e026eb0c1bd13138c73da4cd

Change-Id: I2eda190f0a68de6dc8aa33724f2c8975327a061f
2016-09-19 15:25:45 -07:00
Translation updater bot 7c3021dc88 Localisation updates from https://translatewiki.net.
Change-Id: I1fd2d120d3d595d4b1ce63e055fb61b82ed60273
2016-09-19 23:02:54 +02:00
Alex Monk 0c07caafc7 Open meta dialog to edit categories when user clicks on the category footer
Bug: T145267
Change-Id: Ie88c4d9c6327baffdb83c1affbc0515a68c0fc03
2016-09-19 21:35:45 +01:00
jenkins-bot 2d1a40c67d Merge "Fix missing dependency of ext.visualEditor.mwwikitext upon ext.visualEditor.desktopArticleTarget" 2016-09-19 18:17:33 +00:00
jenkins-bot 376a4520ea Merge "Use correct switch type when opening welcome dialog on NWE" 2016-09-19 18:16:59 +00:00
jenkins-bot 29ff6c43ef Merge "DesktopArticleTarget: Save scroll position before transformPage" 2016-09-19 17:00:00 +00:00
Translation updater bot 3af6091a58 Localisation updates from https://translatewiki.net.
Change-Id: I651c1febf65af00a07103806f428aacc4ef00648
2016-09-17 23:23:29 +02:00
Roan Kattouw cc8ca8e738 DesktopArticleTarget: Save scroll position before transformPage
transformPage() makes significant changes to the DOM, so measuring the
scroll position synchronously right after that results in a slow forced reflow.
Instead, measure the scroll position before reorganizing half the DOM.

Change-Id: I3baee5c11ca228696ddbfb30789745f5f0faa20a
2016-09-17 00:12:39 -07:00
Alex Monk edf5b60368 (attempt to) make NWE work with SET
Ugh.

Bug: T143578
Change-Id: I71e08508eb0914be9d624202b13a4369df512b80
2016-09-17 03:36:47 +01:00
jenkins-bot 0e8e7d17eb Merge "Avoid RequestContext::getMain()" 2016-09-16 16:41:44 +00:00
jenkins-bot 6ca113a83f Merge "Remove unused ContentHandlerDefaultModelFor hook" 2016-09-16 16:40:27 +00:00
Željko Filipin f3f432e722 Disable failing Selenium tests
The tests are failing with RSpec::Expectations::ExpectationNotMetError
for 2-3 days in a row.

Bug: T145861
Change-Id: Ieec2a67857b90033cdd0ddf63025d2af9de504a5
2016-09-16 13:12:02 +02:00
Kunal Mehta b42292fa0b Avoid RequestContext::getMain()
Change-Id: I7802ad88ec7a86d2323f3c582cadf8d80d53ab7d
2016-09-15 18:17:51 -07:00
Kunal Mehta 04f2027d77 Remove unused ContentHandlerDefaultModelFor hook
This was supposed to be removed in 7f02824ec4 except it got missed
somehow...

There was nothing registering it in extension.json, so it was entirely
unused.

Change-Id: I991c464ef0b60543a0ecd4cb1f9dda62e9d73dd4
2016-09-15 18:17:40 -07:00
Translation updater bot d4177b929d Localisation updates from https://translatewiki.net.
Change-Id: I5caaa5d69075922483a3c354d921ceb34517b9bd
2016-09-15 23:05:10 +02:00
Alex Monk 98a42ad1a9 Fix missing dependency of ext.visualEditor.mwwikitext upon ext.visualEditor.desktopArticleTarget
Change-Id: I029ef5faa6490bfab2c71b1df81c51a5b7494b84
2016-09-15 01:30:07 +01:00
Alex Monk 926212dbae Use correct switch type when opening welcome dialog on NWE
Bug: T145225
Change-Id: I032652733576d1a9797cc3dbb3dd24ca69cb30e5
2016-09-15 01:30:01 +01:00
Translation updater bot 1d297d8bc1 Localisation updates from https://translatewiki.net.
Change-Id: I0c5603dd7f98780c10fb58a4a357a3bbc5f702b6
2016-09-14 22:38:50 +02:00
jenkins-bot 8915106f01 Merge "Don't allow auto-enroll of new wikitext editor Beta Feature" 2016-09-13 23:58:45 +00:00
jenkins-bot 2fb10700b3 Merge "Update VE core submodule to master (ed76839)" 2016-09-13 23:54:42 +00:00
James D. Forrester 59bd5393dc Don't allow auto-enroll of new wikitext editor Beta Feature
Change-Id: Icc8e27a8e2a7d88fbbdeaf31b1ef8a5f5c85311f
2016-09-13 14:52:25 -07:00
jenkins-bot f0a819455e Merge "Load icons where we can via RLIM" 2016-09-13 21:21:22 +00:00
L10n-bot f7bc202df1 Merge "Localisation updates from https://translatewiki.net." 2016-09-13 20:58:17 +00:00
Translation updater bot ce77acda5a Localisation updates from https://translatewiki.net.
Change-Id: I6d8b7495b94acacad438abb949d5c8573bd80ea4
2016-09-13 22:58:14 +02:00
James D. Forrester 2b7827869d Update VE core submodule to master (ed76839)
New changes:
7a06bb7 Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo
db9b7a7 Make ve.dm.Transaction plain data by removing the .doc property
62c662c Localisation updates from https://translatewiki.net.
455e949 TableKeyDownHandler: return early if any modifier other than shift is used
9440e38 Localisation updates from https://translatewiki.net.
ed76839 Update OOjs UI to v0.17.9

Change-Id: I70a6387e6ea6d986ed132998df592f12274adf1a
2016-09-13 13:49:43 -07:00
James D. Forrester 36d13a845d Follow-up bfc3ac69: Align with coding conventions
Change-Id: I059cbd5ff3d693230567bb9267b01df491b3e2f8
2016-09-13 08:15:09 -07:00
jenkins-bot 9675eb9bbe Merge "Avoid DBPerformance log warnings due to isBlockedFrom()" 2016-09-13 04:38:36 +00:00