Commit graph

14281 commits

Author SHA1 Message Date
Ed Sanders a1dffa2dd7 Only use pre-computed measurements for position loading bar
Change-Id: I5fc17a432de8030a6154c4e961ac10c73f391a79
2018-03-16 15:39:21 +00:00
Bartosz Dziewoński faa0bfb0f7 VisualEditorDataModule: Remove 'minoredit' and 'watchthis' messages
These messages are used for the checkboxes when saving the page.
But we don't actually use the data from this module; we get them
from the 'action=visualeditor' API in the 'checkboxesMessages'
property. This is necessary because MediaWiki extensions can add
extra checkboxes (e.g. FlaggedRevs), so a static list won't do.
These are unused since 393807462e
(2013) and it is confusing to keep them here.

Change-Id: Ia4ed2142292c3a22623f498c7f43ce590f167709
2018-03-16 01:33:28 +01:00
Bartosz Dziewoński 13d77ba557 Remember 'checkboxesMessages' when storing document state
Bug: T188796
Change-Id: I4785fe2fb7df774735c1bd48c222540a0286dd44
2018-03-16 01:14:29 +01:00
Translation updater bot e436754812 Localisation updates from https://translatewiki.net.
Change-Id: I1768fd9e3f0dac24573fd39813788d648c33ae8f
2018-03-15 22:52:22 +01:00
Željko Filipin 86eeb89809 build: Use commons_upload v1.2.1 Ruby gem for language screenshots
This version is more robust. It reports common problems like
fileexists-shared-forbidden and fileexists-no-change.
In case of trouble it reports the error and goes to the next file.

Bug: T189122
Change-Id: I510ba7d378cb71b177a54d2ba771c51fbdead90f
2018-03-15 17:32:47 +01:00
jenkins-bot c8a04065e0 Merge "build: Use new version of commons_upload Ruby gem for language screenshots" 2018-03-15 10:32:11 +00:00
Translation updater bot 2f519293bc Localisation updates from https://translatewiki.net.
Change-Id: I0913131f1c274bef9be557dffd42eac94fa6bf9a
2018-03-14 22:23:56 +01:00
Bartosz Dziewoński a021482b6f Update VE core submodule to master (dc5a65131)
New changes:
8d8030fd1 Localisation updates from https://translatewiki.net.
37302d389 Show timeout message if diff times out
4fa6e3005 ve.dm.Converter: Handle meta nodes for empty annotations same as normal
f74c630d6 ve.Node: Make #getOffsetPath not fail while rebuilding the document
bd62f3e74 Fix global overlay classes

Bug: T180842
Bug: T187690
Bug: T189118
Change-Id: Ieb404db788bd9ff743f00131458c44f01deac466
2018-03-14 20:55:40 +01:00
jenkins-bot 98d240334d Merge "Use action=compare for wikitext diffs" 2018-03-14 19:19:14 +00:00
jenkins-bot 1d227935d9 Merge "Autosave: only try to remove autosave on teardown if the surface exists" 2018-03-14 19:17:30 +00:00
jenkins-bot 71901413ff Merge "DesktopArticleTarget: Add explicit dependency on 'mediawiki.storage'" 2018-03-14 19:13:56 +00:00
jenkins-bot 79f27a5447 Merge "Clear VE autosave whenever WikiEditor is loaded" 2018-03-14 18:25:48 +00:00
jenkins-bot 3c861d7ed1 Merge "Clear auto-save when switching to fallback wikitext editor" 2018-03-14 17:55:44 +00:00
Bartosz Dziewoński dc9b7170e3 DesktopArticleTarget: Add explicit dependency on 'mediawiki.storage'
This happens to work correctly because we depend on 'mediawiki.user',
and that depends on 'mediawiki.storage'. This is just an implementation
detail though and could change.

Change-Id: Ia23c83ae73bfbcc65b4a169bddf861d83691822e
2018-03-14 18:48:10 +01:00
David Lynch 9762b096c8 Autosave: only try to remove autosave on teardown if the surface exists
It's possible for some load failure states to cause this teardown at a point
without a surface. I observed it in MobileFrontend, when restbase can't be
contacted.

Change-Id: I13489640759c73dad5730d0bbadbfb2a38cb8e53
2018-03-14 11:53:10 -05:00
Ed Sanders d0eafd6b8d Restrict width of diff feedback button mobile
Change-Id: Ia4ceb73efb76d7714102619fce9cd87cf34216f9
2018-03-14 14:32:37 +00:00
jenkins-bot 670f39790f Merge "ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError()" 2018-03-14 09:29:18 +00:00
James D. Forrester f9ab5fa6fe ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError()
Bug: T189205
Change-Id: Ic75594c0a9388814b4ecc887c4262cbbe858d7f9
2018-03-14 10:21:03 +01:00
jenkins-bot e4a8c0b61b Merge "Attach deactivate code to namespace tab ('Main'/'Article')" 2018-03-14 09:19:16 +00:00
Željko Filipin a17ff98216 build: Use new version of commons_upload Ruby gem for language screenshots
The new version has many improvements, including not breaking when the file exists and upating file
description.

Bug: T189122
Change-Id: Ib4b42c9f663bafbbfb0c96e5fb4d9d5f162d2265
2018-03-13 13:41:32 +01:00
Ed Sanders c6653b6a2d Show page title in preview
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
2018-03-13 10:15:16 +00:00
Translation updater bot 327a4191aa Localisation updates from https://translatewiki.net.
Change-Id: I5c9243182a791a13eb41ae595f3a2e7d572f4608
2018-03-12 22:25:40 +01:00
jenkins-bot 540cb864ca Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image" 2018-03-12 12:28:10 +00:00
Ed Sanders e0419f8388 Autosave section title when adding new section in source mode
Change-Id: Idcbe2f12e3eb0bb85e2c986885bd8084b16dbe5b
2018-03-12 12:25:12 +00:00
Translation updater bot e47bc9559a Localisation updates from https://translatewiki.net.
Change-Id: I8cfc4aa4d0b386592a6e9dad51ac8ed502cc4353
2018-03-11 22:31:26 +01:00
Ed Sanders 4fc2b32b17 Disable visual diffs on source mode section edits
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
2018-03-10 22:54:54 +00:00
Ed Sanders 2b033f6ee0 Use action=compare for wikitext diffs
Diffing in action=query is deprecated since 1.30.

Bug: T189397
Change-Id: Ic1fecd4517a1410e3c8e3593a031ad7b8ffb57d4
2018-03-10 22:32:02 +00:00
Translation updater bot 5e58c6264a Localisation updates from https://translatewiki.net.
Change-Id: Ia3b692abdbe2d2102fc6403093ac74ca8af7761c
2018-03-10 22:14:32 +01:00
Ed Sanders e78379a395 Attach deactivate code to namespace tab ('Main'/'Article')
Bug: T189380
Change-Id: I9f05722b9a1c740f9f982d9c5690d48046f19fdd
2018-03-10 19:07:11 +00:00
Ed Sanders c3c3c60f1f Clear VE autosave whenever WikiEditor is loaded
Bug: T189381
Change-Id: I21a76dc32327d6c6e72a793d9b579cb7b6a5e32e
2018-03-10 18:34:17 +00:00
Ed Sanders ec6d9b235a Clear auto-save when switching to fallback wikitext editor
Bug: T189381
Change-Id: Id89fa2a673ad8aef3826c0ef862770bf522bbdcf
2018-03-10 18:04:44 +00:00
jenkins-bot 2ae3f5f1c2 Merge "ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption" 2018-03-10 17:28:34 +00:00
Bartosz Dziewoński 3c676013f8 ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image
Currently this only handles the caption, but there will be more.

Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
2018-03-10 17:16:16 +00:00
Bartosz Dziewoński 26e7728272 ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption
Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.

Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).

The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.

Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
2018-03-10 17:16:16 +00:00
Ed Sanders 9678cdc7c8 Factor out isSaveable method from updateToolbarSaveButtonState
Change-Id: Ic1922ed26bae26a76e8149d48f3fb27fa9ba4330
2018-03-10 16:20:30 +00:00
Ed Sanders 8b208c80d5 Remove unnecessary attachToolbarSaveButton override
It's identical to the code inherited form ArticleTarget.

Change-Id: I7fe7a48b0614f2ac2665ece042bb95a6f77303ad
2018-03-10 16:20:30 +00:00
James D. Forrester c493cafef5 Update VE core submodule to master (01609bfaa)
New changes:
01609bfaa Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML

Change-Id: I9d70f9827cb84d01f7e172e444fa33cf7921ddfd
2018-03-10 13:53:35 +00:00
jenkins-bot 00eb598352 Merge "Update rel attribute checks to be aware of multiple rel values" 2018-03-09 21:44:53 +00:00
jenkins-bot 04e5f6f208 Merge "LinkCache: styleParsoidElements find mw:WikiLink with ~=" 2018-03-09 21:44:52 +00:00
L10n-bot 08c852a6a8 Merge "Localisation updates from https://translatewiki.net." 2018-03-09 21:44:11 +00:00
Translation updater bot d8f196b833 Localisation updates from https://translatewiki.net.
Change-Id: I82bb56ddc586d46246fc62b69cefd8007951c7eb
2018-03-09 22:42:23 +01:00
jenkins-bot 0be5ab3984 Merge "Update VE core submodule to master (3aabb95af)" 2018-03-09 21:40:06 +00:00
jenkins-bot fe6839f396 Merge "i18n: Sort messages alphabetically for easier updates" 2018-03-09 17:39:52 +00:00
James D. Forrester 77c83c3ac2 Update VE core submodule to master (3aabb95af)
New changes:
3aabb95af DiffElement: Allow rich content for change descriptions

Bug: T188389
Change-Id: I7c8a1ba31f9ee811a5c299113bb463500cb63082
2018-03-09 10:18:13 +00:00
jenkins-bot a6ebfaec29 Merge "ce.MWTransclusionNode: increase invisible selector specificity" 2018-03-09 09:24:13 +00:00
libraryupgrader 283cf053e4 build: Updating jakub-onderka/php-parallel-lint to 1.0.0
Change-Id: Ieda87cf26697a6f8f9ce24398be8e0d569c4b7c8
2018-03-09 02:41:19 +00:00
David Lynch b6c6d10d1e ce.MWTransclusionNode: increase invisible selector specificity
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.

Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
2018-03-08 19:27:52 -06:00
Translation updater bot fc0467a26d Localisation updates from https://translatewiki.net.
Change-Id: I925e6d0285f01cc6c53d1e97b3ed713af844db9c
2018-03-08 22:46:15 +01:00
jenkins-bot 6028ad9e37 Merge "Update VE core submodule to master (97bf37687)" 2018-03-08 20:43:56 +00:00
David Lynch 4e10d5b975 Update rel attribute checks to be aware of multiple rel values
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.

Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 14:34:56 -06:00