* Rename 'deactivate' to 'tryDeactivate' as it may prompts
the user to deactivate.
* Merge 'cancel' and 'teardownSurface' in to 'teardown',
extending the parent method.
* Rename elementsThatHadOurAccessKey to $saveAccessKeyElements
and move teardown to parent class where it is setup.
* Move toolbarSaveButton teardown to parent class where it is setup.
* Cleanup changeDocumentTitle
Depends-On: I9d97614695272dca6936ef6f3461178fcf0368a8
Change-Id: Ie998a04c21f6615b4415edf471310db5edca3b5a
New changes:
0aa3e79d2 Update OOjs UI to v0.23.3
0c00812bc Localisation updates from https://translatewiki.net.
0c062b9b2 Cleanup target teardown API
Change-Id: I41e07963a6565ed29752645ae8acf64350daa677
Also:
* Disconnect change event on this.input, which doesn't
get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
their body is empty.
Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
New changes:
ade04f53b Highlight locale substring match in language search
6b21b1962 Unify monospace font family stack
015d19968 Detach icon before updateInvisibleIcon
5092d2e8c Follow-up Iea80013: $attachable -> $bounding
a564d5ace Localisation updates from https://translatewiki.net.
84ec68dfb Make a clear API for setting inspector padding
Bug: T176636
Bug: T177080
Change-Id: Ia8fea335a41342fcdb86fd691966624ce57e95e3
Tests are broken most of the time. Ruby framework will be deprecated next month. Selenium tests
that are needed should be implemented in Node.js.
Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
This code is meant to fix up the tabs if wgVisualEditorTabPosition
was changed and we're seeing cached HTML with the tabs in wrong order.
But it seems it has never worked. `$caEdit[ 0 ].nextSibling` is a text
node and obviously not equal to `$caVeEdit[ 0 ]`, and vice versa for
the other case. The logic is actually correct, so let's fix it to skip
over text nodes.
Also, remove a stray 'eslint-enable' comment left over in
a0f934ed26.
Bug: T50017
Change-Id: I23663a9bfcfdbf52918452c878a128e6960b1191
Vector no longer does the silly thing where the tabs are reversed in
the HTML in RTL languages, so we must remove our hack to do the same,
since otherwise it reintroduces the issue it was intended to prevent.
This essentially reverts 2efd4f0061.
Bug: T50017
Change-Id: Ibeaa55bc34899bffab849ea8ad8b127fb5184d43
New changes:
0a45d669c Replace constructive with progressive UI flag
4ff90218d ve.ce.Surface: Fix typo in documentation
605752edb Update OOjs UI to v0.23.2
7bcb9084b Do not setup inline slugs when rendering is locked
Bug: T176762
Change-Id: Ic8b8a0209306e4fabfbffd809d3f203cb1472cc9
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).
Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.
Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
