Commit graph

97 commits

Author SHA1 Message Date
Amir E. Aharoni 8da4c9b3cc [BrowserTest] Restore the indentation list screenshot scenario
* Add a class to the indentation toolbar button, similarly to what was done in
  Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
* Fix the definition of the indentation pull-down element acordingly.
* Restore the Indentation menu screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26

Change-Id: If2d92aab6d04aa487d6f753fa7cac94f8d8215c8
2015-01-27 13:35:39 -08:00
Amir E. Aharoni d20d70cdd6 [BrowserTest] Show the complete insert pull-down in screenshots
The "insert_pull_down" element only included the menu trigger.

Now it includes the complete pull-down with all the items.

This is consistent with other pull-down elements.

Change-Id: I3f6052eab1ee0322ebb7e6f2116e2d5d0e25f5b1
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 3f31715c09 [BrowserTest] Consistent names for variables that refer to down-arrow
Change-Id: Ib7c799af449a9427f6ba25403cbd6b2d220133f0
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 024481baae [BrowserTest] Simplify the Selenium selector for the Save button
The selector was very long and incorrect.

This patch simplifies and corrects the selector.

This also fixes the VisualEditor_save_dialog scenario
in the language_screenshots scenarios.

Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1
2015-01-27 13:35:39 -08:00
Amir E. Aharoni c80e311a02 [BrowserTest] Fix VisualEditor toolbar actions scenario
The save button changed from constructive (green) to progressive (blue).

Change-Id: Ic410d5ed3847da803d6d83df7f77b6e0edc5d81b
2015-01-27 04:15:51 +00:00
Cmcmahon 295f9f81b1 [BrowserTest] Add test for missing parameter error msg
Test checks for 'Required parameter missing' message, 'Go back'
and 'Continue anyway'.

Paired with Rummana writing this

Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
2015-01-14 16:04:12 +00:00
Amir E. Aharoni 7c128f9a4a [BrowserTest] Make the Save page element language independent
This element used the English label. It should just use
the class to be language independent.

I tested by running VisualEditor_save_dialog scenario
in language screenshots for the Persian language. It fails
on master because of the English label and passes with this commit.

Change-Id: I77955b3dfabbf6a15885c085e3fbdd447b04b4db
2015-01-13 13:05:35 +02:00
Amir E. Aharoni 7a4ec947fa [BrowserTest] Change the Heading menu item from a to span
Change-Id: I214f8dbc73e38073f6e8dedfb61d75b1e829fa38
2015-01-13 12:21:10 +02:00
Amir E. Aharoni cd4bd7a73c Add classes to toolbar UI elements
This cleans up the selectors for the elements on the toolbar
so that they can be tested.

Class names in the form of ve-test-* are added to elements
that have words for labels: 'Paragraph', 'Cite', 'Insert'.
There is no other way to look up these elements in the DOM
except using the UI text, but it is different in different languages,
so this is unusable for the language_screenshots job,
which is multilingual by its nature.

Bug: T76143
Change-Id: Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
2014-12-30 12:16:44 +00:00
Cmcmahon 4fbd141b49 [BrowserTest] update test for new selector
Change-Id: Ic3bc3b416bc7ddadef7a05699f6181c0b7b84cdd
2014-12-17 10:22:44 -07:00
Cmcmahon c34fd60a9b [BrowserTest] update general markup test
refactor for new locator

Change-Id: I089aebb64a9d67d01c1bfa4682927c0de2575051
2014-12-17 09:31:24 -07:00
Cmcmahon 30c3aa2242 [BrowserTest] update Links test
another iframe gone it seems

Change-Id: I33767706675bbdcd1cb45f33da109858ec36986e
2014-12-17 08:51:17 -07:00
ryasmeen@wikimedia.org 5eff6e8aa1 [BrowserTest]Fixing options test
Fixed the unique selector for failing cases
Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915
2014-12-16 17:36:50 -08:00
jenkins-bot 6ca0046599 Merge "[BrowserTest] changing the css paths for Cite options for fixing the tests" 2014-12-16 22:36:50 +00:00
ryasmeen@wikimedia.org aa77e8ab4f [BrowserTest] changing the css paths for Cite options for fixing the tests
Change-Id: Iea90e4bb656b30ec0839e6c843e30ba8ae1fd637
2014-12-16 15:33:37 -07:00
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
2014-12-15 21:37:42 +00:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
2014-12-08 10:43:35 -07:00
jenkins-bot 77b507dfc7 Merge "[Browsertest]Tests for options under Advanced Settings panel" 2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org 416d62df4f [Browsertest]Tests for options under Advanced Settings panel
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
2014-12-02 15:00:33 -08:00
Željko Filipin 15ed437331 [BrowserTest] Fixed a couple of page elements
Change-Id: Ia4652896243705651c86ff5f83dbd03029757705
Paired-With: Amir Aharoni
Bug: T76133
2014-11-27 11:39:02 +01:00
Bartosz Dziewoński e2d4f5b533 [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget
Change-Id: I70f44e71819e9147886bd70baf3460daf9ebbaf2
2014-11-22 01:56:29 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
2014-11-21 13:28:01 -07:00
Cmcmahon f6526cb0a9 [BrowserTest] comments for classes
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
2014-11-21 09:49:50 -07:00
Cmcmahon 473877202b [BrowserTest] rubocop change to an if()
Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc
2014-11-21 09:40:40 -07:00
Cmcmahon 95a798867c [BrowserTest] rubocop proper format for comments
Change-Id: I2fe136f29e0bc430420a0931092695d3f4147112
2014-11-21 09:21:53 -07:00
Cmcmahon 1b69fc97c7 [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense
Change-Id: Ia11c32c74acf4c2226f84ea566f4074b193f4e20
2014-11-21 16:15:58 +00:00
Cmcmahon ede14c75fb [BrowserTest] rubocop updates to replace double quotes with single
Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
2014-11-21 09:06:09 -07:00
Cmcmahon 2f05d1b10a [BrowserTest] more rubocop style fixes
Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1
2014-11-20 12:07:45 -07:00
Cmcmahon 65e4d91cf0 [BrowserTest] Rubocop style fixes
Change-Id: Ieb1ba49f2a987b41f82a3b66c542fba48313eb1f
2014-11-20 11:55:40 -07:00
Cmcmahon 513031c4bf [BrowserTest] locator changed
Change-Id: I3aeb1f60cf512c55f497f4ef6743b149bc0add43
2014-11-20 10:02:20 -07:00
Amir E. Aharoni a513ba9583 [BrowserTest] Fix the index of the insert menu
Change-Id: Id0e821d3cf01efff74fdb189cf09d24d9eb753e2
2014-11-20 10:52:47 +00:00
ryasmeen@wikimedia.org 6cce39ee10 [BrowserTest] Extend options test
Adding cases to test categories in options.feature

Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
2014-11-19 16:26:07 -07:00
Cmcmahon c49b2a77f2 [BrowserTest] once more
Change-Id: I34b4be6aadf991cf9d12c76fd8c8410697b2b500
2014-11-19 14:53:08 -07:00
Cmcmahon 6489767bc7 [BrowserTest] remove sleeps from shared tests
* remove dead code

Change-Id: Id95ff81746eb440124958bcc6dd9334b7ed299a4
2014-11-18 12:59:34 -07:00
Cmcmahon 94bab8f918 [BrowserTest] update transclusion test for Page Object vio and RS
Change-Id: Ie80dce2d117d4d2dc836681dcd9362ae565f2aa8
2014-11-17 14:59:14 -07:00
Cmcmahon fa02c60586 [BrowserTest] fix minor Page Object design violation
Change-Id: I75d282a7e176347b0995f2c2ccda8ab051aca270
2014-11-17 14:18:13 -07:00
Cmcmahon 4383dedcfc [BrowserTest] minor violation of Page Object design pattern
and RSPec syntax also fixed

Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
2014-11-17 14:07:16 -07:00
Cmcmahon 87ad037442 [BrowserTest] remove sleep() from template test
Change-Id: Ia564232e02db2e6be3070d98691097350e920a3b
2014-11-17 13:13:25 -07:00
Cmcmahon 1aa5d8905b [BrowserTest] remove sleeps from links test
Change-Id: Ib0e09735331dadd5bb494fe87683f6f08b6aee31
2014-11-14 12:30:13 -07:00
Cmcmahon 41aaaf4886 [BrowserTest] make bullets test modern
* remove unnecessary wait times
* remove unnecessary sleep() statements
* remove unused steps
* update for RSpec3.0 syntax

Change-Id: Ie76135154042834e2eb8b008872aced5ac210ee5
2014-11-12 10:55:37 -07:00
Vikas S Yaligar 901b0deeed [BrowserTest] Fixed failing language screenshot browser tests
Bug: 73033
Change-Id: Iea3a03b1ec628bfe03f10b4cb2a4795d4fabb8bc
2014-11-10 11:07:49 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
2014-11-05 15:39:10 -07:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
2014-11-05 10:01:55 -07:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
2014-11-04 15:01:45 -08:00
Cmcmahon 3b53b23fb1 [BrowserTest] no iframes for switch mode test
Change-Id: I99e4686144ded173f8d91be87f02a4c144284237
2014-11-04 08:06:33 -07:00
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
2014-11-04 07:46:24 -07:00
Cmcmahon 666001ba1c [BrowserTest] no more iframes for transclusion
Change-Id: Ifc50a50e98de18612e6ab4b548b1cf6ec05bc825
2014-11-03 16:27:17 -07:00
Cmcmahon aab1680244 [BrowserTest] no more iframes for switch modes test
Change-Id: Ifebc458f9ff9583954226d86759753b0314db649
2014-11-03 15:51:55 -07:00
Cmcmahon 396d74053b [BrowserTest] no more iframes for References
Change-Id: I7f5cf7b991cfcfd3ebebe0f17bb594802fe7dea0
2014-11-03 15:41:38 -07:00
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
2014-11-03 15:18:44 -07:00