Ed Sanders
a3433e67fd
Move modules loaded from DAT.init/TargetLoader to ResourceLoader
...
This will make it easier for third parties to load the required
modules for an article-like target.
Also cleanup mobileArticleTarget to better match desktopArticleTarget.
Change-Id: Idb75e2bd99d8cf2c298e101cf92e8af4f85f5ad5
2017-02-27 16:48:56 +00:00
David Lynch
b1d68872b0
DesktopArticleTarget.init: Don't hardcode single-tab accesskey
...
Bug: T156141
Change-Id: I1312283437714bf338a8ee3cf63e93ac67db1c45
2017-02-14 11:24:50 -06:00
Ed Sanders
6bd650d50a
Check for 'veaction' when clicking section edit links
...
Such as in the 'add topic' link.
Bug: T157104
Change-Id: Ide2d4cf8c23a5d0db24456d15b4312f7c0a5f922
2017-02-08 17:48:04 +00:00
Ed Sanders
7a058a4de8
Remove explicit toolbar indicator definitions
...
These are now computed upstream based on position of toolbar.
The menu tool now needs its indicator explicitly hidden.
Change-Id: Id2280f70553e1e45f3a42af45684c5808797925c
2017-02-04 10:25:37 +00:00
WMDE-Fisch
a0af0b0529
Disable VisualEditor in the TwoColConflict extension
...
As for the Translate extension this will read a global set by the
TwoColConflict extension to disable the VisualEditor and its hooks
on the modified edit conflict page there.
Bug: T156251
Change-Id: I164d1546c9d98d8715650e13c63a01d06c76315d
2017-01-30 14:06:59 +01:00
Ed Sanders
1df022a6d6
Ignore section edit links when no action present
...
BUg: T156282
Change-Id: If3d039da36db946dcbba123d3cdc4e99c45f6a4e
2017-01-25 18:13:56 +00:00
Ed Sanders
171286c120
Fix typo in target config
...
Change-Id: I5815ce5b0e05ce166e02bfcced520e3770f5453d
2017-01-20 23:15:23 +00:00
Ed Sanders
f58d00b110
Move #getWikitextFragment up to ArticleTarget
...
Change-Id: Ice4b04db4a45c07ccffc3892e6db5d814c2ec37b
2017-01-20 23:15:17 +00:00
Ed Sanders
1ae5c13cb9
Update VE core submodule to master (f0dcedb)
...
New changes:
5b448fa [BREAKING CHANGE] Merge Mobile/DesktopSurface into Surface
2d8959b Localisation updates from https://translatewiki.net .
7eee772 Follow-up 2d8959b: Fix build for added language 'io'
f0dcedb ve.dm.TableMatrix: Really indent ASCII-art comments
Change-Id: I62708f7caeb03b16cd318aab0b0ee3c674e75a26
2017-01-20 14:35:39 -08:00
Ed Sanders
889ffc0efc
DesktopArticleTarget: Prevent infinite while loop if $content is empty
...
Change-Id: I629b2c3f1a4af3441764db7d1d0a7cec96181396
2017-01-11 18:29:16 +00:00
jenkins-bot
09829ae7b4
Merge "MWMetaDialog: Move categories to the top as they're used most"
2017-01-07 14:56:56 +00:00
jenkins-bot
4d64196fcb
Merge "Fix loadFail parameter handling"
2017-01-04 22:46:27 +00:00
jenkins-bot
e91f8f913e
Merge "Allow 'T-' prefixed sections, and redirect if section link title isn't current page"
2017-01-04 22:38:34 +00:00
Alex Monk
1bcaa9056c
Fix loadFail parameter handling
...
Rename them while we're at it.
Bug: T151278
Bug: T152429
Change-Id: I435ac148007db87da69e8cf48568fafa646abb71
2017-01-04 22:31:08 +00:00
James D. Forrester
6795430831
MWMetaDialog: Move categories to the top as they're used most
...
Bug: T74399
Change-Id: I696d8484ed00c92340f178d5c9dcfe978998dce0
2017-01-04 11:18:00 -08:00
Ed Sanders
808de2acea
Add "templates used" page to meta dialog
...
Bug: T149009
Depends-On: Id617f9afbddf094140133f9659efc4b4e746148c
Change-Id: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6
2017-01-04 18:30:11 +01:00
Ed Sanders
b7dd6077b8
Allow 'T-' prefixed sections, and redirect if section link title isn't current page
...
Bug: T153176
Change-Id: Ic6fda78d00715777df4a273e7d3e150f20185185
2017-01-04 16:53:03 +00:00
jenkins-bot
1ac5ede187
Merge "Don't try to JSON stringify load error messages that are already strings"
2017-01-03 20:22:50 +00:00
jenkins-bot
4abdf21413
Merge "Also allow opening in source mode if VE is unavailable on action=edit"
2017-01-03 20:19:09 +00:00
jenkins-bot
a973528d67
Merge "Don't block VE/NWE from loading if 'editintro' is specified"
2017-01-03 20:13:29 +00:00
jenkins-bot
945d3d4cbc
Merge "After saving a specific section, scroll to it"
2017-01-03 18:49:19 +00:00
Alex Monk
5c2773539e
After saving a specific section, scroll to it
...
Bug: T153297
Change-Id: I233e5226abc44d5d0bf8e56957a133d595e7be6f
2017-01-03 18:38:55 +00:00
jenkins-bot
f439843964
Merge "Factor out preferred editor check"
2017-01-03 17:50:42 +00:00
jenkins-bot
f89a6a3880
Merge "build: Bump file copyright notices for 2017"
2017-01-03 17:11:04 +00:00
jenkins-bot
24d26f5e19
Merge "Move translate extension hack up to 'isAvailable'"
2017-01-03 17:04:11 +00:00
jenkins-bot
7c790f8d12
Merge "Use preferred number casting method"
2017-01-03 17:04:10 +00:00
James D. Forrester
122f49b2dd
build: Bump file copyright notices for 2017
...
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
2017-01-03 08:58:33 -08:00
Ed Sanders
fe85ee1ba6
Don't block VE/NWE from loading if 'editintro' is specified
...
Later we should actually show the edit intro, but that is a
separate issue (T56029).
Bug: T153481
Change-Id: I97622a3d86b975866305aaa745bac51f6b55f217
2016-12-31 15:22:11 +00:00
Ed Sanders
9eebfbcac5
Fix NWE-only edit tab
...
Change-Id: I5d08e30f43fbe08eb8809692728a8ab37f3a1491
2016-12-30 16:42:54 +00:00
Ed Sanders
3f47aec20b
Use preferred number casting method
...
Change-Id: I77215f2bdb6eb055375e5b803d23b6f26df2d8d1
2016-12-29 20:33:15 +00:00
Alex Monk
4af862e6d3
Also allow opening in source mode if VE is unavailable on action=edit
...
Bug: T153508
Change-Id: I5678d3b417c93707edc90bbb76ce4dafcd2098c6
2016-12-29 20:32:58 +00:00
Ed Sanders
c963b73e71
Factor out preferred editor check
...
Change-Id: Ic2e2e2e1d24dba8854315dff068ea9ce5d409c5a
2016-12-29 20:17:55 +00:00
Ed Sanders
7de023caee
Allow switching between 'edit source' and 'add topic'
...
Also between section editing and full page editing
by clicking on 'edit source'.
Change-Id: I9165a7ad4ac2a588a09532c7181ba72b6fd2f811
2016-12-29 15:48:38 +00:00
Ed Sanders
827d4185c4
Move translate extension hack up to 'isAvailable'
...
All modes of VE should be disabled on these pages.
Bug: T153445
Change-Id: I5adfae940ee35c5ee6712e620a0ddda967a542ad
2016-12-27 13:56:10 +00:00
jenkins-bot
d5f66e4fe9
Merge "Preserve checkbox data when switching from VE to NWE"
2016-12-22 12:37:37 +00:00
Ed Sanders
aee5e665f1
Preserve checkbox data when switching from VE to NWE
...
Bug: T153889
Change-Id: Ifc41ea9320c9f2627efff6f33d4ad87c59fad496
2016-12-21 22:35:52 +00:00
Alex Monk
101b0ff45c
Don't try to JSON stringify load error messages that are already strings
...
Change-Id: Ib180c3ac7eb62d351e05153defd6330c3397c478
2016-12-21 04:00:05 +01:00
Bartosz Dziewoński
72569159b8
Add comments in some places where we really want to treat messages as HTML
...
Change-Id: I439338dabd4b031ed1c4cfc9d89af5a6f2971676
2016-12-20 10:50:15 +00:00
Alex Monk
96b8d35bff
Wrap localStorage.getItem calls in try { ... } catch () {}
...
Bug: T153291
Change-Id: Ic4f8c390bfe6936bd182b28b1f2c6d19bf459eba
2016-12-15 23:08:30 +00:00
jenkins-bot
ee2cb3048d
Merge "DesktopArticleTarget: Generate the original page title if needed"
2016-12-15 16:50:47 +00:00
Ed Sanders
17a164363b
Properly clear this.section when switching from VE
...
Bug: T153276
Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
2016-12-15 01:34:30 +00:00
Ed Sanders
856d480f7d
Follow-up Ic1f1de26: Fix typo in edit tab selector
...
Change-Id: I0ac685f1d942a7d40c6926b8ae8d751db04e1474
2016-12-14 17:35:09 +00:00
jenkins-bot
593474912f
Merge "Fix logic for create accesskey=v, and bind to onEditTabClick"
2016-12-14 01:30:17 +00:00
David Lynch
b1aed096cb
DesktopArticleTarget: Generate the original page title if needed
...
When switching from the old wikitext editor to VE, we stored "editing..." as
the original page title. Then restored that when saving / switching to "read".
Instead, detect if we're on top of the classic editor, and use the pagename
message to make a plausibly-correct title.
Bug: T126077
Change-Id: Ib0289de71c3ae947ca0a3e45fe1e620378689c35
2016-12-13 19:28:15 -06:00
jenkins-bot
16c5d489fc
Merge "Don't restore scroll position when doing real section editing (NWE)"
2016-12-13 16:33:16 +00:00
Ed Sanders
db447733b0
Fix logic for create accesskey=v, and bind to onEditTabClick
...
Change-Id: I69020652f2946626c443ef5b724cf92e7905f247
2016-12-13 16:06:57 +00:00
Ed Sanders
d2ea716902
Don't restore scroll position when doing real section editing (NWE)
...
Bug: T152946
Change-Id: I969a8edd4f23bbe6c73855aac059df732102c560
2016-12-13 15:44:54 +00:00
Ed Sanders
69c0fb189a
Fix action=editsource URL rewriting
...
Always look for links unless the only tab is VE.
Bug: T153054
Change-Id: Ic1f1de26fb77098fe62f6263a25c8a40de0e09a7
2016-12-13 15:36:34 +00:00
Ed Sanders
1f3bb5c9e5
Add section= param to URL after loading target
...
This wasn't such a big deal in VE because we load the full
page anyway, but in NWE it is more annoying if you reload the
page and are dumped in a different edit area.
Change-Id: If49569cbe1a2759d8cbbd7ee42dd1b88da39a946
2016-12-13 15:31:57 +00:00
jenkins-bot
a962e7de3b
Merge "Support section=new in NWE"
2016-12-13 13:55:33 +00:00
Ed Sanders
5a8106773c
Support section=new in NWE
...
Bug: T150709
Change-Id: I1002b97060d642df0988da15860a36c13712bade
2016-12-13 12:20:55 +00:00
Ed Sanders
2d645d1631
Use Surface#setDisabled instead of deprecated #disable
...
Change-Id: Idf998ddc0b95efbf6befbcfa493c42b4c3ba1bfc
2016-12-10 20:03:07 +00:00
Ed Sanders
d555b5ba33
Cleanup handling of 'section' param
...
Provide a common function to parsing, and always pass
section to the target, instead of having the target
re-compute it itself.
Change-Id: If9fc24ffa51507cd969fa1b4dfc1519a0b50a572
2016-12-08 20:24:19 +00:00
Ed Sanders
cd87e7483b
Expand dummy surface to be at least valid
...
Change-Id: I3888dd2f72858bbe79c61fa4a6f7967f21c5cb7c
2016-12-08 19:36:57 +00:00
David Lynch
d720041fd7
DesktopArticleTarget: clear out originalCategories when they're updated
...
Bug: T152571
Change-Id: I41b5d5aeea0a01cf922924fa1320369d54fef8cf
2016-12-07 09:48:26 -06:00
David Lynch
af8aad0483
DesktopArticleTarget: Rebuild the category links when they're edited
...
This has to go to the API, because it's skinnable. Also, separates out a few
of the initial page setup functions so they can be re-applied to the new
content inserted.
Bug: T151651
Change-Id: I8d5a6504edc2e0486a0b4f016d8ee6d9a6228de9
2016-12-06 11:28:08 -06:00
Ed Sanders
aa7dba9bdb
Follow-up Ifaf6a2607: Display correct message when switching
...
Use new mode, not old mode for choosing switch message.
Change-Id: I1ad0913b4a23fd6fbf5cdeb07d1a58ec72398d57
2016-12-04 15:51:57 +00:00
jenkins-bot
36d976c4c0
Merge "Save Dialog: add shortcut for opening to the review panel"
2016-12-02 00:36:40 +00:00
David Lynch
2bd34cebd4
Save Dialog: add shortcut for opening to the review panel
...
Create a new MWSaveDialogAction, which can be hooked up to triggers. Switch
the existing save dialog accesskey to just use the trigger system.
(Maintaining all the accesskey logic, so we don't change the shortcut on
people.)
Bug: T149914
Change-Id: I9b4ef8504148703556f802b266a517dd5098c06b
2016-12-01 18:16:18 -06:00
jenkins-bot
e3c0a05b84
Merge "Prevent endless error loop if falling back to wikitext (after a load failure) fails."
2016-12-01 23:17:42 +00:00
Ed Sanders
218742d806
Update VE core submodule to master (ae30d71)
...
New changes:
f58ddea DiffElement: Use document slices with full internal lists
83800c0 DebugBar: Remove hard-coded i18n
b4f89e1 Update OOjs UI to v0.18.1
40c7bf6 Factor out active node functionality from SectionNode for captions
2d967be Move 'mode' property to surface, rename target property to 'defaultMode'
5d8c214 wrapAllNodes in sourcefragment
dd3d9e5 Refactor ve.dm.Transaction
9d61aca Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
df4f72a Make table caption node an active node
b79f72d Core source mode
7533ac4 Localisation updates from https://translatewiki.net .
ae30d71 SourceSurfaceFragment: Check range is not collapsed
Local changes:
Get edit mode from surface where possible
Depends-On: Iec758c1892d518ad4bc2c0d1aaf6ca00fa354323
Change-Id: Ifaf6a26078b2731b374aaad2cb40c08928de9c84
2016-12-01 10:40:01 -08:00
jenkins-bot
3d8a749cf2
Merge "init: Initialise 'active' property in mw.Target instead of subclass"
2016-11-22 23:35:10 +00:00
jenkins-bot
8370b98e3f
Merge "Move around code that sets up edit notices to ensure it runs after we receive the notices to display"
2016-11-22 23:27:26 +00:00
Alex Monk
16e294fba7
Move around code that sets up edit notices to ensure it runs after we receive the notices to display
...
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
2016-11-22 19:16:09 +00:00
Timo Tijhof
cde3d2a7f8
init: Initialise 'active' property in mw.Target instead of subclass
...
This is set to 'true' in mw.Target#setupSurface(), but not initialised or
used there in that class.
It was previous initialised in an indirect subclass (DesktopArticleTarget).
Move this to the parent class instead for clarity.
Change-Id: Ie3e12d254aa4b689fdce64620e110164311bc60a
2016-11-21 18:06:52 -08:00
Ed Sanders
7f2d5b5bee
Don't re-bind edit tab in DAT when using SET
...
In SET the tab's events are already bound in DAT.init.
Bug: T151258
Change-Id: I04529dbdea2d2ff5e52b0f11035a4ac11946617b
2016-11-21 22:09:26 +00:00
Ed Sanders
e1a887ccf8
Migrate DesktopWikitextArticleTarget code upstream
...
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
2016-11-20 02:52:14 +00:00
Alex Monk
86719eb90f
Prevent endless error loop if falling back to wikitext (after a load failure) fails.
...
Change-Id: Id48fa13a33aee9fabf857d20a75d26463c329f44
2016-11-16 18:52:26 +00:00
Ed Sanders
ff4761bbd9
Fix handling of failure to load visual mode
...
Reject the activating deferred making handleLoadFailure
redundant.
Fix logic for switching back to OWE aware of NWE.
Change-Id: I328fc944bb6b9152752742fe35c56b95e3255b88
2016-11-15 12:44:38 +00:00
Ed Sanders
b4ff55a38c
Always set mode when activating the target
...
Otherwise if the target was already loaded the mode will
not be changed, which can cause the wrong editor to load
in multi edit tab mode.
Change-Id: I64071dfdfc8511cce51bda20b9c62d7fc126c528
2016-11-15 12:44:38 +00:00
Ed Sanders
521c3c8436
Pass isModified when switching from VE to NWE
...
Bug: T150707
Change-Id: I9ae525aa7a5883bb45f91262db8abc082983ee1b
2016-11-14 23:05:21 +00:00
jenkins-bot
0c1eff31ef
Merge "Teardown the toolbar properly"
2016-11-14 17:26:54 +00:00
Ed Sanders
f2e0b408b4
Teardown the toolbar properly
...
Depends-On: I53a86bf5e0322dc9766ae4ddf31ff0ae5568df7e
Change-Id: If9cc876a57272679584ebc653cf2ee8e17ddb821
2016-11-12 14:28:11 +00:00
jenkins-bot
cf3c972a3a
Merge "Move NWE URL changes into JS"
2016-11-12 00:02:50 +00:00
Ed Sanders
b1b6f9836e
Remove redundant narrow-threshold calculation
...
This is done upstream in OOUI.
Change-Id: Icc0e535f9d1113a14d2c1cc275efebbc98e3a38c
2016-11-11 18:54:30 +00:00
Alex Monk
807cb6b54e
Move NWE URL changes into JS
...
Bug: T148077
Change-Id: Ic9b94184a48026254cf4a0a812fe6fc8455841b5
2016-11-11 18:31:22 +00:00
Ed Sanders
6f8e0d9699
Replace confirm with OO.ui.confirm
...
Also enable no-alert eslint rule to prevent alert/confirm/prompt
being used in the future.
Change-Id: I2851e1f58c1861f75dbb20192e5cf6c343da75db
2016-11-11 13:13:58 +00:00
James D. Forrester
26e7267f02
ArticleTarget: Use an OOUI MessageDialog, not window.alert()
...
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.
Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
2016-11-10 12:55:49 -08:00
jenkins-bot
28787b0f3c
Merge "Rename methods used for setting up multiple edit tabs"
2016-11-09 00:45:01 +00:00
jenkins-bot
45a75047fa
Merge "Move save dialog checkbox code up from DAT into ArticleTarget"
2016-11-08 17:14:45 +00:00
jenkins-bot
efb4133119
Merge "Use onEditTabClick handler in SingleEditTab"
2016-11-08 17:10:06 +00:00
Ed Sanders
55fcded32e
Replace non-standard whitespace in comments
...
This is required to pass eslint:recommended.
Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
2016-11-08 14:15:12 +00:00
Ed Sanders
2fa4cfef16
Rename methods used for setting up multiple edit tabs
...
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
2016-11-08 12:47:30 +00:00
Ed Sanders
f6a205d77f
Use onEditTabClick handler in SingleEditTab
...
Gives us extra functionality like checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.
Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
2016-11-08 12:39:15 +00:00
Alex Monk
e81c6e5b43
Move save dialog checkbox code up from DAT into ArticleTarget
...
So it applies to MobileArticleTarget.
This shows the checkboxes on mobile.
Bug: T148914
Change-Id: Ib6559d5601004e58b72903805059e04f42acc85f
2016-11-05 06:24:49 +00:00
Alex Monk
7c80976f5b
Remove 'vesection' parameter
...
Just use the normal section parameter, haven't been able to figure out why VE
would need to be special about that.
Bug: T149958
Change-Id: I9338d0f1498fbb579fa8c340d6e7274c6d48155b
2016-11-05 02:08:13 +00:00
jenkins-bot
b6d3dabfbf
Merge "Add binding for when only tab is new wikitext editor"
2016-11-02 21:36:21 +00:00
jenkins-bot
65236ae67f
Merge "Try to make client and server code to get last editor work the same"
2016-11-02 20:07:07 +00:00
jenkins-bot
254e77a296
Merge "Set section to null when switching from NWE to VE"
2016-11-02 19:45:14 +00:00
Ed Sanders
3fb757c307
Add binding for when only tab is new wikitext editor
...
Bug: T149796
Change-Id: I675c5876fbb9ca8427983e9d4252cccda35775f9
2016-11-02 19:10:28 +00:00
Ed Sanders
56679dfb35
Set section to null when switching from NWE to VE
...
This prevents the discard warning from being shown if the user
switches back to NWE then back to VE, as by this point they
have left section editing.
Change-Id: I734684c54a8900aab3332ed8421cb42f7f845738
2016-11-02 15:53:29 +00:00
Ed Sanders
7db58ab3d8
Fix binding of onEditTabClick to section links in SET
...
Bug: T149797
Change-Id: I0f753718ccddb9c2b68cdc82ff379bd59d7006ad
2016-11-02 15:50:30 +00:00
Ed Sanders
e655880d14
eslint: Remove unused exception and fix documentation errors
...
Don't enable valid-jsdoc yet though, due to @chainable bug.
Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
2016-10-28 12:02:36 -07:00
James D. Forrester
36befda61c
build: Replace jscs and jshint with eslint
...
It's new, it's fresh, it's amazing, it's here.
Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
James D. Forrester
c45c79eca2
ve.init.mw.DesktopArticleTarget: Fix missing '&&'
...
Change-Id: I0e91cde3d38d3f5bdd7dde790093db21d8a64036
2016-10-27 16:53:55 -07:00
Ed Sanders
244eeb9ea1
Update VE core submodule to master (e4c8003)
...
New changes:
e4c8003 Bring in target 'mode' property from MW
Local changes:
Use upstream Target#setMode functionality
Depends-On: I9d501cb77c714fbd299b5816d302b0bdde7833cd
Change-Id: I2fcda6ca7d82d880101d9ba2a027d4ef066aa238
2016-10-27 16:12:31 -07:00
Ed Sanders
fad3b429c8
Make meta dialog tools visibile but disabled in NWE
...
Following our unwritten rule of trying to keep the interface
as consistent as possible.
Change-Id: I58668acb5bac12de73b7b8f52e670f68336c399f
2016-10-27 14:48:51 -07:00
Ed Sanders
dc902b4c93
Pass edit token when saving/diffing in new wikitext editor
...
Change-Id: Ia14a4d204e367a3d0d46165a51b0cdc6fc3d57e7
2016-10-26 17:39:14 -07:00
jenkins-bot
3c443724e2
Merge "Follow-up I64a8ed73: Fix NWE getWikitextFragment"
2016-10-26 23:57:44 +00:00
Alex Monk
53f8aac0d5
Follow-up I64a8ed73: Fix NWE getWikitextFragment
...
Also fix the rejection Deferred line if things go wrong
Change-Id: I8f060de1972dd0ae79c81162c61efd5956e48955
2016-10-27 00:37:22 +01:00
jenkins-bot
3750081797
Merge "Don't show confirm dialog when switching to NWE"
2016-10-26 21:48:15 +00:00
jenkins-bot
60565711ff
Merge "Fix handling of API responses"
2016-10-26 20:42:35 +00:00
jenkins-bot
035987b9be
Merge "Create init.isWikitextAvailable and add page content check"
2016-10-26 20:42:06 +00:00
jenkins-bot
b5317b694f
Merge "Fix edit source links for NWE"
2016-10-26 00:25:22 +00:00
Ed Sanders
460df1f25f
Don't show confirm dialog when switching to NWE
...
Bug: T148099
Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed
2016-10-25 17:20:16 -07:00
Ed Sanders
de2f07d523
Fix handling of API responses
...
NWE can return data in 'visualeditoredit' instead of
'visualeditor'. We may want to change this later.
Also restore removed hack code that popuplates missing
VE API data when requesting wikitext.
Change-Id: I9a782a85444d37a3e21c071db7e175ee9b0b1c4f
2016-10-25 17:20:16 -07:00
jenkins-bot
b341e3406a
Merge "Fix arguments passed to requestPageData when switching"
2016-10-26 00:04:34 +00:00
Ed Sanders
7b9229f5b8
Fix toolbar transition
...
The contents of the bar to should appear to move in to place, not
just be revealed.
Change-Id: I01a85e3455462cf70b6c3f25a236ab6cb82c706c
2016-10-25 15:55:41 -07:00
Ed Sanders
702f931ef2
Fix arguments passed to requestPageData when switching
...
Change-Id: I890d782829fd077096be364c26a41b56ec4a2df3
2016-10-25 15:52:52 -07:00
Ed Sanders
e977ca4336
Fix edit source links for NWE
...
We fixed these to use vesection instead of section.
Change-Id: I0aa6530b6707239c41216421394379301b0878a7
2016-10-25 15:50:14 -07:00
Ed Sanders
751853942f
Create init.isWikitextAvailable and add page content check
...
Bug: T149007
Change-Id: I2e16c6361c32f3c1ebd2ae7c9f41089d56b67b06
2016-10-24 15:36:44 -07:00
jenkins-bot
50e102da0c
Merge "Send RB errors through the normal error handling process"
2016-10-20 23:01:02 +00:00
jenkins-bot
0f566448ed
Merge "Switch to the wikitext editor if VE fails to load"
2016-10-20 23:01:01 +00:00
Ed Sanders
2dfdd82317
Prevent edit source from acting twice
...
Bug: T148309
Change-Id: I5ef3f4b7cbc7298e89aa531c174657b1d1bccdf6
2016-10-16 19:06:06 -07:00
jenkins-bot
23eb869d9d
Merge "Get rid of ?venotify= from URL post-save"
2016-10-14 23:30:16 +00:00
Alex Monk
b5815e9ffd
Send RB errors through the normal error handling process
...
Change-Id: I230ff6d3c9a6a183fb483f5adfd7ccdc025a07af
2016-10-14 11:17:56 -07:00
Alex Monk
39aa3021a7
Switch to the wikitext editor if VE fails to load
...
Also kill some dead HACK code in DesktopWikitextArticleTarget#switchToWikitextEditor
Bug: T135748
Change-Id: Ie5aaa0f3c3bd20755abaac9b86af015b71eb777b
2016-10-14 18:15:16 +00:00
jenkins-bot
246e2ebb4e
Merge "Tidy up DAT load failure handling"
2016-10-14 00:32:30 +00:00
Alex Monk
70bf00e9b0
More NWE-SET integration fixes
...
Also stop calling $skin->getUser() so much, store the result
Change-Id: Ic91a660bc4b97a82f1d2b0bffb55425564696da1
2016-10-13 22:46:16 +01:00
Alex Monk
49283f7250
Fix typo in DAT.init.js
...
Change-Id: I75f7de16ea06d62a1bdfa0e04294fef5560fd5c9
2016-10-13 22:22:57 +01:00
Alex Monk
6b87b2671e
Fix another case where we need to pass the section
...
Bug: T144654
Change-Id: I5f91b9329525ceaeb971d02f93c959d908d748f7
2016-10-13 20:28:21 +01:00
Ed Sanders
4040442ad8
Section editing in NWE
...
Bug: T144654
Change-Id: Ida6e721e0d980b47e3fda6a1f0744cbce1b2235a
2016-10-12 12:55:11 -07:00
Kunal Mehta
6c93a49244
Get rid of ?venotify= from URL post-save
...
Use history.replaceState if available to get rid of the venotify query
parameter to avoid polluting URLs.
Ideally this would just use a cookie like the core post-edit
notification.
Change-Id: I6ce142012053e2fc18dd44fd0f7b82914acea076
2016-10-12 11:05:12 -07:00
Ed Sanders
4fc2904a87
Follow-up I9547dfd: Only enable VE tabs if VE is available
...
Otherwise VE is launched on namespaces where it is disabled
(but NWE is enabled).
Bug: T147890
Change-Id: I62f4ff96b991553a4eb0be9efb2e84bc80ca2bb4
2016-10-11 14:19:36 -07:00
Ed Sanders
605f7b625b
Hid category links in source edit mode
...
Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
2016-10-07 16:24:23 -04:00
jenkins-bot
7551b0e788
Merge "Use createTextNode in wikitext converter"
2016-10-06 23:20:21 +00:00
Ed Sanders
01ed8e954e
Use createTextNode in wikitext converter
...
Has better browser support. innerText is for getting the
text as rendered.
Bug: T147584
Change-Id: Ie2cf732d537aa4053d5b45d85c2d678a0d338017
2016-10-06 14:50:08 -04:00
Ed Sanders
aa7da97f2d
Use safer batchPush in converter
...
Some older browsers may fail with >1024 arguments. This
does not have a noticeable effect on performance.
Change-Id: I8c85f43425997735bbbe08d27374b79502e02ecf
2016-10-06 13:19:00 -04:00
Alex Monk
d2dd3689cf
Tidy up DAT load failure handling
...
Get rid of the 504 Gateway Timeout handling while we're here, in preparation
for bug T135748 where that kind of thing will be made normal.
Change-Id: Ia4abb1a68ff7ab7ff365c7348bf4d2ad35c43a27
2016-10-06 00:52:28 +01:00
jenkins-bot
c8f3474f3d
Merge "Fix styling of categories now they are editable"
2016-10-05 21:33:49 +00:00
jenkins-bot
6604a6a3a9
Merge "Use a proper error message when VE fails to load due to not being able to connect"
2016-10-05 18:29:28 +00:00
jenkins-bot
80596f9f22
Merge "Disable switch-to-VE button in NWE if VE is unavailable, don't hide it"
2016-10-05 18:29:26 +00:00
jenkins-bot
eae2305269
Merge "Allow NWE on non-VE namespaces"
2016-10-05 18:22:56 +00:00
Ed Sanders
a0dd888485
Use a streamlined 'converter' in wikitext mode
...
Converting a document we know contains just plain text paragraphs
is slower than it needs to be. The speeds up the conversion of
[[Barack Obama]] from ~2000ms to <100ms.
Change-Id: I2081858d835286b48db0627696a9eb5294317c2e
2016-10-05 16:40:28 +00:00
Alex Monk
f860bd0d36
Use a proper error message when VE fails to load due to not being able to connect
...
Not just 'HTTP 0'
Change-Id: Icd1b5b64ca8ea4af80e3cf32f8502d8fb0d11ae2
2016-10-05 16:39:27 +00:00
Alex Monk
aeaa49f9b2
Disable switch-to-VE button in NWE if VE is unavailable, don't hide it
...
Bug: T146182
Change-Id: I9d5095147288a78e2ba7dbddd3d7e6673c97859f
2016-10-04 18:41:11 +01:00
Alex Monk
d15034011f
Allow NWE on non-VE namespaces
...
Bug: T146182
Change-Id: I9547dfd591ad1e68e045b4928765a95895e37737
2016-10-03 22:20:18 +01:00
Ed Sanders
1ce3a81c63
Fix styling of categories now they are editable
...
Bug: T147084
Change-Id: I8c2acf507c72f6a35aadf595bad0c8c378140a0b
2016-10-02 15:43:17 -04:00
Alex Monk
d0abe11aca
NWE: Don't show button to switch to VE if it isn't available
...
Bug: T146182
Change-Id: I4bd039726ebccfd4351ecc68e6d7662752412d1b
2016-09-24 02:43:38 +01:00
Alex Monk
8a80b5bbc3
Split isAvailable from visual-specific checks
...
Not fully tested
Bug: T146182
Change-Id: I5d7ae6e49991660ecdc2daf46b319947f83a1018
2016-09-20 23:53:53 +01:00
jenkins-bot
089e22ff6c
Merge "(attempt to) make NWE work with SET"
2016-09-20 22:45:14 +00:00
jenkins-bot
f6b7c64e92
Merge "Open meta dialog to edit categories when user clicks on the category footer"
2016-09-20 00:58:29 +00:00
Alex Monk
0c07caafc7
Open meta dialog to edit categories when user clicks on the category footer
...
Bug: T145267
Change-Id: Ie88c4d9c6327baffdb83c1affbc0515a68c0fc03
2016-09-19 21:35:45 +01:00
jenkins-bot
376a4520ea
Merge "Use correct switch type when opening welcome dialog on NWE"
2016-09-19 18:16:59 +00:00
Roan Kattouw
cc8ca8e738
DesktopArticleTarget: Save scroll position before transformPage
...
transformPage() makes significant changes to the DOM, so measuring the
scroll position synchronously right after that results in a slow forced reflow.
Instead, measure the scroll position before reorganizing half the DOM.
Change-Id: I3baee5c11ca228696ddbfb30789745f5f0faa20a
2016-09-17 00:12:39 -07:00
Alex Monk
edf5b60368
(attempt to) make NWE work with SET
...
Ugh.
Bug: T143578
Change-Id: I71e08508eb0914be9d624202b13a4369df512b80
2016-09-17 03:36:47 +01:00
Alex Monk
926212dbae
Use correct switch type when opening welcome dialog on NWE
...
Bug: T145225
Change-Id: I032652733576d1a9797cc3dbb3dd24ca69cb30e5
2016-09-15 01:30:01 +01:00
jenkins-bot
9721998763
Merge "Provide the new wikitext editor as a beta feature"
2016-09-13 00:56:48 +00:00
James D. Forrester
1d64e3280c
Provide the new wikitext editor as a beta feature
...
Still needs to be de-feature-flagged later.
Bug: T142644
Change-Id: I8e2588909ff95085b5a4d58f4394d9bc805f5598
2016-09-08 00:38:08 +00:00
Ed Sanders
d0bb5511a5
Cleanup getDocToSave API and use in source mode
...
Instead of getting wikitext from the HTML, which is probably
slower and leads to issues with the whitespace stripping hack,
override getDocToSave and get text from the linmod directly.
Bug: T144621
Change-Id: I6b6cf16ee8f3720398ba8f5c85e7715c2e68329f
2016-09-07 12:09:41 -07:00
Ed Sanders
3c25f3aede
Switch from NWE to VE using 'Edit' tab
...
Bug: T143577
Change-Id: I19d942c879c9ccf70e95beb5f8de589eb6363039
2016-09-06 17:23:24 -07:00
jenkins-bot
06ca8ea7ba
Merge "Disable veaction=editsource if NWE is disabled"
2016-09-06 15:52:27 +00:00
Ed Sanders
7b3deab5a1
Disable veaction=editsource if NWE is disabled
...
Bug: T144651
Change-Id: I6a1e42b2da267bc42adeee0c818046eab0b387f8
2016-09-02 17:55:37 -07:00
Ed Sanders
edadf530e1
Make VE<->NWE switching progress bars non-cancellable and labelled
...
Soft dependency on Ifa41578164 in core to support the
non-cancellable flag.
Bug: T143582
Change-Id: I886a8f5ca90737938e4c0fedb2b456d851a12326
2016-09-02 16:47:17 -07:00
jenkins-bot
feb756dfb1
Merge "Update tab and history state when switching between NWE & VE"
2016-09-02 20:43:32 +00:00
Ed Sanders
e3dcf029ce
Update tab and history state when switching between NWE & VE
...
Bug: T143577
Change-Id: I729c0f4a8131f54f81be2d776bddf3020a21e704
2016-09-02 19:31:35 +00:00
jenkins-bot
dcbb8e2e90
Merge "Fix restoration of redirect HTML after exiting without saving"
2016-09-01 16:12:05 +00:00
Alex Monk
d907e973fd
DesktopWikitextArticleTarget#switchToVisualEditor: Use correct revision ID property
...
So we ensure we send the actual revision ID, not potentially undefined, to the
method. If we send undefined, it'll give us an etag for revision number 0...
And that will cause issues when we later attempt (in a future editor switch) to
pass an etag for revision 0 along with the correct revision.
Bug: T143920
Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab
2016-09-01 02:45:22 +01:00
jenkins-bot
572e7375d7
Merge "Preserve data when switching from NWE to VE"
2016-08-30 23:33:43 +00:00
James D. Forrester
ba4532aa9d
Rename EditButtonPublishNotSave to EditSubmitButtonLabelPublish
...
Depends-On: I4fbe54876095378a476399bf5e336c8df3e91e14
Change-Id: Iface24f77775216a0ab9eb464e7e10624af7719d
2016-08-29 10:46:49 -07:00
jenkins-bot
f071b0380d
Merge "Vary the 'save' labels to 'publish' for public wikis"
2016-08-25 21:36:41 +00:00
jenkins-bot
3063a9f23e
Merge "init: Discard attempts to activate while we're already activating"
2016-08-25 20:12:45 +00:00
Ed Sanders
134b62eb09
Preserve data when switching from NWE to VE
...
Bug: T143917
Change-Id: I910e731914bd71fdb131dae79d233d4306facc5d
2016-08-25 11:06:40 -07:00
James D. Forrester
deef47414a
Vary the 'save' labels to 'publish' for public wikis
...
Bug: T131132
Change-Id: I4a497265661d5ce0f6144988b514509dfa1bddfd
Depends-On: I56634ed223778a0650cf36ac7256151b13c494f1
2016-08-25 09:37:52 -07:00
David Lynch
c1a065295f
init: Discard attempts to activate while we're already activating
...
Perhaps in the future we could enhance this so that clicking a different edit
link queues that up for after the current activation finishes / aborts the
current activation cleanly.
Also, error-checking on setting an invalid progress state when loading.
Bug: T143160
Change-Id: I6c78cb19953df6fb564c06bac807e6897b63df19
2016-08-24 19:57:47 -05:00
James D. Forrester
b7c7d06968
Show a different label for buttons on create vs. modify
...
To align with the linked patch in MediaWiki core. Taking advantage of
the opportunity to use core's messages for these, and remove some dead
wood old messages that were never used like "restore" items in mobile.
Bug: T139033
Depends-On: Ie81b5edd275963a965cd44d0fd325cae9ee2f1a6
Change-Id: Ie00e94cc77cb750a7e8d1104366bb3dad65af8a4
2016-08-24 16:01:11 -07:00
David Lynch
11a4e4e6b9
init: port in isUnModifiedLeftClick without any VE core dependencies
...
Bug: T143467
Change-Id: I4c0ecf80ecfff04472e136801264d50dafe39575
2016-08-22 14:40:34 -05:00
Alex Monk
166588c726
Fix insertion of templates, media, and various other things into wikitext surface
...
Pretty much fix everything on the insert menu... RB doesn't like it when you
try to specify both title and revision ID, but don't provide an ETag.
Change-Id: Ib25d023309d984ed8848f67b349b23231f27a957
2016-08-17 21:12:00 -07:00
Alex Monk
d24fd1e389
Don't show unsaved-changes warning if user has already saved in wikitext dialog
...
Add an extra surface check - makes sure it's attached.
Change-Id: I1720ba18b5966549fefb839013776ac9dfe0468a
2016-08-17 21:12:00 -07:00
Alex Monk
f60730a580
Fix name of mweditmodeve-tool message
...
Change-Id: Ib48a61b4ea56221808d96efd5cf4a5c13b8aeb0c
2016-08-17 06:21:56 +01:00
Ed Sanders
c452e134cc
Wikitext surface alpha feature
...
Edit wikitext with the VE interace.
Bug: T104479
Bug: T142138
Change-Id: Ic95b47e0dd378578555c4a2342ca9c87064ed1d5
2016-08-12 18:37:29 +00:00
David Lynch
87ea771ae6
Centralize some checks for unmodified left clicks
...
Change-Id: I59cee4da9bbca4c8a29eaf9d52cb00ab6e70b670
Depends-On: I4f164f7cf1d755c3662571b2a1a8371d9fe756f9
2016-08-11 13:33:26 -07:00
Alex Monk
96421b283c
Fix restoration of redirect HTML after exiting without saving
...
This feels like it's getting far more complicated than it should be.
Bug: T140032
Change-Id: Id951400cead61da37b8bdfa05cf8add6c115547d
2016-08-09 22:43:25 +01:00
jenkins-bot
cf4c2d41b3
Merge "Rewrite TOCWidget based on Linker::generateTOC"
2016-08-05 22:18:22 +00:00
Ed Sanders
bb7b38575f
Rewrite TOCWidget based on Linker::generateTOC
...
Use the new node cache to find headings.
Change-Id: I5eb75c5db5ca466fd6f16a57c693c2a4458cff7c
2016-08-05 14:11:15 -07:00
Alex Monk
7f39d4e75d
Use .textSelection( 'getContents' ) instead of .val() to get the value of #wpTextbox1
...
To allow gadgets like wikEd to use textSelection to return the latest value.
Bug: T135747
Change-Id: Ie353cf547dea6c100c5f01ab56c9b415be1ffdb8
2016-07-31 21:58:51 +01:00
Roan Kattouw
5483b25657
Reduce mayhem caused by ?oldid=currentRevId
...
If you viewed a page with an ?oldid= query parameter set to the ID
of the current revision, some parts of VE would believe we were
in oldid mode (because there's an oldid present), but others
wouldn't (because the revid we're editing equals the newest revid).
This caused bugs when opening the editor a second time after saving
(which is normally impossible to do after an oldid-mode edit, because
we navigate to a new page after an oldid save, but we don't do that
in this case).
Ensure that:
* The internal state of DesktopArticleTarget is updated correctly
after saving in this case
* The ?oldid= parameter is removed from the URL after saving
* DesktopArticleTarget.init doesn't preload the article HTML
on a second/subsequent editor load: this causes issues because
it caches the oldid, and generally speaking the Target's internal
state is not considered
Bug: T141330
Change-Id: I74034328797c59f7249f1f6f4f53a92ee1c26334
2016-07-25 20:04:47 -07:00
David Lynch
e9b99d8181
MWSaveDialog: Give checkboxes a class based on their origin's name
...
Bug: T138631
Change-Id: I2c31becd57c7988c4dd26c09ee01b4f7820c7aaa
2016-07-19 11:21:36 -05:00
Ed Sanders
e50aa6fa34
Pass ve.dm.Document to addSurface as documented
...
Change-Id: Ic4ef3763e20d0f954e21dd651309b0e9eee65fd2
2016-07-18 11:13:54 +01:00
jenkins-bot
c3ab6950bc
Merge "DAT.init#setEditorPreference: Change section edit alongside tab labels"
2016-07-14 16:26:02 +00:00
Ed Sanders
c645295bee
Fix vertical positioning of progress bar
...
Bug: T140029
Change-Id: I5b38d375559449eded559e4443131516b1937b6d
2016-07-12 15:56:50 +01:00
Alex Monk
16c38ec27a
DAT.init#setEditorPreference: Change section edit alongside tab labels
...
When our remember-last preference changes work, alongside changing the
label of the edit tab, also change the label of the edit section links.
I seriously have no idea WTF I was thinking back in December when I
put some of this code into #activatePageTarget.
Bug: T137424
Change-Id: I581c0acf0a3ad11ad3bcf4e2e46242907ca9166f
2016-06-30 10:22:44 +00:00
jenkins-bot
dc59190e64
Merge "Set an automatic summary of empty string when switching from VE into WTE"
2016-06-29 16:16:57 +00:00
jenkins-bot
0d45972cb3
Merge "Fix our display of redirects during and after editing"
2016-06-29 16:15:43 +00:00
Alex Monk
984823a77d
Replace section edit click handlers in DAT instead of doing it badly in init
...
If you deactivate without saving (e.g. using the back button), the page
contents aren't replaced and so adding the page click handlers is pointless
and harmful because they will run twice.
This was my fault in Iad1713e1
Bug: T135387
Change-Id: I3c83009bfc0f42125cdcde7f7a51de9bc2f72abf
2016-06-29 03:58:57 +01:00
Tpt
2a2a041933
Allow extensions to register a specific target per content model
...
Bug: T138489
Change-Id: Ic9d2fa34b90afc58f7e31adf38f97a701aac64f9
2016-06-24 15:38:28 +00:00
Alex Monk
4382e18385
Fix our display of redirects during and after editing
...
Change-Id: Ib559eb8fb8a2643af25ad8df858212f3e9d14b13
2016-06-15 20:25:59 +01:00
Alex Monk
3bda9a75aa
Set an automatic summary of empty string when switching from VE into WTE
...
So if the user supplies a summary in VE, WTE with the "Prompt me when entering
a blank edit summary" preference won't moan.
Bug: T135979
Change-Id: I0e2d2b6f8fb03bb56d600f1118daf82fb3715b66
2016-06-15 18:37:56 +01:00
Alex Monk
9900d42816
On serialization failure, reset document opacity.
...
In case we were switching to source.
Normally MWWikitextSwitchConfirmDialog#getActionProcess would do this for us,
but this closeWindow call doesn't trigger that, we can't get it by overriding
MWWikitextSwitchConfirmDialog#close either.
Bug: T134333
Change-Id: I66a12ff6d13601250b9d470e1be54fe38a1ef06c
2016-06-13 23:45:43 +01:00
jenkins-bot
6a6d3b9368
Merge "Fix loading bar opacity"
2016-06-07 14:07:48 +00:00
Ed Sanders
61cb539c7b
Fix config of mobile surfaces
...
Change-Id: I0109a93a41b0387199a0424b60a26a415393bc5d
2016-06-03 10:51:42 +01:00
jenkins-bot
6e6d2bf66b
Merge "Move $editableContent computation into overridable method"
2016-06-01 17:40:15 +00:00
Ed Sanders
538959dc49
Move $editableContent computation into overridable method
...
Change-Id: Ibb0b877a01f8982fb895616c4c0d3e897bf37c85
2016-06-01 09:58:17 -07:00
Ed Sanders
0a0ca68d62
Simplify teardown of toolbar save button
...
Bug: T136421
Change-Id: I6829ad75b93c6aa6c6db51b5c9cd84915c75cdb8
2016-06-01 17:52:58 +01:00
Ed Sanders
b33cd5d8f1
Fix loading bar opacity
...
* Ensure ve-loading isn't removed early
* Quickly detach then reattach the loading bar during
activation so it doesn't get moved and marked as original content
Change-Id: I263c9627348953a11966f8bcc435d0d89b0b6084
2016-06-01 14:52:57 +01:00
jenkins-bot
d70485244d
Merge "Allow extensions to support extra namespaces and content models"
2016-06-01 01:02:51 +00:00
Ed Sanders
796da84576
Allow extensions to support extra namespaces and content models
...
Change-Id: If67bab93da355da609b6df274514b5c72a6ed91a
2016-06-01 01:55:03 +01:00
jenkins-bot
337109fef1
Merge "Un-blacklist Firefox versions 12,13,14"
2016-05-31 16:55:38 +00:00
Ed Sanders
20fa650a6b
Un-blacklist Firefox versions 12,13,14
...
T52720 (link corruption in FF13/14) appears to be fixed.
T52780 (editor not loading in FF11/12) appears to be fixed.
FF11 has a new issue where templates are normalised even
when not touched (T136607)
Change-Id: I34358e3d90b8186e6b89c04c038ab79c908fc81b
2016-05-31 09:46:50 -07:00
Ed Sanders
4d466f16b5
Add fallback selectors if image page has no existing local content
...
Change-Id: I1fac3b35b5d498115c96b07c29cf409be72a1389
2016-05-31 16:42:21 +01:00
Ed Sanders
d6a770bb4d
Remove unused namespace class
...
Introduced recently but then abandoned.
Change-Id: Ifa999f0e60fe1b6d68c63813025c9fd48b79ad5f
2016-05-28 20:54:24 +01:00
Alex Monk
afd5944bde
Followup I9280fe4d: Merge main case with default, they are identical
...
Change-Id: I280f0eba1c99f5e96ffe5466e8398115fbc5f4f8
2016-05-26 18:15:27 +01:00
James D. Forrester
1b9427c5dd
Follow-up 1dc933be
: Don't fatal when editing non-NS0/6/14 pages
...
Change-Id: I9280fe4d771cf7ce1ee3874a34d7a14b672b222c
2016-05-26 09:07:07 -07:00
Ed Sanders
1c5c1fc6b9
Append surface & toolbar components in the correct places
...
Use setSurface and setupToolbar to position the surface and the
toolbar save button in the DOM.
Change-Id: Ide634848f4e78501724c358bcb1fdab8abd491b9
2016-05-26 08:50:21 -07:00
Ed Sanders
1dc933bead
Genericise target initialisation across namespaces
...
Define $editableContent on target construction, and mark
all non-ancestor nodes between that at the target container
as uneditable (50% opacity, no pointer events).
Bug: T58289
Change-Id: I7fe51104bd5aa1bd53ffc604e5f02752c7553578
2016-05-25 12:50:36 +01:00
Alex Monk
8c3dc0887d
Don't show tab preference dialog again if it's already been shown
...
Bug: T135534
Change-Id: Ifecac607acccc0e18e61b07e8456566d4671aa1b
2016-05-20 02:36:25 +01:00
Alex Monk
349b1f5e57
Add WTE welcome dialog
...
Bug: T133800
Change-Id: I6eb43274e22f647958c3ab1b6d5c12b3dbea388e
2016-05-10 23:28:21 +00:00
Alex Monk
1ba035e053
Fix deactivating VE after user explicitly decideas to discard changes
...
Bug: T134794
Change-Id: Idf1941793317a6aff9fe57082b85e3ebff0c72b4
2016-05-10 23:39:57 +01:00
Alex Monk
3c55bfbb80
Add a hidden link with accesskey=v in SET prefer-wt mode and remember-last wikitext
...
Try to tidy up a bit of code in DAT.init.js as well
Bug: T116406
Change-Id: Iad1713e14ea1f982886ba06e0b722c554ab2b892
2016-05-01 21:01:57 +01:00
jenkins-bot
80636c235e
Merge "Add a popup after switching into VE from WTE"
2016-04-25 22:42:55 +00:00
Ed Sanders
6efd583ff7
Add method that runs after activation, for overriding
...
Change-Id: I046583e61f328baddb0c09eaff122e991c85f992
2016-04-22 17:17:56 +01:00
Ed Sanders
7a007e2874
Create MW targets using a factory
...
Move the existing static property 'name' to 'trackingName'
to make way for a real registry index.
Change-Id: Iab0d5be611ece7038234551c4847b07517b4348d
2016-04-21 21:06:39 +01:00
Ed Sanders
7576810b28
Use Array.prototype.indexOf in support check
...
The SupportCheck method asserts that the method is available so use it
instead of the confusingly named jQuery version.
Change-Id: I2105384cc4f6f2ec1cdb24a7bf3b0f4cce7672d3
2016-04-21 12:41:13 +01:00
Alex Monk
0bbe2e38ee
Add a popup after switching into VE from WTE
...
Bug: T131066
Change-Id: I2294da7d09dfbacb9187aba5e6e703511cec3c9f
2016-04-20 18:46:00 -07:00
Ed Sanders
a6aa6daa28
Defer before restoring scroll position, and allow 0
...
Bug: T131791
Change-Id: Id48b913effe5313c193ce62b19faf5655278ff6d
2016-04-19 21:42:09 +01:00
jenkins-bot
d4f9a85f27
Merge "Set mw.libs.ve.EditingTabDialog.static.message instead of passing it to setup data"
2016-04-17 17:49:28 +00:00
jenkins-bot
227de9cfef
Merge "Close VE SET dialog when we deactivate"
2016-04-17 17:43:01 +00:00
jenkins-bot
299027e528
Merge "Don't select edit tab when VE is opened while user has prefer-wt pref"
2016-04-17 17:39:56 +00:00
Alex Monk
4ccc1ad5af
Don't select edit tab when VE is opened while user has prefer-wt pref
...
You can still open VE with prefer-wt mode by going to veaction=edit, and
T116406 proposes making it accessible with a keyboard shortcut as well.
Change-Id: Ifc25b5147a96a200ac3a7de465d5cdf67e2e255b
2016-04-15 02:37:46 +01:00
Ed Sanders
011ff4e133
Replace transitionend event with setTimeout
...
transitionend events seem like a neater solution, but we should
migrate all of our code at once, and provide a polyfill for
browsers which don't support it (IE9).
Change-Id: If6ae030856f8e69cc8bb26f21bfed30d5d22775c
2016-04-14 16:21:41 +01:00
Alex Monk
f3c5e2f410
Set mw.libs.ve.EditingTabDialog.static.message instead of passing it to setup data
...
Change-Id: I2bfb79e258253e00c9f856bbbb3c4efae55a128c
2016-04-13 22:46:14 +01:00
Alex Monk
47cfc03d72
Close VE SET dialog when we deactivate
...
You can trigger deactivation by browsing back.
Bug: T132494
Change-Id: I8f66e22a745d84a3ca4b144c389c3ae654974789
2016-04-13 22:41:27 +01:00
Alex Monk
9170bd8acd
Try to make client and server code to get last editor work the same
...
On the client: getLastEditor in ve.init.mw.DesktopArticleTarget.init.js
On the server: VisualEditorHooks::getUserEditor in VisualEditorHooks.php
Change-Id: I9cc0f367aee2dda43cffc6918bfb042ac8ae3bb2
2016-04-11 23:58:31 +01:00
jenkins-bot
5dc1257507
Merge "More minor/watch checkbox state computation server-side"
2016-04-11 14:18:56 +00:00
Ed Sanders
f342dc01c3
Adjust DOM and CSS so UI surface runs from top to bottom of page
...
Place things like the page title and redirect link inside a new
container $originalContent, which is appended to the surface
when ready. Replace margins with padding in various places.
This will allow us to surface-height-matching sidebar for dialogs.
Change-Id: I60d80fb303bdaf93e9d121f62d534ee3a3056e59
2016-04-11 13:18:36 +01:00
Roan Kattouw
12eb41acff
More minor/watch checkbox state computation server-side
...
Following through on my threat from 72b0d2a19c
(November 2013).
Change-Id: I0daeef2a0373bbdb06627053e9d726d6fc20a3f6
2016-04-08 18:02:01 -07:00
jenkins-bot
597a095a64
Merge "Ensure veswitched is not set when we set wteswitched in the URI"
2016-04-05 15:51:33 +00:00
Alex Monk
373a19f1cc
Ensure veswitched is not set when we set wteswitched in the URI
...
veswitched and wteswitched together cannot result in any sane behaviour.
To reproduce:
* Open VE (while having multi-tab pref?), switch into WTE
* Make a change
* Switch into VE
Change-Id: I90e19169e3fab60ab876c8e4d349801309db262f
2016-04-05 01:27:37 +01:00
Alex Monk
7788aece55
After saving and setting HTML, set single-editor edit section handlers again
...
Change-Id: I6e0962271e7e1460abbe82864b47fddc5bd7f235
2016-04-02 09:53:25 +03:00
Alex Monk
4210c4bee0
Use veaction=edit in URL instead of action=edit when we're using multiple tabs
...
TODO: What about prefer-wt users switching from WTE?
Bug: T131064
Change-Id: I9aa701cbda3964decb8b1ee853c0a281567a0ccb
2016-03-30 02:54:01 +01:00
Alex Monk
b1aebf0b48
Don't strip namespace from text that we replace firstHeading with
...
wgTitle is basically just $title->getText()
wgPageName is $title->getPrefixedDBkey()
So we need to take wgPageName and run getPrefixedText (difference is underscores
get replaced by spaces)
Change-Id: Ib99f0d20f1ba99338f80bbbf39cffd544887c3fa
2016-03-25 04:45:09 +00:00
Alex Monk
2063025237
Don't change focus to VE surface if we're opening the SET dialog
...
Bug: T130552
Change-Id: Idc4639bb3f51690a827bdbdb0419e9303dd39a1b
2016-03-23 01:08:32 +00:00
jenkins-bot
4e4684e7d0
Merge "Show redirect target inside target"
2016-03-17 22:54:39 +00:00
jenkins-bot
33c9055fdc
Merge "Reload page after user selects multi-tab option of SET dialog"
2016-03-17 15:39:09 +00:00
Alex Monk
3288d4e3f9
Show redirect target inside target
...
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
2016-03-17 15:21:06 +00:00
Alex Monk
02953f5d64
Suppress meta dialog on refresh pages if we want to show SET dialog
...
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
2016-03-15 08:10:46 +00:00
Alex Monk
3807a918f9
Reload page after user selects multi-tab option of SET dialog
...
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
2016-03-11 05:39:29 +00:00
Alex Monk
4462f2539a
Suppress welcome dialog this time if we're showing the SET pref dialog
...
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
2016-03-10 17:54:15 +00:00
Timo Tijhof
cf1d7c0dab
mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined"
...
Regression from 863a2c2974
.
Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.
> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor
Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
2016-03-08 23:13:11 +00:00
jenkins-bot
8d7baccd5f
Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist"
2016-03-07 23:28:58 +00:00
jenkins-bot
39f3cfa4a7
Merge "Keep summary and checkbox selections when swtiching WTE->VE"
2016-03-07 23:17:08 +00:00
jenkins-bot
15f8efed70
Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity"
2016-03-07 23:14:26 +00:00
James D. Forrester
79d1f92b42
DesktopArticleTarget: Add Edge and MSIE to whitelist
...
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
James D. Forrester
b0407d840d
Follow-up I65d96627: Remember the user's preference in WikiEditor too
...
Oh dear.
Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
2016-03-07 13:03:35 -08:00
James D. Forrester
302aeefd85
DesktopArticleTarget.init#getLastEditor: Check values for validity
...
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
2016-03-07 11:27:23 -08:00
Alex Monk
dde45949a3
Try to fix handling of empty document on WTE->VE switch
...
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
2016-03-04 02:05:41 +00:00
Alex Monk
21334a0fa8
Keep summary and checkbox selections when swtiching WTE->VE
...
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
2016-03-02 11:55:50 +00:00
Alex Monk
d46c5e9f91
Fix WTE->VE switching in prefer-wt SET mode
...
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
2016-02-29 23:46:11 +00:00
jenkins-bot
e39d8a744b
Merge "Show welcome dialog on mobile too"
2016-02-29 03:02:03 +00:00
James D. Forrester
ab4d3e956b
Update VE core submodule to master (0371bbe)
...
New changes:
0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern
Local changes: Use new VisualEditorSupportCheck pattern
Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
2016-02-26 12:26:56 -08:00