Commit graph

164 commits

Author SHA1 Message Date
jenkins-bot b83511ac54 Merge "Add image upload tab to media dialog" 2015-10-07 01:54:20 +00:00
Ed Sanders 97ddc8af2b Add image upload tab to media dialog
Uses the ForeignStructuredUpload BookletLayout.

Bug: T40030
Change-Id: I103044210e714d99350a28a48619beacefb43eaa
2015-10-06 18:40:19 -07:00
jenkins-bot cd29e0376d Merge "Add error element to MWLiveExtensionInspector" 2015-10-05 22:53:20 +00:00
James D. Forrester 8e8fe70d79 Update VE core submodule to master (8feaeef)
New changes:
9cb6f74 Move insertion annotation calc logic from DM Surface to ElementLinearData
04d4bfd Refactor the code that determine insertion annotations
d9efa1c DimensionsWidget: Fix alignment of labels
66ba732 Always render generated content the first time, including errors
23a957c Consistently use spaces inside brackets in CSS
f17c8ad Localisation updates from https://translatewiki.net.
f4d0643 Localisation updates from https://translatewiki.net.
ec29e77 Follow-up I553e31: Don't show error for non-rendered GCNs
5f2402b Pass staging state through Document#commit to ve.dm.Node update event
0d3e998 Fix ve.ce.Document HTML tests
7c95c6a Wrap <hr>s so their margins are clickable
164b9a3 Localisation updates from https://translatewiki.net.

Change-Id: I069082baeb45105bf2e0106879d472319a6ffe2a
2015-10-05 09:57:20 -07:00
Thalia 9307fa7095 Add error element to MWLiveExtensionInspector
As part of the plan to render extension errors in the
inspector instead of the view, append an element to
contain the error. More specifically, the element is
a div that contains a LabelWidget (in which the error
message is displayed) and a ButtonWidget (to expand
and collapse the error).

Initially the error element is hidden, but if Parsoid
returns an error, the element will be shown. If the
error is longer than 1 line, it is truncated but can
be expanded. On closing the inspector, any remaining
error is collapsed and hidden.

Depends on I6002d9870d2b to work

Bug: T113172
Change-Id: Ie84130d4ac0da9a738bf98ad0a3677d47566d585
2015-10-05 00:22:22 +01:00
Roan Kattouw 28fbf2bcda Update autodisable logic
* Make betatempdisable appear checked if autodisable is true
* Set autodisable=false only if betatempdisable is also false
* On wikis where $wgVisualEditorTransitionDefault=true, set
  autodisable=true when the user disables VE

Change-Id: I3415af4a735afb10cf246f4b22b9d84ef98c882f
2015-09-28 18:19:56 -07:00
jenkins-bot ce8107ec0b Merge "Autodisable preference" 2015-09-28 23:46:59 +00:00
Alex Monk 97e70ba3cc Autodisable preference
We want to flip the default of visualeditor-enable to true, but don't
necessarily want to turn it on for users who already have contributions but who
haven't already enabled it. Therefore we're considering adding such users to
this autodisable preference which they can self-remove (by explicitly enabling
VE) or we can target later, separate from betatempdisable users.

Bug: T112352
Change-Id: I1ce5e6c92055e30fdc82bc912a767e913b190ef6
2015-09-29 00:30:27 +01:00
Ed Sanders f814ea719b MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget
Depends on I335bd912d in MediaWiki core.

Bug: T101169
Change-Id: I2932c9df5444d1363af5af9b438bb905ed298148
2015-09-27 14:03:52 +01:00
James D. Forrester c0c5a028cf Add MediaWiki version requirement to extension.json
Remove the now-empty ::onSetup hook.

Change-Id: I67fe9cf9d05a16199a507f99f5ec295ae7e64dc2
2015-09-26 14:27:44 +00:00
Alex Monk 3386f66770 Save dialog: Make review/resolve actions work in mobile
Depends on Ic92378b7

Bug: T111894
Change-Id: I5ca5f803642dd12db4e9fb213dc6478701661528
2015-09-26 00:08:31 +01:00
James D. Forrester 207f55dc8c Update VE core submodule to master (3c65a2a)
New changes:
90ed001 Localisation updates from https://translatewiki.net.
c2f2096 Rename ve.ui.PreviewWidget to ve.ui.PreviewElement

Change-Id: I35103bc5d98b7eee77c9f5f22c441091b6453687
2015-09-24 13:50:08 +01:00
jenkins-bot 75b95173fc Merge "MWWelcomeDialog: Split text, tweak styling" 2015-09-16 18:42:32 +00:00
James D. Forrester 71dd91d5d1 Update VE core submodule to master (5018704)
New changes:
4a089dd dm.Annotation: Remove unused convenience wrapper
f30ad5c PreviewWidget: De-duplicate code with a private function
c16da30 Restore scroll immediately after paste
45b1406 Links: Explicit entry/exit with cartouches

Change-Id: I48ad7fb3f68ebb5eff89cc7e2b00878cca550222
2015-09-16 10:49:24 -07:00
James D. Forrester 9b0779da9b MWWelcomeDialog: Split text, tweak styling
Change-Id: If15dc9fe4a01e81cf7d85e2670878bbd5899f068
2015-09-16 10:16:44 -07:00
James D. Forrester e5e1810f02 MWWelcomeDialog: Alter to be welcoming, use a nice image
Drop beta-ness as users don't care and it confuses them. Leaving the preference
alone for now.

Bug: T99963
Bug: T112354
Change-Id: I0e039dec54d528fce24226e76b931b593dd13a9e
2015-09-14 18:29:07 -07:00
jenkins-bot 85bc110774 Merge "Remove command help height hack" 2015-09-11 18:48:19 +00:00
Ed Sanders b68099bcb4 Remove command help height hack
No longer needed, depends on Ia98a91c8a in core.

Change-Id: I3789e629fef7883984bd944d2c44472d4b89199a
2015-09-11 12:46:10 +01:00
jenkins-bot 3a15ef608c Merge "Use RESTBase v1 API" 2015-09-10 20:14:35 +00:00
jenkins-bot 3ed7164b35 Merge "Load visualeditor-saveerror-titleblacklist and fancycaptcha-reload-text for all targets" 2015-09-10 17:59:21 +00:00
Alex Monk 2fcf6b7ce7 Load visualeditor-saveerror-titleblacklist and fancycaptcha-reload-text for all targets
During testing of saveFailure for T110272, I noticed these were showing up as broken
missing messages on mobile.

Change-Id: I20ce66ba180b6f40443ba7a9a7a0da3de3b4e6f3
2015-09-09 03:55:52 +01:00
jenkins-bot 343854a5b4 Merge "Remove compatibility aliases for old ve init modules" 2015-09-08 18:31:56 +00:00
James D. Forrester 5337b249a2 Update VE core submodule to master (d58d7d4)
New changes:
5542fe9 Localisation updates from https://translatewiki.net.
0a64089 Follow-up 5542fe9: Fix build for added language 'glk'
26c8862 Update OOjs UI to v0.12.7
0481471 Make ve.ui.Sequence#execute return false if the command is missing
20fd431 Localisation updates from https://translatewiki.net.
521d281 Localisation updates from https://translatewiki.net.
a76cbef build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue
7022385 Back out "Re-use example surface across surface view tests"
3a8f7af Don't call setInsertionAnnotations on handleInsertion
10700e2 Localisation updates from https://translatewiki.net.
3b75d9d Don't descend into overflow clipped nodes for highlights
9492aca De-duplicate methods in NodeDialog and NodeInspector using mixin

Change-Id: I06a239269c68351f046f8aa221bb82899a8f57b1
2015-09-05 22:55:25 +00:00
jenkins-bot f6a2e3658c Merge "Abstract mwExtension behaviour into MWExtensionWindow" 2015-09-05 21:26:31 +00:00
Ed Sanders 8815d1397f Abstract mwExtension behaviour into MWExtensionWindow
Allows us to create an MWExtensionDialog base class that shares
the logic.

Change-Id: I53c8f1713a3513d2635cfd736ec8fc3f9616d864
2015-09-05 18:18:24 +01:00
Alex Monk 2c201a6d88 Load new gallery styles module
Bug: T98878
Change-Id: Iafebab7332df59900d8144018f8b67a719e5df3f
2015-09-04 19:11:15 +01:00
jenkins-bot 8502d3ea05 Merge "Specialized inspector for ISBN magic links" 2015-09-01 18:34:23 +00:00
C. Scott Ananian 7cc23367f6 Specialized inspector for ISBN magic links
Implement a special node type, context item, and inspector for
ISBN/PMID/RFC magic links.  Add buttons to the link inspectors
to convert back and forth between "simple" links, and magic links.

Depends on I5d000d8b63dafdfe0a2753069d3f0ac5b03b8829 in Parsoid
for clean round-tripping of localized ISBN magic links.

Bug: T63558
Change-Id: Id5b7a2ae3c80b0e5eed598f0bd024d3e94f7e9aa
2015-09-01 14:25:59 -04:00
Ed Sanders e4c351e362 Implement getUserConfig and setUserConfig in MW
Depends on I5704a0e3e0 in core.

Change-Id: I0d6c9317a91dc02566d8877bd1aefae581213cbb
2015-09-01 01:03:38 +00:00
C. Scott Ananian 96e330650d Use RESTBase v1 API
This requires https://gerrit.wikimedia.org/r/214351 in core, which adds
support for emulating the RESTBase v1 API to the
ParsoidVirtualRESTService.

$wgVisualEditorPrefix is now deprecated.  Parsoid is configured using
VRS (preferred) or $wgVisualEditorDomain, which defaults to
$wgCanonicalServer.

This bumps our MW-core dependency to 1.26wmf21.

Bug: T110780
Change-Id: I9175ac8db8310f0c9574c8272b5e39932557d57e
2015-08-29 02:12:29 +00:00
Jforrester f78e7c7cbd Remove compatibility aliases for old ve init modules
Not to merge before 2015-09-07.

This reverts commit 90e2111c95.

Change-Id: Iefb748c5fc7b010e7c4d95d6fb24265f004a386c
2015-08-26 23:29:04 +00:00
Ed Sanders a33b082c13 MWWikitextStringTransferHandler: Show indeterminate progress bar while converting
Also store the abortable API request so it can be cancelled
by the dialog.

To test this, put sleep(4); in ApiVisualEditor.php.

Depends on Ied21e574baa in core.

Change-Id: I83ffa9e0b7164ca4a34eae86cde452d8f38dc853
2015-08-23 14:18:40 -07:00
Ed Sanders 17f0fffe85 Update VE core submodule to master (1191940)
New changes:
de69c36 Fix typos in function names
fa80099 [BREAKING CHANGE] Split out linear context from context
db1d28c Only show alien context for focusable nodes
1191940 build: Bump grunt-jscs to 2.0.0 and make pass

Local changes:
* Update context inheritance

Change-Id: I284e2b30cd1903770482ee1c554687b676a2d626
2015-08-18 11:24:08 -07:00
jenkins-bot d0b3c40239 Merge "Set the default feedback message to the page URL" 2015-08-18 15:55:25 +00:00
C. Scott Ananian a6775796fe Detect paste of wikitext and convert it
This invokes Parsoid to convert likely wikitext pastes.

This addresses about 20% of the <nowiki> insertion quantified at
https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki
for 2015-04-08 which were due to inadvertent pastes of wikitext.

For a better user experience, suppress Parsoid's P-wrapping if the
output consists of a single top-level P element.  This ensures that
pasting '[[Foo]]' won't add an unexpected newline before the paste.

Bug: T54204
Bug: T109449
Change-Id: I26a4cd8dc5b7e7caf16ca081dbe7baf6a7db8e5c
2015-08-18 15:16:06 +00:00
C. Scott Ananian 550a979fdb Update VE core submodule to master (0bf4ce7)
New changes:
44f8204 Autolink pasted links

Local changes:
* Add UrlStringTransferHandler from core

Change-Id: I7eae6da2739fa47b22ed1e7fbf53e9473e037c5b
2015-08-18 07:20:29 -07:00
jenkins-bot a150550bea Merge "MWNumberedExternalLinkNode: Provide a context item" 2015-08-17 20:16:27 +00:00
James D. Forrester 31b4466d5f MWNumberedExternalLinkNode: Provide a context item
Bug: T98211
Change-Id: I0ca7811f5be5ce058f2ec22b2ce80e3228af5886
2015-08-17 13:10:58 -07:00
Alex Monk 48f941caf9 Set the default feedback message to the page URL
Bug: T109081
Change-Id: Ibc36acd38738e2d45621d477c0406b28a744290a
2015-08-17 17:26:12 +01:00
Ed Sanders 0e528b53b5 Update message list
Change-Id: Id48c93e0b20d4720d6543028c87f34216e931841
2015-08-17 15:35:23 +01:00
Ed Sanders 311b86fd98 Add missing message for done button in mobile
Unlikely to be seen as it only shows on hover.

Change-Id: I468ce80b8d2a3e5150965f237f0149ea58dafd0e
2015-08-13 15:33:29 +01:00
James D. Forrester 1d6085b801 Update VE core submodule to master (e61ebf2)
New changes:
61d20a1 Hide on-screen keyboard when selecting nodes on all mobile platforms
e5aff79 Localisation updates from https://translatewiki.net.
a99a897 Update OOjs UI to v0.12.3
3c01a14 Make DM nodes sensibly hashable
a611eb9 Make ve.dm.example.postprocessAnnotations fluent
496c895 Update ve.dm.ElementLinearData#hasContent documentation
fcaa035 Support RegExp sequences; trigger sequence matcher after newline
edda1d4 Add a mechanism to wait until ve.init.platform has been created
e174155 Autolink URLs when typing
ac9248f Allow drag and drop of links (and subsequent autolinking)
c88fad6 Localisation updates from https://translatewiki.net.

Local changes:
* Define `ve.init.platform.getUnanchoredExternalLinkUrlProtocolsRegexp`.
* Make `ve.ui.MWLinkAction` extend `ve.ui.LinkAction`.
* Override `ve.ui.LinkAction.getLinkAnnotation` so auto-links use the proper
  `ve.ui.MWExternalLinkAnnotation` type.

Change-Id: I934f76158512e2e89b614ed92fef6481f70728e7
2015-08-12 14:31:06 -07:00
James D. Forrester 4054864b3f Update VE core submodule to master (d3d2293)
New changes:
8218ced Localisation updates from https://translatewiki.net.
c7f4587 Fix resizable node teardown
90869e0 Context: Store default button config in a static property
d9d747f MobileContext: Provide a delete button for nodes' context
9dadbfc MobileContext: Provide a fallback context item for alien nodes

Change-Id: If135c9309baf1af58e3c58fdec099e794bc08e64
2015-08-11 08:43:27 -07:00
Ed Sanders 92fc30db48 Update VE core submodule to master (da9d929)
New changes:
2464397 Move toolbar floating code up to the target
11bdc21 Separate SA target into Mobile and Desktop
7ab3389 AlignableContextItem: Fix styling in mobile
758619f CONTRIBUTING.md: Update file paths and build instructions

Local changes to mw.Target to handle toolbar floating.

Change-Id: I0751817e3a6668b120134bfcb6c611b121a46501
2015-08-10 12:33:14 -07:00
Ed Sanders d9ff657c51 Remove Minerva MobileWindowManager.css
Moved to core in Ic916562d.

Bonus: rename default folder form apex to default.

Bug: T96703
Change-Id: Ied452d831e497125ce312a03b180e3581b30e4ec
2015-08-10 08:49:35 -07:00
James D. Forrester 09fc1e299b Update VE core submodule to master (58912e1)
New changes:
a56746e Ensure demo init script runs last
ab6a1bd Context emits resize events
564701a Provide a context item for table cells in mobile
9f92a0f MobileWindowManager: Bring in styles from MW-Minerva

Change-Id: If0da9079bbab6f930979ed17be3b27cb0a5bea60
2015-08-10 08:47:53 -07:00
Ed Sanders 0e62e577e4 MWMobileSaveDialog: Use short save messages for space
Change-Id: I04e01a8941f905384e385caf1267d7c36cb2aa52
2015-08-07 17:38:52 +00:00
Ed Sanders ac9f1a0919 MobileArticleTarget: Give toolbar split focused/unfocused modes
Split the toolbar into two modes depending on if the surface is focused:
* When unfocused, show a hamburger containing back and source switch
* When focused, show editing tools, and a check button to unfocus

For the editing toolbar, space the tools out using table-cell layout
and hide labels below 480px.

Depends on I06813e3ff in core (surface blur method).

Bug: T93325
Change-Id: Ibf09cb29019d7a71e1e144b326710b1f6506cd0c
2015-08-06 15:43:36 -07:00
Ed Sanders 707628cfb1 [BREAKING CHANGE] Use save dialog in mobile
Bug: T96186
Change-Id: I4319e23da2d1bfd0cbba9719dbc9642a233bdf67
2015-08-06 21:52:14 +00:00
Ed Sanders 90e2111c95 Add aliases for old ve init modules
Due to HTML caching, these need to be available for 30 days
after the change.

Change-Id: Ia92ecc03623ef9b42d1948d32c69951672bee146
2015-08-05 19:26:11 +01:00