Commit graph

16841 commits

Author SHA1 Message Date
Ed Sanders 421ef465b9 Update VE core submodule to master (1cf71b3f3)
New changes:
f99a7cd43 Apply desktop contexts' line-wrapping to new mobile contexts
fad2671d3 Localisation updates from https://translatewiki.net.
262c84128 scrollSelectionIntoView: Code simplifications
a13c86033 scrollSelectionIntoView: Fix mobile logic
04774b03c Allow passing a pre-existing HashValueStore to getModelFromDom
1cf71b3f3 Catch errors from getNodeAndOffset

Bug: T202723
Change-Id: I41cf726dad38d4fe6647a1b760d66126fcee393f
2019-06-20 13:39:59 +01:00
Ed Sanders ad87c6c009 Improve debug bar margins on mobile
Change-Id: I6fd8b89dd44d5d8d933822851499264e4d0f4585
2019-06-20 13:15:52 +01:00
Timo Tijhof 45f3b5644c trackSubscriber: Remove use of 'ext.eventLogging.subscriber' alias
Deprecated in favour of 'ext.eventLogging'.

Bug: T221281
Change-Id: I16ca136be84b9c50208c4e702ec75d7ca33afd96
2019-06-20 00:57:17 +01:00
Ed Sanders 22f43207fe Apply active external link fix to all skins
Change-Id: Ic66082fca53f803f9ede6c100beb9072b40a0c00
2019-06-18 15:23:10 +01:00
jenkins-bot 69ff78868f Merge "Remove 'mobile-ab' config for section editing" 2019-06-17 20:37:51 +00:00
Translation updater bot 71f0bba6d1 Localisation updates from https://translatewiki.net.
Change-Id: I3dc685284886808cadcad317d05529384067c686
2019-06-17 22:34:32 +02:00
Translation updater bot 015afb93c5 Localisation updates from https://translatewiki.net.
Change-Id: I91e84d1886036d108b3fa4bec6412e2c3442759f
2019-06-16 22:36:55 +02:00
Max Semenik 718e7107b8 Don't use Maintenance::$mDescription directly
Change-Id: I8ec00d0e7b0105dd9d30602007bcc7aecc8ca089
2019-06-14 17:52:36 -07:00
Bartosz Dziewoński 600e369347 iOS browser menu bar tap stealing hack for bottom contexts
Change-Id: I7607bef4253fde894e307bcecaac6bd342864c0c
2019-06-14 23:49:38 +02:00
Ed Sanders df8feb6faf Move mobile context to bottom of page
Hidden behind ve.newMobileContext feature flag.

Bug: T204733
Depends-On: Id276686a0e82c12c457c81eaec9939722c65c7ec
Depends-On: Id5f7ead769dc30c0fbd2a8b8f6f6c4d68dcfabac
Change-Id: Ibd4b699dfe4bb9bcaec6898b6b82357eb287d128
2019-06-14 20:57:22 +00:00
Bartosz Dziewoński 01afd73aea Update VE core submodule to master (44556e8fd)
New changes:
ee96c6334 Localisation updates from https://translatewiki.net.
2a9ff2c54 Localisation updates from https://translatewiki.net.
5facf5ef6 Localisation updates from https://translatewiki.net.
afe09ea26 Make annotationsAtModelSelection fail in fewer cases
f6278bba0 Fix clipping on label preview in link context
42717187a ve.ui.AnnotationInspector: Deactivate surface after closing on mobile
44556e8fd Move mobile context to bottom of page

Bug: T199617
Bug: T204733
Bug: T220633
Bug: T225541
Change-Id: Icd6de1d7e380a14444ddba2044553c8c13682706
2019-06-14 22:56:24 +02:00
jenkins-bot 8cce3fa72a Merge "Avoid setting '&section' (with no equals or value) when switching to OWE" 2019-06-14 18:41:19 +00:00
Bartosz Dziewoński a68cc38b22 Avoid setting '&section' (with no equals or value) when switching to OWE
mw.Uri requires undefined rather than null to unset a parameter;
null instead generates a parameter with no value (and no equals sign).
Our own code in ve.init.mw.DesktopArticleTarget.init.js parseSection()
can't parse that and causes an exception.

Change-Id: I783ea6b91c115b79bbd9deac6669bea0661139af
2019-06-14 20:20:26 +02:00
jenkins-bot 5507d52287 Merge "Localisation updates from https://translatewiki.net." 2019-06-14 05:06:29 +00:00
jenkins-bot 355a54b792 Merge "trackSubscriber: Migrate away from deprecated 'schema.' modules" 2019-06-14 00:27:11 +00:00
Translation updater bot bf4acae10b Localisation updates from https://translatewiki.net.
Change-Id: Ie0cd5443876335478d305a1da9468b01484d5f5e
2019-06-13 22:41:00 +02:00
jenkins-bot ed6d540289 Merge "MobileArticleTarget: Update loading interface for new design" 2019-06-13 20:00:34 +00:00
Timo Tijhof fda2729ebc trackSubscriber: Migrate away from deprecated 'schema.' modules
The EventLogging extension no longer uses these internal modules.
They were phased out as part of last year's "lightweight EventLogging"
project (detailed at T187207). Migration notes at T205744.

VisualEditor has migrated already, mostly. It still depended
on the existence of these module names for some condition guards.

* The subscriber for 'mwTimingHandler' was guarded by 'schema.EditAttemptStep',
  but did not emit events of that schema. What 'mwTimingHandler' really
  needs is the '*SamplingRate' variable for its call to 'inSample()'.
  This previously worked because the variable and the schema are both
  provided by the WikimediaEvents extension.

* The subscriber for 'activityHandler' had a separate schema guard. This
  might suggest an intent for the code to silently degrade if WikimediaEvents
  were to be changed to no longer supply the second schema, or for the code
  to work for third-parties without WikimediaEvents if they register only
  the schema. However, this subscriber too calls 'inSample()' and needs those
  variables.

I've assumed for now that it is okay for these to all be guarded together.
Even if the schemas were to be removed and we were to forget updating this
code, the new EventLogging client degrades gracefully from this (no errors).

Bug: T221281
Change-Id: I260c25752c3becfe6e499813197fbf7a3dba88c3
2019-06-13 18:28:49 +00:00
Ed Sanders 87a3402203 Remove 'mobile-ab' config for section editing
Test is over.

Reverts I2c22d7636ae11d2db7780ae5adb3abe9df532b7c

Change-Id: I883dc8d6de6f2f39afc6b42c60503c3155f9fd8f
Depends-On: If3d24b44e37ca53826c60ada02cdf5636aa8606a
Bug: T225645
2019-06-12 17:45:20 +01:00
jenkins-bot 9114e5403b Merge "Reorder calls so that window is scrollable when trying to scroll to section" 2019-06-11 22:18:13 +00:00
Bartosz Dziewoński baa8bcb476 Reorder calls so that window is scrollable when trying to scroll to section
Bug: T225292
Change-Id: I07d899098cff13cf4f8224c45f118290bc392c53
2019-06-11 22:02:39 +00:00
jenkins-bot 67f9e17b44 Merge "Cleanup mwcore messages and dependencies" 2019-06-11 21:16:20 +00:00
jenkins-bot 53722cb92a Merge "Remove switch confirm dialogs" 2019-06-11 20:52:39 +00:00
Ed Sanders 2b7bbf0737 Cleanup mwcore messages and dependencies
* Move many messages from mwcore to articletarget or mwsave
* Delete old unused messages
  - visualeditor-beta-label
  - visualeditor-toolbar-savedialog
  - visualeditor-toolbar-savedialog-short
* Remove unused core messages (showtoc/hidetoc)
* Fix typos in comments

Change-Id: I59455f4cad272db9fd05f45f8a66069e5da0421d
2019-06-11 20:42:01 +00:00
Ed Sanders 7ad624f0a3 Remove switch confirm dialogs
Bug: T220007
Change-Id: I81b39a02d573d96bcb6b4238aabbcd077e874906
2019-06-11 22:35:34 +02:00
Translation updater bot e43c446e11 Localisation updates from https://translatewiki.net.
Change-Id: I2332f42f1c1092ccaf91eb173dec1e9802588e4f
2019-06-10 22:56:10 +02:00
Ed Sanders efae95dabf Dialogs: Use close flag for close actions
Bug: T225021
Change-Id: Ifd0cb40031c2717cc0716f98a27c124f54709003
Depends-On: I67b8474b0662f8dbc23c1b5ff883e3d4093bdbd4
2019-06-10 15:58:47 +01:00
libraryupgrader cdd3c69db5 build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: I59039cf354649d34661be0151df5dd94807606b4
2019-06-10 04:40:05 +00:00
jenkins-bot e60c7d777e Merge "Update VE core submodule to master (e531c251e)" 2019-06-07 21:37:40 +00:00
libraryupgrader a32c2a42e5 build: Updating mediawiki/mediawiki-codesniffer to 26.0.0
Change-Id: Iec9fc6e2ec593f7bcf8c1fe6b5762b65db2929ec
2019-06-07 15:54:03 +00:00
Translation updater bot edaa1d86d6 Localisation updates from https://translatewiki.net.
Change-Id: Idda8d8498ee74e4790a2c100c2c70512d4adcec1
2019-06-06 22:49:22 +02:00
James D. Forrester 14e747b398 Update VE core submodule to master (e531c251e)
New changes:
7f101ce9a Add new messages for add/edit link
e531c251e Update OOUI to v0.32.1

Change-Id: Ib9fb48c531c8bc787bd2efc3e4f59af8977b1977
2019-06-05 15:38:12 -07:00
Bartosz Dziewoński eb8aede95f MobileArticleTarget: Update loading interface for new design
* Remove animation for toolbar sliding into place. It now happens on
  the fake toolbar in MobileFrontend shown before the real toolbar
  loads, and our toolbar just transparently replaces it.

Bug: T217784
Depends-On: If21aa0ea619ec2500ce5fca6fe81eb27f26bb047
Change-Id: Ib6ff7594e1982d1b46e9ca89d6b9722d025e8207
2019-06-05 12:43:33 -04:00
Bartosz Dziewoński f48b5bcc9a MobileArticleTarget: Fix silly indirection via a global variable
Change-Id: I71349313b493c18cebe30df0b1b03defe81bb80e
2019-06-05 16:40:18 +00:00
Jforrester c1b9ce84c8 Merge "CollabTarget: Enable undo" 2019-06-05 03:25:04 +00:00
Jforrester 597bbefe0b Merge "Update VE core submodule to master (2da36280a)" 2019-06-05 03:24:45 +00:00
Ed Sanders 48b4051bef CollabTarget: Enable undo
Change-Id: I228ae26662d6577a1499ded1611b48a96f2fc8ef
Depends-On: Ic40e7290a06175916c8b7c0b20b5e8e8acbba7c8
2019-06-04 22:59:13 +00:00
James D. Forrester 65edcaf631 Update VE core submodule to master (2da36280a)
New changes:
ca588de0d CommentAnnotation: Make deleteable
02eb9e835 Synchronizer: Fix defaultName config
4101ca058 Add removeEmptyLastChildOnEnter to CheckListNode
080317f9f CheckListNode: Flip margins based on content direction
df1dbd0c4 Localisation updates from https://translatewiki.net.
a55f5d7d9 Make undo concurrency-aware

Bug: T185706
Change-Id: Id2b993eb6efcb0dde0c7d1ea1fc6a6cf91bc0e43
2019-06-04 15:57:46 -07:00
Bartosz Dziewoński 9cbc22c70d MobileArticleTarget: Remove a method that just calls the parent
Follow-up to 500462f4b2.

Change-Id: I1916a58b8814d1f03a14a35881f531d9de319736
2019-06-04 15:52:13 -04:00
Bartosz Dziewoński 4184d44dc5 MobileArticleTarget: Remove duplicate way to trigger abandon warnings
Abandon warnings are already handled by the code in MobileFrontend's
EditorOverlayBase. Using window.history.back() causes that code to run.
Having a duplicate way to trigger them only results in inconsistencies
because our dialogs animate in a different way.

Bug: T222315
Change-Id: I19c5616a6aeecf0ac63f37a564ef44f11df010b0
2019-06-04 15:50:59 -04:00
Translation updater bot 742564d1d2 Localisation updates from https://translatewiki.net.
Change-Id: Id625d72c939e7b643ebb6bfc0ce4c05cb20597a0
2019-06-02 22:31:12 +02:00
jenkins-bot 1ed01e0a05 Merge "Synchronizer: Fix defaultName config" 2019-06-02 15:43:16 +00:00
Ed Sanders 25cbd22b23 Synchronizer: Fix defaultName config
Change-Id: I2b7482f6405d7da8515f30c8060f7eac1758e6a9
2019-06-01 17:51:41 +01:00
Umherirrender e1442aa343 Add phan
Change-Id: I7352036536c1c8415b681f48f3ee0dcec315c035
2019-05-31 14:48:22 +00:00
Thalia cdb3b880af Use MediaWiki\Block\DatabaseBlock instead of Block
This follows the rename of the Block class in I6d96b63ca0.

Change-Id: Ib652feb34b7f10726ec775ff2929ca12ed66a8e1
2019-05-31 15:34:00 +01:00
Ed Sanders dbd4dfd727 Update VE core submodule to master (53e69bf14)
New changes:
5810e0cd4 Update UnicodeJS to v12.0.0
145991ded Fix file list on demo page
53e69bf14 SurfaceSynchronizer: Force websocket transport

Bug: T201531
Bug: T201532
Bug: T201533
Bug: T201534
Change-Id: I96beb31df55b41bf1d259f5e6964245008face22
2019-05-30 23:02:27 +01:00
jenkins-bot 8bd98a42af Merge "Allow switching from WTE to VE with changes in non-RESTBase mode" 2019-05-30 21:10:37 +00:00
Translation updater bot 142810144b Localisation updates from https://translatewiki.net.
Change-Id: I3af7db8676dde62427c9b66167f963ca9db05e06
2019-05-30 22:54:40 +02:00
Bartosz Dziewoński 8ae4925676 Allow switching from WTE to VE with changes in non-RESTBase mode
* Change the query in ve.init.mw.ArticleTargetLoader#requestParsoidData
  so that in non-RESTBase mode with wikitext it still returns the
  metadata required to initialize the editor, using the backend API
  code added in I1b35b28e428a1f86d2e34d90ddbe73361ce14818. This fixes
  the exception from T222312.

* Introduce new configuration option $wgVisualEditorAllowLossySwitching
  to control this feature. It is enabled by default, fixing T214542.
  We allow it to be disabled because switching in non-RESTBase mode may
  cause "dirty diffs" (non-semantic changes to the wikitext), which are
  undesirable on wikis where users carefully review all changes.

Bug: T214542
Bug: T222312
Change-Id: I58879cba5612002c70c24731306214d2577c2c52
2019-05-30 20:18:53 +02:00
jenkins-bot 0ce9cfcf90 Merge "Update VE core submodule to master (06f1ebb8e)" 2019-05-29 22:07:08 +00:00