hideLoading always gets called after activating, not just failing
Follows-up: I13058ae1
Bug: T127184
Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
New changes:
0e1f948 Localisation updates from https://translatewiki.net.
621f30e Localisation updates from https://translatewiki.net.
73c9829 FocusableNode: Bind position events later
75f2eb9 FocusableNode: Change mouseout events to mouseleave
6aeaabb Fix cache invalidation of SurfaceFragment.leafNodes
32ceee2 Share getSelectedNode logic between Surface and SurfaceFragment
a9782a0 ve.ce.Surface: Cache current selection
4fd5da1 Move model fallback for getDirectionFromSelection into method
b829a53 Move selection directionality to ve.ce.Selection
ba43c98 Replace some $.hasClass with Element.classList.contains
2beaa08 Localisation updates from https://translatewiki.net.
2ba1197 ce.TableNode#onSurfaceModelSelect: Table overlay optimisation
9d00622 Localisation updates from https://translatewiki.net.
33d090b Update OOjs UI to v0.15.4
Change-Id: Iab28b0513b075b4dfb1b207a55a0b297c3cea885
To get at least some Cucumber scenarios running in Jenkins, disable all
of them that are failing and run only ones that are passing.
The next step will be to fix failing scenarios.
Bug: T94162
Change-Id: Id0338c1d6b86d6b45220c5c0802074be397fb607
New changes:
fbd2dbd Localisation updates from https://translatewiki.net.
a455f9e Fix structure of broken nested lists from Google Docs
2f50c78 Table overlay: Prevent unnecessary scrolls when editing cells
8b1208c [BREAKING CHANGE] Move scrollIntoView down into the surface
Change-Id: I181d3277e745aa90cdf278eee28b640b570cbff3
New changes:
7da4868 After KeyDown, check unicorns before polling the surfaceObserver
6f4153f Document annotation content container usage
Change-Id: Iaa23da99f2f789e7a41fbec18ccc1c5b22830542
* Try to hide loading bar on failure
* Don't set wgAction back to 'view' if we're dropping the user back to the
wikitext editor
Bug: T125580
Change-Id: I13058ae131a1dda3b172e78d9b143d70831c47f1
The title is visibly varied in the context menu separately, and
we don't usually change the link tool's title - so this is just
a performance drain (updateState happens a lot).
Change-Id: I9cf2aa509a6aac3a2914fa52167cb4463843cd72
New changes:
cfef99f build: Bump various devDeps to latest and make pass
52dfc0d Localisation updates from https://translatewiki.net.
cf23fba SurfaceFragment: Handle multi-range annotations correctly
ac8bfe8 Localisation updates from https://translatewiki.net.
36ab134 Update OOjs UI to v0.15.3
fd38a4a Use plain DOM in ve.ce.LinkAnnotation
016e208 Localisation updates from https://translatewiki.net.
f5ff675 FocusableNode: watch for image loaded/layout changes for invisible icons
Change-Id: Idfb2175ef5c0ad1e557f341325878fd8c46e169a
* Override the static cloneElement. getClonedElement shouldn't
be overridden as doing so misses static invocations.
* Apply the same fix to extension nodes
* Fix DOM loop to reference clone.originalDomElements[ i ]
Logically depends on Id8024c171c to work.
Bug: T126169
Bug: T126114
Change-Id: Icf4d3115db5b12b97a6c805ff3d0b71d9e88b804
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
This version of the linter cleans up a number of options. 'es5' is now assumed to be
true by default, and replaced as 'esversion'; 'latedef' is extended to also cover
functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid
future-incompatible names for ES6+ support.
I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is
meant to be loaded by all JS-capable clients to determine if it is (amongst other
things) capable of ES5, so now we assert ES3 compatibility via jshint.
* grunt-jscs: 2.5.0 -> 2.7.0
Minor version bump that doesn't affect us.
* grunt-jsonlint: 1.0.6 -> 1.0.7
Trivial version bump that doesn't affect us.
Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.
Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
New changes:
c231686 getViewportDimensions: Fix calculation of 'bottom'
76d7f27 KeyDownHandlers: Make Tab behave the same in table cells as in table selections
19891d6 ResizableNode: Remove assumption about 'width'/'height' attributes
380ff04 cloneElements: Use the correct node type when cloning
5e31903 Localisation updates from https://translatewiki.net.
Change-Id: I1225329b99779d84390ca5ee70de5b431cd8cbda
