Commit graph

6796 commits

Author SHA1 Message Date
Roan Kattouw 861d0976d5 Make the order of insert tools consistent in dialogs
The promote/demote rules in mw.Target had changed, but these changes
weren't copied to MWMediaEditDialog and MWReferenceDialog.

Also, we ideally shouldn't need to maintain these things
completely separately from each other.

Bug: 62286
Change-Id: I459c3310f2ac0d8860a686a05da4f45d9a888801
2014-03-05 14:49:52 -08:00
Translation updater bot 7efd0b6c65 Localisation updates from https://translatewiki.net.
Change-Id: I080bb0e657f7963752f06e129bd46232f49e63b2
2014-03-05 21:12:14 +00:00
jenkins-bot 99fb026af4 Merge "Deal with 'none'/'border' and default size in media edit" 2014-03-05 19:11:19 +00:00
jenkins-bot d7eaf9ea1b Merge "[Browser tests] Updated Ruby version from 2.1.0 to 2.1.1" 2014-03-05 10:48:26 +00:00
Moriel Schottlender 89aecd54ba Deal with 'none'/'border' and default size in media edit
There are several conditions to defaultSize behavior of thumbnails and
frameless images and other images when it comes to default size. In the
same principle is 'border' which is not quite a type despite the fact
it 'behaves' as such in wikitext (and has a unique identifier that comes
instead of the other types.

This commit aims to organize this behavior for the user in an
understandable manner.

* Add 'basic' image type for images that have no specified type ('none')
* Handle the difference in 'default' size behavior between basic images
  and thumbnails/frameless. The thumb/frameless images have the default
  wiki size. Other images' default size is their original dimensions.
* Force wiki-configured default size for thumbnails and frameless images
  in the DM. This is done because at the moment Parsoid's output is of
  Wikipedia's default size rather than the local wiki's. The size is
  adapted if needed, directly in the DM.
* Added 'border' as a pseudo-type checkbox flag that sets css class
  'mw-image-border' is for parsoid rendering on save.
* Add 'make full size' to the size widget select and treat it as a faux
  default button for basic and frame images.

Bug: 62013
Bug: 62024
Bug: 61155
Bug: 61059
Bug: 61282
Change-Id: I6778705306f0dd6bb96afeb91383089a4ddab7ed
2014-03-05 03:53:46 +00:00
Translation updater bot f804838f49 Localisation updates from https://translatewiki.net.
Change-Id: I3f4086c274bd8c476add7042648014cc93ba3db2
2014-03-04 20:46:42 +00:00
vikassy 3486b0f424 [Browser tests] Updated Ruby version from 2.1.0 to 2.1.1
Bug: 62152
Change-Id: I61cbb10749fcc568429c626497a76c41074368e8
2014-03-04 19:48:48 +00:00
James D. Forrester a78a8b458e Update VE core submodule to master (48dd09a)
New changes:
48dd09a Update OOjs UI to v0.1.0-pre (8ac38a5c31)

Add OOjs UI's new Apex theme to the module definition (for users on
older versions of MediaWiki that do not have it available).

Change-Id: Ia79c2380aa2368d58e5980131cf70c91576dfd49
2014-03-04 11:45:12 -08:00
James D. Forrester 73f7707f4e Update VE core submodule to master (f93e960)
New changes:
5bde356 Update OOjs UI to v0.1.0-pre (f3bc5c6c1c)

Change-Id: Ic7114ffef63c26d4d73a6c86b7e3d62330f7641f
2014-03-03 18:52:11 -08:00
James D. Forrester 5823976fff Update VE core submodule to master (674b245)
New changes:
7c5b7be Increase keyboard shortcut height hack to work in FF
c9fb99d Changeable UI language in SA demo
6a885bf Localisation updates from https://translatewiki.net.
674b245 Update scripts: Ensure clean master, latest npm dependencies, abort on grunt error

Change-Id: I0648d6ea531fbfbab5a5230911a5e98819538158
2014-03-03 18:34:48 -08:00
Roan Kattouw 810fc7df16 Update VE core submodule to master (74be717)
Also add MW configuration for ModelRegistry back, was removed in core.

New changes:
564c459 Localisation updates from https://translatewiki.net.
f30e061 Consistency in test header comments
74be717 Remove MW-specific config and genericise tests in ModelRegistry

Bug: 53148
Change-Id: I67e77bd41bbff52f88632ff9e4cf5e4c48251174
2014-03-03 11:24:56 -08:00
Ed Sanders b14326624b Consistency in DM MW test naming and comments
Move MWConverter to Converter and fix some comments.

Change-Id: I8b73d064c890e9cdae61f8118b092e5041febaa5
2014-03-03 14:34:08 +00:00
Translation updater bot f72a0a4b2c Localisation updates from https://translatewiki.net.
Change-Id: I19f5d3fd4783f4c65a787828ae3366b0e659f58b
2014-03-02 20:46:00 +00:00
jenkins-bot 0aa43650b7 Merge "Revert "Revert "Set href attribute of newly inserted image to image title""" 2014-03-01 01:38:43 +00:00
Jforrester cb9548a8e6 Revert "Revert "Set href attribute of newly inserted image to image title""
This reverts commit e9ae4a94b4.

Change-Id: Icad3c2f5d3f0ddfba4bb0033011a3e5089fb5cd1
2014-03-01 01:35:57 +00:00
jenkins-bot eb10020f27 Merge "Add tooltip to page options menu widget in the toolbar" 2014-03-01 01:35:46 +00:00
Trevor Parscal 400a522fa6 Make TransclusionContent inputs full width and autosize
Also add classes to the other pages that don't have them yet for CSS targeting.

Change-Id: I0415852f93a1c54f6370016a968fd9b67d9adc42
2014-02-28 17:27:55 -08:00
Trevor Parscal 2fb2f441e8 Prevent superfluous setPage calls by introducing a lock
Also, use new getClosestPage method in ooui to select which page should
be selected next when a page is removed.

Change-Id: I7ce4d2ca55aac72f3aaa14c98c7189a440598e08
2014-02-28 17:26:04 -08:00
Trevor Parscal 61c1f11fef Use small option for template dialog
It's much cuter this way.

Change-Id: Ibd4a3660b2ec1613ec64c75d29574b73da69a3b8
2014-03-01 01:24:29 +00:00
Trevor Parscal 3edad8d0da Fix off-by-one error in TransclusionModel when moving items
The error occurs when moving an item down (increasing index) which
removes the item, adjusts the index and then inserts the item. The index
shouldn't be adjusted when moving one down, however, because once
removed everything shifts and the +1 index set initially to move it is
still good.

Change-Id: I44bd2b3eb4bbbef58a6ac181e75969ec7c2cab6f
2014-03-01 01:24:11 +00:00
Trevor Parscal 315f10cea4 Cleanup dialog properties
No need to re-initialize properties set in parent class.

Change-Id: Ib98d9636ef169f58b4044d09972063bd5f19b3af
2014-03-01 01:24:02 +00:00
Trevor Parscal def3a5e21a Cleanup page class names and comments
Change-Id: I739b5d9b295d09b86104133a8f4eb30070d664f2
2014-03-01 01:23:17 +00:00
Trevor Parscal ec004d16be Move parameter adding to a placeholder page
Parameter placeholder pages are generated for parameter with empty
string as their name.

Change-Id: I56c3df1ada6c4f41ebf6466ca280a2333da60071
2014-02-28 17:20:24 -08:00
Trevor Parscal 85e0bf533a Use template name as dialog title whenever possible
Change-Id: I4235f6ed68e1f95c4593caa23ada734fb8493426
2014-03-01 00:57:55 +00:00
Trevor Parscal cb5a9b948c Redesign template parameter pages to be more space efficient
* Show label, input and remove control on a single line
* Right align label to conserve vertical space without sacrificing
  fill-out speed
* Show description in gray text below the input
* Show remove button only when page is active
* Make description lighter when page is innactive

Change-Id: Iaa09f3bf909ccd415de7af8f428495fef3046893
2014-03-01 00:52:06 +00:00
Trevor Parscal be27de3b89 Remove outline from TemplateDialog
Change-Id: I1df5700a241671678b22f490d5d3fc4a456a4218
2014-03-01 00:51:17 +00:00
Trevor Parscal d1b0b87257 Use label of first template as Template dialog title
Change-Id: Ib273430c94249c8dbad14abb9d1f6ad3286bdc8a
2014-03-01 00:51:01 +00:00
Trevor Parscal 21efc9994b Cleanup duplication in TransclusionDialog classes
Change-Id: I96bcd07a1548b21c8a11b9d2990400d4f48e044a
2014-03-01 00:50:37 +00:00
Trevor Parscal cbd3419dfb Update VE core submodule to master (ac4b49a)
Also update template/transclusion code for OOJS UI
OutlineControlWidget changes, and uses some of the new
functionality.

New changes:
ac4b49a Update OOjs UI to v0.1.0-pre (51f922ba17)

Change-Id: Id7a1f60cd6ce3bdaba7ccb8774563b9e81c75cad
2014-02-28 16:41:42 -08:00
Roan Kattouw be096d8c9e Update VE core submodule to master (74a059a)
New changes:
da51da3 ve.ui.MediaSizeWidget: Use lowercase types hint for primitive value
54a8606 Blur the surface when a dialog is opened
3c3234f Don't show phantoms for hidden protected items
0fb119b Fix handleEnter in nodes that don't split
74a059a Don't allow getNearestCorrectOffset to return -1

Change-Id: I7c5669eb780d4b73b056ce1ca5daed453e7398df
2014-02-28 16:23:21 -08:00
James D. Forrester 3efa7490d6 Add tooltip to page options menu widget in the toolbar
Currently "Page options" but better suggestions are welcome.

Bug: 61892
Change-Id: I5cf7a4cabaaf7a5d5d0bd1b806f8d95ea4d88033
2014-02-28 11:26:47 -08:00
Ed Sanders 09c0611484 Fix-up mwcore split: Split out MWDialogTool
Because everything was broken.

Follows-up I6374854eaa1 which split up mwcore into smaller parts but
left MWDialogTool still as one file part of mwcore. Since the various
ve.dm classes are now part of the other modules that depend on mwcore,
the MWDialogTool classes were pointing at classes that don't exist yet
(e.g. ".modelClasses = [ ve.dm.MWBlockImageNode ];").

Change-Id: Ic05b173d730a8a0f6539fdcd818aaf674d2a4019
2014-02-27 16:33:19 +00:00
jenkins-bot 43abad6193 Merge "Mark hidden categories as different in the meta-data dialog" 2014-02-27 02:12:58 +00:00
Krenair 5fc0faa7e8 Mark hidden categories as different in the meta-data dialog
This gives users a clue to understand why they won't display in the
category box at the foot of the page.

Bug: 50763
Change-Id: I1cf3a76bbf6370e7f67ec16f0a931f6ea4ba9d28
2014-02-27 02:08:48 +00:00
Roan Kattouw efe925067c Followup 0f45399: move some forgotten files out of mwcore
Transclusion/TemplateModel classes to mwtransclusion, CE
LinkAnnotations to mwlink.

Change-Id: I4fdef01ce50a78e109a6297d287da49ca8e41d08
2014-02-26 17:42:00 -08:00
jenkins-bot 66df1ec1b5 Merge "Track edits where user switched into wikitext editor from VE" 2014-02-27 01:35:56 +00:00
Krenair 952a239866 Track edits where user switched into wikitext editor from VE
By adding a tag called 'visualeditor-switched'.

Bug: 56465
Change-Id: I1426d300499b59ca55c9b97fc1560f4adbfa9295
2014-02-27 01:33:40 +00:00
jenkins-bot 2000083819 Merge "Remove "msgs" files for i18n batch processing" 2014-02-27 01:25:58 +00:00
jenkins-bot 10c5ff54ca Merge "Don't use a changeable tooltip for edit notices" 2014-02-27 01:23:52 +00:00
jenkins-bot a9f0d3cb5c Merge "Split up ext.visualEditor.mwcore into smaller parts" 2014-02-27 01:21:46 +00:00
James D. Forrester 09f6daab23 Remove "msgs" files for i18n batch processing
No longer needed, and have been throwing up confusing i18n string search hits.

Change-Id: I17d3850ff4f17c1c92735dcf3deb9a33fe5d6de2
2014-02-27 01:21:03 +00:00
James D. Forrester 532077b57f Don't use a changeable tooltip for edit notices
We can't change tooltips once they're set for buttons like this (they're
static), so for values that can change we need to use language that does
not need plurals.

Bug: 61891
Change-Id: I78e5576e348ee92bc39315fd494b3398ae2c14bf
2014-02-27 01:20:43 +00:00
James D. Forrester 0f45399082 Split up ext.visualEditor.mwcore into smaller parts
Core retains core functionality, including text styling and architectural
items like dialogs.

The new modules are:
* mwformatting
* mwimage
* mwlink
* mwmeta
* mwreference
* mwtransclusion

The new modules are loaded in ViewPageTarget (for desktop), except for
mwlinks which is included from MWTarget (for desktop and mobile), per the
needs of the Mobile team.

Also, mwgallery was moved to desktop-only loading status.

Some styles which were loaded in mwcore but only used in modules is now
loaded in said modules.

This does not split up ext.visualEditor.core yet, which is left as an
exercise for the fool-hardy.

Bug: 61075
Change-Id: I6374854eaa13af824c11078d2f7004dc8a211a30
2014-02-26 16:31:15 -08:00
jenkins-bot ce51fde0d1 Merge "Default/custom switch size quickfix" 2014-02-26 23:42:40 +00:00
Moriel Schottlender 0f51538272 Default/custom switch size quickfix
Handling a bug where the placeholders weren't set to images that weren't
set to default size. The switch to 'default' failed because there were
no placeholders and data for default to go on. This is now fixed in this
commit; if the image is non-default, the values are given to the media
size widget from the config settings.

Change-Id: I402b8d4de606c0939daa316408fcf5de2f0b2181
2014-02-26 18:39:05 -05:00
Roan Kattouw a1a5588aa8 Update VE core submodule to master (238c961)
New changes:
9426fe0 Check indentation was successful before trying again
a30d192 Add special case to de-indentation for slugs in listItems
91a275d Bold/italic icons for ar
523bbdb ve.js: Remove unused hasOwnProperty reference
016faa6 Add italic S icon, and set bold/italic for ksh
0910113 A strikethrough Y icon, and set bold/italic/strikethrough for fi
0c1c35d Allow annotations to remove other annotations
4305ccb Restore focus after node-destroying actions
55634da Localisation updates from https://translatewiki.net.

Change-Id: I8b390061fd7209245b3eff429954e6ec4271d8a3
2014-02-26 15:01:44 -08:00
Translation updater bot 0d5021bf33 Localisation updates from https://translatewiki.net.
Change-Id: Ia7bffeb357b08f9dfa953b034e9cddea7fab7d9c
2014-02-26 22:04:49 +00:00
jenkins-bot e594fb364a Merge "Use regexes for text of headings links" 2014-02-26 21:41:56 +00:00
cmcmahon 5544333be9 Use regexes for text of headings links
Change-Id: I196e555c818dda0f9211e9e402255b29d93a3b7e
2014-02-26 14:37:05 -07:00
Moriel Schottlender 2a5ac5fb6a Limit thumbnail dimensions in media edit dialog
Add a dynamic limit to image dimensions; image is limited to its max
size if it is 'thumb' and unlimited in size otherwise.

This change depends on ve-core Scalable/MediaSizeWidget adjustment
https://gerrit.wikimedia.org/r/115306 (merged)

Bug: 61282
Change-Id: I1247b1360ae50af039673fa3f2b3521e457ef578
2014-02-26 12:43:26 -08:00