Commit graph

295 commits

Author SHA1 Message Date
Ed Sanders 425e581613 Unregister core image types
Once MW images are registered, we should remove core image support so
we don't accidentally match to them (e.g. an MW inline image with an
unsupported extra RDFa type).

Change-Id: I1c8567346c371fe338f95b232c9ac53e009c5a46
2015-06-02 14:36:14 +01:00
Ed Sanders b7f92605b2 Move test registry hacks into QUnit setup/teardown hooks
Change-Id: I7b56bc7a9a69f64073ab97bdb1911d17b328b8b8
2015-06-02 14:36:10 +01:00
ryasmeen@wikimedia.org cb1612b60a [BrowserTest] Fixing the test for general markup
Identifier mismatch.Updated now.

Change-Id: Ibf7b6aea144e2435d2a23e4768481a11cb8a6619
2015-05-25 14:43:56 +02:00
ryasmeen@wikimedia.org 058da228dd [BrowserTest] Fixing broken test for Page Options test
The test was broken as some identifiers were wrong. Updated it.

Change-Id: I03541e4ae0ed7e4c121b801a036e49bebe4d5909
2015-05-24 21:30:53 +02:00
ryasmeen@wikimedia.org 0da5989eb7 [BrowserTest] Fixing the broken test for bullets
The test was broken for using wrong identifier in the test. Updated them correctly.

Change-Id: I46a9c4ebaf1b44f0db24f2b64dcd863697011203
2015-05-24 14:30:59 +00:00
jenkins-bot 2e24426fdf Merge "[BrowserTest] Fix the lists and indentation screenshot scenario" 2015-05-15 13:35:47 +00:00
jenkins-bot f7b6fea4a2 Merge "[BrowserTest] Fix the special character button screenshot" 2015-05-15 13:35:22 +00:00
Amir E. Aharoni 462315f16f [BrowserTest] Fix the lists and indentation screenshot scenario
* The element's class name changed.
* Zooming is removed - it was breaking the test and
  it's not needed anyway.
* Fix another element with the same class.

Change-Id: I46a867619ed49936c3868f6b1b15e773bdb6f6b1
2015-05-15 15:02:34 +03:00
Amir E. Aharoni e471860536 [BrowserTest] Fix the special character button screenshot
The element moved out of the Insert menu to the toolbar.

Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
2015-05-15 13:56:47 +03:00
Amir E. Aharoni f30f90ace0 [BrowserTest] Fix the text formatting screeshot scenario
The element's class name changed.

Change-Id: I7070c1e06f6639783097b953cc384b12eff2a23b
2015-05-15 13:49:52 +03:00
Bartosz Dziewoński e459c14442 ve.init.mw.ViewPageTarget: Simplify toolbar save button and inner toolbar code
All this is no longer needed since 121216184718e7ebe22d6ecc8f5af5fe4e202465 in
OOjs UI and started causing issues after bb9c9c4f6a2fca6aed0e671e904e469d57da5f34.

Bug: T98795
Change-Id: I6493d6b52b313aac521aee2b0cff1571ea63bbe5
2015-05-12 13:50:40 +02:00
James D. Forrester 85381a6b75 Update VE core submodule to master (2714bfc)
New changes:
8dc8b26 Trim leading and trailing whitespace from annotations
306feb4 Add get(Col|Row)Count to TableSelection and use in isFull*
1c06d21 Cursor holders for native cursoring to ce=false nodes
b08384d Provide file extension fallback for FileTransferHandlers
28844ed [BREAKING CHANGE] Move all icons to OOjs UI's icon packs
9d37355 demo: Set 'lang' attribute of target
8945420 Follow-up 8dc8b266: account for annotations that return []
c2bbc97 Localisation updates from https://translatewiki.net.

Local changes:
* Switch to using OOjs UI icons for VisualEditor core features
* Update test for whitespace trimming

Change-Id: I12b22a411600b6e8e61858e7ed600fb53eedd95d
2015-04-16 14:02:59 -07:00
Ed Sanders fdcd42f73a Split AlienExtensionNode into inline and block
MWExtensionNode:
* Inherit from LeafNode at the top level. Inline and block only
  differ in CE where inline has isContent set.

MWAlienExtensionNode:
* Inhert from MW(Inline|Block)ExtensionNode respectively. Both
  mixin MWAlienExtensionNode.

Bonus:
* Bring in paragraph unwrapping on inline nodes from MWMathNode

Bug: T93712
Change-Id: Ib04234f740cf1f27c861d8b3cfeea5e323b94678
2015-04-09 16:32:02 +01:00
Amir E. Aharoni 9962663f81 [BrowserTest] Disable the Cite button screenshot
It looks differently in different languages,
and it is likely changing now with Citoid being deployed,
so it shold be disabled for now and revived when Citoid deployment
stabilizes.

Change-Id: If6a6ecf450060eb1387aaf90fd0cfb937b08bd3d
2015-03-27 14:46:39 +03:00
Amir E. Aharoni 8cb387a269 [BrowserTest] Redefine the Apply changes element for language screenshot
Redefine the element to include the full button
and remove the padding, which is now not needed.

Change-Id: I1ac244bc97b38c9d8b47ddd778a653783a748a49
2015-03-27 14:16:48 +03:00
Amir E. Aharoni d941263d33 [BrowserTest] Add padding to some more screenshots
Change-Id: If103488927e3309479b7b5f9f380135052c7ac9d
2015-03-27 14:11:14 +03:00
Amir E. Aharoni 0745d38a72 [BrowserTest] Add padding to the "Apply changes" button screenshot
Change-Id: I1a7aaca8013bf671ff39c310d5ad0dd1725b094a
2015-03-27 00:43:49 +02:00
Amir E. Aharoni 0cd5797a56 [BrowserTest] Add padding to screenshots of the page settings dialog
Change-Id: I460fc82a10ca5172537a97f28f3a50573c784a93
2015-03-27 00:43:01 +02:00
Amir E. Aharoni a1271abae3 [BrowserTest] Add padding to the Edit Links screenshot
Change-Id: Ife795e5f34b69fc6790cd04b217f823205737c0c
2015-03-27 00:41:38 +02:00
Amir E. Aharoni 5795b84d59 [BrowserTest] Add padding to the page settings item screenshot
Change-Id: I38f9d81cbfaa28c51997105bdc2cbaa81ed02783
2015-03-27 00:40:31 +02:00
Amir E. Aharoni fb4212232d [BrowserTest] Show the full Formatting pull-down in the screenshot
The scenario for the Formatting pull-down screenshot didn't click
the "More" element in the bottom. This is now added.
The "More" element itself is redefined to be generic and work with
all pull-down menus - there is supposed to be only
one active menu at a time.

Change-Id: I27122f3192b220919311993ecd9a10d85ef5828d
2015-03-27 00:31:11 +02:00
jenkins-bot c3ac0f0dd1 Merge "[BrowserTest] Add padding to the Formatting menu screenshot" 2015-03-26 14:28:45 +00:00
jenkins-bot cc4ac9c327 Merge "[BrowserTest] Add the toolbar to the special chars screenshot" 2015-03-26 14:28:39 +00:00
Amir E. Aharoni 0631a42735 [BrowserTest] Add the toolbar to the special chars screenshot
This makes it clearer which button opens the special character tool.

Change-Id: I34a2ba182af0bdce164c4b21f97ee1bb13152593
2015-03-26 16:20:19 +02:00
jenkins-bot b669d5a95d Merge "[BrowserTest] Add padding to editing tabs screenshot" 2015-03-26 14:17:22 +00:00
Amir E. Aharoni 96a2aad660 [BrowserTest] Add padding to the lists and indentation screenshot
Change-Id: I7ef7f1b0bbf3a0a7b56cb7051677a0df3ff8a41b
2015-03-26 15:59:44 +02:00
Amir E. Aharoni f7c2edf886 [BrowserTest] Fix the lists and indentation screenshot
Capture the whole button and menu.

Change-Id: I035109916a90efbd12e5f3ddb58b98a53b8e57d3
2015-03-26 15:57:42 +02:00
Amir E. Aharoni ef5bd83e55 [BrowserTest] Add padding to the Formatting menu screenshot
Change-Id: I606678381a9d291342b3c5d9cba67aef125725ee
2015-03-26 15:40:47 +02:00
Amir E. Aharoni d7926f460c [BrowserTest] Add padding to editing tabs screenshot
Change-Id: I60b915f470a751c041718bf339fa5bd27d5291ef
2015-03-26 15:38:00 +02:00
Amir E. Aharoni 8eb5ca1536 [BrowserTest] Add padding to Insert button screenshots
Change-Id: Ic79942bddf811b7f219424c9ae317c7664f9a193
2015-03-26 15:23:49 +02:00
Amir E. Aharoni b62be2355e [BrowserTest] Capture the whole Insert button in the screenshot
Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
2015-03-26 15:13:47 +02:00
James D. Forrester 497e7eb4a1 Update VE core submodule to master (cb06317)
New changes:
5197b2d Rangestate optimization
80a07cf Unmix GeneratedContentNode from AlienNodes
f510e9c Make (Node/Annotation/MetaItem)Factory inherit from ModelFactory
b625ff0 Localisation updates from https://translatewiki.net.
5c4653c ve.qunit: Use 'jscs:disable' comment rather than hacks
90e9480 Remove registration of abstract AlienNode classes
d325674 i18n/en.json: Convert from spaces to tabs, like all other files
f40fc15 Add 'classes' config option to focusable nodes to simplify AlienNode
f7c8999 Document config options as @cfg
ad3aa0b ve.ce.Surface.test: Groundwork for testing non-linear selections
cd1a992 Localisation updates from https://translatewiki.net.
c92471e Move drop marker to highlights layer and position absolutely

Change-Id: I437663d93a346a06c6a5137cce5149c7a6fcbb7f
2015-03-25 18:20:35 +00:00
jenkins-bot 80d8312c28 Merge "Add unit test for mwAlienExtension node" 2015-03-25 14:59:34 +00:00
Amir E. Aharoni 1d1ffac74e [BrowserTest] Capture the whole formatting button in the screenshot
This makes the screenshot nicer and more complete.

Change-Id: I0dd9efd2978ff5468ab6101b11b7e6fdd3b0da30
2015-03-24 12:34:42 +02:00
Amir E. Aharoni cbed069984 [BrowserTest] Rename headings dropdown scenario
Change-Id: Ib59cf24ad30823ddfcf1d31a9eb2c45efd0199fc
2015-03-24 10:45:22 +02:00
Amir E. Aharoni 8c48b3055f [BrowserTest] Add padding to the Headings dropdown screenshot
Makes it look nicer.

Follow up to
Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556

Change-Id: Ic4d473159942918776b7c5e7107e48b824c228e3
2015-03-24 10:31:50 +02:00
Amir E. Aharoni 47af0b6449 [BrowserTest] Capture the whole dropdown indicator in the screenshot
The Headings menu screenshot started from the arrow-down element:
https://commons.wikimedia.org/w/index.php?title=File:VisualEditor_Toolbar_Headings-en.png&oldid=154425461

Now it captures the whole menu so it will look more complete

Change-Id: Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556
2015-03-24 10:18:33 +02:00
Ed Sanders 1be77a90e3 Add unit test for mwAlienExtension node
Change-Id: I0323cf16f103ad801127568afe75e03d90e62c37
2015-03-23 16:06:09 +00:00
Amir E. Aharoni 065d26e363 [BrowserTest] Add a screenshot for the Page settings menu item
Change-Id: I0ec601dc9559521746fe6e7fbad05f2df8f7497e
2015-03-23 12:38:45 +02:00
Amir E. Aharoni 73523eb5cf [BrowserTest] Add a screenshot for the category item
Change-Id: I3f607e1013dbdac6974b33b557d8a0fffe4d4590
2015-03-23 12:31:00 +02:00
Roan Kattouw 884f301aa0 For empty / whitespace-only headings, output <p> instead of <h#>
Because sending HTML like <h2>  </h2> or <h2></h2> to Parsoid
produces undesirable output like ==  == or ==<nowiki />==

Bug: T51452
Bug: T52100
Bug: T57769
Bug: T61647
Change-Id: If15a1b4b31d4f08c23ecdf2ecf61a8a14a77259a
2015-03-20 23:05:37 +00:00
Amir E. Aharoni c4f21ecd03 [BrowserTest] Remove when_not_visible check from 'I click Save page'
The when_not_visible line fails, but it doesn't seem to be needed
in the first place. The when_present line appears to be enough.

Change-Id: I572dabb5d53553d454f6e40c5602fbe3252c3657
2015-03-19 14:54:32 +02:00
Amir E. Aharoni e34aa6aab4 [BrowserTest] Disabling the References list test
The functionality chnaged significantly, so the steps must be changed.
Removing the tag until it's done.

Change-Id: Iacdf78d3b6f00e39cb2bf313b79489035f1c0b62
2015-03-19 14:26:08 +02:00
Amir E. Aharoni 425b53a1e2 [BrowserTest] Revert the definition of the disabled_save_button element
The element is <div>, and using English text doesn't work
in other languages.

Follow up to
Icd79ec9b489557c3259ff7f2c11b2a899c767d0f

Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7
2015-03-19 12:14:38 +00:00
Ed Sanders b83d23c620 Update VE core submodule to master (b57d224)
New changes:
541659f [BREAKING CHANGE] Remove domElements attribute from aliens

Local changes:
* Update alien tests

Change-Id: I26a7ebc709fae9d2365a7f9ce2c4cfdcc10620a2
2015-03-18 14:16:10 -07:00
James D. Forrester 70cff83f68 Update VE core submodule to master (6bd2ea5)
New changes:
44ca3b6 Use store indices in annotate operations
3ebbcce Make range optional in getUsedStoreValuesFromRange
9d03a5e Set originalDomElements whenever a data element is created
4cfffde Simplify annotation hashes
4eeb8bb Add handlers for font annotations
4a6d6f0 Localisation updates from https://translatewiki.net.
05de45e ve.ui.ToolbarDialogTool: Fix documentation
6797d6d Use type from toDataElements when creating annotations
b3a3839 Store reference to DM document in transactions
c073a24 Load special characters in Platform instead of SpecialCharacterDialog

Local changes:
* Add new files to VisualEditor.php
* Re-sort i18n strings in VisualEditor.php
* Re-run extenson.json creation
* Update documentation HTML file
* Update tests for adjacent annotations fix

Change-Id: I7a5e79e68ab8a7aae0e9af42d011943019f7f85f
2015-03-18 12:15:24 -07:00
Cmcmahon 698f36cdd4 [BrowserTest] update Cite test for new UI
* Access to Cite options changed
* Various target locators also changed

Paired with Rummana for these changes.

Change-Id: Ib7c3fbd1842879745d3d3128c66d90cc2b4f98cb
2015-03-17 15:54:14 -07:00
Moriel Schottlender bbb5c84149 Remove MWTransclusionMetaNode
Since all transclusion nodes can be interacted with (including the
'hidden' ones,) there is no need for MWTransclusionMetaNodes.

Change-Id: I23d37e3d82029b7475ec68ebb04883c7e05370cc
2015-03-12 13:12:32 -07:00
Ed Sanders f4221167a7 Test for class attribute duplication bug
Depends on I8b48376 in core.

Bug: T88148
Change-Id: I63c3fa939495659becd72f93fc5aac881629327f
2015-03-11 10:42:14 -07:00
Cmcmahon d5f78cc6e4 [BrowserTest] Update locator for the Insert/More link changed
Change-Id: I2d4f68edb4bfad6813e9138afb77efadd75b2986
2015-03-11 17:29:46 +00:00