Commit graph

45 commits

Author SHA1 Message Date
Ed Sanders 86c405a2e1 Prefere ve.extendObject over $.extend
Change-Id: I37fef45701653cef08de9ec699865aa4fdf477bc
2021-11-15 21:30:19 +00:00
Ed Sanders a71dd4f797 Ensure correct classes are added to surfaces
* Create getSurfaceClasses method.
* Pass surfaceClasses to target widgets.

This ensures that the 'content' class is passed to mobile
target widgets, and the 'mw-body-content' class is added
in a less hacky way.

Change-Id: Ibce6d1a1d0fda63cca354761f1b91f808858e95b
2021-05-23 20:04:28 +01:00
Ed Sanders 09f4af2a63 CollabTarget: Add close button on mobile
Move comment button into 'insert' menu to make room.

Change-Id: I00ace1477d08041e9af6d81ae2e6635151575f8b
2020-08-03 07:55:06 +00:00
Ed Sanders a9d7884d3b ExportWikitextDialog: Add ellipses to "Export" buttons
This indicates these are not the final actions in the process.

Change-Id: I88227a1025f56ea59ef76a59b81cde22e81a959a
2020-07-30 16:23:02 +01:00
Bartosz Dziewoński 7b47575a45 Add accessibility labels to all type: 'list' toolbar groups
Bug: T245776
Change-Id: I67d8e239f4fed7dd7ac4b98be3362426e753076b
2020-03-14 14:13:53 +01:00
Ed Sanders 20561e7e10 Remove citefromid alias support
Change-Id: I74d67a2ea5118ee18c462ccfea06a72cc73c627b
2019-06-20 16:06:07 +01:00
Ed Sanders 48b4051bef CollabTarget: Enable undo
Change-Id: I228ae26662d6577a1499ded1611b48a96f2fc8ef
Depends-On: Ic40e7290a06175916c8b7c0b20b5e8e8acbba7c8
2019-06-04 22:59:13 +00:00
jenkins-bot 7dc2fee2f7 Merge "MobileCollabTarget: Cleanup toolbar" 2019-05-17 16:55:29 +00:00
Ed Sanders d3d8748967 CollabTarget: Disable nullSelectionOnBlur, as per ArticleTarget
Change-Id: I690e6d63109267f3b385311ecdf84eea24b0e998
2019-05-17 16:29:53 +02:00
Ed Sanders 47af04b8d9 MobileCollabTarget: Cleanup toolbar
Change-Id: I4b2e21ce61cb647ca6a74bdbdd8def614ed41341
2019-05-14 20:19:54 +01:00
Ed Sanders 7f39bb9520 CollabTarget: Replace button in toolbar
Change-Id: Ib9d08dd473421e915a0a00edd5c058dcd292fabe
2019-05-09 10:56:43 -05:00
Ed Sanders 0db4ae6e00 eslint: Enable valid-jsdoc
Change-Id: Ia0d1e57246a1c567d73022ceca9b8c02850f9bc8
2019-04-17 17:13:39 +01:00
jenkins-bot 53db6727b3 Merge "Rename 'citefromid' to 'citoid'" 2019-04-11 11:01:00 +00:00
Ed Sanders 72df5f690f Update VE core submodule to master (f039957f3)
New changes:
f039957f3 [BREAKING CHANGE] Use keyed objects for importRules blacklists

Local changes: Use extendObject to set importRules

This allows us to inherit the ruleset from the parent
so we don't have to worry about keeping it up to date.
(For example alienTableCell from upstream was missing
in MW).

Media/Gallery dialogs: Add missing mwTable types.

Change-Id: I366a091ff4def66cc25200b3d1b2c23ba6b716f7
Depends-On: I8ff7e8242c8db235a0f9e11e2e52f90d62d368a0
2019-04-09 16:58:26 -07:00
Ed Sanders d784304ed1 Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: I2d7e389cc01808e41353681dd2448a0385543f2e
2019-04-03 13:19:45 +01:00
Ed Sanders 332aa1f3d2 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
2019-02-20 20:23:43 +00:00
Ed Sanders 74f6c4899c build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I63a0ebf0b31a0d5d4e680a4e2a5a0be4850be165
2019-01-08 17:00:09 +00:00
Ed Sanders d44e7fb3e8 Mobile target improvements
Change-Id: If55097a45ae812b712a74f41af350bfaa69f6135
2018-10-07 12:47:53 +01:00
Ed Sanders d15094c27d Update VE core submodule to master (7443791cf)
New changes:
7bdf15b76 Cleanup: Allow a DM surface to be used to construct a UI surface
27b36e04d Cleanup: Move setSynchronizer from view to model

Change-Id: I6b13dadcdaf4107fbf5b7ca50d9b5a52767a32ec
2018-08-25 23:22:09 +01:00
Ed Sanders cb10316a7b Export to page using action=submit
Change-Id: I0d719905203d24a545d9b7dcea5bb9d032f10a76
2018-08-19 11:25:17 +00:00
Ed Sanders 85b33a9c5f Store more edit metadata after import
Change-Id: Ib6f1a77ef61982ea54de0bfc1ddf1dd78afd4a6f
2018-08-17 15:26:09 +01:00
Ed Sanders 5be3be4ba4 Store importTitle in document, and display in sub heading
Change-Id: I431b721d8af3180b78a565e322a45745d06f67a1
2018-08-12 16:13:00 +01:00
Ed Sanders 8d56212632 rebaser: Use upstream username persistence
Change-Id: Id07b3d829e4662df9c51dcf122a5d050a92bb2fa
Depends-On: I3bd55a910cc306c3c22fe349b6193f5a3f165495
2018-08-07 19:36:32 +00:00
Ed Sanders 1220efd9e4 rebaser: Fix disable of refs while not supported
Some tools were still showing in the 'insert' menu.

Change-Id: I755e234641623fccd893e78fc3d9973a8a19eb44
2018-08-04 09:41:12 -04:00
Ed Sanders 5b043520c0 CollabTarget: Add convert to wikitext dialog
Change-Id: I49841fd17dd106154a2f53df2e051c6dc0cc3910
2018-07-26 10:46:12 -04:00
Ed Sanders 4dc573a0c9 Pass importTitle directly to target, instead of through query string
Change-Id: I2d561c3b2b8992b78412707d70a55ded0f5ad1c9
2018-05-23 17:20:05 +00:00
jenkins-bot 7e0ad66a69 Merge "CollabTarget: Pass import promise to setSynchronizer" 2018-05-23 17:13:50 +00:00
Ed Sanders 86786bc947 CollabTarget: Pass import promise to setSynchronizer
Depends-On: I188e749c315ddbb5f8779db10987178a51d27f5c
Change-Id: I57fe6af459416e039274ea4c360e09a55123b024
2018-05-23 16:59:01 +00:00
Ed Sanders 8f9cc64bba Temporarily disable broken ref tools in CollabTarget
Bug: T194838
Change-Id: Ic671fb158a14899b343c79f80ec8cde3ac72a495
2018-05-20 12:18:32 +02:00
jenkins-bot 40f9c827de Merge "Import button for CollabPad" 2018-05-19 12:28:42 +00:00
Ed Sanders 0fe6c53b2e Import button for CollabPad
Change-Id: I1f454fb7914b2de0cb5f393aeed9001b6a5a2e40
2018-05-19 19:42:35 +08:00
Jforrester ed049cb646 Merge "Use getAuthorNames" 2018-05-18 18:47:33 +00:00
Ed Sanders 6ddd2ba96c Add commentAnnotation to CollabTarget toolbar
Change-Id: I7450b401fa68a1d91522579e9e9e70c0d052bcc3
2018-05-18 19:36:41 +02:00
Ed Sanders fcd9a480a1 Use getAuthorNames
Depends-On: Ib5f3c7cd6343b582ae9f4b5efcfa24f66243af52
Depends-On: I2a49315d01aa075373f9b5f0d8802a7e7dd4dca3
Change-Id: Ib02945a46326659b652cdc01976396ef698a8080
2018-05-18 12:30:10 +00:00
David Lynch aab3c106df CollabTarget: remember current name, briefly
Change-Id: I2804f21c00b9224217d340948ca3c437f1b8b1a4
2018-05-16 18:16:44 +02:00
David Lynch c3d03ae101 CollabTarget: set name to logged in MW user
Change-Id: Ic39ce1790d3a267123810bdb87cc0a844df0d42c
2018-05-16 12:48:34 +02:00
Ed Sanders 900b74e9a9 Update VE core submodule to master (14bcc9256)
New changes:
14bcc9256 Give toolbars groups names

Local changes:
Give toolbars groups names

Also create an empty placeholder group for reference tools.
This allows targets to specify if they should show them.

Depends-On: Iccaf35cf941cb47ad55e8d98373461f5eaff5fed
Change-Id: I0bace5e5fe05f9c214d57a74c478b48a7dcaec3b
2018-05-13 18:09:33 +01:00
Ed Sanders 624f181592 MW-Rebaser: Disable history commands
Change-Id: I46bb5e92548fe35c3490cd3df36b2a8f1cca520a
2018-01-25 10:21:33 -08:00
Ed Sanders e4585d520b CollabTarget: Minimise dependencies, and make toolbar tweaks
Change-Id: I37cccd5760b8e65fc4232ca4572147f3b031255d
2017-09-08 15:46:45 +00:00
Ed Sanders 058e30d29d Fix toolbar position on Special:CollabPad
Adds missing ve-init-mw-desktopArticleTarget-toolbar-open class.

Change-Id: I8579928c8daa224bb9bec8fa5f4360fb3c52c5a1
2017-07-24 09:38:29 +01:00
Ed Sanders c7221988a1 Update VE core submodule to master (8be817396)
New changes:
26085a853 Make author list a ListPopupTool
c4ea53eef Update OOjs to v2.1.0
8c94697f3 Update OOjs UI to v0.22.0
cdebc4817 Follow-up 8c94697f: Actually commit the icon changes I had locally
8be817396 Update OOjs UI to v0.22.1

Local changes for author list popup

Change-Id: I36bcaf122528a4a12882aaff3b33ef936082a391
2017-05-31 17:48:45 -07:00
Ed Sanders 578deca159 rebaser: Initialize toolbar
Change-Id: I06e66859219e8d657063f24c59811338a195a28b
2017-05-21 11:44:01 +02:00
Ed Sanders 5d00944d09 CollabPad: Move synchronizer/authorList to Target from Target.init
Change-Id: I828ab12662e03cf674e20ae5676ca6eaa2592eba
2017-05-21 10:30:33 +02:00
Ed Sanders cf0a03ff5a CollabPad: Add popstate/teardown handling
Change-Id: I3faa7e2dd79fa5f1816833852325185caa4e82d4
2017-05-21 09:56:53 +02:00
Ed Sanders 574baf2e8e Provide VE-rebaser in MediaWiki as Special:CollabPad
Change-Id: I3ffe0e2b6af43d4018dcd79877f4f27ed7d6a7e7
2017-05-20 19:51:09 +00:00