Ed Sanders
bbfcbeb79d
Use ES5 trim instead of jQuery
...
Change-Id: I6e8b958176385cb672380454fcc3b4970261caa9
2015-11-20 11:48:55 -08:00
jenkins-bot
8fae033411
Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs"
2015-11-19 16:47:13 +00:00
Ed Sanders
dbdae59128
AceEditorWidget: Ensure loadingPromise is set when setupEditor runs
...
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
2015-11-18 23:11:10 -08:00
jenkins-bot
9f1aedbefc
Merge "Make selectRange method of AceEditorWidget focus the input"
2015-11-19 03:28:44 +00:00
Thalia
18448bb42b
Make selectRange method of AceEditorWidget focus the input
...
The selectRange method does this in TextInputWidget, so it
should here too.
Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
2015-11-18 19:14:50 -08:00
jenkins-bot
718e06cf1b
Merge "Add method to toggle the AceEditorWidget print margin"
2015-11-18 21:46:44 +00:00
Thalia
21fd89ba3c
Add method to toggle the AceEditorWidget print margin
...
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
2015-11-18 13:38:41 -08:00
jenkins-bot
52f151193a
Merge "Make focus method of AceEditorWidget chainable"
2015-11-18 20:29:48 +00:00
Thalia
88d466ba23
Make focus method of AceEditorWidget chainable
...
The focus method of InputWidget and other descendants
of InputWidget is already chainable
Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
2015-11-18 12:21:44 -08:00
Ed Sanders
bd40f62c17
Introduce MWExtensionPreviewDialog
...
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.
Depends on Icd622e15cd7 in VE core.
Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
2015-11-18 19:33:32 +00:00
jenkins-bot
d5562830fd
Merge "MWSignatureTool: Restrict command to linear selections"
2015-11-18 06:17:56 +00:00
Ed Sanders
259ec31ece
MWSignatureTool: Restrict command to linear selections
...
Change-Id: If6109c2ef2a18eccaccf18bd1d76c272a1dc3cd5
2015-11-17 22:08:23 -08:00
jenkins-bot
761ecc96f4
Merge "AceEditorWidget: Implement getRange"
2015-11-18 06:04:27 +00:00
Ed Sanders
f9ca524ef9
Wikitext paste: Fail if result has no visible content
...
For example if '[[category:foo]]' is pasted.
Bug: T118191
Change-Id: I9c51846414dd6b885b33f1dc9076edadbc6464c4
2015-11-18 03:33:14 +00:00
Ed Sanders
a5d700807a
AceEditorWidget: Implement getRange
...
Depends on I109a666679 in OOUI.
Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
2015-11-18 03:32:54 +00:00
Ed Sanders
e1d14099e0
Image/gallery icons: Rename and use new upstream versions
...
Depends on oojs-ui > 0.13.2.
Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
2015-11-18 01:49:31 +00:00
jenkins-bot
370a060ffc
Merge "AceEditorWidget: Implement selectRange"
2015-11-17 23:49:46 +00:00
Ed Sanders
5e96050b48
AceEditorWidget: Implement selectRange
...
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.
Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
2015-11-17 23:39:33 +00:00
Ed Sanders
b5c16ac95c
Make 'moment' a dependency of just 'mwimage', not all of VE-MW
...
Change-Id: I23c193bfb34203aa6f2ef1d3633c208e5c692c97
2015-11-17 14:55:10 -08:00
jenkins-bot
2fcbc18dff
Merge "Provide a tool to insert a signature in namespaces that need it"
2015-11-17 00:16:42 +00:00
jenkins-bot
3e9d040a79
Merge "AceEditorWidget: Allow users to force an Ace editor refresh"
2015-11-16 22:46:24 +00:00
Ed Sanders
35c44db988
AceEditorWidget: Allow users to force an Ace editor refresh
...
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.
Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
2015-11-16 12:12:10 -08:00
Ed Sanders
470a4a551b
AceEditorWidget: Refactor to ensure setValue runs synchronously
...
Also ensure setEditorWidget is only called once when
loadingPromise resolves.
Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
2015-11-16 11:36:08 -08:00
Bartosz Dziewoński
9be5c85db4
Provide a tool to insert a signature in namespaces that need it
...
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.
This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.
Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327 >,
which is already available under the MIT license.
Changes include:
* The tool is now always visible if the wiki allows signatures in any
VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.
Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).
Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb
Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
2015-11-16 18:06:32 +01:00
Ed Sanders
b21b939a67
AceEditorWidget: Emit resize event at end of cycle
...
Ensures the widget has taken its new size before emitting the event.
Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
2015-11-13 18:48:35 -08:00
C. Scott Ananian
236fad19b6
Ensure magic link nodes inherit the annotations of their text
...
If you create an autolink in the middle of bolded text, the magic link
should also be bolded. Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.
Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
2015-11-13 13:48:18 -08:00
jenkins-bot
53dbf3ac2f
Merge "Replace 'source' icon with OOUI's 'wikiText' one"
2015-11-11 01:42:00 +00:00
Alex Monk
87affb5ca4
Restructure education popup code to work without overriding onSelect
...
That code was breaking on mobile which uses a subclass of the normal
link inspector.
Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
2015-11-09 23:18:01 +00:00
Ed Sanders
216d0ea7a7
Update CommandHelpRegistry calls for breaking change in core
...
New changes:
281b543 Slugs: Remove vertical alignment hack
d6ddbe4 Localisation updates from https://translatewiki.net .
94bb263 Follow-up d6ddbe4: Fix build for added language 'sd'
bc8579d [BREAKING CHANGE] CommandHelp: Cleanup registry API
Change-Id: I65e2bfc299fbd60d6bdc7a57a030980b6cb8ab18
2015-11-05 07:29:44 -08:00
Ed Sanders
3716682570
CommandHelpDialog: Move registrations to where sequences are defined
...
Change-Id: I031575bbf40cd789252ac5e082bb5fa435eab257
2015-11-04 15:03:58 -08:00
David Lynch
6df227d4e0
MWCommandHelpDialog: update for core changes
...
Also: update VE core submodule to master (61f3fe7)
New changes:
4ef3666 Localisation updates from https://translatewiki.net .
cfa3482 Localisation updates from https://translatewiki.net .
d3486d4 CommandHelpDialog: Rename 'category' to 'groupName'
b5578d1 Localisation updates from https://translatewiki.net .
926595e Update OOjs UI to v0.13.1
61f3fe7 [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog
Change-Id: If651ed30ab85175c7a262d9ccccc2e1613b0f3d6
2015-11-04 12:01:45 -06:00
Alex Monk
6341c4a3b5
Apply same hide/show logic to both education popup dots
...
Bug: T117627
Change-Id: Icbde23f396935b7f6275ed89ce264ce5e49ebf6a
2015-11-04 15:56:40 +00:00
James D. Forrester
09800aa249
Replace 'source' icon with OOUI's 'wikiText' one
...
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
2015-11-04 06:15:29 -08:00
Ed Sanders
42b3463e7d
Source icon: Use double brakcets
...
This is now a candidate for upstreaming to OOUI as the
'wikitext' icon, which is slightly larger.
Bug: T111038
Change-Id: I19a287926d6f100d2cb5ed1d713387a2dac56b37
2015-11-04 14:07:41 +00:00
Alex Monk
b550323b53
Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit
...
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
2015-11-03 23:55:17 +00:00
Ed Sanders
6dd7576941
AceEditorWidget: Add method to clear undo stack
...
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.
Bonus: Add documentation for the widget.
Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
2015-11-03 13:41:09 -08:00
Ed Sanders
1b40e6434f
VESwitchConfirmDialog: Set pending on the correct button
...
Button indices were the wrong way around; find the button by
name to avoid future problems.
Change-Id: I778ff11875539d38f5a8905c9ff472fd3bd6baae
2015-11-03 18:58:59 +00:00
Ed Sanders
28a5d0db84
VESwitchConfirmDialog: Use modes to hide 'keep' button
...
Change-Id: I92110ea14ded335db330721c08314c7a20169886
2015-11-03 18:57:15 +00:00
Ed Sanders
17898270ee
CommandHelpDialog: Move insertions into a separate group
...
Also add table and comment insertions.
Change-Id: If87261bf3d01854ab1f7ce1b447589fa8098dcf2
2015-11-03 17:03:56 +00:00
Ed Sanders
91152e2c05
CommandHelpDialog: Use new method for getting access key prefix
...
Change-Id: I85628e9282d7b78a4fdd2ea2f3b0b72019302dcc
2015-11-03 11:06:54 +00:00
jenkins-bot
adb0c427ef
Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it"
2015-11-03 01:47:41 +00:00
Alex Monk
f71a5a5bca
Dialog for switching between wikitext and visual editing
...
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
2015-11-03 01:36:29 +00:00
jenkins-bot
097482bbff
Merge "MWEducationPopupTool: Changes to the dot"
2015-11-03 01:24:35 +00:00
jenkins-bot
ab42a490d9
Merge "AceEditorWidget: Preserve selection on setValue"
2015-11-03 01:17:18 +00:00
Alex Monk
5eaa211d43
MWEducationPopupTool: Changes to the dot
...
Make the dot more like the one in the designs, with two circles etc.
Change-Id: Ic3e1b2dcd846c5825455b68697acab44016ee598
2015-11-03 01:15:44 +00:00
Ed Sanders
e582fae840
[PULL THROUGH] Remove resize detection now that TextInputWidget implements it
...
This depends on the OOUI release which contains Iaadaf1f9f.
Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
2015-11-03 01:13:26 +00:00
jenkins-bot
fdafb7e887
Merge "ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up"
2015-11-02 19:08:06 +00:00
David Lynch
8bda88f661
Add mediawiki-specific sequences to the command help dialog
...
The extension registers a lot of sequences that don't apply to core
VisualEditor. Pretty much the opposite of the trigger situation, where
almost all are in core. So, merge them into the help dialog.
Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING CHANGE] Include sequences in the command help dialog
Bug: T116013
Change-Id: I5ad2939c10140b954fb29e1e50414ab7d79aeab7
2015-10-31 21:28:57 -05:00
Ed Sanders
bd22be33db
AceEditorWidget: Preserve selection on setValue
...
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.
Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
2015-10-30 16:14:09 +00:00
Thalia
7731508134
Make new error element
...
Bug: T114754
Change-Id: I5839ba62fe4b4708ff51dc549c5294189d7f8843
2015-10-29 22:32:42 +00:00