Commit graph

15866 commits

Author SHA1 Message Date
James D. Forrester beb1cbfc01 Update VE core submodule to master (1d9e3a217)
New changes:
5f0d6fd0b Fix updatePlaceholder to use attachedRoot
24365b65e ve.ce.Surface: handles clipboard images with HTML
1d9e3a217 ve.ce.Surface: Add more handleDataTransfer tests

Bug: T208631
Change-Id: I4464011284b8b36a1469a0bd79cdf8e79d586997
2019-02-13 13:53:36 -08:00
Ed Sanders 3269d53632 Support only surfacing part of the document
Bug: T76541
Depends-On: I227a0d704b9b337cff2102d424be9795d6362ed7
Change-Id: Iac71a51c8696434658f24fbb41c8142237bd810e
2019-02-13 19:03:44 +00:00
Ed Sanders bc02c44d36 rootNode/documentNode -> attachedRootNode
Change-Id: I56bb10749cac04e17ace2781b4d693ec5f522e7c
2019-02-13 19:03:36 +00:00
Bartosz Dziewoński 7b2bd6be09 ve.init.mw.MobileArticleTarget: Better match surface top spacing to read mode
Using margin instead of padding allows the surface margins to collapse
with the margins of first/last paragraph inside the surface, like they
do in read mode. This fixes the slight jump seen in T210630#4949865.

Bug: T210630
Change-Id: I69d4d4bd9390a1007bc40cda9e78a6b3e7a1bd1d
2019-02-13 13:37:31 +01:00
Bartosz Dziewoński 7fedb7be07 ve.init.mw.MobileArticleTarget: Change "back" tool icon from "<" to "x"
Icon name changed from 'previous' to 'close'.

This matches MobileFrontend's wikitext editor and other overlays.

Bug: T210630
Change-Id: I5f588c65887dd2247d3f816959807f943215e0c3
2019-02-13 00:29:24 +01:00
Translation updater bot f3768c8c21 Localisation updates from https://translatewiki.net.
Change-Id: I27f3cb6847ede888aab68c135d37a047dea5fe08
2019-02-12 22:25:51 +01:00
Bartosz Dziewoński 1faf0b00fa Filter out duplicate categories in NWE preview
Use them as object keys, which naturally deduplicates the entries.

Bug: T214811
Change-Id: I6159021b95d78b1a163faebb289578d277ff110d
2019-02-12 19:18:09 +01:00
James D. Forrester 5ff1ea4ab0 Update VE core submodule to master (3df16c6ce)
New changes:
3df16c6ce Add back deprecated alias 'root' of 'attachedRoot'

Change-Id: I6074248ddde90ad4feebbbb97c9449bb57be37b0
2019-02-11 14:04:21 -08:00
Translation updater bot 62229b189a Localisation updates from https://translatewiki.net.
Change-Id: I0294452104f584cf5772bfeae09142eae5ce222a
2019-02-11 22:28:28 +01:00
James D. Forrester ade7830f42 Update VE core submodule to master (121f78425)
New changes:
121f78425 Convert if-block to while-block for repeated annotations

Bug: T215741
Change-Id: Iae7ab58f0be8cb0e9c1d209c302bf7325750cf04
2019-02-11 08:29:03 -08:00
Translation updater bot aa0a3b806e Localisation updates from https://translatewiki.net.
Change-Id: Ia3f9b92b0337aa69c186c9c214c07c044debd0fc
2019-02-10 22:19:03 +01:00
James D. Forrester f24f3f0bb4 Update VE core submodule to master (c4d559b29)
New changes:
3ca89325c Support only surfacing part of the document
cbd658090 Return teardownPromise from Target#destroy
1e50283cc Remove teardown hacks
432a07291 Remove surface model disable/enable calls from inspectors
ee056df77 Remove deprecated surface.disable/enable aliases
8c93458d5 Abstract out #isEditable from FragmentInspector#getMode
c4d559b29 Remove duplication of action in AnnotationInspector

Bug: T76541
Change-Id: Iea29e565d7da46d1bc8763ab0b8e549566d19b50
2019-02-09 14:18:47 -08:00
jenkins-bot e965868def Merge "Fix TypeError in MWTocWidget.initFromMetaList" 2019-02-09 18:47:08 +00:00
Chunliang Lyu 4774fbdf5c Fix TypeError in MWTocWidget.initFromMetaList
If a page contains __NOTOC__ magic word, it would break the VisualEditor
with "Uncaught (in promise) TypeError: Right-hand side of 'instanceof' is not
an object at VeUiMWTocWidget.ve.ui.MWTocWidget.initFromMetaList".

The issue seems to be that we removed ve.dm.MWTOCForceMetaItem and
ve.dm.MWTOCDisableMetaItem in commit 57a06a6e75,
but the code in initFromMetaList still refers to them.

Change-Id: I857cddcc7d4aa73375357ef922591ed94d760166
2019-02-09 19:31:27 +01:00
Roan Kattouw b15f819fdf ve.init.mw.Platform: Migrate away from deprecated specialCharacters API
Use require('mediawiki.language.specialCharacters') instead of
mw.language.specialCharacters.

Change-Id: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e
2019-02-08 16:59:25 -08:00
James D. Forrester 3d29156cfe Update VE core submodule to master (a5437289b)
New changes:
6df27402a ve.ce.Surface: Handle all font weights above 700
bfebd5a28 Fix function name
a5437289b Localisation updates from https://translatewiki.net.

Change-Id: I1980a836de0d393f55adbe47b91337fb7ca3cb5f
2019-02-07 16:22:41 -08:00
Translation updater bot 848c0e2375 Localisation updates from https://translatewiki.net.
Change-Id: I91ae3763612f1e44c34435dcfb96d893e5c11b29
2019-02-07 22:28:56 +01:00
jenkins-bot d2fe2f7f8d Merge "DesktopArticleTarget: Make the progress bar into a reusable widget" 2019-02-06 22:37:28 +00:00
jenkins-bot d1c7b9a5d1 Merge "Fix function name" 2019-02-06 22:36:21 +00:00
Ed Sanders fed2067df9 Fix function name
Change-Id: I540ec247f37a21dfd0b84c8b593a6a37197bfcb2
2019-02-06 21:54:23 +00:00
jenkins-bot b7cf486403 Merge "ve.ui.MWTransclusionContextItem: Use the right class name in override" 2019-02-06 21:53:41 +00:00
jenkins-bot 72aff8c16a Merge "mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't" 2019-02-06 21:43:40 +00:00
Bartosz Dziewoński 9ff514a460 ve.ui.MWTransclusionContextItem: Use the right class name in override
Follow-up to I47a995905fef5aa2cabb2b3215111de0b506e7f7.

Bug: T209610
Change-Id: I204e92771bcde9015244a1697c3a7e6bd888a516
2019-02-06 22:36:52 +01:00
jenkins-bot c7049f4de1 Merge "DesktopArticleTarget: Fix position of progress bar if editor is reloaded" 2019-02-06 21:31:33 +00:00
jenkins-bot 559e9d86de Merge "DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar" 2019-02-06 21:31:11 +00:00
Bartosz Dziewoński 6e076b3b6c DesktopArticleTarget: Make the progress bar into a reusable widget
We want to add a similar progress bar on mobile without copy-pasting
all this code.

Bug: T210630
Change-Id: I7192869cb719114ffd04940eabf38cf0f0421c13
2019-02-06 22:20:37 +01:00
libraryupgrader 36ef6d856f build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgParser
* MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle

The following sniffs was renamed:
* MediaWiki.VariableAnalysis.ForbiddenGlobalVariables.ForbiddenGlobal$wgTitle

Change-Id: Iabe2a787bae7fe299bed548c0097613ff5493a0d
2019-02-06 18:33:13 +00:00
Bartosz Dziewoński cb09d6a54d DesktopArticleTarget: Fix position of progress bar if editor is reloaded
Change-Id: I5f181a9516ff64988aa67e54ebd342c56e4b7e70
2019-02-06 02:11:48 +01:00
Bartosz Dziewoński 28950a8b5c DesktopArticleTarget: Match NWE toolbarPlaceholder height to real toolbar
Toolbar was made bigger in If5722df41e75a1d4bdf8afc83c81670d1be3a1b8.

Change-Id: Id85869e6ad0bfad1acebda3a64bab5328de3932d
2019-02-06 02:11:48 +01:00
jenkins-bot ce6a24dd0c Merge "Tests: Duplicate module to test.VisualEditor ahead of next phase" 2019-02-05 22:47:52 +00:00
James D. Forrester 5826a6b89c Tests: Duplicate module to test.VisualEditor ahead of next phase
Change-Id: If6e0450ec73051d9b1d9111aed808fee26b45705
2019-02-05 14:16:10 -08:00
Translation updater bot 9b8dd975f5 Localisation updates from https://translatewiki.net.
Change-Id: I2f82ac4176a6e3e32c8de1442e2908ad110db64a
2019-02-05 22:38:02 +01:00
jenkins-bot f5bae30b4a Merge "ve.ui.MWTransclusionContextItem: Remove "Generated from" prefix from description (mobile)" 2019-02-05 19:13:55 +00:00
James D. Forrester 1db665e0c3 Update VE core submodule to master (5838dce23)
New changes:
5838dce23 ve.ce.Surface: Handles font weight bold

Bug: T93081
Change-Id: Ib25d68fe06a3a58d60582cbd91c8be34fe6e94fa
2019-02-05 10:13:53 -08:00
jenkins-bot e52adb1590 Merge "ve.dm.MWInternalLinkAnnotation: Correctly generate relative links" 2019-02-05 17:07:56 +00:00
jenkins-bot 4e0f9c865d Merge "Update VE core submodule to master (67e60b00e)" 2019-02-05 11:58:27 +00:00
Translation updater bot 8cf10ccb42 Localisation updates from https://translatewiki.net.
Change-Id: I091d9b7fbad1e8baf530c6a59ed11556d033713e
2019-02-04 22:15:51 +01:00
James D. Forrester ce250a23f2 Update VE core submodule to master (67e60b00e)
New changes:
d615196b2 build: Update eslint-config-wikimedia to 0.10.1
67e60b00e Localisation updates from https://translatewiki.net.

Change-Id: I521eaec173ff16e33396f4fdd9947552458cda7a
2019-02-04 12:04:40 -08:00
Bartosz Dziewoński 18fb16c81d ve.dm.MWInternalLinkAnnotation: Correctly generate relative links
We could generate incorrect links to pages whose title contains a
colon ':' and therefore looks like a fully-qualified URL.

Bug: T206231
Bug: T206357
Change-Id: Ie34694d903a6d97589cc46417f70659559494619
2019-02-04 20:08:01 +01:00
Bartosz Dziewoński c56b764330 ve.ui.MWTransclusionContextItem: Remove "Generated from" prefix from description (mobile)
It does not provide any additional information, and it is long enough
that it causes the actual template name(s) to not fit on the screen on
small mobile sizes.

Bug: T209610
Change-Id: I47a995905fef5aa2cabb2b3215111de0b506e7f7
2019-02-04 19:48:28 +01:00
Translation updater bot 156e70c795 Localisation updates from https://translatewiki.net.
Change-Id: I99f54c3e3696a31798af7d8c3d18b7c21d0aeac1
2019-02-03 22:39:00 +01:00
jenkins-bot 748d25237e Merge "Remove "return true" legacy behavior from hook handler functions" 2019-02-02 22:37:26 +00:00
jenkins-bot 73b2acf2a6 Merge "build: Update eslint-config-wikimedia to 0.10.1" 2019-02-02 21:45:27 +00:00
Derick Alangi 8d6c7a6648 Remove "return true" legacy behavior from hook handler functions
Change-Id: I18fee692f6cd247c41ffb9b357047a6be0facb11
2019-02-02 21:04:04 +01:00
Derick Alangi 68d196c3e9 Fix PHPDoc comments to the canonical format (@param [Type] [name])
Change-Id: I105af4a02c8823698d3437159eb1886b9a71f76a
2019-02-02 20:50:26 +01:00
Ed Sanders c463e812ed build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I223b39d49167ef7a831208b523654c69ad0bea5b
2019-02-02 11:02:27 -08:00
James D. Forrester 3ab699f6ed mw.Platform.setUserConfig: Don't try to set for logged-out users, it doesn't
Bug: T214963
Change-Id: Idc61685b6087c0fe0082bd0b039f2f454ca92970
2019-02-01 20:50:58 -08:00
James D. Forrester 1510874cc6 Update VE core submodule to master (3c1c8429d)
New changes:
8bfeae442 Fix "factory pattern" typo
79f0415b4 Localisation updates from https://translatewiki.net.
8b2e8d9f5 Rebuild demos with new language
9b1d76641 AnnotationAction: Activity-logging used wrong field name in two cases
4734b7fb5 ve.ui.FindAndReplaceDialog: Debounce calls to save user options

Bug: T214963
Change-Id: I34040967f857e5098097f51789caac68e6258a42
2019-02-01 20:07:15 -08:00
James D. Forrester b74f4db570 MWMediaTransferHandler: Fix new eslint warning from unused global
Change-Id: I729cfb8d6b487ecd5b42af5921ca8f1e18cfd749
2019-02-01 20:07:15 -08:00
Bartosz Dziewoński c91047b129 ve.ui.MWGalleryDialog: Allow normal tools in gallery captions
PHP parser and Parsoid now both allow normal wikitext in gallery captions.

Bug: T187958
Change-Id: I3470ec1f81493c58e4c2bdad00d5d78af8b4a10b
2019-02-01 19:51:35 -08:00