Commit graph

15582 commits

Author SHA1 Message Date
David Lynch 4e10d5b975 Update rel attribute checks to be aware of multiple rel values
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.

Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 14:34:56 -06:00
James D. Forrester 650836d08f i18n: Sort messages alphabetically for easier updates
Change-Id: Ia93565c87b6bd15b7db13d2c33f444da8b8d33ca
2018-03-08 20:02:07 +00:00
jenkins-bot b718a7634e Merge "Hooks: Don't register beta features if they're enabled for all" 2018-03-08 15:17:14 +00:00
jenkins-bot d1e3a4147d Merge "build: npm/rake entry point for screenshots upload" 2018-03-08 14:56:08 +00:00
James D. Forrester e54554ae83 Update VE core submodule to master (97bf37687)
New changes:
e10e2c0b6 Remove gecko-specific paste tests, add copy test
c555b6567 Complete test coverage of autosave methods
fc02e085e Localisation updates from https://translatewiki.net.
08a55658e CE Surface tests: Add missing </tbody> tags
ff5a766bb CE Surface tests: Avoid execCommand on tests failing in Firefox
46160f796 Run and make voting the Firefox tests in CI

Bug: T182626
Bug: T189201
Change-Id: Iee50ddf350e4a3312024b280cdeded08d325ea06
2018-03-08 14:41:40 +00:00
James D. Forrester 285254979a Hooks: Don't register beta features if they're enabled for all
Change-Id: I8a618a8ce76f48b143955dd7a5877b68d8e1205d
2018-03-08 14:41:40 +00:00
jenkins-bot 8e79d85583 Merge "Blacklist Web of Trust junk from being added to pages" 2018-03-08 00:33:48 +00:00
David Lynch f8c5608caf LinkCache: styleParsoidElements find mw:WikiLink with ~=
`noopener` being added to the rel caused issues.

Bug: T189175
Change-Id: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 00:14:16 +00:00
jenkins-bot e6917e2e0c Merge "Update VE core submodule to master (f46b51b83)" 2018-03-07 23:26:35 +00:00
Antoine Musso 2aadc18105 build: npm/rake entry point for screenshots upload
We have a Jenkins job to take screenshots of VisualEditor and upload the
result to commons.wikimedia.org. That roughly does:

    npm install
    node_modules/.bin/grunt screenshots-all

    bundle install
    bundle exec upload

However on CI, the Docker container only accepts 'npm run-script XXX' or
'bundle exec rake YYY'.

Add a npm script 'screenshots-all' invoking 'grunt screenshots-all'.

Add a rake task 'commons_upload'. I have added a basic check to make
sure environment variables are properly set before invoking the upload
script.

Thus on CI the usage will become:

  npm install
  npm run-script screenshots-all

  bundle install
  bundle exec rake commons_upload

Which match the CI convention.

Bug: T189122
Change-Id: I221ed8d6178dd036eac287f0f811834a6d4ffd22
2018-03-07 23:23:30 +01:00
Translation updater bot 433dc82ad2 Localisation updates from https://translatewiki.net.
Change-Id: Ie3d742d2ee46f0ee596227b5f63832e441c32397
2018-03-07 22:48:05 +01:00
Bartosz Dziewoński b05ac142c6 Blacklist Web of Trust junk from being added to pages
Bug: T189148
Change-Id: Icc4b2d0ddf5104e26a3f563816f6f971d71e2531
2018-03-07 22:12:43 +01:00
James D. Forrester a083ee372f Update VE core submodule to master (f46b51b83)
New changes:
a687da2cc Add visual diff messages for changed dir: and style: attributes
3cf650c5a Fix node type check
b239c9313 Use equalDomElement in DiffElement & TextState tests
cd2dfc205 Don't descend into dataElement-generated nodes in renderHtmlAttributeList
61a1c351e Move isInternal from ve.dm.Node to ve.Node
c535f74fe Stop using FlatLinearData directly
5ec94b067 build: Use “OOUI” as unified name for library upgrade script
8bbd7d356 Update OOUI to v0.25.3
73a81c239 Add unit tests for autosave methods in DM surface

Bug: T160588
Bug: T182360
Bug: T189030
Bug: T189104
Bug: T189120
Change-Id: I581c206312ff5bcc6b7cb41522f1f7ba307bbd1c
2018-03-07 20:59:47 +00:00
jenkins-bot 1749a5ee41 Merge "Follow-up I5357a909: Fix logic for autosave from edited state" 2018-03-07 20:02:47 +00:00
Ed Sanders 045f3b7640 Follow-up I5357a909: Fix logic for autosave from edited state
Bug: T189071
Change-Id: I5439a73ffcf26795f58625720b1f1667ee3965cc
2018-03-07 18:43:28 +00:00
Translation updater bot 7abaa02287 Localisation updates from https://translatewiki.net.
Change-Id: I9ff46b54cf7076fc5b25983f9bc2ab91904c8d8c
2018-03-06 22:18:56 +01:00
Ed Sanders 94db6545bb Update VE core submodule to master (23666aff0)
New changes:
23666aff0 color-picker: Remove fallback PNGs we don't use

Local changes:
Pull through color picker lib from core

Change-Id: Ib213f801a90e400fae2838e21bbdb011dc61311a
2018-03-06 17:46:47 +00:00
Jforrester 16437646fe Merge "Update VE core submodule to master (ca771b8bc)" 2018-03-06 13:14:21 +00:00
James D. Forrester d144599cea Update VE core submodule to master (ca771b8bc)
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

Local changes:
Follow-through rename of IndexValueStore->HashValueStore

Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
2018-03-06 12:55:30 +00:00
jenkins-bot eb125877e2 Merge "Revert "For empty / whitespace-only headings, output <p> instead of <h#>"" 2018-03-06 12:22:31 +00:00
Ed Sanders a274bdb8f7 Revert "For empty / whitespace-only headings, output <p> instead of <h#>"
Parsoid now handles empty headings for us in
scrub_wikitext mode (which we use).

This reverts commit 884f301aa0.

Bug: T187913
Change-Id: I8690bbced64be76622929f78f9c9e0d8f85d4be8
2018-03-05 23:27:52 +00:00
Translation updater bot c9ca09cee3 Localisation updates from https://translatewiki.net.
Change-Id: Ie191a7c81080c53b9422f040427462a76700219e
2018-03-05 22:25:08 +01:00
David Lynch 09237b71ef mwExample: add test case for cross-document numberedlink paste
Bug: T188429
Change-Id: I722f30f07abd65dba93e9ba297b6933ef8ca79c2
2018-03-05 13:35:25 -06:00
jenkins-bot 1202276e70 Merge "Update VE core submodule to master (30cf85e12)" 2018-03-05 19:19:18 +00:00
jenkins-bot 9dc41b59fc Merge "MWNumberedExternalLinkNode: set an explicit type" 2018-03-05 19:14:35 +00:00
James D. Forrester 55a30052a8 Update VE core submodule to master (30cf85e12)
New changes:
ffce287bc Handle errors in storeDocState better
d31cf65ee Localisation updates from https://translatewiki.net.
5f6664e2e Follow-Up I2bbf812: Fix comment node selectors

Bug: T188904
Change-Id: Ic4147641ed8a0c2857468dbd60dd433f50be7e9d
2018-03-05 19:08:24 +00:00
David Lynch 795b428477 MWNumberedExternalLinkNode: set an explicit type
This lets copy-paste between documents retain the numbered status rather than
falling back on pasting "<a>[3]</a>".

Update the part of LinkCache which selects on mw:ExtLink, so it will handle
possible multiple values in the link rel.

Bug: T188429
Change-Id: Ia5e4c9fa45e94da9cbfcd2a42d017d0fda1c511f
2018-03-05 11:59:41 -06:00
jenkins-bot 0871b8da85 Merge "Revert "Follow-up e19092240: During the config cut-over, don't graduate 2017WTE"" 2018-03-05 16:35:12 +00:00
Ed Sanders 4c759e2587 autosave: Handle switched document with no transactions
Always store immediately if fromEditedState is true. Also
now that we only store if there is state to recover, remove
the check for transactions before deciding to show the notification.

Change-Id: I5357a9098b91e303f5c71881ea03a080d2969fff
2018-03-04 23:40:24 +00:00
Ed Sanders 007bb6fa09 Refactor diffpage init
Avoid re-rendering the diff if it hasn't changed.

Change-Id: Icbc8eb58625cf7c5485d0045e26993a170016309
2018-03-04 14:45:33 +00:00
jenkins-bot 05c0a88b5c Merge "Fix infinite recursion in positionDiffElement" 2018-03-04 10:12:27 +00:00
Translation updater bot 622039abc5 Localisation updates from https://translatewiki.net.
Change-Id: I131be752534c517224d6f0aec88ec0bff30a39b1
2018-03-03 22:25:58 +01:00
Ed Sanders 43ea4c2b51 Fix infinite recursion in positionDiffElement
updateSize eventually calls setDimensions, which calls
positionDiffElement, so protect against infinite recursion.

Change-Id: I07992f337394712000e6e12c637c6e1442869722
2018-03-03 18:47:08 +00:00
Translation updater bot 319fa2c82e Localisation updates from https://translatewiki.net.
Change-Id: I0af08e8a60e75e23ccf4b5ef86cdebe455a6d006
2018-03-02 22:31:33 +01:00
James D. Forrester 47d69989f8 Update VE core submodule to master (17721d5f5)
New changes:
1ef63f783 Replace node instanceof ve.dm.TextNode with node.type === 'text'
2f93c59d3 Only run checkLinearOffset in tests

Change-Id: Id9bf5283be26a282d1986248e5e1a67db396e13a
2018-03-02 10:39:22 -08:00
Ed Sanders d5a61eb95d Make edit notices popup wider (320 -> 450)
Bug: T184379
Change-Id: Id2df8f8d162db3389206666fa07ea4cc0be8cdec
2018-03-02 13:29:54 +00:00
jenkins-bot ad6ded970f Merge "ve.ce.MWBlockImageNode: Fix handling of borders" 2018-03-02 13:15:50 +00:00
Ed Sanders c8d0f62095 fetchSpecialCharList: Set directionality
Specifically, set arabic(extended) and hebrew to 'rtl'.

Logically depends on I14abd3e0c0d23f79aa01d96c216eea913024b4c8
to set the dir attribute in UI.

Bug: T56310
Change-Id: I1c7e28d3d2f20ca84115be6d49650cd9a81d78dd
2018-03-01 23:22:45 +00:00
Translation updater bot 936fa0b617 Localisation updates from https://translatewiki.net.
Change-Id: I2fa78e1b238f9b58362cbebe1d9d01f1b844423e
2018-03-01 22:42:12 +01:00
James D. Forrester fbc37064a5 Update VE core submodule to master (f5c88eb30)
New changes:
bdb1a680a SpecialCharacterPage: Allow setting lang/dir via special attributes property
37945174e Localisation updates from https://translatewiki.net.
19766f68b Follow-up 37945174e: Add 'myv' language to build to unbreak the repo
a9a87f97e Fix blocked triggers on OSX
76774b366 Map 'Ctrl+D' on OSX to forwards delete key handler
f5c88eb30 Use unsafeDeserialize in restoreChanges

Bug: T56310
Bug: T187920
Change-Id: Ic9853bccae87aab7c8f1d07f715fca3e532017a0
2018-03-01 10:50:47 -08:00
jenkins-bot e7d7d5bab1 Merge "autosave: Don't store initial document state until first change" 2018-03-01 18:47:39 +00:00
jenkins-bot fbbda2a480 Merge "ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override" 2018-03-01 18:39:48 +00:00
Ed Sanders 11ac2736a1 autosave: Don't store initial document state until first change
1. It wastes valuable time during setup.
2. If a user reloads the page without making changes we
   should give them the latest html from the server to
   minimise the chance of an edit conflict.

Change-Id: I9a1f8cfd65ef2552fe2c3d6d2bbf975851b52003
2018-03-01 18:25:10 +00:00
Bartosz Dziewoński d239b6ee6a ve.ce.MWBlockImageNode: Fix handling of borders
After change 89aecd54ba (2014),
there is no 'border' value for the 'type' attribute, instead
there is a 'borderImage' attribute only present when 'type'
is 'none' or 'frameless'.

Change-Id: Id87ba09b647f5f69b1c9350209e66acdea2c9d69
2018-03-01 01:08:30 +01:00
Bartosz Dziewoński 5b7c93f0d5 ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override
MWBlockImageNode already can't have any slugs:
* It can't have inline slugs, because it can't directly contain
  content (`this.canHaveChildrenNotContent()` is true)
* It can't have block slugs, because it can't contain paragraphs
  (`this.isAllowedChildNodeType( 'paragraph' )` is false).

(The only thing it can contain is a mwImageCaption.)

Change-Id: Ice6505da2356f004ef048ed0b1a9e03d08af02d1
2018-03-01 01:08:30 +01:00
Translation updater bot a8b91c1e33 Localisation updates from https://translatewiki.net.
Change-Id: I54ab3faf9d29c9e5eb090f70cff9b22881832807
2018-02-28 22:27:47 +01:00
jenkins-bot 6155cd4434 Merge "Remove autoGenerated hack" 2018-02-28 18:41:29 +00:00
jenkins-bot 9840316ee9 Merge "Centralize Parsoid resource name parsing logic" 2018-02-28 15:09:20 +00:00
Ed Sanders 90b6a1b5cf Clarify autosave comment
Change-Id: I0bdaf989886be8537ea45237ceea88a5cca11fc1
2018-02-28 14:36:58 +00:00
Ed Sanders 19d9e9eb98 Tag TODO comments with bug number
Change-Id: I965e8d4bed4fdfa24738ca5cce0ae3f51e7f2b40
2018-02-28 14:36:42 +00:00