wikimedia/mediawiki-extensions-VisualEditor

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-04 18:58:37 +00:00

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	209aaf6943	ParsoidClient: Fix getPageHtml() $targetLanguage param inconsistencies * DirectParsoidClient: Actually allow null to be provided. Previously we tried to call methods on it unconditionally. * VRSParsoidClient: Require the param to be provided (even if null). No reason to diverge from the interface, which requires it. Change-Id: Id9a450dc8b8eb3e82cf87718b96975e5a3c6180c	2022-09-26 22:52:31 +02:00
daniel	0cd6c90d5a	Extract RESTbase client code into VRSParsoidClient. This makes the "direct" client and the VRS based client implement the same interface, so the caller doesn't have to know which one it is using. It looks like ParsoidHelper will not be needed if we use this approach. Change-Id: Ib1c1d7355951fc0765227dd01a9edfc554fc448d	2022-09-14 18:20:36 +01:00

Author

SHA1

Message

Date

Bartosz Dziewoński

209aaf6943

ParsoidClient: Fix getPageHtml() $targetLanguage param inconsistencies

* DirectParsoidClient: Actually allow null to be provided.
  Previously we tried to call methods on it unconditionally.

* VRSParsoidClient: Require the param to be provided (even if null).
  No reason to diverge from the interface, which requires it.

Change-Id: Id9a450dc8b8eb3e82cf87718b96975e5a3c6180c

2022-09-26 22:52:31 +02:00

daniel

0cd6c90d5a

Extract RESTbase client code into VRSParsoidClient.

This makes the "direct" client and the VRS based client
implement the same interface, so the caller doesn't have to know
which one it is using.

It looks like ParsoidHelper will not be needed if we use this approach.

Change-Id: Ib1c1d7355951fc0765227dd01a9edfc554fc448d

2022-09-14 18:20:36 +01:00

2 commits