Commit graph

8226 commits

Author SHA1 Message Date
Moriel Schottlender ae4511a02b Hide "no results" messaage in media search widget
After resolving the search queries to the API, make sure to display
or hide (!) the "no results" message.

Bug: 67438
Change-Id: I518fbf5ae18bb2265710600516d556c60e2b4924
2014-09-04 19:03:03 -04:00
jenkins-bot 4be972799f Merge "Rename $label to $labelElement in MWParameterPage to avoid naming conflict" 2014-09-04 21:07:41 +00:00
jenkins-bot 71875de0c6 Merge "Check for changes in the model" 2014-09-04 21:07:12 +00:00
Moriel Schottlender cb86c4f030 Check for changes in the model
Create an image model hash and check for changes to the image every
time the dialog is changed, so we can activate and deactivate the
apply button properly.

Bug: 68058
Change-Id: I94b7e4879c6e752432c6f937a8cf1b9f15d1b56d
2014-09-04 14:05:01 -07:00
Alex Monk 160d99d9f4 Rename $label to $labelElement in MWParameterPage to avoid naming conflict
Causing the label of each parameter to be missing ($label actually gets sent to the outline item
widget, for some reason). Looks like it was caused by I1abecd8a.

Bug: 70406
Change-Id: I598ffe5066d0ae8267324d4125d05514449064d5
2014-09-04 22:02:28 +01:00
jenkins-bot e16ebe0e7c Merge "Set default dimensions based on original dimensions" 2014-09-04 21:01:43 +00:00
Translation updater bot efdf3f3553 Localisation updates from https://translatewiki.net.
Change-Id: I368d44e1a2f5887a2ab78335b8737bc010cc9edf
2014-09-04 22:09:45 +02:00
Cmcmahon 6a90a9070a [BrowserTest] Locator for template field remove changed
Change-Id: I647a937c6e07e6bf3dae515fd684ebe2274ddc54
2014-09-04 10:45:55 -07:00
Cmcmahon 16ca79057f [BrowserTest] updates for Cite test
Test additional fields

Change-Id: I9368962bd2b8e7217c064c9b8779d5d53585154d
2014-09-04 10:07:27 -07:00
Moriel Schottlender a83086c007 Set default dimensions based on original dimensions
Make sure default dimensions are only set if we have the original
dimensions. Also fix a bug where image default dimensions were
calculated according to current width/height rather than those
of the original dimensions.

Bug: 68000
Change-Id: I8c3acc18b317f82c6b88966950e74b956936dda4
2014-09-04 11:29:51 -04:00
James D. Forrester 7ac7797d4a Update VE core submodule to master (65991da)
New changes:
de40432 Absolutely eradicate absolute selection coordinates

Change-Id: I1df26e32d28299792e6634f360683e589408b587
2014-09-03 18:08:02 -07:00
James D. Forrester 5dbe1d10fc Update VE core submodule to master (8eb47c7)
New changes:
7600823 Remove lies about event objects being passed through
4a3adbb Ignore focusin/focusout events on iframes
c5fe1cd Position the paste target just below the top of the screen
71dc684 Reorder CSS rules in ve.ce.Surface.css to make sense
99d3235 Update OOjs UI to v0.1.0-pre (36d0c7dc3b)

Change-Id: I3732683bcd0652b909411beec1dd7a228c2cc6fc
2014-09-03 17:55:16 -07:00
James D. Forrester f2e22babaa Update VE core submodule to master (1f82a47)
New changes:
5d063a2 Don't use three different coordinate systems in getSelectionRect()
feeb1ae Only focus the paste target if focusedNode has changed
2c1bb97 Update OOjs UI to v0.1.0-pre (4cef83f702)

Local changes:
* Update references to renamed classes
* Update calling patterns element mixins

Change-Id: I330c0e308807597dec31dad8dbf713eb29fdc290
2014-09-03 17:20:09 -07:00
James D. Forrester a74950a693 Update VE core submodule to master (7004717)
New changes:
6d8a59f Create ImageNode mixin to share logic between Block & Inline
aa6765f Fix `ve.dm.Transaction.newFromReplacement` when `removeMetadata` is true
a6e7a0c Set expanded=false on command help dialog layout
029dbe4 Allow override of window manager in language input widget
8407325 Annotate inserted special characters
4666caf Localisation updates from https://translatewiki.net.
f67e81e Factor out ve.dm.Transaction.pushReplaceInternal
7004717 Prefer String#slice over substr() or substring()

Change-Id: I72dbf37750b5582049cb0fb2730a99066a64b067
2014-09-03 10:35:21 -07:00
jenkins-bot bfbe8cbbeb Merge "Shrink height of summary box in save dialog from 80px to 4em" 2014-09-02 20:25:00 +00:00
jenkins-bot 567b0e7d53 Merge "Use combo box widget to suggest existing values for reference group" 2014-09-02 20:21:32 +00:00
Translation updater bot 8840ccdb53 Localisation updates from https://translatewiki.net.
Change-Id: I8764d5cf5293cd444582c658ef9d2c064a359fab
2014-09-02 22:18:50 +02:00
jenkins-bot 2d92bdb9d1 Merge "Update anoneditwarning message per core change" 2014-09-02 19:05:03 +00:00
Alex Monk 100b70bd50 Update anoneditwarning message per core change
Follows up I687e47c2 by James, approved by Bartosz.
This should be merged before thursday.

Change-Id: Ia28f59a341e1a04b4d143abbfe5c63e4a420056f
2014-09-02 19:59:13 +01:00
jenkins-bot 8951b983a8 Merge "Add debugging help to VisualEditor" 2014-09-02 18:16:40 +00:00
Mark A. Hershberger 363b986879 Add debugging help to VisualEditor
VE doesn't use the debug log at all, it seems.  This adds a single
wfDebugLog call so that the person using the debug log can see that it
actually does hit VE.

Also, returns better information for parsoid errors.

For example, without it, a parsoid misconfiguration of setInterwiki()
gives:

    Error loading data from server: parsoidserver-http-bad-status:
    500. Would you like to retry?

with it, you get something like the following:

    Error loading data from server: parsoidserver-http-bad-status:
    500: Page Fetch failure for "BADURL": Error: getaddrinfo
    ENOTFOUND. Would you like to retry?

or

    Error loading data from server: parsoidserver-http-bad-status:
    500: Page Fetch failure for "BADURL": 404. Would you like to
    retry?

Bug: 39057
Bug: 43147
Bug: 63149
Change-Id: I52db9fac42d7c0228b93ce3caec470fff98254f0
2014-09-02 14:57:06 +00:00
Translation updater bot acb59eac90 Localisation updates from https://translatewiki.net.
Change-Id: Ic15801ebe7ce7cb536103f73b7f7fc7949d4719c
2014-09-01 22:38:04 +02:00
James D. Forrester 0637104a17 Shrink height of summary box in save dialog from 80px to 4em
Change-Id: Ifd40bb19c7b57bab15c127d2de16940f9a239235
2014-09-01 12:06:22 -07:00
James D. Forrester a26aeca144 Update VE core submodule to master (dd2398c)
New changes:
d635974 Use staging instead of undo in annotation inspector
29233b8 Localisation updates from https://translatewiki.net.
efb3296 Localisation updates from https://translatewiki.net.
cfc5ad1 Localisation updates from https://translatewiki.net.
c609e02 Update OOjs to v1.1.0
dd2398c Update OOjs UI to v0.1.0-pre (adfcf92c6a)

Change-Id: Id122cd8a266554fdbe9f10dcdf53d87c7dd21b17
2014-09-01 10:36:02 -07:00
Translation updater bot 1f136f9d1d Localisation updates from https://translatewiki.net.
Change-Id: I411434f0e235af80ca010d0a4186ee914744c790
2014-08-31 22:01:02 +02:00
Translation updater bot 5eba10284d Localisation updates from https://translatewiki.net.
Change-Id: I2c5cf553aeb26e2579af0c6857de01e74a4508e0
2014-08-30 22:44:16 +02:00
Alex Monk 802b018133 Use combo box widget to suggest existing values for reference group
Bug: 61574
Change-Id: I2ab47e79a8b90db8631d042c80b0759e9c250523
2014-08-30 02:33:04 +01:00
jenkins-bot 29da2fcee2 Merge "Update VE core submodule to master (d6d6db4)" 2014-08-29 20:38:00 +00:00
Alex Monk 14b23d7ba4 Make sure mediawiki.notification is loaded -before- calling ViewPageTarget#checkForWikitextWarning
That function needs to return the result immediately, not wait for module loading (via mw.notify).
This was breaking us being able to keep track of what wikitextWarning object was in use (but only
the first time we used the module), and therefore fail to close the warning when the wikitext
disappeared.

Bug: 70168
Change-Id: I0f1427423a5fe82ec8e70e2f0462a3044ca7ace8
2014-08-29 21:18:24 +01:00
Translation updater bot 4f4cdd8ca3 Localisation updates from https://translatewiki.net.
Change-Id: I9eb1f89d5f9e3bee5833f09d8f9ed37044b03ca9
2014-08-29 21:22:44 +02:00
James D. Forrester 6340a5a3e8 Update VE core submodule to master (d6d6db4)
New changes:
378bc4c Polyfill Node.prototype.normalize in IE
d54cd30 Call onTargetInputChange when the link inspector is ready
00f7a00 Only undo if an initial annotation was applied
5d39686 Make filibuster code debug only
fdda60a Track selectionBefore in staging transactions

Change-Id: I2a70d599838b3575c5b0a63ffc60d023b04a8e80
2014-08-29 12:05:12 -07:00
jenkins-bot 7964c5874c Merge "[BrowserTest] update Cite element locators" 2014-08-29 17:16:22 +00:00
Cmcmahon 1b45b120e8 [BrowserTest] update Cite element locators
Also small refactor for readability

Change-Id: I65c1b589413bdb7de784aa3c4e0e189fca10bab3
2014-08-29 10:12:31 -07:00
jenkins-bot 68b3b5b9e1 Merge "Add missing ve.Filibuster.js to manifest" 2014-08-29 16:42:09 +00:00
Ed Sanders 0e84c912a3 Add missing ve.Filibuster.js to manifest
Change-Id: I7ea93a2c5b16ac91852506509cc09f97b47f46d3
2014-08-29 17:39:13 +01:00
Cmcmahon 3a964326a5 [BrowserTest] element locator changed
Change-Id: I456cd0718513e6338ccbbae86634d3e3bd1464b9
2014-08-29 09:12:50 -07:00
jenkins-bot 3286115c21 Merge "Return undefined, not null from onbeforeunload" 2014-08-28 23:11:30 +00:00
jenkins-bot f79d099490 Merge "In LinkTargetInputWidget, put existence status into LinkCache" 2014-08-28 22:17:03 +00:00
Alex Monk 51d2de4547 In LinkTargetInputWidget, put existence status into LinkCache
Bug: 69886
Change-Id: Ib37ba971c006c0bedc94f3ea9f1185461c9617b5
2014-08-28 23:09:13 +01:00
jenkins-bot effdff7378 Merge "Greylist IE11" 2014-08-28 21:58:35 +00:00
Roan Kattouw 4fc69878e1 Greylist IE11
There are still bugs and we're not marking it as a supported
browser yet, but it's no longer unusable.

Bug: 50085
Change-Id: I86b152da4c5dd895335d6f76b91c44f2eb3cd1a4
2014-08-28 21:51:18 +00:00
Roan Kattouw f0cadeca42 Return undefined, not null from onbeforeunload
IE doesn't accept null as a "do nothing" value, only undefined.
If you return null, it'll show a popup with the text "null".

Change-Id: I984a7ded483c4c178cbca2a9af9abd895e6ded56
2014-08-28 14:38:49 -07:00
jenkins-bot 7492cc7949 Merge "Pick up 'summary' parameter from URL to use as initial edit summary" 2014-08-28 21:29:07 +00:00
James D. Forrester adb0593c92 Update VE core submodule to master (be42edf)
New changes:
7a2e989 Update OOjs UI to v0.1.0-pre (43f379c884)

Local changes:
Eliminate all references to Agora, now Minerva

Change-Id: I497e122a35090a909b1fbb00d0a9487d97e09da1
2014-08-28 13:51:10 -07:00
James D. Forrester a9b01bdc8d Update VE core submodule to master (15cce1d)
New changes:
235faf9 Try a bit harder not to create empty text nodes
72f9aff Followup 355be3ed: fix getOffset() behavior inside block aliens
c81dd57 Trigger handleDelete inside onCut
edb4c60 Only block language change if dir hasn't changed
15cce1d Localisation updates from https://translatewiki.net.

Change-Id: Ic205fd2ae9ddc3f870b74a49bfc02fea9a14546a
2014-08-28 13:45:34 -07:00
Translation updater bot 8084ab0198 Localisation updates from https://translatewiki.net.
Change-Id: Ifc5808737c12f0a334cc6bca3c73620145b921e8
2014-08-28 22:32:08 +02:00
jenkins-bot aed40d6d04 Merge "Fix various bugs in our Monobook stylesheet" 2014-08-28 17:43:40 +00:00
jenkins-bot 1135d066ac Merge "Make the image model persistent" 2014-08-28 16:08:03 +00:00
Moriel Schottlender e34fdae776 Make the image model persistent
Make sure the image model can switch parameters when the image
source is switched, rather than having to instantiate a new
image model.

Also, when the image is changed, retain aspect ratio but make sure
to preserve the width of the previous image (unless the new image
is smaller)

Added 'resizeToBoundingBox' and 'scaleToThumbnailSize' static methods
in MWImageNode that return scaled dimensions based on the image
dimensions and the bounding box detals.

Depends on core change Idbb8b29db8e

Bug: 69450
Bug: 68000
Change-Id: I4327c86a9127f46da5522dc1197411fda757d5a4
2014-08-28 12:04:49 -04:00
James D. Forrester f99a0a4bc0 Update VE core submodule to master (c9304ac)
New changes:
8592238 Localisation updates from https://translatewiki.net.
446b53d Remove unnecessary execCommand('undo') from onCut

Change-Id: I804eb7dbb0205780bdae06db45cc9c94f09eab02
2014-08-28 08:34:26 -07:00