Ed Sanders
7db58ab3d8
Fix binding of onEditTabClick to section links in SET
...
Bug: T149797
Change-Id: I0f753718ccddb9c2b68cdc82ff379bd59d7006ad
2016-11-02 15:50:30 +00:00
jenkins-bot
5709e89399
Merge "eslint: Remove unused exception and fix documentation errors"
2016-10-28 19:12:19 +00:00
Ed Sanders
e655880d14
eslint: Remove unused exception and fix documentation errors
...
Don't enable valid-jsdoc yet though, due to @chainable bug.
Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
2016-10-28 12:02:36 -07:00
jenkins-bot
bce6aeb92a
Merge "build: Replace jscs and jshint with eslint"
2016-10-28 18:43:15 +00:00
James D. Forrester
36befda61c
build: Replace jscs and jshint with eslint
...
It's new, it's fresh, it's amazing, it's here.
Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
jenkins-bot
daf7a32c03
Merge "ve.init.mw.DesktopArticleTarget: Fix missing '&&'"
2016-10-28 00:12:45 +00:00
James D. Forrester
c45c79eca2
ve.init.mw.DesktopArticleTarget: Fix missing '&&'
...
Change-Id: I0e91cde3d38d3f5bdd7dde790093db21d8a64036
2016-10-27 16:53:55 -07:00
jenkins-bot
eabd56618b
Merge "Set Api-User-Agent in requests to RESTBase/Parsoid"
2016-10-27 23:24:09 +00:00
Ed Sanders
244eeb9ea1
Update VE core submodule to master (e4c8003)
...
New changes:
e4c8003 Bring in target 'mode' property from MW
Local changes:
Use upstream Target#setMode functionality
Depends-On: I9d501cb77c714fbd299b5816d302b0bdde7833cd
Change-Id: I2fcda6ca7d82d880101d9ba2a027d4ef066aa238
2016-10-27 16:12:31 -07:00
Ed Sanders
fad3b429c8
Make meta dialog tools visibile but disabled in NWE
...
Following our unwritten rule of trying to keep the interface
as consistent as possible.
Change-Id: I58668acb5bac12de73b7b8f52e670f68336c399f
2016-10-27 14:48:51 -07:00
James D. Forrester
7eeb66f63e
Set Api-User-Agent in requests to RESTBase/Parsoid
...
Bug: T149050
Change-Id: I7670450724f18865a7d9c7c7eb182449964f32b0
2016-10-27 08:56:19 -07:00
Ed Sanders
dc902b4c93
Pass edit token when saving/diffing in new wikitext editor
...
Change-Id: Ia14a4d204e367a3d0d46165a51b0cdc6fc3d57e7
2016-10-26 17:39:14 -07:00
jenkins-bot
3c443724e2
Merge "Follow-up I64a8ed73: Fix NWE getWikitextFragment"
2016-10-26 23:57:44 +00:00
Alex Monk
53f8aac0d5
Follow-up I64a8ed73: Fix NWE getWikitextFragment
...
Also fix the rejection Deferred line if things go wrong
Change-Id: I8f060de1972dd0ae79c81162c61efd5956e48955
2016-10-27 00:37:22 +01:00
jenkins-bot
3750081797
Merge "Don't show confirm dialog when switching to NWE"
2016-10-26 21:48:15 +00:00
jenkins-bot
60565711ff
Merge "Fix handling of API responses"
2016-10-26 20:42:35 +00:00
jenkins-bot
035987b9be
Merge "Create init.isWikitextAvailable and add page content check"
2016-10-26 20:42:06 +00:00
Ed Sanders
049a32c60a
Remove transform rule once toolbar has opened
...
Transform rules mess up the z-index context, so this
puts the toolbar dropdowns back in front of the content.
Change-Id: I7ba2cf295c83c55e5b1eead3a04760ea53390d37
2016-10-26 10:25:47 -07:00
jenkins-bot
b5317b694f
Merge "Fix edit source links for NWE"
2016-10-26 00:25:22 +00:00
Ed Sanders
460df1f25f
Don't show confirm dialog when switching to NWE
...
Bug: T148099
Change-Id: Icd756dc31ef8628795915ea972bb0ded385532ed
2016-10-25 17:20:16 -07:00
Ed Sanders
de2f07d523
Fix handling of API responses
...
NWE can return data in 'visualeditoredit' instead of
'visualeditor'. We may want to change this later.
Also restore removed hack code that popuplates missing
VE API data when requesting wikitext.
Change-Id: I9a782a85444d37a3e21c071db7e175ee9b0b1c4f
2016-10-25 17:20:16 -07:00
jenkins-bot
b341e3406a
Merge "Fix arguments passed to requestPageData when switching"
2016-10-26 00:04:34 +00:00
jenkins-bot
e3de154696
Merge "CSS styleguide fixes"
2016-10-26 00:04:33 +00:00
Ed Sanders
6358d9ed6d
CSS styleguide fixes
...
These will be enforced in future versions of stylelint-config.
Change-Id: I0689cbeee6586d2d3dcb0021a3f613dc2ac73691
2016-10-25 15:58:10 -07:00
Ed Sanders
7b9229f5b8
Fix toolbar transition
...
The contents of the bar to should appear to move in to place, not
just be revealed.
Change-Id: I01a85e3455462cf70b6c3f25a236ab6cb82c706c
2016-10-25 15:55:41 -07:00
Ed Sanders
702f931ef2
Fix arguments passed to requestPageData when switching
...
Change-Id: I890d782829fd077096be364c26a41b56ec4a2df3
2016-10-25 15:52:52 -07:00
Ed Sanders
e977ca4336
Fix edit source links for NWE
...
We fixed these to use vesection instead of section.
Change-Id: I0aa6530b6707239c41216421394379301b0878a7
2016-10-25 15:50:14 -07:00
Ed Sanders
751853942f
Create init.isWikitextAvailable and add page content check
...
Bug: T149007
Change-Id: I2e16c6361c32f3c1ebd2ae7c9f41089d56b67b06
2016-10-24 15:36:44 -07:00
Roan Kattouw
13801bb6d3
ApiVisualEditor: Move diffing and serializing to ApiVisualEditorEdit
...
These require POST, especially paction=serializeforcachekey because
it calls ApiStashEdit::parseAndStash() which needs a master DB connection.
Move them to the edit module so we can require POST for that one and keep
allowing GET for the main module. This fixes the warnings we currently get
for using parseAndStash() in a module that does not require POST.
Change-Id: I64a8ed7305105fa4c46902b99984306a7ff468cc
2016-10-21 15:24:13 -07:00
jenkins-bot
50e102da0c
Merge "Send RB errors through the normal error handling process"
2016-10-20 23:01:02 +00:00
jenkins-bot
0f566448ed
Merge "Switch to the wikitext editor if VE fails to load"
2016-10-20 23:01:01 +00:00
Ed Sanders
2dfdd82317
Prevent edit source from acting twice
...
Bug: T148309
Change-Id: I5ef3f4b7cbc7298e89aa531c174657b1d1bccdf6
2016-10-16 19:06:06 -07:00
jenkins-bot
23eb869d9d
Merge "Get rid of ?venotify= from URL post-save"
2016-10-14 23:30:16 +00:00
Alex Monk
b5815e9ffd
Send RB errors through the normal error handling process
...
Change-Id: I230ff6d3c9a6a183fb483f5adfd7ccdc025a07af
2016-10-14 11:17:56 -07:00
Alex Monk
39aa3021a7
Switch to the wikitext editor if VE fails to load
...
Also kill some dead HACK code in DesktopWikitextArticleTarget#switchToWikitextEditor
Bug: T135748
Change-Id: Ie5aaa0f3c3bd20755abaac9b86af015b71eb777b
2016-10-14 18:15:16 +00:00
jenkins-bot
246e2ebb4e
Merge "Tidy up DAT load failure handling"
2016-10-14 00:32:30 +00:00
Ed Sanders
e1e02fa0d8
Update VE core submodule to master (90cbd62)
...
New changes:
abf8f41 Replace Array#concat with Array#push in converter
02aeb90 Localisation updates from https://translatewiki.net .
902ddda Use safer batchPush in converter
6368191 Use current surface's sequence registry in command help dialog
f7ce4b9 Optimize batchPush on small lists
fb43a0a ve.batchPush: add unit test to exercise long-array path
d6c7d24 Factor out RESTBase ID regular expression
ffcbf4b IndentationCommand: Use hasMatchingAncestor
d447023 Allow ommission of range from ve.dm.Document cloneFromRange
cfbc344 Don't strip empty paragraphs on paste if they are generated
01c918b Localisation updates from https://translatewiki.net .
1467947 Fix documentation of getMetadataIdRegExp
Local changes:
* Define RESTBase ID pattern in platform and fix slightly
* Bring in paste test from core, which requires platform switching.
Bug: T147607
Depends-On: Ifc1c15872a50f915e5ef8d561b3a363dc5f4d28f
Change-Id: I3eb21e115de92a67afa85b5675fcbca5b111adb6
2016-10-13 17:10:33 -07:00
Alex Monk
70bf00e9b0
More NWE-SET integration fixes
...
Also stop calling $skin->getUser() so much, store the result
Change-Id: Ic91a660bc4b97a82f1d2b0bffb55425564696da1
2016-10-13 22:46:16 +01:00
Alex Monk
49283f7250
Fix typo in DAT.init.js
...
Change-Id: I75f7de16ea06d62a1bdfa0e04294fef5560fd5c9
2016-10-13 22:22:57 +01:00
Alex Monk
6b87b2671e
Fix another case where we need to pass the section
...
Bug: T144654
Change-Id: I5f91b9329525ceaeb971d02f93c959d908d748f7
2016-10-13 20:28:21 +01:00
jenkins-bot
d20040aec0
Merge "Section editing in NWE"
2016-10-13 01:51:56 +00:00
jenkins-bot
78df357278
Merge "mw.LinkCache: Links aren't missing if they're known"
2016-10-13 00:52:09 +00:00
James D. Forrester
0a3dbfb621
mw.LinkCache: Links aren't missing if they're known
...
Thanks to new sparkly API data.
Bug: T72123
Change-Id: I9d4ff14bb2e81404224819c9153a7b8d86ca6f11
2016-10-12 17:21:58 -07:00
Ed Sanders
4040442ad8
Section editing in NWE
...
Bug: T144654
Change-Id: Ida6e721e0d980b47e3fda6a1f0744cbce1b2235a
2016-10-12 12:55:11 -07:00
Kunal Mehta
6c93a49244
Get rid of ?venotify= from URL post-save
...
Use history.replaceState if available to get rid of the venotify query
parameter to avoid polluting URLs.
Ideally this would just use a cookie like the core post-edit
notification.
Change-Id: I6ce142012053e2fc18dd44fd0f7b82914acea076
2016-10-12 11:05:12 -07:00
Ed Sanders
4fc2904a87
Follow-up I9547dfd: Only enable VE tabs if VE is available
...
Otherwise VE is launched on namespaces where it is disabled
(but NWE is enabled).
Bug: T147890
Change-Id: I62f4ff96b991553a4eb0be9efb2e84bc80ca2bb4
2016-10-11 14:19:36 -07:00
Ed Sanders
605f7b625b
Hid category links in source edit mode
...
Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
2016-10-07 16:24:23 -04:00
jenkins-bot
7551b0e788
Merge "Use createTextNode in wikitext converter"
2016-10-06 23:20:21 +00:00
Ed Sanders
01ed8e954e
Use createTextNode in wikitext converter
...
Has better browser support. innerText is for getting the
text as rendered.
Bug: T147584
Change-Id: Ie2cf732d537aa4053d5b45d85c2d678a0d338017
2016-10-06 14:50:08 -04:00
Ed Sanders
aa7da97f2d
Use safer batchPush in converter
...
Some older browsers may fail with >1024 arguments. This
does not have a noticeable effect on performance.
Change-Id: I8c85f43425997735bbbe08d27374b79502e02ecf
2016-10-06 13:19:00 -04:00
