Commit graph

9 commits

Author SHA1 Message Date
Ed Sanders 79adf3f934 EditCheck: Only show add-reference in before save workflow (for now)
Change-Id: I6131af12fe4e9a85d9beaf4ca25cea1802461d26
2024-12-18 13:37:41 +00:00
Ed Sanders a26c145574 Allow checks to be dismissed by fragment or ID
Bug: T379804
Change-Id: I8c275a560971b95e3bbcf4921633e17c0078511f
2024-12-18 13:37:41 +00:00
David Lynch 37627ad9ae EditCheck: move checks to a sidebar
Bug: T341308
Bug: T379443
Change-Id: I66147d95fc23d0f72960ff93a76b3e5ba65ce44e
2024-12-11 20:20:00 +00:00
Ed Sanders e62327efe0 EditCheck: Replace highlights/selection with fragments
'selection' is only used by AddReferenceEditCheck but this can
be done in the act method.

Provide a method for getting highlight selections from
these 'affected fragments' that can be overridden.

Change-Id: Ida661682efd8ae99d945f0e310ea3ce12efc8770
2024-12-05 12:24:36 +00:00
David Lynch 2c73af983e Edit check: move some methods into BaseEditCheck
This is mostly cleanup from 4cd67004d removing Diff, which was the
original caller of the moved functions.

Change-Id: I015cb310527d9e7593e4ba6ac15ac204435d9ab4
2024-11-25 10:50:41 -06:00
David Lynch d806186810 Edit check: move config defaults to the client-side
This lets us encapsulate everything about a check in its JS definition,
which makes it much simpler for other extensions or gadgets to create
checks.

Change-Id: Ica23fc26a576d55addb001e4baf78b3702927208
2024-11-22 10:57:45 -06:00
David Lynch afb55049a3 Editcheck: fix typo in ConvertReferenceEditCheck
Follow-up to 4cd67004de

Change-Id: Ie95f36344c3627bcf0ab2a8fc2abcaf1745ab3a8
2024-11-21 11:33:23 -06:00
Ed Sanders 43b49080c9 EditCheck: Add more method documentation
Change-Id: Ia250a0c09d700b0f8e78bf2ea9c17e35b8c40d6d
2024-11-19 13:56:18 +00:00
Ed Sanders ee79edb58b Move edit checks to /editchecks folder
Change-Id: I27eee69c4086d44fd7d60bacde9a76c170af63fe
2024-11-14 16:44:59 +00:00