Commit graph

7166 commits

Author SHA1 Message Date
Trevor Parscal 9e6451d40c Fix inserting references list while selecting another kind of node
There are two ways dialogs determine if they are inserting or updating.

1. They evaluate whether the dialog is inserting or not and set a boolean
   flag, used later to steer the saving code

2. They evaluate whether the dialog is inserting or not and, if not,
   store the node to be updated in a property, used later to steer the
   saving code

In the reference list dialog, setup used strategy 1, and teardown used
strategy 2. We've now normalized to use strategy 2 in both methods, which
fixes this bug.

Bug: 61885
Change-Id: I1b077b2aef4121328bce2b373874dd7373e405a1
2014-04-14 19:44:28 +00:00
cmcmahon 219ca37909 [browser test] make test pass in both Chrome and FF
Change-Id: I36fc3eb31d0a97145cff5f43aef3a5365286de29
2014-04-14 12:10:02 -07:00
jenkins-bot 261fcbbbc0 Merge "Update VE core submodule to master (1064150)" 2014-04-12 00:34:36 +00:00
jenkins-bot ba7cf40ceb Merge "Also set requiresRange for CitationDialogTool" 2014-04-11 19:26:32 +00:00
Roan Kattouw 2d671a38a2 Also set requiresRange for CitationDialogTool
The citation tools weren't being greyed out when the selection was null

Change-Id: I7d4d486a010f4c1301f3081661e7f343c24452df
2014-04-11 12:19:04 -07:00
jenkins-bot d20ff82e5c Merge "Use updated tab labels on description pages for files in foreign repos" 2014-04-11 19:11:10 +00:00
James D. Forrester dc5ec4f256 Update VE core submodule to master (1064150)
New changes:
de81534 Put CommandHelpDialog keyboard shortcuts in kbd not div elements

Change-Id: I1070e824814f92ef322a58af9552e64fa3018d05
2014-04-11 12:06:45 -07:00
Roan Kattouw b54b517dbc Followup b2296bdd2: the property is called requiresRange, not requiresFocus
Change-Id: I09937603e1957f1acbdbe4cc56e47e00f31c892b
2014-04-11 11:59:55 -07:00
jenkins-bot d8453acff5 Merge "Remove remaining uses of surfaceModel#getSelection in dialogs" 2014-04-11 18:43:14 +00:00
Ed Sanders 340a939c97 Remove remaining uses of surfaceModel#getSelection in dialogs
These were being used indirectly in the MW*Model's. Use surface
fragments instead.

Fixes I0fae3e5ff2bd.

Change-Id: I1d6aa5e00a9315cf7088f87f9e9d828833feec64
2014-04-11 11:14:43 -07:00
Roan Kattouw 989fd6214c Fix JS error when opening VE on redirect page
Change-Id: I95dd2dc2c52ffa3d420a579592e84001bd2b10e8
2014-04-11 10:13:51 -07:00
jenkins-bot 49ce63020c Merge "Disable MW tools when surface loses focus" 2014-04-10 19:38:09 +00:00
Ed Sanders b2296bdd2a Disable MW tools when surface loses focus
Bug: 62410
Change-Id: I00fa2de637b2c1f2a57c8c1f09e90f71285feab7
2014-04-10 12:01:47 -07:00
Trevor Parscal afb182c23c Limit the number of citation tools to 5
Don't let too much toothpaste get out of that tube aye!?

Change-Id: I5cd92b7826d55ddde505f1bb883c6f8ed3223ec0
2014-04-10 11:47:34 -07:00
James D. Forrester aeec009c14 Update VE core submodule to master (74353d9)
New changes:
af131d3 Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit
b064ae8 Convert language name to lower case when looking for i18n file
f16dcac Fix ve.dm.SurfaceFragment#getSelectedNode
0fe1152 Clean up lots of minor things in SurfaceFragment
aec3043 Add excludeInsertion to translateRange()
f930950 Add excludeInsertion property to SurfaceFragment
a7ddd89 Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap
8108a0f Remove zh-[hk|tw] in favour of zh-han[s|t]
74353d9 Update OOjs UI to v0.1.0-pre (729c7bbe31)

Change-Id: I7aaebb071d544aec069d5ddab68740d93aed5bf4
2014-04-10 10:25:28 -07:00
jenkins-bot 9a7e602b76 Merge "Remove zh-[cn|tw] in favour of zh-han[s|t]" 2014-04-10 14:50:47 +00:00
Siebrand Mazeland 639b7bc6b2 Remove zh-[cn|tw] in favour of zh-han[s|t]
Change-Id: I8ba62c08980d60b1932b1a9a07f756446a1bed3b
2014-04-10 12:19:23 +02:00
Ed Sanders 0e51180709 Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors
Move various bits of code from initialize to setup as required.

MWDialog is now useless so use ve.ui.Dialog directly.

New changes:
0b2d03f [BREAKING CHANGE] Pass fragments, not surfaces, to windows (reprise)
0101ac4 Update OOjs UI to v0.1.0-pre (ac6848398c)

Change-Id: I0fae3e5ff2bd0da5b74c244af226b07b1f5883bd
2014-04-09 20:28:30 -07:00
Roan Kattouw f2422d916c Update VE core submodule to master (c150259) for scalable changes
ve.dm.Scalable is now a computational model for image scaling and
size manipulation. This commit adjusts the nodes and the edit and
insertion dialog to handle the new scalable model, and by that
use a centralized computational engine for all scaling and size
changes.

New changes:
3ec19fb8 Refactor Scalable functionality

Change-Id: I017a017924f544cc8bc9b7d8245335759ae0e890
2014-04-09 17:29:49 -07:00
James D. Forrester 273759a657 Update VE core submodule to master (b1f8fe2)
New changes:
9c716a6 Fix covering annotations logic
b1f8fe2 Prevent context flashing on window resize

Change-Id: Ib0e6fbf440944a2b12072c32813794fe759ea917
2014-04-09 16:44:33 -07:00
jenkins-bot 93d2175901 Merge "Limit the number of initially visible parameters in the parameter search widget" 2014-04-09 23:06:13 +00:00
Trevor Parscal 70655da2b9 Limit the number of initially visible parameters in the parameter search widget
* Truncate beyond 3 parameters
* Add a special option class that, when clicked, shows the remaining parameters
* Use a special option class for the no parameters item instead of hacking the normal one
* Simplify the design of the no parameters item: no icon, centered text

Change-Id: Ia8259e91b42a59c2b08019df36217d485208ad99
2014-04-09 12:56:02 -07:00
Translation updater bot 3dc9a388a3 Localisation updates from https://translatewiki.net.
Change-Id: Iff6d0157e956d9c76b6921f3fd225cdcfd79d514
2014-04-09 19:40:51 +00:00
Ed Sanders 164cf27299 Use new model directionality in MW
Depends on I2065e17020dc89 in core.

Change-Id: I6e99db601af58a9c4200f885887de451f9f70daa
2014-04-09 18:21:25 +00:00
Roan Kattouw ca6a9da129 Update VE core submodule to master (35c09bf)
New changes:
33e6dcd Update OOjs UI to v0.1.0-pre (98570355f6)
a90eb8c Inspectors should only hide on blur if the selection has been cleared
d6feda2 grunt: Run grunt-build as part of grunt-test and grunt-watch
3972dce Apply annotations to partially annotated selections
5b157e2 Debug bar fixes
8907f17 Use new banana checker as a linter to avoid lacking qqq messages
a6bdc7a Re-sync generated files output from `grunt`
cf31d70 Localisation updates from https://translatewiki.net.
4c2e83a Listen to close events on window sets to give focus back to the surface
290d593 Set content directionality on the model
9772a50 Use #isContentOffset instead of slug detection for word expansion
7203025 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();
4964b82 Localisation updates from https://translatewiki.net.
957d81c Revert "'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();"
35c09bf Update OOjs UI to v0.1.0-pre (70932872ba)

Change-Id: I205604fb8bd93948b7de84498da7fdf30fc70c1d
2014-04-09 11:20:33 -07:00
jenkins-bot 89319a5d28 Merge "[browser test] Fix edit mode test." 2014-04-09 14:09:26 +00:00
Krenair 99640bf1a7 Use updated tab labels on description pages for files in foreign repos
See I4a43b759

Bug: 63666
Change-Id: Ie4aeddde4909f455472dc5239156c23200033ee8
2014-04-09 00:26:29 +01:00
Translation updater bot c25a48c057 Localisation updates from https://translatewiki.net.
Change-Id: I3c1be1b8841860f1372e4df97a3bc77c2a6f5862
2014-04-08 20:07:22 +00:00
jenkins-bot 6c6937a2ad Merge "Actually actually fix double-clicking on hieroglyphics nodes" 2014-04-08 19:29:54 +00:00
jenkins-bot 7297802c10 Merge "Additional initializeSelection methodicde" 2014-04-07 21:54:05 +00:00
Roan Kattouw cedca2490c Actually actually fix double-clicking on hieroglyphics nodes
Bug: 63651
Change-Id: Ib97d202b43e6910a3e223d14031c33a95ca7a251
2014-04-07 14:45:18 -07:00
Translation updater bot 729f81d3db Localisation updates from https://translatewiki.net.
Change-Id: If993097e66cc2a8092770a05fc435f556300e1ec
2014-04-07 20:39:24 +00:00
Trevor Parscal 84ed719cd0 Additional initializeSelection methodicde
Changes:

* Change uses of initializeSelection to selectItem
* Use "choose" event to respond to deliberate item selection by the user

Depends on changes in OOJS-UI (Ib3826ed)

Change-Id: Ia167a70ca5f40b1f15adad30620fdb13ef0d02d7
2014-04-07 12:15:40 -07:00
cmcmahon 8134988b48 [browser test] Fix edit mode test.
This test never worked.  Last week this feature broke but the
test continued to pass.  Let's not do that again.

Change-Id: I9819a3304191959b9b194b3e675dfdd273618881
2014-04-07 11:50:54 -07:00
Siebrand Mazeland f8d56e6804 Move VisualEditor disabling from now-scrapped preferences section
'editing/beta' section stopped being used by anything other than
VisualEditor in 3c0aa26a0da68a9 in June 2013, and the section was
removed from MediaWiki core in ief2c7d1df876fb04.

This is a follow-up to 799e11ca7e which omitted one occurrence.

Change-Id: I05a6cce89d71808d82c12f54beb6b7a6730b265f
2014-04-07 11:42:41 +02:00
jenkins-bot c58103d53e Merge "Move VisualEditor disabling from now-scrapped preferences section" 2014-04-07 08:48:06 +00:00
James D. Forrester 799e11ca7e Move VisualEditor disabling from now-scrapped preferences section
'editing/beta' section stopped being used by anything other than VisualEditor
in Id8b9a47a in June 2013, and the section was removed from MediaWiki core in
I76667a15cc today.

Change-Id: Ida16f714c28c46d552b92c05b07b63f5d6dd361e
2014-04-06 16:53:25 -07:00
Translation updater bot fc3ae966c3 Localisation updates from https://translatewiki.net.
Change-Id: Iaaf15f689e37de89071a6e624a7b15ffa430ef66
2014-04-06 19:45:23 +00:00
Translation updater bot 079f99ba6c Localisation updates from https://translatewiki.net.
Change-Id: I6f97b8bd8eb6a8e846becb70e2615be5004298a1
2014-04-05 19:47:04 +00:00
Trevor Parscal fc94173ff6 Fix more intalize typos
Change-Id: I24e0b3a93c15cc8a781eb9a35d9ba09510db40bd
2014-04-04 17:13:34 -07:00
James D. Forrester 0ee4ba5d11 Use new banana checker as a linter to avoid lacking qqq messages
Change-Id: I02647d519ff85f78178d4fb48f014081ca3e82ef
2014-04-04 15:22:57 -07:00
Timo Tijhof 486e9cbbed grunt: Run grunt-build as part of grunt-test and grunt-watch
Especially the latter is nice, but might as well run it as part
of test.

Change-Id: I77b9e6be3adc57565390c9881165b462f0f34b56
2014-04-04 13:48:00 -07:00
Translation updater bot 2fb6b5662c Localisation updates from https://translatewiki.net.
Change-Id: I4b2ba5709553ad9bb5442d5fc238185ec28ea1a2
2014-04-04 20:26:09 +00:00
James D. Forrester a29e447e1c Update VE core submodule to 58c01b5
New changes:
58c01b5 Fix debug bar margins

Change-Id: I07ef4d9da5c325bd7a9918bcd1738f80bafe39ba
2014-04-04 12:33:48 -07:00
jenkins-bot b71e58c0f7 Merge "Give the edit tab <li> closest to the collapsed tabs menu class=collapsible" 2014-04-04 19:32:21 +00:00
jenkins-bot aeb4fabd2d Merge "Fix order of start and base timestamps when switching to the wikitext editor" 2014-04-04 19:31:58 +00:00
jenkins-bot 0610e7718d Merge "[browser test] maintenance, locator changed" 2014-04-04 19:31:07 +00:00
cmcmahon 9f57feff2f [browser test] maintenance, locator changed
Change-Id: I9d9f410afe6d4fd90489ba7816b9c0dec92460b0
2014-04-04 11:51:30 -07:00
James D. Forrester 33e21197ca Update VE core submodule to master (7f97fd8)
New changes:
7f97fd8 Update OOjs UI to v0.1.0-pre (eaa1b7f06d)

Change-Id: Icd448a81fe6330e264de58f3f1a83b7bd36339d2
2014-04-04 10:41:51 -07:00
Trevor Parscal 9556467595 Revert edit mode tool's onSelect method
Turns out surfaces don't have access to targets after all.

Bug: 63503
Change-Id: Ib14291ce4efe4b3dd5579cd270828936b6a175ae
2014-04-04 00:04:29 +00:00