Commit graph

9335 commits

Author SHA1 Message Date
jenkins-bot 04f398beaa Merge "[BrowserTest] Shorten lines for clarity" 2015-02-05 09:10:53 +00:00
jenkins-bot 8900b2ce92 Merge "[BrowserTest] Simplify the Selenium selector for the Save button" 2015-02-05 09:05:36 +00:00
jenkins-bot 9f36a8b669 Merge "[BrowserTest] Remove extra empty lines to make Rubocop pass" 2015-02-05 09:05:34 +00:00
Timo Tijhof 62c1d64ad0 mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting
* Use .ve-activated for elements changed in activate()
  - hideReadOnlyContent()
  - mutePageContent()
  - mutePageTitle

* Use .ve-active for elements changed in onSurfaceReady()
  - hidePageContent()

* Set 've-activated' class from activate() instead of transformPage()
  to consolidate reflows and minimise DOM interaction. It's still
  in the same (synchronous) execution path, but a few statements
  earlier now.

* Remove obsolete #toc wrapper. This <div> (with data property
  to distinguish it from potentially foreign parents in the future)
  was there to aid slideDown/slideUp animations, because those
  don't work well on table elements. See eba7d58dd1.

* Remove obsolete setTimeout in restorePageTitle().
  The removal of .ve-init-mw-viewPageTarget-pageTitle was delayed
  by one second (introduced in Ibc3fa2fb7 / 4cc88b9850). This
  was to account for a jQuery animation we no longer use.

* Remove unused '.ve-init-mw-viewPageTarget-transform-muted'
* Remove unused '.ve-init-mw-viewPageTarget-transform'
* Remove unused '.ve-init-mw-viewPageTarget-pageTitle'

The resulting stylesheet exposes that we're not consistent in
whether elements hide immediately (ve-activated) or once the
surface is ready (ve-active). This is intentionally kept as-is
within this commit.

Of the different elements that had their opacity changed, only
firstHeading was being animated. This animation was removed.

Bug: T88590
Bug: T87160
Change-Id: I87033456f715d99a88425e38e8ac5171144f4ec8
2015-02-04 19:24:29 -08:00
jenkins-bot 21f39e3086 Merge "Unbind watch event handler in VPT when necessary" 2015-02-05 02:09:17 +00:00
Alex Monk dd52503b6a Unbind watch event handler in VPT when necessary
Caught by Timo in I1df2836f

Change-Id: I0f0af71cdca26f7e8d13f9ea50d22c833b6e1683
2015-02-05 01:16:11 +00:00
jenkins-bot 110f6a2550 Merge "MWTransclusionDialog: Add a little margin to the addTemplateFieldset" 2015-02-05 00:42:14 +00:00
James D. Forrester d6c3bb2c7a Update VE core submodule to master (55e3589)
New changes:
cd3e393 Followup a92661781: fix attribute resolution
b440e22 Fix owner doc in demo
41472ba Localisation updates from https://translatewiki.net.
b46edca Update OOjs UI to v0.6.6

Change-Id: I7ef63efa1ada4eb667fe208749b0f3ef78960673
2015-02-05 00:35:05 +00:00
jenkins-bot ae8bdbda4b Merge "extension.json: Add "VisualEditorPluginModules" to "config"" 2015-02-05 00:07:43 +00:00
Kunal Mehta 6502b5ba06 extension.json: Add "VisualEditorPluginModules" to "config"
This somehow got missed in the conversion to extension registration.
It's being read as an attribute, but also as a Config setting, which
throws ConfigExceptions if not set.

Change-Id: I261398e269ab60a8787877f8a7ace97c50c2be45
2015-02-04 15:39:14 -08:00
Translation updater bot 2180830ee2 Localisation updates from https://translatewiki.net.
Change-Id: I91f3598488bc79fe0b502dfc877cb238c90de003
2015-02-04 22:29:45 +01:00
James D. Forrester ccbf32534f MWTransclusionDialog: Add a little margin to the addTemplateFieldset
Change-Id: I2549a9ca3df788cf92761b638a14760f8c413f46
2015-02-04 11:45:06 -08:00
jenkins-bot a7762b66a5 Merge "Adjust to ooui's show/hide css change" 2015-02-04 17:03:45 +00:00
jenkins-bot b43e798bb4 Merge "Make API module's LinkCache data transmission format more efficient" 2015-02-04 01:18:21 +00:00
jenkins-bot b5ea06c276 Merge "Improve references test data" 2015-02-04 01:16:19 +00:00
Roan Kattouw bc51095888 Improve references test data
* Remove unused extsrc
* Add <a>s inside of reference <span>s
* Add <li>s inside of reference list
* Change reference list to one for the g1 group rather than the main group
* Consequently, the reference defined inside the reference list moves to g1
** Due to a bug, explicitly set group="g1" on that ref for now

Change-Id: I266a4323c7353e00bd4288d5de51c252bbcdf3d7
2015-02-03 16:43:15 -08:00
jenkins-bot 82784d2217 Merge "[BrowserTest] Test for checking General Settings for media" 2015-02-04 00:30:16 +00:00
Translation updater bot 94b949db77 Localisation updates from https://translatewiki.net.
Change-Id: I91dae3d789b001b65429a6c38515011f9dfddb14
2015-02-03 22:57:12 +01:00
ryasmeen@wikimedia.org fcb9473c68 [BrowserTest] Test for checking General Settings for media
Change-Id: I503c01642a9fc23684912909e8da8e61998528a6
2015-02-03 21:53:40 +00:00
jenkins-bot 7928974236 Merge "test: Rebuild .rubocop_todo.yml" 2015-02-03 19:46:28 +00:00
jenkins-bot 184feebf1f Merge "ApiVisualEditor: Default format is jsonfm not json, so note this" 2015-02-03 19:45:36 +00:00
jenkins-bot b0dde09990 Merge "Update VE core submodule to master (c9b90ce)" 2015-02-03 19:45:23 +00:00
James D. Forrester 4208c63608 test: Rebuild .rubocop_todo.yml
Change-Id: Id2170f8d0f83edcd318eb469fb1f961d9172c7b3
2015-02-03 11:43:02 -08:00
Roan Kattouw e367ecc948 Make API module's LinkCache data transmission format more efficient
We used to send data like { title: { missing: true|false } }
With this change, we send data like { missing: [titles], existing: true|[titles] }
where 'existing' is set to true (assume all non-missing titles exist)
for current revisions and to an array of existing titles for
old revisions.

This is because we always output this data for links in the current
revision, even when loading an old revision: in that case we rely
on the client to request the omitted information, so there we can't
assume that all pages we don't have information about exist.

Bug: T88259
Change-Id: I7b58b3f669cc78fd81b60859cf76928a9087066f
2015-02-03 11:30:40 -08:00
jenkins-bot 0e926f5fcd Merge "Wait with showing edit notices until after the welcome dialog is closed" 2015-02-03 18:44:02 +00:00
James D. Forrester c3f716add8 ApiVisualEditor: Default format is jsonfm not json, so note this
Bug: T87582
Change-Id: I15952626c50690708d7cff8cc5a2983d8e4fb6bb
2015-02-03 10:24:51 -08:00
James D. Forrester e14626e6b2 Update VE core submodule to master (c9b90ce)
New changes:
39f2c09 Update scalable and view on direct attribute change
f02e8bb Use .prop() instead of .attr() where appropiate
32458db Use new window#updateSize method
50db41d Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build)
cf6414b build: Use karma to v0.12.31
4856215 Use text input's setLabel functionality in find dialog
0e3ec9a Fix typo in F&R teardown
8c0bdf6 Reinstate keypress filtering for Firefox

Change-Id: I40888c23111ce0566de437be1399b63cf569cbcf
2015-02-03 10:18:40 -08:00
jenkins-bot 07e95ac365 Merge "[BrowserTest] Updating test for Media Settings interface" 2015-02-03 07:42:33 +00:00
Timo Tijhof 1d00894497 mw.Target: Add mw-body-content class before we attach surface
If added afterwards, this causes child elements styles with
'em'-values to get redrawn (or even animated).

Bug: T88387
Change-Id: Ic1aba14b7cfe0ff6e7191f0b6052ed9cc4585fcd
2015-02-02 20:25:02 -08:00
Alex Monk f3dd60dbe3 Hide extra space at the top of the single transclusion dialogs
Bug: T78045
Change-Id: I36974f69128a3e2c303076e3bd740f270e178c6b
2015-02-02 16:49:49 -08:00
Kunal Mehta 55d9e76188 Add extension.json
Needs Iff1523b86f754ca in mediawiki/core to work properly.

Bug: T87992
Change-Id: I869873eef6d19fdaee75201b87d8c4a8d4d05f3f
2015-02-02 16:31:00 -08:00
jenkins-bot 3d6aa68c7c Merge "Use ActionFieldLayout in the template placeholder page" 2015-02-02 23:48:27 +00:00
jenkins-bot 4d53c5d86a Merge "Increase user-input delay in MediaSearchWidget" 2015-02-02 23:47:21 +00:00
jenkins-bot d3bcefffb6 Merge "Do not send search query on whitespace" 2015-02-02 23:46:53 +00:00
jenkins-bot b0915d2df8 Merge "Update VE core submodule to master (8218942)" 2015-02-02 22:43:23 +00:00
jenkins-bot 2388ee443c Merge "build: Bump devDependencies to latest" 2015-02-02 22:43:21 +00:00
jenkins-bot 17ac459ecb Merge "[BrowserTest] Add basic test for table creation" 2015-02-02 22:39:04 +00:00
James D. Forrester bed038b509 build: Bump devDependencies to latest
Updates:
* grunt-contrib-csslint  0.3.1  ->  0.4.0
* grunt-contrib-jslint   0.10.0 -> 0.11.0
* grunt-jscs             0.8.1  ->  1.2.0

For jscs, leaving requireSpacesInsideArrayBrackets to avoid headaches for now.

Change-Id: I62d34444edbba65c8bd22d2fa5e50e16cabb0042
2015-02-02 14:30:39 -08:00
Moriel Schottlender 7734e7e71f Do not send search query on whitespace
If the user inserts a whitespace to the search input we don't want
the API query to be sent out.

Change-Id: I8cd68a6039ca98e3d78c9f1aa88f4098a1a99edc
2015-02-02 14:20:29 -08:00
Elena Tonkovidova 0240a51717 [BrowserTest] Add basic test for table creation
Change-Id: I07022e27da9d7114c18a82cdbd62e4cb82ddc7e2
2015-02-02 15:15:13 -07:00
James D. Forrester 9e8374bc71 Update VE core submodule to master (8218942)
New changes:
49ccab7 Localisation updates from https://translatewiki.net.
2a9dd3b Update OOjs UI to v0.6.4
bdcc3c5 Follow-up 6fc57d41: Update build results with grunt
960ee07 build: Fail in CI if there are resultant changes
ae85883 Rename file drop to data transfer
f8a530a Update OOjs UI to v0.6.5
9e6b090 Provide Platform#getConfig and shortcut ve#config
8218942 Localisation updates from https://translatewiki.net.

Change-Id: I1825668073aae66d33317ce31a6e2e179046ee1a
2015-02-02 14:14:39 -08:00
Moriel Schottlender 5d8108f229 Increase user-input delay in MediaSearchWidget
Increase the timeOut for the typing delay so we send search API
requests less frequently when the user types a search term.

Bug: T88188
Change-Id: Ibaf7184fb0eb9a02b460b0a66eabade791aea620
2015-02-02 14:01:49 -08:00
Translation updater bot 151a683743 Localisation updates from https://translatewiki.net.
Change-Id: I9382244c12e88bde8d58e42e55e40ba1457f1723
2015-02-02 22:32:25 +01:00
Moriel Schottlender 70fb0ea24f Use the new image cache in the media dialog
Prevent another api call for image sizing by caching the chosen
image in the media dialog with the imageInfoCache.

Bug: T88187
Change-Id: If2d905eeb5907f29b6839692509dfc07a06c230e
2015-02-02 19:32:46 +00:00
jenkins-bot d5f7bac940 Merge "Combine imageinfo requests" 2015-02-02 19:32:00 +00:00
Bartosz Dziewoński c0d69dd3db Wait with showing edit notices until after the welcome dialog is closed
Its white overlay is pretty good at obscuring them, and the notices popup
would close when the dialog is closed, making it very easy to miss them.

Also fixed indentation.

Bug: T86987
Change-Id: I9f93c4169de98ef77a1eb33fd31a0ec524b6d2b7
2015-02-02 17:25:02 +00:00
Ed Sanders f4bb7de786 Only re-render if the images is larger than the last rendering
Means we don't make unnecessary requests to the image API
and make the server side image resizer do extra work.

Bug: T88248
Change-Id: I20e1d37c913522eafc45a9a2e263051322b9b083
2015-02-01 13:07:48 -08:00
Alex Monk dc69b15db1 Template dialog: Disable 'Apply changes' until a change is made
Bug: T76926
Bug: T76927
Change-Id: I5a664f865c11690a19b754fc9877baf37e34edad
2015-01-31 03:19:06 +00:00
jenkins-bot 73e05df441 Merge "MWLinkTargetInputWidget: Check title is valid in MediaWiki" 2015-01-31 03:13:36 +00:00
jenkins-bot ed8f711b88 Merge "Don't corrupt href="./" in internal links" 2015-01-31 02:48:11 +00:00