Commit graph

7602 commits

Author SHA1 Message Date
Moriel Schottlender 74c3b758e2 Show beta welcome dialog before surface is ready
Split up beta and meta dialog show methods so that beta dialog
is displayed as soon as possible, regardless of the surface being
ready. Also make sure that we destroy the temporary window
manager on destroy.

Bug: T90454
Change-Id: Ib8f94518af431487ce940a74a8c268dbdbe403d2
2015-03-26 12:36:40 -07:00
Alex Monk 9019f02130 Check for the two revision IDs returned by the server being different
With RESTbase we'll be able to retry the older one, but right now we have to do
both with the same request.

This commit retries loading once, then starts emitting errors.

Bug: T92993
Change-Id: Ifbf44b777279dafbe31ab438838d70acd44de726
2015-03-25 20:46:27 +00:00
Ed Sanders 8f012e76ce Use new createFromElement method from ModelFactory
Depends on Ia23e5d25 in core.

Change-Id: Iac6f0aaacb8404a28a41e33088fc7f519c227317
2015-03-25 18:26:56 +00:00
James D. Forrester 497e7eb4a1 Update VE core submodule to master (cb06317)
New changes:
5197b2d Rangestate optimization
80a07cf Unmix GeneratedContentNode from AlienNodes
f510e9c Make (Node/Annotation/MetaItem)Factory inherit from ModelFactory
b625ff0 Localisation updates from https://translatewiki.net.
5c4653c ve.qunit: Use 'jscs:disable' comment rather than hacks
90e9480 Remove registration of abstract AlienNode classes
d325674 i18n/en.json: Convert from spaces to tabs, like all other files
f40fc15 Add 'classes' config option to focusable nodes to simplify AlienNode
f7c8999 Document config options as @cfg
ad3aa0b ve.ce.Surface.test: Groundwork for testing non-linear selections
cd1a992 Localisation updates from https://translatewiki.net.
c92471e Move drop marker to highlights layer and position absolutely

Change-Id: I437663d93a346a06c6a5137cce5149c7a6fcbb7f
2015-03-25 18:20:35 +00:00
jenkins-bot 80d8312c28 Merge "Add unit test for mwAlienExtension node" 2015-03-25 14:59:34 +00:00
jenkins-bot 5f3e0b033b Merge "Emit activation entry/exit traces at the appropriate times" 2015-03-25 03:15:56 +00:00
Translation updater bot 900c102073 Localisation updates from https://translatewiki.net.
Change-Id: I5046e0f3ef112f430f363ff95236f978a3b5ba5c
2015-03-24 22:35:44 +01:00
Amir E. Aharoni 1d1ffac74e [BrowserTest] Capture the whole formatting button in the screenshot
This makes the screenshot nicer and more complete.

Change-Id: I0dd9efd2978ff5468ab6101b11b7e6fdd3b0da30
2015-03-24 12:34:42 +02:00
Amir E. Aharoni cbed069984 [BrowserTest] Rename headings dropdown scenario
Change-Id: Ib59cf24ad30823ddfcf1d31a9eb2c45efd0199fc
2015-03-24 10:45:22 +02:00
Amir E. Aharoni 8c48b3055f [BrowserTest] Add padding to the Headings dropdown screenshot
Makes it look nicer.

Follow up to
Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556

Change-Id: Ic4d473159942918776b7c5e7107e48b824c228e3
2015-03-24 10:31:50 +02:00
Amir E. Aharoni 47af0b6449 [BrowserTest] Capture the whole dropdown indicator in the screenshot
The Headings menu screenshot started from the arrow-down element:
https://commons.wikimedia.org/w/index.php?title=File:VisualEditor_Toolbar_Headings-en.png&oldid=154425461

Now it captures the whole menu so it will look more complete

Change-Id: Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556
2015-03-24 10:18:33 +02:00
Ori Livneh 13292744b1 Emit activation entry/exit traces at the appropriate times
Due to changes in the way VisualEditor is loaded, the trace.activate.{enter,exit}
events no longer enclose the entire VisualEditor initialization process. This
change ensures that trace.activate.enter is emitted as soon as the user clicks
on an edit link / tab and that the trace.activate.exit is not emitted until the
toolbar has been fully activated.

Change-Id: Ief798faa95a58898b9ae4dcbbbd30506c5dbd9a7
2015-03-23 23:19:12 +00:00
Translation updater bot 66f72a07be Localisation updates from https://translatewiki.net.
Change-Id: I0d28ccfd8a04289c7c146a442462e722cad3884e
2015-03-23 22:12:32 +01:00
Ed Sanders 1be77a90e3 Add unit test for mwAlienExtension node
Change-Id: I0323cf16f103ad801127568afe75e03d90e62c37
2015-03-23 16:06:09 +00:00
Amir E. Aharoni 065d26e363 [BrowserTest] Add a screenshot for the Page settings menu item
Change-Id: I0ec601dc9559521746fe6e7fbad05f2df8f7497e
2015-03-23 12:38:45 +02:00
Amir E. Aharoni 73523eb5cf [BrowserTest] Add a screenshot for the category item
Change-Id: I3f607e1013dbdac6974b33b557d8a0fffe4d4590
2015-03-23 12:31:00 +02:00
Ed Sanders e006449c7f Vertically center the progress bar within the visible part of #content
On short pages which don't extend below the fold, the progress
bar should center within the #content element.

Change-Id: I0b99e42f5bab8177d3b4ca6dd372d6403ae9b136
2015-03-23 02:34:40 +00:00
Translation updater bot e50b74d906 Localisation updates from https://translatewiki.net.
Change-Id: I07c34680d002661f9d0c8c46366ace2115e8311f
2015-03-22 21:20:52 +01:00
Roan Kattouw 884f301aa0 For empty / whitespace-only headings, output <p> instead of <h#>
Because sending HTML like <h2>  </h2> or <h2></h2> to Parsoid
produces undesirable output like ==  == or ==<nowiki />==

Bug: T51452
Bug: T52100
Bug: T57769
Bug: T61647
Change-Id: If15a1b4b31d4f08c23ecdf2ecf61a8a14a77259a
2015-03-20 23:05:37 +00:00
Roan Kattouw 8470e2c272 Update VE core submodule to master (f8f9728)
New changes:
68e20d4 Create AlignableContextItem to quickly adjust AlignableNodes
0150df2 Update OOjs UI to v0.9.3
b333fd3 FragmentInspector: Execute action on enter, rather than closing with data
2d14f7a Fix webkit column hack
be780eb Don't drop whitespace when removing empty slug paragraphs
cc19787 Split handlesOwnChildren and ignoreChildren
7f1c9a7 Localisation updates from https://translatewiki.net.

Local changes:
Add ignoreChildren to handlesOwnChildren nodes

Change-Id: Id3dc7efae8d30b6551b2fc3104ed00bc86339176
2015-03-20 16:04:15 -07:00
Translation updater bot de92c00127 Localisation updates from https://translatewiki.net.
Change-Id: I58a01eae294114e644c86abb4164829f76b8e481
2015-03-20 21:38:25 +01:00
jenkins-bot 335a7012bb Merge "Make loading progress bar determinate" 2015-03-20 20:15:42 +00:00
Ed Sanders 6d8fbd8221 Make loading progress bar determinate
Estimate loading times to show smooth loading progress.

Bug: T90622
Bug: T92456
Bug: T52206
Change-Id: Ic6e31a938b474c5a11c0c12302ec6c0ebc2c414d
2015-03-20 20:08:01 +00:00
jenkins-bot 2c8f47492b Merge "TransclusionDialog: Initialize label mode button" 2015-03-20 00:34:48 +00:00
Trevor Parscal 5e833f0c10 Update VE core submodule to master (5d5f8a4)
New changes:
622693a Work around JS errors when editing image properties
a0498f8 [BREAKING CHANGE] Emit rerender for dead nodes

Local changes:
Use the new traverse function to bind handlers to rerender events of
generated content nodes to update the target of async rendered reference
content in reference context items.

Bug: T91314
Change-Id: I762a6c4c9438b431444c7af7b43043ee1517a15c
2015-03-19 16:14:17 -07:00
Trevor Parscal 8fc1e2dea0 TransclusionDialog: Initialize label mode button
Because the mode label is set after measurements of the foot are made,
the body of a ProcessDialog was set to overlap the foot.

At some point T93290 will be fixed, but in the mean time we can solve
this problem by setting an &nbsp; initially.

Bug: T92986
Change-Id: I995d5ecd81b86ee188cf237f74487ec70480e297
2015-03-19 23:06:46 +00:00
Translation updater bot 1410b9a5dd Localisation updates from https://translatewiki.net.
Change-Id: Ia65b36b35f7aa62264e41672537adfcdddf06021
2015-03-19 21:17:53 +01:00
Amir E. Aharoni c4f21ecd03 [BrowserTest] Remove when_not_visible check from 'I click Save page'
The when_not_visible line fails, but it doesn't seem to be needed
in the first place. The when_present line appears to be enough.

Change-Id: I572dabb5d53553d454f6e40c5602fbe3252c3657
2015-03-19 14:54:32 +02:00
Amir E. Aharoni e34aa6aab4 [BrowserTest] Disabling the References list test
The functionality chnaged significantly, so the steps must be changed.
Removing the tag until it's done.

Change-Id: Iacdf78d3b6f00e39cb2bf313b79489035f1c0b62
2015-03-19 14:26:08 +02:00
Amir E. Aharoni 425b53a1e2 [BrowserTest] Revert the definition of the disabled_save_button element
The element is <div>, and using English text doesn't work
in other languages.

Follow up to
Icd79ec9b489557c3259ff7f2c11b2a899c767d0f

Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7
2015-03-19 12:14:38 +00:00
jenkins-bot e05c842d64 Merge "Fix edit conflicts" 2015-03-19 02:39:28 +00:00
Alex Monk 74cb83d2f8 Fix edit conflicts
When we moved to mw.Api, edit conflict errors stopped going via onSave and
started going to onSaveError instead. So the case to check for them in onSave
would not have worked - instead, they would go through onSaveError and get
picked up by our unknown error code, which just picks out error.info and shows
it, instead of showing our edit conflict screen.

Also return in a couple of other error cases where we probably should've been
(but not necessarily must've been... that didn't necessarily show to the user
if another error emit already caused saveDeferred to be rejected)

Change-Id: Iae7a66a8aa96ee777e9fa780005feeb429129d5f
2015-03-19 02:36:21 +00:00
jenkins-bot 230b47979f Merge "Restore async rendering of ReferenceContextItem" 2015-03-19 01:52:37 +00:00
Ori Livneh 94877eb668 Set mwtiming events' target to 'mwTarget', if unset
We're currently rewriting "mwtiming.performance.system.domLoad" to
"timing.ve.undefined.performance.system.domLoad". The "undefined" comes from
the missing targetName property on the event. I'm not sure why it is missing,
but having it default to 'mwTarget' will Do the Right Thing™.

Task: T93156
Change-Id: If70ff601b6c54ec8f95171cbc43c82c87a177508
2015-03-19 00:40:28 +00:00
Trevor Parscal 9f660f9db8 Restore async rendering of ReferenceContextItem
We moved toward serialization, but in the case where we don't have a
rendering yet and it's happening async, we need to use the same DOM
container that will be rendered into.

Bug: T91336
Change-Id: I53920591fde02175d4162b1fe5899b97b10a5b0f
2015-03-18 23:28:24 +00:00
jenkins-bot 1046d309b2 Merge "Handle TitleBlacklist errors" 2015-03-18 22:44:36 +00:00
jenkins-bot e8e58bf058 Merge "Set action.saveFailure.message key in Edit schema" 2015-03-18 22:43:17 +00:00
Alex Monk 88088d4ecc Set action.saveFailure.message key in Edit schema
This relies on WikimediaMessages' version of the Edit schema being updated at
the same time.

Change-Id: Iee97fdd2a867f2c252ca7756f2e6341377d9fbb7
2015-03-18 22:24:40 +00:00
Alex Monk c286511f17 Handle TitleBlacklist errors
Relies on I69cf0a88

Using our own new message because TitleBlacklist's own one includes text that
we can't parse on the client and relies on a parameter we don't get from the
API.

This relies on WikimediaMessages' version of the Edit schema being updated at
the same time.

Change-Id: I4c75369b8b97973b72899bfaecbd5a996a440c68
2015-03-18 21:58:51 +00:00
Ed Sanders b83d23c620 Update VE core submodule to master (b57d224)
New changes:
541659f [BREAKING CHANGE] Remove domElements attribute from aliens

Local changes:
* Update alien tests

Change-Id: I26a7ebc709fae9d2365a7f9ce2c4cfdcc10620a2
2015-03-18 14:16:10 -07:00
James D. Forrester 70cff83f68 Update VE core submodule to master (6bd2ea5)
New changes:
44ca3b6 Use store indices in annotate operations
3ebbcce Make range optional in getUsedStoreValuesFromRange
9d03a5e Set originalDomElements whenever a data element is created
4cfffde Simplify annotation hashes
4eeb8bb Add handlers for font annotations
4a6d6f0 Localisation updates from https://translatewiki.net.
05de45e ve.ui.ToolbarDialogTool: Fix documentation
6797d6d Use type from toDataElements when creating annotations
b3a3839 Store reference to DM document in transactions
c073a24 Load special characters in Platform instead of SpecialCharacterDialog

Local changes:
* Add new files to VisualEditor.php
* Re-sort i18n strings in VisualEditor.php
* Re-run extenson.json creation
* Update documentation HTML file
* Update tests for adjacent annotations fix

Change-Id: I7a5e79e68ab8a7aae0e9af42d011943019f7f85f
2015-03-18 12:15:24 -07:00
jenkins-bot 05766564d1 Merge "Remove font tags on import (paste/drop)" 2015-03-18 18:29:57 +00:00
jenkins-bot 275ba972bb Merge "Follow-up f620111b: pass parameters to fallback requestPageData() call" 2015-03-18 18:25:24 +00:00
Ed Sanders ba20a26292 mw.ViewPageTarget: Grey-out body content as soon as edit is clicked
Set 've-activated' as soon as edit is clicked, with a 've-loading' state.

This necessitates moving the relevant styles to mw.ViewPageTarget.init.css.

Change-Id: Ic9757cdbf63a2f72eda0dd03ff5588d79028ba0e
2015-03-18 17:56:28 +00:00
Roan Kattouw 3375411afd Follow-up f620111b: pass parameters to fallback requestPageData() call
Bug: T93036
Change-Id: I84eba70d9c0af63b442993c8c59fee89da45c14f
2015-03-18 16:23:37 +00:00
Translation updater bot c62c5c0df3 Localisation updates from https://translatewiki.net.
Change-Id: Ie0473ffcff8cb171cea78eeedd323dc778a5dc9c
2015-03-18 16:08:45 +01:00
Ed Sanders fbe207fabf Remove font tags on import (paste/drop)
Change-Id: I46c7d4aee2f35ccf8ab6967c0273bc46c5a79347
2015-03-18 08:51:13 +00:00
jenkins-bot ddaee51606 Merge "Insert a new references list immediately, rather than showing a dialog" 2015-03-18 02:28:54 +00:00
jenkins-bot 4ef6eb8010 Merge "Unbreak TargetLoader when ViewPageTarget.init isn't present" 2015-03-18 00:42:10 +00:00
Roan Kattouw 812cb9aa2c Unbreak TargetLoader when ViewPageTarget.init isn't present
By lazy-initializing mw.libs.ve

Change-Id: I2fea8a0935b43b5a25287f68bd7487c448d006b6
2015-03-17 17:38:29 -07:00