Commit graph

125 commits

Author SHA1 Message Date
Amir E. Aharoni 73523eb5cf [BrowserTest] Add a screenshot for the category item
Change-Id: I3f607e1013dbdac6974b33b557d8a0fffe4d4590
2015-03-23 12:31:00 +02:00
Amir E. Aharoni 425b53a1e2 [BrowserTest] Revert the definition of the disabled_save_button element
The element is <div>, and using English text doesn't work
in other languages.

Follow up to
Icd79ec9b489557c3259ff7f2c11b2a899c767d0f

Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7
2015-03-19 12:14:38 +00:00
Cmcmahon 698f36cdd4 [BrowserTest] update Cite test for new UI
* Access to Cite options changed
* Various target locators also changed

Paired with Rummana for these changes.

Change-Id: Ib7c3fbd1842879745d3d3128c66d90cc2b4f98cb
2015-03-17 15:54:14 -07:00
Cmcmahon d5f78cc6e4 [BrowserTest] Update locator for the Insert/More link changed
Change-Id: I2d4f68edb4bfad6813e9138afb77efadd75b2986
2015-03-11 17:29:46 +00:00
Cmcmahon ac5a38a03d [BrowserTest] fix edit test
This has been failing for a while, for several reasons, originally
because an updated version of Cucumber interpreted an "&"
character in an unexpected way.

Change-Id: Icd79ec9b489557c3259ff7f2c11b2a899c767d0f
2015-03-10 14:27:03 -07:00
Amir E. Aharoni 76b50c5b34 [BrowserTest] Update the Edit tab scenario
Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.

Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
2015-02-26 12:59:34 +02:00
Amir E. Aharoni 5a70225a6b [BrowserTest] Fix VisualEditor_More_Settings scenario
The screenshot here is supposed to capture the menu that opens
when the hamburger icon is pressed.

The previous code captured the whole toolbar. This is now fixed.

A sample screenshot is here:
https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png

Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc
2015-02-25 00:17:15 +00:00
Amir E. Aharoni acf67c7af2 [BrowserTest] Update the scenario for Cite screenshot
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.

* The clicking step is removed.
* The element is reconfigured.

Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
2015-02-25 00:16:53 +00:00
Amir E. Aharoni a993be469b [BrowserTest] Remove extra empty line to make Rubocop pass
Change-Id: I0628cb5af5a716740150d78fce29c97f8c3cf85d
2015-02-20 13:37:56 +02:00
Vikas S Yaligar b960e4c999 [BrowserTest] Edited language screenshot steps which had iframe elements
Bug: T89370
Change-Id: If87d30fc23bfc867e6c62a3edefc8b2591c6ce48
2015-02-19 23:46:22 +05:30
Amir E. Aharoni 26763e7731 [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures
Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b
2015-02-17 13:24:52 +02:00
Amir E. Aharoni 5a715d05ad [BrowserTest] Remove an empty line to make Rubocop pass
Change-Id: I110fef0f98ee7a2c5b74971b1e068bca0869e912
2015-02-17 10:20:12 +00:00
Cmcmahon df1013b7da [BrowserTest] Remove unused steps and locators
No more iframes

Change-Id: I3d6420f2a017a132d5695921daa5efb5117f3176
2015-02-12 11:53:58 -07:00
Cmcmahon 5d03721bb7 [BrowserTest] Update transclusion test for better locator
Also remove unused step and element

Change-Id: If99cde6a3ec1f0fb87628e5d8600a83034e11ee1
2015-02-12 11:27:40 -07:00
Cmcmahon 7d3e8a8ac5 [BrowserTest] Cite message no longer in iframe
Change-Id: I027bf87c0eb91edb7dc6218c3bc8f66a8c1aa69e
2015-02-12 10:54:02 -07:00
Cmcmahon 924e738652 [BrowserTest] Bring references test up to date.
This addresses some old technical debt.

We also shifted the re-use reference test to the cite.feature where
it belongs in the current architecture.

Paired with Rummana for the update

Change-Id: Ie50ac5bffec0d0ab6bcad704c323639f8e8553f0
2015-02-10 15:57:44 -07:00
jenkins-bot 31e4fbec90 Merge "[BrowserTest] Update the definition of formula_image element" 2015-02-10 09:41:30 +00:00
Cmcmahon 3db521ce41 [BrowserTest] make References test pass
Somehow the Insert element got removed from the page object. Fixeded.

Change-Id: I970d4824ebeed817f621b09714e0d58d99bee573
2015-02-09 10:36:44 -07:00
Cmcmahon 18679b74ba [BrowserTest] Make media tests pass
Like in the Cite tests, need a sleep to make the tests pass
locally.

Updated a locator also

Change-Id: Idd962e110fd7191325bdac7e641960858de1db9e
2015-02-09 10:24:12 -07:00
Cmcmahon dd671b4843 [BrowserTest] update Cite test to pass
I'm hoping the sleep() calls here are temporary. VE seems to be
loading an intermediate page before showing the diff view, or
sending an invalid onload event or some such.

Also updated the locator for the Basic text input

Change-Id: I73795f6b1ff0da42f8afd92598ab6786c9a0b88b
2015-02-09 10:00:41 -07:00
ryasmeen@wikimedia.org cefb9b265a [BrowserTest] [WIP]Fixing the test media_general_settings.feature
Change-Id: Ic83477f12db08ed25452f19ca3dc410940a8ebf5
2015-02-06 16:16:33 -07:00
Amir E. Aharoni 8d5b48d018 [BrowserTest] Update the definition of formula_image element
The class name of the formula image changed.

Follow up to
Ib50d0381f5743db1f6678609cd4eca5a56a8682b

Change-Id: Ic78b5be572c8757c4d8f35bd878adf4ecf7c8fb0
2015-02-05 14:26:59 +02:00
Amir E. Aharoni 4a73b3e4b1 [BrowserTest] Rename iframe to window_frame
It's not an iframe anymore, so the name shouldn't be confusing.

Change-Id: Id93595d56d7d88871ab79ca91e1714d9a70fad17
2015-02-05 10:32:21 +00:00
Amir E. Aharoni 4bab4fd921 [BrowserTest] Restore the formula screenshot scenario
* Restore the Formula editor screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
* Get the 'More' element clicked to show the formula item.
* Fix the definition of the formula editor textarea element.

Change-Id: Ib50d0381f5743db1f6678609cd4eca5a56a8682b
2015-02-05 10:28:37 +00:00
Amir E. Aharoni 8063c6c754 [BrowserTest] Restore page settings language screenshots
* Add classes to elements in the page settings dialog boxes
* Restore the scenario that was disabled in
Id41d1329d22679b6a61201ceafc81eafa222d909

Change-Id: I5636e744daec2adf013d399bfb019e4d47912083
2015-02-05 12:16:48 +02:00
jenkins-bot 3351d84bf0 Merge "[BrowserTest] Restore the indentation list screenshot scenario" 2015-02-05 09:17:55 +00:00
jenkins-bot c73d949ba7 Merge "[BrowserTest] Show the complete insert pull-down in screenshots" 2015-02-05 09:15:07 +00:00
jenkins-bot 8238658ad7 Merge "[BrowserTest] Consistent names for variables that refer to down-arrow" 2015-02-05 09:12:25 +00:00
jenkins-bot 8900b2ce92 Merge "[BrowserTest] Simplify the Selenium selector for the Save button" 2015-02-05 09:05:36 +00:00
ryasmeen@wikimedia.org fcb9473c68 [BrowserTest] Test for checking General Settings for media
Change-Id: I503c01642a9fc23684912909e8da8e61998528a6
2015-02-03 21:53:40 +00:00
jenkins-bot 07e95ac365 Merge "[BrowserTest] Updating test for Media Settings interface" 2015-02-03 07:42:33 +00:00
Elena Tonkovidova 0240a51717 [BrowserTest] Add basic test for table creation
Change-Id: I07022e27da9d7114c18a82cdbd62e4cb82ddc7e2
2015-02-02 15:15:13 -07:00
ryasmeen@wikimedia.org eea130381a [BrowserTest] Updating test for Media Settings interface
Fixed the following:
1.The workflow was incomplete and incorporated new changes
2.Wrong css pointer to the first image
3.The Given statement was defined as When in step definition file
4.Removed unnecessary/obsolete steps that was making the test to fail while we can verify the basic functionality with miminum steps.

Change-Id: Ic8a265678900ed52bbed6d90e971d6c016ef610d
2015-01-30 18:11:33 -08:00
Amir E. Aharoni 8da4c9b3cc [BrowserTest] Restore the indentation list screenshot scenario
* Add a class to the indentation toolbar button, similarly to what was done in
  Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
* Fix the definition of the indentation pull-down element acordingly.
* Restore the Indentation menu screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26

Change-Id: If2d92aab6d04aa487d6f753fa7cac94f8d8215c8
2015-01-27 13:35:39 -08:00
Amir E. Aharoni d20d70cdd6 [BrowserTest] Show the complete insert pull-down in screenshots
The "insert_pull_down" element only included the menu trigger.

Now it includes the complete pull-down with all the items.

This is consistent with other pull-down elements.

Change-Id: I3f6052eab1ee0322ebb7e6f2116e2d5d0e25f5b1
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 3f31715c09 [BrowserTest] Consistent names for variables that refer to down-arrow
Change-Id: Ib7c799af449a9427f6ba25403cbd6b2d220133f0
2015-01-27 13:35:39 -08:00
Amir E. Aharoni 024481baae [BrowserTest] Simplify the Selenium selector for the Save button
The selector was very long and incorrect.

This patch simplifies and corrects the selector.

This also fixes the VisualEditor_save_dialog scenario
in the language_screenshots scenarios.

Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1
2015-01-27 13:35:39 -08:00
Amir E. Aharoni c80e311a02 [BrowserTest] Fix VisualEditor toolbar actions scenario
The save button changed from constructive (green) to progressive (blue).

Change-Id: Ic410d5ed3847da803d6d83df7f77b6e0edc5d81b
2015-01-27 04:15:51 +00:00
Cmcmahon 295f9f81b1 [BrowserTest] Add test for missing parameter error msg
Test checks for 'Required parameter missing' message, 'Go back'
and 'Continue anyway'.

Paired with Rummana writing this

Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
2015-01-14 16:04:12 +00:00
Amir E. Aharoni 7c128f9a4a [BrowserTest] Make the Save page element language independent
This element used the English label. It should just use
the class to be language independent.

I tested by running VisualEditor_save_dialog scenario
in language screenshots for the Persian language. It fails
on master because of the English label and passes with this commit.

Change-Id: I77955b3dfabbf6a15885c085e3fbdd447b04b4db
2015-01-13 13:05:35 +02:00
Amir E. Aharoni 7a4ec947fa [BrowserTest] Change the Heading menu item from a to span
Change-Id: I214f8dbc73e38073f6e8dedfb61d75b1e829fa38
2015-01-13 12:21:10 +02:00
Amir E. Aharoni cd4bd7a73c Add classes to toolbar UI elements
This cleans up the selectors for the elements on the toolbar
so that they can be tested.

Class names in the form of ve-test-* are added to elements
that have words for labels: 'Paragraph', 'Cite', 'Insert'.
There is no other way to look up these elements in the DOM
except using the UI text, but it is different in different languages,
so this is unusable for the language_screenshots job,
which is multilingual by its nature.

Bug: T76143
Change-Id: Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
2014-12-30 12:16:44 +00:00
Cmcmahon 4fbd141b49 [BrowserTest] update test for new selector
Change-Id: Ic3bc3b416bc7ddadef7a05699f6181c0b7b84cdd
2014-12-17 10:22:44 -07:00
Cmcmahon c34fd60a9b [BrowserTest] update general markup test
refactor for new locator

Change-Id: I089aebb64a9d67d01c1bfa4682927c0de2575051
2014-12-17 09:31:24 -07:00
Cmcmahon 30c3aa2242 [BrowserTest] update Links test
another iframe gone it seems

Change-Id: I33767706675bbdcd1cb45f33da109858ec36986e
2014-12-17 08:51:17 -07:00
ryasmeen@wikimedia.org 5eff6e8aa1 [BrowserTest]Fixing options test
Fixed the unique selector for failing cases
Change-Id: I41bde7245328303fcc8c5afea8f7228c1d36b915
2014-12-16 17:36:50 -08:00
jenkins-bot 6ca0046599 Merge "[BrowserTest] changing the css paths for Cite options for fixing the tests" 2014-12-16 22:36:50 +00:00
ryasmeen@wikimedia.org aa77e8ab4f [BrowserTest] changing the css paths for Cite options for fixing the tests
Change-Id: Iea90e4bb656b30ec0839e6c843e30ba8ae1fd637
2014-12-16 15:33:37 -07:00
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
2014-12-15 21:37:42 +00:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
2014-12-08 10:43:35 -07:00