Commit graph

332 commits

Author SHA1 Message Date
James D. Forrester e9af948c3e Hooks#onAuthPluginAutoCreate: Only act if not default
Change-Id: If52c23b523953aabf52ef3e889a77b422a149c63
2016-04-01 14:29:26 +03:00
jenkins-bot ec1f924c59 Merge "Defer the user save in onCustomEditor() to post-send" 2016-03-26 03:16:50 +00:00
Aaron Schulz 42943a49d1 Defer the user save in onCustomEditor() to post-send
Bug: T92357
Change-Id: Ifc71b57f006673b2ea62175976292ca0562fc787
2016-03-24 14:21:39 -07:00
Aaron Schulz 7fd0747ffd Avoid master queries on GET requests for blocking
Bug: T92357
Change-Id: I031d71a87d49e0a33eed7c0c520097770f14937e
2016-03-24 13:24:00 -07:00
Alex Monk 73969d74cd Simplify showtabdialog logic a little bit
Don't unnecessarily nest if statements, don't check tabs preference twice

Change-Id: I788d978b2e13030104be7ea295137a09abc032a8
2016-03-06 00:07:06 +00:00
Alex Monk ade0862db1 Give a useful message in the temporary blank edit screen
Bug: T128028
Change-Id: Ife0a9de96965a9848f362696fc403708fd344825
2016-02-27 21:42:10 +00:00
James D. Forrester e7a3ec43bf build: Update mediawiki-codesniffer to 0.6.0, add "composer fix"
Change-Id: Ic96081539c2ae98b5b239b59ca9b0362b337e522
2016-02-17 08:18:02 -08:00
Alex Monk 35d38ae13a Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"
This reverts commit 5b083a7272.

Change-Id: Ief26646da34e88b6a32c782a8b0b40dd1ba53903
2016-02-13 02:17:54 +00:00
jenkins-bot 4a751524c4 Merge "Edit mode switch: Show popup next to VE switch button" 2016-02-10 01:51:57 +00:00
Ed Sanders 80124c88a6 Edit mode switch: Show popup next to VE switch button
Only show if the user came from VE.

Change-Id: Ic362ba534d135fca5516c8ba401f6b2a22886ff1
2016-02-10 01:36:32 +00:00
Alex Monk 188ec0f5d2 Send users whose browsers support JS but are unsupported by MW to the WTE using venoscript=1
Bug: T123457
Change-Id: Ia7e6f4dc1b7dc15fa287bf6b2c4ea12eb4a7c4ba
Depends-On: Ice6ebb95bfcb2050f4813705467942f95f7e720c
2016-02-09 19:04:14 +00:00
jenkins-bot b7f710baa0 Merge "Set page title when we take over action=edit" 2016-02-06 15:38:39 +00:00
James D. Forrester 1e0486a679 Remove all Extension:Cite code, now moved there
Depends-on: I39936ed83d5a60471a0a75da753f498e80aef234
Depends-on: Ifd853bf9f901065798bd0063aeaa786a3761aa71
Depends-on: I32c93c5118eafe5f071252290c58d3de8dacc81a
Change-Id: Iba0f25b3ebe4e5e63377da57afb760d6980f9907
2016-02-05 21:36:56 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
2016-02-05 21:36:56 +00:00
Alex Monk eb1cab32ff Set page title when we take over action=edit
Bug: T125670
Change-Id: If2ac6457ba82fbd046649afb1e24eab3232c5d85
2016-02-05 02:26:14 +00:00
Alex Monk c2e792e334 SET: Set user's editor to wikitext if the browser doesn't do JS
Bug: T121257
Change-Id: I8c734934a76ac73ff943db1712e679a7e73aa1e1
2016-02-04 01:22:54 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
2016-01-26 16:47:26 +00:00
Alex Monk f6c2d234be Try to do a better job of matching user agent strings
Bug: T124264
Change-Id: Ieb51d97f46c478ee5527e4bc20a54c6929b54727
2016-01-22 02:32:32 +00:00
jenkins-bot dbad1e0495 Merge "SET: Browser blacklisting checks" 2016-01-15 20:59:19 +00:00
Alex Monk b0cadabcd8 SET: Browser blacklisting checks
Only basic testing done.

Bug: T121298
Change-Id: I3a3e2632916ce359d8f91f3f9404b86353b87d31
2016-01-12 17:16:18 +00:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
jenkins-bot 6b7fc00f68 Merge "DesktopArticleTarget: Change tab text on server side when possible" 2015-12-16 19:51:03 +00:00
Alex Monk 27822d6612 SET: Always show wikitext editor on action=edit if multiple tabs are in use
VE tab will take you to veaction=edit then instead

Bug: T120987
Change-Id: I6e9bb24199e974435992c3b9a7b87c1b668187b3
2015-12-15 20:12:43 +00:00
Alex Monk c99a5b627e DesktopArticleTarget: Change tab text on server side when possible
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.

Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
2015-12-15 10:49:45 -08:00
Alex Monk 76a12f2f9b Try to actually resolve visualeditor-editor preference setting when switching editors
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743.

Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
2015-12-15 17:35:22 +00:00
jenkins-bot 33cbf199f1 Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"" 2015-12-14 20:53:28 +00:00
Jforrester 40807a0743 Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"
This reverts commit 5b083a7272.

Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
2015-12-14 20:46:08 +00:00
jenkins-bot 51d493918b Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 2015-12-14 16:46:02 +00:00
Kunal Mehta 7f02824ec4 Remove no longer needed ContentHandlerDefaultModelFor hook
As of 3b44da3261673 in MediaWiki core, all MediaWiki:*.json pages are
given the JSON content model, so our hook that does the same is no
longer needed.

Change-Id: I8b39edf36b479ca22d74481c3d571d15db69aa1e
2015-12-12 13:34:11 -08:00
James D. Forrester 5b083a7272 DesktopArticleTarget: Don't abort in SET mode if veswitched is set
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
2015-12-11 18:15:25 -08:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
2015-12-10 23:13:25 +00:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
2015-12-10 12:12:59 -08:00
jenkins-bot 0d9643e9e2 Merge "Single edit tab: Update preference value" 2015-12-10 01:33:25 +00:00
Alex Monk bca222912c Hide VE tabs preference when user has disabled VE
Bug: T120965
Change-Id: I846124f762d811be4fbfb32c08063fc57a029cb4
2015-12-09 22:54:28 +00:00
Alex Monk e8a682f567 Single edit tab: Update preference value
It's all Timo's fault for suggesting the new values in I65d96627 PS21, obviously.

Bug: T120969
Change-Id: Ib0309342a831ec1950c1be8c7a0c79a31c413163
2015-12-09 22:51:16 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Alex Monk 748db015b0 Single edit tab and section links
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
2015-12-08 17:47:16 +00:00
Ed Sanders be45a9172e Update VE core submodule to master (d6f2d75)
New changes:
94f2edb Paste sanitization: Check for whitespace *before* newlines
c981b96 Fix-up Ie5414f62c: Fix call to non existant method
d6f2d75 FindAndReplace: Implement whole word matching

Local changes:
* Message and config for FindAndReplace whole word matching

Change-Id: I103b9b1ec92c0aae1e51e1a94db6b8b5e759dbea
2015-12-03 09:40:12 -08:00
Bartosz Dziewoński 9be5c85db4 Provide a tool to insert a signature in namespaces that need it
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.

This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.

Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.

Changes include:
* The tool is now always visible if the wiki allows signatures in any
  VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.

Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).

Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb

Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
2015-11-16 18:06:32 +01:00
Alex Monk b550323b53 Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
2015-11-03 23:55:17 +00:00
Alex Monk f71a5a5bca Dialog for switching between wikitext and visual editing
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
2015-11-03 01:36:29 +00:00
jenkins-bot a0a0f0e2c0 Merge "Allow switching from wikitext to VE" 2015-11-02 23:18:33 +00:00
Alex Monk 85b745666f Allow switching from wikitext to VE
Just by pressing the VE tab for now

Requires a relatively new version of restbase

Bug: T49779
Change-Id: I2a5294345f5e0f469c1dd1bdd29dbce211571a4e
2015-11-02 20:55:19 +00:00
Alex Monk 9f3864723f Register the preference to hide education popups
This is needed for logged in users

Bug: T117083
Change-Id: I8e214ef2f043c97e387b65f47db6b8d234c55339
2015-10-30 02:10:46 +00:00
jenkins-bot 81a89952ef Merge "Educational popups and highlights for links+citations" 2015-10-14 21:52:50 +00:00
Alex Monk 9d6fbc894e Educational popups and highlights for links+citations
Bug: T108620
Change-Id: I42b0e06f50aca5cb783d88f79a080461e745ceee
2015-10-06 14:33:57 +01:00
Ed Sanders 6c1891c150 Find and replace: Add pref keys for find/replace text inputs
Adds support for storing find and replace text inputs added
in core in I8ae8d49.

Change-Id: I78dea87025e2bfa1b3ff977b16986e8431ddfb22
2015-10-04 13:39:58 +01:00
James D. Forrester 01bd73c808 Update VE core submodule to master (ca4bd8c)
New changes:
8c917a7 Add focused class to surface when focused
04d7f8c Localisation updates from https://translatewiki.net.
dfc71e6 Move cursor offset calc from CE Surface to DM Document
02040d0 Localisation updates from https://translatewiki.net.
7d6d49e IME tests: Add IE11 Win8.1 Korean; name specific Windows versions
7ce9d64 Localisation updates from https://translatewiki.net.
ca4bd8c Update OOjs UI to v0.12.10

Change-Id: I7c04d72cb6bf1d21eb257e2a6cf42c61c7d34eba
2015-09-29 15:14:02 -07:00
Roan Kattouw 28fbf2bcda Update autodisable logic
* Make betatempdisable appear checked if autodisable is true
* Set autodisable=false only if betatempdisable is also false
* On wikis where $wgVisualEditorTransitionDefault=true, set
  autodisable=true when the user disables VE

Change-Id: I3415af4a735afb10cf246f4b22b9d84ef98c882f
2015-09-28 18:19:56 -07:00
jenkins-bot ce8107ec0b Merge "Autodisable preference" 2015-09-28 23:46:59 +00:00