Commit graph

7391 commits

Author SHA1 Message Date
Moriel Schottlender e0894b807f Surfaces should have parent document direction
Make sure all surface widgets have documents that are initialized
with the direction of the parent document, so the alignment is set up
correctly.

Bug: T71969
Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
2014-12-10 16:46:16 -05:00
Translation updater bot 70e8633c05 Localisation updates from https://translatewiki.net.
Change-Id: I3c4f3b3115aa8daa8b7fb3c4c800b4907e6fd564
2014-12-10 22:11:36 +01:00
jenkins-bot f51cc6f2ea Merge "ve.ui.MWParameter*: Use the destructive flag for all four remove buttons" 2014-12-10 02:04:33 +00:00
Roan Kattouw a032ea039e Move from legacy TimingData schema to new statsd API
This API doesn't have the ability to track any other data
in addition to a name and a duration in milliseconds, so
we add the target name ('mwTarget' or 'mobile') to the
event name and discard all other data.

Change-Id: I25ae0243f8983142d7755b65b05c18d5df36a253
2014-12-10 00:25:42 +00:00
jenkins-bot ed22cbffea Merge "Prefer localStorage to store ve-beta-welcome-dialog" 2014-12-09 22:39:09 +00:00
James D. Forrester eac5aabeb3 ve.ui.MWParameter*: Use the destructive flag for all four remove buttons
Previously we were only doing it for one of the four.

Bug: T78033
Change-Id: Ib0091052a5c858dfd37b8755b6e3b84406b7c745
2014-12-09 14:28:40 -08:00
Alex Monk 51b091b9cd Prefer localStorage to store ve-beta-welcome-dialog
Bug: 62884
Change-Id: I3fe45e890c29aaa8d28edfb6986dc8c7541861c7
2014-12-09 21:04:13 +00:00
Translation updater bot 2edf5a7104 Localisation updates from https://translatewiki.net.
Change-Id: Ifc36f5299dfc91692e2357cb4ba2c2909477e658
2014-12-09 21:59:30 +01:00
Roan Kattouw 29995d806b Remove IEHacks.css in favor of .ve-init-target-ie class
Move reference style hack to MWReferenceNode.css, and move
heading style hack to ve.init.mw.Target.css

Change-Id: Icbd53f8df998c9f7bcc701b7c29dc226dfc5c05f
2014-12-08 15:45:23 -08:00
Roan Kattouw 3321261e98 Split up ve.init.mw.ViewPageTarget.css
* Move styles that apply to all targets to ve.init.mw.Target.css
* Move styles for MWPopupTool subclasses to ve.ui.MWPopupTool.css

Change-Id: I34c8a6200ee337debf00c4e432948f1b86f1b60a
2014-12-08 15:42:19 -08:00
jenkins-bot 09bfc0cb9c Merge "Followup 1c04d32d: release saveDialog reference even if closed" 2014-12-08 23:06:37 +00:00
Roan Kattouw dad06ef495 Followup 1c04d32d: release saveDialog reference even if closed
It's good that we're not trying to close the save dialog
if it's not open, but we still need to release our reference
to it in that case, otherwise trying to open the save dialog
in a new incarnation of the editor will fail.

If you opened VE, opened the save dialog, closed it,
went back to read mode, opened VE again, and tried to open the
save dialog again, it would fail because it tried to open
the cached reference to the previous editor's save dialog.

Bonus: prevent JS errors in this case by only attaching an
onClose handler if the dialog actually opened successfully.
If opening the dialog failed, the callback parameter isn't
a promise but an OO.ui.Error, and calling .always() causes
a JS error.

Change-Id: I62d6d3e7cd3df2c29a0c99e2e23bf1aac5187a12
2014-12-08 14:49:39 -08:00
Translation updater bot 4c3a6e55ee Localisation updates from https://translatewiki.net.
Change-Id: I771f43da908ad0d352ff74c622dea4cbcbd2bb42
2014-12-08 23:24:37 +01:00
Cmcmahon 978308ee1f [BrowserTest] update Cite tests
Seems that a set of invisible textareas have appeared

Change-Id: I2ee81c782220c632393d2bbdc66ca66a5c8bf667
2014-12-08 10:43:35 -07:00
Translation updater bot 381c0bd5a0 Localisation updates from https://translatewiki.net.
Change-Id: I1ba254f3d7e22a6264703f65f7fa0f78b0a22ef9
2014-12-07 21:57:36 +01:00
jenkins-bot 9d1b8fdded Merge "Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths" 2014-12-06 21:41:13 +00:00
Timo Tijhof ee954cbdd5 Use String#slice instead of discouraged String#substr
Aside from the confusion and differences between substr() and
substring() and IE8 bugs with substr(), substr() was removed from
the spec as of ECMAScript 5. It's been standardised in the
optional Annex B section of ES5.

Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
2014-12-06 21:26:20 +00:00
James D. Forrester baffe9d7e1 Update VE core submodule to master (32397d8)
New changes:
5e60f12 Ensure clipboard key is removed from paste target
32397d8 Update OOjs UI to v0.4.0

Local changes to compensate for new OOUI version, and updated wfUseMW call.

Change-Id: I005f7b23a36e04f1305d4aa037c19a5c7db9a699
2014-12-06 12:28:07 -08:00
Alex Monk fc6eaf6825 Don't re-enable apply changes in reference dialog if the changes have been undone
Per Roan on Ib5229bdc

Bug: T57976
Change-Id: I0450ab59ea8aa2e3130eb9124de74e67ffc0497f
2014-12-05 23:50:57 +00:00
jenkins-bot 7a0e11ed0c Merge "Disable Apply Changes in reference dialog until changes have been made" 2014-12-05 22:46:26 +00:00
Alex Monk a7b9b89479 Fix href parsing in transclusion nodes when on alternative (e.g. mobile) domains/paths
Use model HTMLDocument when parsing transclusion nodes and their link hrefs

As well as mobile, this also covers the issue I found in /w/index.php?veaction=edit

See also T76374

Bug: T76379
Change-Id: I07c9ba0adbcee32f7eb2ca280d3a1d46e963d28f
2014-12-05 22:23:09 +00:00
Translation updater bot a9e939649e Localisation updates from https://translatewiki.net.
Change-Id: I7dc624ec5d93b6ee5be968cd5d744e81f2e0dab9
2014-12-05 23:16:32 +01:00
Bartosz Dziewoński d39dfaa837 MWCategoryInputWidget: Don't explode on invalid titles
canonicalQueryValue can be null at this point, so let's not insert it
into an array that contains strings.

Bug: T76868
Change-Id: I8096a9c1017e883d28124bf807d2d375ae98452a
2014-12-05 21:07:57 +01:00
Alex Monk b0b53befdc Fix call to mw.log.warning
Should be mw.log.warn

Added by I111176b8

Change-Id: I58b78e89a7f5a21fe050e2a90bf856c388f7213d
2014-12-03 23:35:51 +00:00
Translation updater bot fd8f9463aa Localisation updates from https://translatewiki.net.
Change-Id: I9bcf93cd047e84c80a50d0ef34b7474bcdb6486f
2014-12-03 22:30:16 +01:00
James D. Forrester e722c1726f Update VE core submodule to master (0229301)
New changes:
5eb7294 Find and replace
123a6ad Find and replace tool
557f70f Go backwards through find and replace results on shift enter
4a4ed81 Allow language widget to filter on available languages

Local changes to adjust.

Change-Id: I15e14d6d3c7ee60e465baf3a4df7572851cbca3e
2014-12-03 10:36:39 -08:00
Roan Kattouw dbf232a7dc Clean up deactivate mess
Both onDocumentKeyDown and onViewTabClick would check
this.activating and invoke deactivate() differently depending
on its value. That's ugly, so incorporate the "don't show a dialog
if deactivating during activation" logic into deactivate() itself.

Rename the override parameter to noDialog, and fix the broken
logic around it (it overrode too much).

Also move setting this.activating = false; out of these event
handlers into cancel(), where it clearly belongs because
activatingDeferred is being rejected there.

Change-Id: I6c040c74d36f829128a175f00d4e712dd19d31a7
2014-12-02 16:50:36 -08:00
jenkins-bot 45e98c7699 Merge "Cancel VE when escape key pressed" 2014-12-03 00:33:19 +00:00
Alex Monk c0fd5e616d Cancel VE when escape key pressed
Or at least open the confirmation dialog about it.

Relies on I0047bd9d to not break stuff on the second try.

Bug: T52868
Change-Id: Id178a2a0aad2f4bf5f589d66efde61aaa6fae498
2014-12-02 16:29:15 -08:00
jenkins-bot 77b507dfc7 Merge "[Browsertest]Tests for options under Advanced Settings panel" 2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org 416d62df4f [Browsertest]Tests for options under Advanced Settings panel
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
2014-12-02 15:00:33 -08:00
jenkins-bot d7f954b1b5 Merge "Make LinkCache fail more gracefully when given undefined" 2014-12-02 22:45:08 +00:00
jenkins-bot 63e09d4659 Merge "Handle encoding of links in transclusion nodes properly when determining existence" 2014-12-02 22:22:15 +00:00
Roan Kattouw 2ed648c4db Make LinkCache fail more gracefully when given undefined
If you tried to do styleElement( undefined, $element ), you'd
get an exception in the mw.Title constructor from a setTimeout.
That's not very nice, and there's no point sending non-strings
through the queue and other data structures in LinkCache, so
instead just make get() return a rejected promise when given
non-string values.

Change-Id: Iab06929d7e232a8ecd8eb1eff9d1190c303421c1
2014-12-02 14:02:45 -08:00
jenkins-bot d71279cdfe Merge "ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve" 2014-12-02 21:50:12 +00:00
jenkins-bot 6c4c3408b8 Merge "Track new pagedeleted save error in TargetEvents" 2014-12-02 02:04:11 +00:00
Roan Kattouw 915278dfea Track new pagedeleted save error in TargetEvents
Change to Schema:Edit takes it to revision 10676603.

Change-Id: I87a3812585ac0dd22a66ceffdf320ad8bc326155
2014-12-01 17:58:31 -08:00
Alex Monk db4d034fd7 Disable Apply Changes in reference dialog until changes have been made
Bug: T57976
Change-Id: Ib5229bdc480ec437436c5d8d351b06417d4ffd9b
2014-12-02 01:34:44 +00:00
Alex Monk c2ed5201e5 Handle encoding of links in transclusion nodes properly when determining existence
Bug: T75823
Change-Id: I9398e4e1657b218043658d83b13c3dc78ffa8ff1
2014-12-02 01:09:12 +00:00
Translation updater bot 5613f53a96 Localisation updates from https://translatewiki.net.
Change-Id: I5c54331b5438652841ad92ed8a90a45623263563
2014-12-01 22:23:50 +01:00
Bartosz Dziewoński e6ea9db351 ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve
Change-Id: I265aba968d861020852ada5034e166189efd3218
2014-12-01 20:59:53 +01:00
jenkins-bot 7734e0083a Merge "i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>" 2014-12-01 19:35:34 +00:00
jenkins-bot 0445ee640d Merge "Remove duplicate startSanityCheck from ViewPageTarget" 2014-12-01 19:22:56 +00:00
James D. Forrester 7ab402eeb5 i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>
Bug: T75969
Change-Id: I6bbe2dbec74edae9fb1b09e03f3102b7a2d0be97
2014-12-01 11:22:34 -08:00
Ed Sanders 7dc4dd66a0 Remove duplicate startSanityCheck from ViewPageTarget
Method was moved to parent, but not deleted from child. Also move
sanityCheckPromise to parent where it is used.

Change-Id: Ie2b00330d796cd089fd4bc84d9332c316500633f
2014-12-01 19:19:51 +00:00
jenkins-bot 55eba4c1cc Merge "Change event listener for caption surface in media dialog" 2014-12-01 19:05:09 +00:00
jenkins-bot 0cfaf9f95b Merge "Set panels after everything is initialized in media dialog" 2014-12-01 18:48:24 +00:00
Translation updater bot 64604a475d Localisation updates from https://translatewiki.net.
Change-Id: I6aa9f444c3e6090edcf851a51e094f0fac042b4b
2014-11-30 22:16:32 +01:00
Translation updater bot 59bccb0bd5 Localisation updates from https://translatewiki.net.
Change-Id: I87dde90d5069228d31da11c7dae3583fa8988320
2014-11-29 12:59:08 +01:00
Amir E. Aharoni 9dad03819e Mention the "Continue" label as a parameter in visualeditor-recreate
Bug: T75971
Change-Id: Id075233da4e8a2978b07b5f2735ac6620ff5330d
2014-11-27 22:33:35 +02:00
Željko Filipin 15ed437331 [BrowserTest] Fixed a couple of page elements
Change-Id: Ia4652896243705651c86ff5f83dbd03029757705
Paired-With: Amir Aharoni
Bug: T76133
2014-11-27 11:39:02 +01:00
jenkins-bot a2d7d64fcf Merge "Followup 6d21d83: unbreak switching to edit source" 2014-11-27 00:27:39 +00:00
Moriel Schottlender 78b86cd72d Set panels after everything is initialized in media dialog
Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
2014-11-26 19:26:44 -05:00
Roan Kattouw 616a9cd1bf Followup 6d21d83: unbreak switching to edit source
Forgot to pass the wikitext parameter through, oops :(

Bug: T76114
Change-Id: Ic852e4b10c17b2417f582f35fabb87823e0202e3
2014-11-26 16:24:50 -08:00
Roan Kattouw 8fc9b290c0 Followup c56a921: use cite-transclusion-* tools in MWReferenceDialog, not cite-*
Because a lot of toolbar customization was removed, use an evil
hack to get this in there for now. Should be cleaned up later.

Bug: T76082
Change-Id: I0fd5ddc6fa11162deb615f0b387d6d59c5cc4a3a
2014-11-26 15:49:04 -08:00
Translation updater bot a14f88d80e Localisation updates from https://translatewiki.net.
Change-Id: Ibf83b770faf5df229365a73fb2d812d3c5fd0697
2014-11-26 22:37:44 +01:00
Moriel Schottlender 30ce139955 Change event listener for caption surface in media dialog
Make sure the dialog is listening to the correct event for when
caption surface changes.

Bug: T76074
Change-Id: I214947a440e4f78adf1541d8008599fe65ac8b2c
2014-11-26 20:04:07 +00:00
James D. Forrester e90cbe6a37 Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote>
Also push it into correct place in the toolbar, and disable it from media and
reference dialogs' toolbars.

Change-Id: Icc3bf056860e35def13e03e77ffc6782acc4196a
2014-11-25 19:01:02 -08:00
jenkins-bot cee93a0758 Merge "If the user types in ':' at the beginning of a line, make it a blockquote" 2014-11-26 02:02:32 +00:00
jenkins-bot cb9a96f845 Merge "Follow normalisation response from category status query" 2014-11-26 02:02:27 +00:00
jenkins-bot dc76bb63fb Merge "If the user types in '==' at the start of a line, make it an H2" 2014-11-26 02:02:21 +00:00
James D. Forrester e314ed9938 If the user types in ':' at the beginning of a line, make it a blockquote
Depends on I9507219 in VE-core.

Change-Id: I2e3219b473799194f8d305d228fc9eb3403921a8
2014-11-26 01:58:53 +00:00
jenkins-bot cf131ee2b7 Merge "Revert "ve.init.mw.trackSubscriber: Populate platform field with hack"" 2014-11-26 01:57:09 +00:00
Catrope 64ce195fae Revert "ve.init.mw.trackSubscriber: Populate platform field with hack"
Caused JS errors when invoked too early.

This reverts commit 35d3898543.

Change-Id: Ie7dd4ef8323a16bb694e6300a096ba53cf4a0a91
2014-11-26 01:55:30 +00:00
James D. Forrester 9a7eddee79 If the user types in '==' at the start of a line, make it an H2
Bug: T53897
Change-Id: Ic858a38f866d929d46041fb7df93102ec89eefb3
2014-11-25 17:52:57 -08:00
jenkins-bot 8e32cc332d Merge "Provide '[[' and '{{' to trigger the appropriate window open actions" 2014-11-26 01:51:58 +00:00
James D. Forrester f1fa43225a Provide '[[' and '{{' to trigger the appropriate window open actions
Bug: T52093
Change-Id: I917201ee07ee9a4269f5fe4cfa06aad9302aa69d
2014-11-25 17:50:10 -08:00
jenkins-bot c8c00b78f7 Merge "Warn users who write ';' or ':' on a new line that it won't work" 2014-11-26 01:43:31 +00:00
jenkins-bot 57c4858f33 Merge "Point wikitext markup link in warning to MW.org" 2014-11-26 01:43:19 +00:00
Roan Kattouw 35d3898543 ve.init.mw.trackSubscriber: Populate platform field with hack
Use the target used as a proxy for the platform.
Assuming all mobile target users are tablets for now.

Change-Id: I24610e6b6d472744dc1011385c8810a65e06decf
2014-11-25 17:23:50 -08:00
James D. Forrester 70c0b36ba6 Warn users who write ';' or ':' on a new line that it won't work
Bug: T71689
Change-Id: Id0ebae825ea013fe0968dcf458922802290e0b2b
2014-11-25 17:08:58 -08:00
jenkins-bot d34c275020 Merge "Work around broken BooketLayout#focus method in OOUI for now" 2014-11-25 23:57:26 +00:00
Roan Kattouw d2b8091372 Work around broken BooketLayout#focus method in OOUI for now
Change-Id: I1750951487fc7a8e1fcb5fff5dea6ee9a2547cf1
2014-11-25 15:54:03 -08:00
Alex Monk 378ab667e9 Follow normalisation response from category status query
To do things like strip off invalid invisible characters from the end of names.
(see bug)

Also rename that function because it covers more than just hidden status now

Bug: T74080
Change-Id: I8374695a991c4d3e397992ad9277b99d9288eec4
2014-11-25 23:35:43 +00:00
James D. Forrester caa47cb4d5 Point wikitext markup link in warning to MW.org
Bug: T69273
Change-Id: Ie9e7307909c18eabaa0e294ac7a1e9c3a3f3f4d1
2014-11-25 15:05:27 -08:00
Ed Sanders 9ce13e70ac Register '<p># ' sequence for creating numbered lists
Replaces wikitext warning sequence.

Change-Id: I438654212284d4a022b11bd59ea2f8bc52f0d737
2014-11-25 22:40:05 +00:00
Ed Sanders 5ce4885529 Replace hacky wikitext warning listener with sequences
Uses the generic sequence detection now available in core instead
of a custom hack that had to been manually bound and unbound to
every surface and surface widget.

As the sequence detection looks at just-typed characters the behaviour
has reverted to showing a auto-hide message. This resolves an issue
with the previous system whereby typing in the same paragraph as existing
wikitext patterns triggered the warning.

Depends on I6a4d71d in core.

Bug: T53751
Change-Id: I7d914b1b60a1cf8c79a724e5f634e1e666c9562d
2014-11-25 22:39:29 +00:00
Translation updater bot 2fdf3b5d20 Localisation updates from https://translatewiki.net.
Change-Id: I34f9ba7b451e526c44ee0fdbd52e5f737c0f54b5
2014-11-25 21:52:07 +01:00
jenkins-bot 69fe06a7ae Merge "Check wgRelevantArticleId to determine relevant page existence even on special pages" 2014-11-25 19:44:02 +00:00
jenkins-bot a7dc4af551 Merge "Catch pagedeleted errors and give the ability to re-create the page" 2014-11-25 19:42:58 +00:00
jenkins-bot 0130b6b45c Merge "Create ve.ui.MWCommandHelpDialog.css for height hack" 2014-11-25 19:42:43 +00:00
jenkins-bot 9fd9730549 Merge "Fix rounded corners issue on help button by destroying notices" 2014-11-25 19:42:39 +00:00
Ed Sanders fa34e91da8 Create ve.ui.MWCommandHelpDialog.css for height hack
Height differs to core due to extra commands.

Change-Id: I8162ff4db86ceeac0ca92d165b185a418f9e4fc7
2014-11-25 19:19:16 +00:00
Ed Sanders 0ab28904e6 Fix rounded corners issue on help button by destroying notices
Empty this.$element in notices when there are no elements to display
as just hiding with CSS makes other items in the group no the last
child and therefore breaks any CSS rounded corners rules.

As notices are only ever generated at load, destroying the tool
is not a problem.

Bug: T63575
Change-Id: I63a044ca63f61b976f57e34ce9537034e68a2614
2014-11-25 17:12:40 +00:00
jenkins-bot f3d772a709 Merge "Only try to close save dialog before destroying surface if it's currently open" 2014-11-25 03:12:03 +00:00
Ed Sanders f79aed7572 Update VE core submodule to master (8ca8c41)
Local changes:
* Rename paste rules to import rules (also used by drag and drop)

New changes:
f5d83f8 Remove data-parsoid removal hack
99f938f Create 'preserveGenerated' mode for cloneElements and use in copy
938b44d [BREAKING CHANGE] Rename paste rules to import rules
c51288c ve.ce.Surface: Move insert HTML path to DM
10ce4cf Provide a FileDropHandler for HTML files
701bb9c Provide a FileDropHandler for CSV and TSV files
ca6b444 build: Update update-oojs.sh and update-oojs-ui.sh scripts

Change-Id: I5cfa15ab3efd03e2c64c2f9f725cb3098f53b32a
2014-11-24 18:55:32 -08:00
jenkins-bot 5861db05b0 Merge "Filter out comments from external paste" 2014-11-25 02:07:24 +00:00
jenkins-bot 17fd82b99a Merge "Fix MW skin hacks" 2014-11-25 00:47:32 +00:00
jenkins-bot 330a1732cb Merge "Change command list from whitelist to blacklist" 2014-11-25 00:42:48 +00:00
jenkins-bot 35cbae3d76 Merge "Fix the "you are now logged in/out" warning" 2014-11-25 00:19:14 +00:00
Translation updater bot 7bdbd77304 Localisation updates from https://translatewiki.net.
Change-Id: Ibcd694dba6997715bdcdc4948b8a52ef9d019dee
2014-11-24 22:05:24 +01:00
Ed Sanders c56a921585 Change command list from whitelist to blacklist
Also remove toolbar definitions as they can now be derived from
command availability.

Depends on If32d514a in core.

Change-Id: I2313f3cc2531686b27f96dc1110b28bb4b295f89
2014-11-24 18:28:37 +00:00
Ed Sanders 325bd0994e Filter out comments from external paste
Bug: T71821
Change-Id: I165efd75adf3d4092860c6d2bc408469dba31388
2014-11-24 11:20:18 +00:00
Alex Monk 1c04d32d75 Only try to close save dialog before destroying surface if it's currently open
Otherwise the closure promise will be rejected as it was already closed with
different data, if you ever opened and closed the save dialog before pressing
the 'Read' button. This means the code in the $.when will never be run, and
the surface never destroyed.

Bug: T75589
Change-Id: I3ffdd1c82506bcd2accc0f3fa113c0950a31918e
2014-11-23 22:30:40 +00:00
Translation updater bot 07a265c3a1 Localisation updates from https://translatewiki.net.
Change-Id: Ib4cb30426f2e42f56da8efa725f9a81259703ea3
2014-11-23 22:43:42 +01:00
jenkins-bot 6b11f8d05e Merge "Always return boolean from an action" 2014-11-23 21:21:58 +00:00
jenkins-bot b69fef2196 Merge "Focus the bookletLayout on ready in the template dialog" 2014-11-23 17:19:11 +00:00
Ed Sanders 2ee4fc0b36 Always return boolean from an action
Command#execute expects this so it knows if the action was
successful.

Change-Id: Iaef1b7d217f0a6cd848b8df4a920c6546a79f503
2014-11-23 17:19:10 +00:00
Translation updater bot a4986e0ee2 Localisation updates from https://translatewiki.net.
Change-Id: If3ccefe94168c271b5bb812a7367e2322cf5bc96
2014-11-22 22:44:08 +01:00
Ed Sanders 2653ce3bb3 Fix MW skin hacks
* Ensure surface widget font size matches main surface,
  move vector-specific hack to vector css file and fix.
* Fix base font size in non-isolated monobook windows.
* Move monobook z-index hack to global overlay only.

Change-Id: I1607dc77f81ac9c522e09a3b502aeb38fee02178
2014-11-22 17:52:46 +00:00
jenkins-bot 268a852455 Merge "Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook" 2014-11-22 02:29:01 +00:00
Roan Kattouw 9b3316a360 Fix the "you are now logged in/out" warning
It would tell you you were logged out when you were actually
logged in, and when I looked into it, I found lots of broken
things, including lots of confusion between the current
anon-ness and username and the new anon-ness and username.

ve.init.mw.Target:
* Check the new isAnon value, not the old one
* Pass the username to the event, rather than just anon-ness

ve.init.mw.ViewPageTarget:
* Use the passed username (new username) rather than the
  username from mw.config (which is updated, but confusing)

Change-Id: Icf406d49100d81e87c677fd6b57ff93cc29f601f
2014-11-21 18:23:11 -08:00
Roan Kattouw 0bc3edfd91 Focus the bookletLayout on ready in the template dialog
Depends on I60377cb5 in oojs-ui

Change-Id: I5d8b73f878bf136efdc97493ef1f6e7bd6f56066
2014-11-21 18:13:27 -08:00
Bartosz Dziewoński e2d4f5b533 [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget
Change-Id: I70f44e71819e9147886bd70baf3460daf9ebbaf2
2014-11-22 01:56:29 +00:00
James D. Forrester a8b4fc4966 Update VE core submodule to master (c8201dd)
New changes:
ff237d4 Fix z-indexes in core
e88d43e Localisation updates from https://translatewiki.net.
cf61803 Consistently use ve.ui.WindowManager everywhere
f9dfdb8 Update OOjs UI to v0.1.0-pre (23565e7519)
f79f7e3 Update OOjs UI to v0.1.0-pre (8f8896196f)
c8201dd Update OOjs UI to v0.1.0-pre (9ed4cf2557)

Local changes for the breaking change to OptionWidget and sub-classes.

Change-Id: Ife6abd312d4dc97be67cb84eea4cb9c6a0a31b1d
2014-11-21 17:41:04 -08:00
jenkins-bot 0ed86dd9da Merge "Add instrumentation for edit schema" 2014-11-22 00:26:31 +00:00
jenkins-bot adb186e454 Merge "OO.ui.WindowManager -> ve.ui.WindowManager" 2014-11-21 22:12:59 +00:00
Roan Kattouw 4cf254a31b OO.ui.WindowManager -> ve.ui.WindowManager
In keeping with Id6660a4b54 in VE core.

Change-Id: I6fa6c0cdc3e514a66889e41c2eb4c710650a3405
2014-11-21 13:58:53 -08:00
Alex Monk 9bb766c5bb Catch pagedeleted errors and give the ability to re-create the page
Bug: 52073
Change-Id: I86a6e1510ccb5e59e94a5262dd3ccd91fdf05a70
2014-11-21 21:44:15 +00:00
James D. Forrester 6f446e0d1a Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook
In I19da270a we bumped the z-index for the overlay from 4 down to 2, to avoid
clashing with the toolbar. However, the site logo, search box and personal
tools all have a z-index of 3, so 4 is required. Instead, bump the toolbar's
z-index up by 1 to 5.

Change-Id: I7e1edcf05cde054c7bcb8c13b5633930fb5ed3b5
2014-11-21 13:29:16 -08:00
Cmcmahon 34f3572372 [BrowserTest] love for test that targets test2wiki
Change-Id: Ie37d88e891b592745e8f430da4481f2f1d2bd530
2014-11-21 21:28:25 +00:00
Cmcmahon f7a7a89d00 [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome
No combination of WebDriver for any version of Chrome on Linux
works 100% correctly.

Remove the failing tests for now.

Change-Id: I46be2c2c857e93234c839d32f1c0d4224733d0f7
2014-11-21 21:26:20 +00:00
Translation updater bot bc031a78ba Localisation updates from https://translatewiki.net.
Change-Id: I2cd1e9f2abf494d61a1a2011e7a271c0dd937f97
2014-11-21 22:12:28 +01:00
jenkins-bot 7416393354 Merge "[BrowserTest] consolidate some duplicate elements" 2014-11-21 20:30:28 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
2014-11-21 13:28:01 -07:00
Roan Kattouw 6d21d83244 Add instrumentation for edit schema
Move ve.track() subscriber to its own file, and have it
route mwtiming.* events (for TimingData) and mwedit.* events
(for Edit schema) differently. Most of the data population
lives in the subscriber, so actual ve.track() calls are
pretty lightweight.

Existing ve.track() calls with timing data were kept with
their names intact for backwards compatibility, but
we may eventually want to throw them out and start from scratch.

ve.init.mw.ViewPageTarget.init.js:
* Remove old track subscriber
* Track init and ready events
* Remove old ve.track( 'Edit', ... ) crap that didn't work

ve.init.mw.ViewPageTarget.js:
* Fire the saveWorkflowBegin event before the save dialog
  loads rather than after
* Remove unnecessary this.events.trackSaveError() calls:
  TargetEvents already listens to these events itself
* Remove badtoken handler because all it was was an
  unnecessary trackSaveError() call
* Add abort tracking
** Pass trackMechanism through deactivate() and cancel()

ve.init.mw.Target.js:
* Add static.integrationType to populate the 'integration'
  field in the schema

ve.init.mw.TargetEvents.js:
* Simplify onSaveError* methods away into connect bindings
* Map track topics to mwtiming.* so they can be routed separately
* Track save-related mwedit.* events

Depends on I978eda96c in WikimediaEvents

Change-Id: Iae677d9b15c71d2b18e795bd5179d11876c06abd
2014-11-21 11:59:15 -08:00
jenkins-bot 1b3fe26a3a Merge "Move tearDownBeforeUnloadHandler() to cancel()" 2014-11-21 19:42:59 +00:00
jenkins-bot ad908a666d Merge "Prevent JS errors when surfaceReady fires after deactivation" 2014-11-21 19:41:00 +00:00
James D. Forrester a1d75042c0 Update VE core submodule to master (fb57e24)
New changes:
7d8ed7f Copy in some IE CSS hacks from ve-mw
a2e962e Update OOjs UI to v0.1.0-pre (20c61ec865)
d99c62f Update OOjs UI to v0.1.0-pre (d4cfcce969)
7fe02b3 Fix lots of spelling mistakes and typos

Local changes:
Remove redundant IE CSS rules since core's I013688c5

Bug: 73565
Change-Id: Ic60cd5290932ec38fab26492fffa17c3a8e91398
2014-11-21 10:28:34 -08:00
jenkins-bot d8b82d2de7 Merge "Fix lots of spelling mistakes and typos" 2014-11-21 17:54:05 +00:00
Cmcmahon f6526cb0a9 [BrowserTest] comments for classes
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
2014-11-21 09:49:50 -07:00
Cmcmahon 473877202b [BrowserTest] rubocop change to an if()
Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc
2014-11-21 09:40:40 -07:00
Cmcmahon 95a798867c [BrowserTest] rubocop proper format for comments
Change-Id: I2fe136f29e0bc430420a0931092695d3f4147112
2014-11-21 09:21:53 -07:00
Cmcmahon 1b69fc97c7 [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense
Change-Id: Ia11c32c74acf4c2226f84ea566f4074b193f4e20
2014-11-21 16:15:58 +00:00
Cmcmahon ede14c75fb [BrowserTest] rubocop updates to replace double quotes with single
Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
2014-11-21 09:06:09 -07:00
Ed Sanders 2997cee444 Fix lots of spelling mistakes and typos
Change-Id: Icf78d3d599326d3f12d09edcd2b8491ed35ade04
2014-11-21 13:00:50 +00:00
jenkins-bot c8028dfe06 Merge "Fix ridiculously small font size in overlays under MonoBook" 2014-11-20 20:01:22 +00:00
Roan Kattouw 9ed9c6cfe0 Move tearDownBeforeUnloadHandler() to cancel()
Make sure it always gets torn down on deactivate, not
just on save. Otherwise we end up with multiple copies of it.

Change-Id: I7b95c316641fc48ce7087a0042ec6174fe03180b
2014-11-20 19:23:17 +00:00
Roan Kattouw 5317ce8082 Prevent JS errors when surfaceReady fires after deactivation
If you clicked "Read" while the editor was loading
(but only while the "Edit" tab was already active, not before)
then you could get in a situation where surfaceReady fired
on an already-aborted target, which caused JS errors.

It seems like we should clean more things up in this
case, but I don't know what they are. In any case,
we should not try to set things up on a non-activating
target when surfaceReady fires.

Change-Id: Id57bd63ff288156725e472e7d89009022090253a
2014-11-20 19:22:49 +00:00
jenkins-bot dc6eec0bb7 Merge "[BrowserTest] more rubocop style fixes" 2014-11-20 19:13:30 +00:00
jenkins-bot d8808da403 Merge "Insert last modified text as HTML" 2014-11-20 19:12:07 +00:00
Cmcmahon 2f05d1b10a [BrowserTest] more rubocop style fixes
Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1
2014-11-20 12:07:45 -07:00
jenkins-bot 0394e23516 Merge "[BrowserTest] Rubocop style fixes" 2014-11-20 19:00:03 +00:00
Cmcmahon 65e4d91cf0 [BrowserTest] Rubocop style fixes
Change-Id: Ieb1ba49f2a987b41f82a3b66c542fba48313eb1f
2014-11-20 11:55:40 -07:00
jenkins-bot 921f606209 Merge "Remove unused CSS: toolbar contains no PopupButtonWidgets" 2014-11-20 18:27:55 +00:00
jenkins-bot 3bad2c8ffb Merge "Use super to call parent constructors" 2014-11-20 18:27:51 +00:00
Alex Monk 8a1adef97c Fix ridiculously small font size in overlays under MonoBook
Copy in the font-size:127%; rule from MonoBook's main.css which is applied to
div#globalWrapper

Caused by Id425c56d

Bug: 73660
Change-Id: I05502295b81c62fd1180dff860dea68d76c2dfa9
2014-11-20 17:56:38 +00:00
Cmcmahon 513031c4bf [BrowserTest] locator changed
Change-Id: I3aeb1f60cf512c55f497f4ef6743b149bc0add43
2014-11-20 10:02:20 -07:00
Ed Sanders 7abbea1c19 Use super to call parent constructors
Change-Id: I5f911fc35c420cd7980bc1fbaecf3b685596c7a8
2014-11-20 13:58:27 +00:00
Ed Sanders 6ffbc72f82 Remove unused CSS: toolbar contains no PopupButtonWidgets
Change-Id: I719a4dec30d5ca52337bd3a7d2506065562d831d
2014-11-20 13:56:48 +00:00
Amir E. Aharoni a513ba9583 [BrowserTest] Fix the index of the insert menu
Change-Id: Id0e821d3cf01efff74fdb189cf09d24d9eb753e2
2014-11-20 10:52:47 +00:00
James D. Forrester 7317114187 Update VE core submodule to master (029fc7e)
New changes:
029fc7e Update OOjs UI to v0.1.0-pre (1fa4eb7a73)

Update changes:
Changes were generated by running this script:
https://gist.github.com/trevorparscal/265f1b8c854190637a1e

File changes:

Scripts (modules/ve-mw/ui/widgets)
- ve.ui.MWInternalLinkMenuItemWidget.js → ve.ui.MWInternalLinkMenuOptionWidget.js
- ve.ui.MWLinkMenuItemWidget.js → ve.ui.MWLinkMenuOptionWidget.js

File content changes:

Scripts (*.js)
- MWInternalLinkMenuItemWidget → MWInternalLinkMenuOptionWidget
- MWLinkMenuItemWidget → MWLinkMenuOptionWidget
- ContextMenuWidget → ContextSelectWidget
- ContextItemWidget → ContextOptionWidget
- TextInputMenuWidget → TextInputMenuSelectWidget
- MenuWidget → MenuSelectWidget
- MenuItemWidget → MenuOptionWidget
- MenuSectionItemWidget → MenuSectionOptionWidget
- OutlineWidget → OutlineSelectWidget
- OutlineItemWidget → OutlineOptionWidget

Styles (*.less)
- contextMenuWidget → contextSelectWidget
- contextItemWidget → contextOptionWidget
- textInputMenuWidget → textInputMenuSelectWidget
- menuWidget → menuSelectWidget
- menuItemWidget → menuOptionWidget
- menuSectionItemWidget → menuSectionOptionWidget
- outlineWidget → outlineSelectWidget
- outlineItemWidget → outlineOptionWidget

Change-Id: Ifded7f9e17923dbb56a722b7424ccd2854194c21
2014-11-19 17:04:26 -08:00
ryasmeen@wikimedia.org 6cce39ee10 [BrowserTest] Extend options test
Adding cases to test categories in options.feature

Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
2014-11-19 16:26:07 -07:00
Alex Monk b50ad63fb5 Check wgRelevantArticleId to determine relevant page existence even on special pages
Added to core in I06cd0378

Bug: 66885
Change-Id: I9ce889be0ae1cbaab13a9f408d07b168da8affdd
2014-11-19 22:45:23 +00:00
Cmcmahon c49b2a77f2 [BrowserTest] once more
Change-Id: I34b4be6aadf991cf9d12c76fd8c8410697b2b500
2014-11-19 14:53:08 -07:00
Translation updater bot d043be3315 Localisation updates from https://translatewiki.net.
Change-Id: Iea9ba638731f58e49ac2a2c1219180cf2d465ecc
2014-11-19 22:41:42 +01:00
lokal-profil 591f3fcedb API i18n: Fix consistency in messages
Fixed consistency in two messages and added article to a third.
Affected messages:
* apihelp-visualeditor-description
* apihelp-visualeditor-param-oldid
* apihelp-visualeditoredit-param-oldid

Reported at:
https://translatewiki.net/wiki/MediaWiki:Apihelp-visualeditor-param-oldid/sv
https://translatewiki.net/wiki/MediaWiki:Apihelp-visualeditoredit-param-oldid/sv

Change-Id: I054cf021482276c3676e91d9cf9f6fcdfc12d583
2014-11-19 15:46:22 +00:00
James D. Forrester cfb20ef8a1 ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with <comma-seperator>
Bug: 66894
Change-Id: Idd6d02e35b9aa0db5f71c75adb0a0400cc31c83a
2014-11-19 11:19:50 +00:00
jenkins-bot 30d8bf60f1 Merge "ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists" 2014-11-19 11:06:01 +00:00
Timo Tijhof 420b336d31 mw.ViewPageTarget.init: Simplify hideLoading and pushState
Follows-up Ica33de675, If505a46f54.

* The setting of 'uri' looked like a redundant local alias before
  passing on to pushState, but is actually important on itself.

* Remove binding for hideLoading. It's a detachable method on
  a singleton, not an instance method.

Change-Id: Ic3536caf3f42ee893124312fd5981b67336bd480
2014-11-19 02:58:17 +00:00
Roan Kattouw bb6e01c488 Fix back button not exiting VE
When you clicked the Back button in the browser, the URL
in the address bar would change (removing veaction=edit),
but we would not go back to read mode. This was broken
by 5c0c11753 almost a month ago but apparently no one noticed.

This is because 5c0c11753 moved the pushState() calls to
be earlier (in init init), making the replaceState() call
in the ViewPageTarget constructor (which is there
specifically for this bug) run too late in those cases.

The simplest way to fix this is to duplicate these replaceState()
calls before the pushState() calls in init init.
I feel a bit bad about copying code, but not very bad
because the code I'm copying already has a FIXME comment
about how there should be a better way :P

Change-Id: I6627a5d1d9377ae815bc58bceeb059ce9f4f19ab
2014-11-19 02:07:41 +00:00
jenkins-bot aa44c8916b Merge "Consistently use location as global, and location.href for full url" 2014-11-19 02:00:35 +00:00
jenkins-bot c8152914eb Merge "Use history as global instead of via window" 2014-11-19 01:59:26 +00:00
Timo Tijhof dc648e6b06 test: Omit 'window' in mw-preload.js
Follows-up 92c38ea.

Change-Id: Ib8a37036a1a9dac980527bfccd506fff5ea8dce1
2014-11-19 01:46:38 +00:00
Timo Tijhof c0692af5f7 Use history as global instead of via window
Just like DOM interfaces such as document and location. And JS
constructors like Object.prototype, and libs like jQuery.
No need for the window host object.

Change-Id: Ie39aaea2ca17bdec5fb3afe32a4e6c9f751bd0c6
2014-11-19 01:12:11 +00:00
Timo Tijhof 82657727f9 Consistently use location as global, and location.href for full url
The location object is a global, just like document.

Using it via 'window' needlessly adds complexity and, for example,
makes it harder to catch typos in static analysis.

Standardise on location.href in place of the many different
variants for accessing and assinging the full url:

 location =
 location.href =
 location.assign() =

And each with 'window', 'document' and without host object.

Change-Id: If88515bd88fc5b93ebacd4ec41fce02fec540f18
2014-11-19 00:20:08 +00:00
Alex Monk 94fadaec4a Insert last modified text as HTML
mw.msg can return things with <br />, which we want to be interpreted as HTML
rather than just escaped as text.

Bug: 73571
Change-Id: I7861432d9361e01f9def0578c342e60715c3d764
2014-11-18 23:42:18 +00:00
James D. Forrester 6b61addd06 ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists
Change-Id: I1289c43ea4be1cd9dc1addb7c765d7050b311d8d
2014-11-18 14:22:30 -08:00
Translation updater bot 384232ee64 Localisation updates from https://translatewiki.net.
Change-Id: I7e799602cb9d11c2e77be38b3707ebd0b82c7d9d
2014-11-18 21:35:49 +01:00
Cmcmahon 210169c55b [BrowserTest] forgot a bit of dead code
Change-Id: I249e229d449eb74ff341f511e84290a4ca731f92
2014-11-18 13:09:17 -07:00
Cmcmahon 6489767bc7 [BrowserTest] remove sleeps from shared tests
* remove dead code

Change-Id: Id95ff81746eb440124958bcc6dd9334b7ed299a4
2014-11-18 12:59:34 -07:00
jenkins-bot 4807d4c847 Merge "Replaces spaces with tabs in en.json" 2014-11-17 23:47:39 +00:00
Cmcmahon 06aa53747c [BrowserTest] interim step, no functional change
Change-Id: I3a7787c4ab9206c70f0f64b6c0986ae93ddb3d84
2014-11-17 15:14:32 -07:00
Cmcmahon 94bab8f918 [BrowserTest] update transclusion test for Page Object vio and RS
Change-Id: Ie80dce2d117d4d2dc836681dcd9362ae565f2aa8
2014-11-17 14:59:14 -07:00
Cmcmahon 743d035fa1 [BrowserTest] update switch-edit-mode test for RSpec3
Change-Id: Ia040f8b6e76a42c2c80bda382bf6ad6f30988ba1
2014-11-17 14:42:59 -07:00
Timo Tijhof 173181f857 Replaces spaces with tabs in en.json
Bug: 72132
Change-Id: I1cc0379a824caec957c4e63963634e67973f1cf2
2014-11-17 22:37:43 +01:00
Translation updater bot 3386871003 Merge "Localisation updates from https://translatewiki.net." 2014-11-17 21:29:42 +00:00
Translation updater bot f8d851c50a Localisation updates from https://translatewiki.net.
Change-Id: Iee3bdfaa9ef9b032cba0a958eb06ebbbb2e505a5
2014-11-17 22:29:16 +01:00
Cmcmahon fa02c60586 [BrowserTest] fix minor Page Object design violation
Change-Id: I75d282a7e176347b0995f2c2ccda8ab051aca270
2014-11-17 14:18:13 -07:00
Cmcmahon 4383dedcfc [BrowserTest] minor violation of Page Object design pattern
and RSPec syntax also fixed

Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
2014-11-17 14:07:16 -07:00
jenkins-bot 83797c4925 Merge "[BrowserTest] more update to Cite test for RSpec3" 2014-11-17 20:59:12 +00:00
jenkins-bot c5ec9cb8d5 Merge "Methods for new "maps" property in TD Root" 2014-11-17 20:56:49 +00:00
Cmcmahon 3c5e695c5d [BrowserTest] more update to Cite test for RSpec3
Change-Id: Ia2fa25bffe9bbdffb0eafc19396c06be253216c3
2014-11-17 13:56:08 -07:00
Cmcmahon 94c30f01da [BrowserTest] update Cite test for RSpec3
Change-Id: I589a65e0fe1b21ca6476a5c31b97d7632da39b13
2014-11-17 13:31:30 -07:00
Cmcmahon 87ad037442 [BrowserTest] remove sleep() from template test
Change-Id: Ia564232e02db2e6be3070d98691097350e920a3b
2014-11-17 13:13:25 -07:00
jenkins-bot 51976d6237 Merge "[BrowserTest] interim step to sort G/W/T statements properly" 2014-11-17 19:29:12 +00:00
Cmcmahon ea0fac5e4f [BrowserTest] interim step to sort G/W/T statements properly
no change to function

Change-Id: I2c2e9ccb6535c875d37ef59ab873a2f3280cca60
2014-11-17 12:27:06 -07:00
jenkins-bot 7efa601837 Merge "On save, if there was no 'last modified' text at the bottom of the page, add it" 2014-11-17 17:48:50 +00:00
jenkins-bot e85550c350 Merge "Don't try to get newtimestamp from edit if no change was made" 2014-11-17 17:48:44 +00:00
Cmcmahon 9a4d2eeef9 [BrowserTest] interim step to alphabetize
no change to function

Change-Id: Id655a9777e3b8bd3e3fbb974c73912f9f975bf7c
2014-11-17 09:09:06 -07:00
Alex Monk ac6f6caeac On save, if there was no 'last modified' text at the bottom of the page, add it
Just hope that wgMaxCredits is 0.

Change-Id: Idf4a7cceb0650eaec4442244066d875a3ff38e06
2014-11-17 01:18:46 +00:00
Alex Monk ff3d76f488 Don't try to get newtimestamp from edit if no change was made
ApiEditPage can give us 'nochange' instead of the
'oldrevid'/'newrevid'/'newtimestamp' keys if we gave it a null edit.

Bug: 73463
Change-Id: Ic22597dfed11de3823471673404090a9bce12928
2014-11-17 01:03:00 +00:00
Translation updater bot fce0ed5d6c Localisation updates from https://translatewiki.net.
Change-Id: I0a857cef14050c92c1236612006ad34b34bf49bc
2014-11-16 22:53:55 +01:00
Translation updater bot 9b3b81c234 Localisation updates from https://translatewiki.net.
Change-Id: I3e9b5d8b65d6b1a1b57762ae904554a7b4d47c73
2014-11-15 23:18:28 +01:00
Cmcmahon 17f6badf0a [BrowserTest] update references test for modern RSpec syntax
simple update to a nice test

Change-Id: Iad00e779295ccc610d20241693a87b76b817fbd6
2014-11-14 15:52:51 -07:00
jenkins-bot 02407138ad Merge "[BrowserTest] remove sleep from multiedit test" 2014-11-14 22:35:31 +00:00
Cmcmahon 6d22cebb62 [BrowserTest] remove sleep from multiedit test
* put the shared step in shared_steps.rb
* replace "onfocus" with simple "click"
* update RSpec while we're at it

Change-Id: I77754abdbeba1314758f5fe10601f6601e8783bd
2014-11-14 15:30:10 -07:00
Translation updater bot e670131ea5 Localisation updates from https://translatewiki.net.
Change-Id: I934ae1c25cf6d1396dc4517d438a76556d4c209d
2014-11-14 22:27:52 +01:00
Cmcmahon 36e07b247e [BrowserTest] simple upate to a nice test
Change-Id: Ib52582a677d8dc2f22552bf7c60f48de8f20d3c7
2014-11-14 13:43:31 -07:00
Cmcmahon ea9df60aa3 [BrowserTest] RSpec update
Change-Id: I03f89eda4292482dedaa335e3546af724ee55024
2014-11-14 13:32:59 -07:00
Cmcmahon 1aa5d8905b [BrowserTest] remove sleeps from links test
Change-Id: Ib0e09735331dadd5bb494fe87683f6f08b6aee31
2014-11-14 12:30:13 -07:00
Cmcmahon da42fe407c [BrowserTest] hygiene changes
* alphabetize headings steps
* move diff view check to shared_steps.rb

Change-Id: I68ac8de2f67a61bdd50f4892f58368e1bbd71271
2014-11-14 16:05:14 +00:00
Translation updater bot 4387c52f93 Localisation updates from https://translatewiki.net.
Change-Id: I92a1563c843ad912a71f642caa9d7af2300f0f6c
2014-11-13 23:12:26 +01:00
jenkins-bot ed7cfa1207 Merge "When saving, return the full contentSub to the client" 2014-11-13 20:45:09 +00:00
Cmcmahon e4eeb40c17 [BrowserTest] interim alphabetization only
Change-Id: I3a724d2cadbc40c63978058e4b2684ef86ceec03
2014-11-13 10:04:19 -07:00
Cmcmahon 3ed807277e [BrowserTest] minor updates for hygiene, no functional changes
Change-Id: I3d8ca33bd850caeb44b8e8e8017f2fa302676b1a
2014-11-13 09:08:15 -07:00
jenkins-bot 12bff6a622 Merge "[BrowserTest] make bullets test modern" 2014-11-13 15:33:47 +00:00
jenkins-bot 6c377214b1 Merge "Move addClass calls to setup in GeneratedContentNodes" 2014-11-12 23:43:17 +00:00
Ed Sanders ef38ce8c8c Move addClass calls to setup in GeneratedContentNodes
Ensures classes persist on content update.

Change-Id: I4828ad3208351e4b00e0be1f905b7eafd5e5e93b
2014-11-12 22:52:59 +00:00
Translation updater bot 07c104b807 Merge "Localisation updates from https://translatewiki.net." 2014-11-12 21:25:27 +00:00
Translation updater bot e70164725a Localisation updates from https://translatewiki.net.
Change-Id: I9a171c6b8c17a0a98f4a87619f28d3196c588b90
2014-11-12 21:55:17 +01:00
jenkins-bot bec4ecfb37 Merge "Rename input variables in media dialog" 2014-11-12 20:48:24 +00:00
Ed Sanders 320206fe42 Rename input variables in media dialog
Change-Id: I9b8edfaccb163aff313e267bb1a0f74455502242
2014-11-12 19:51:48 +00:00
Ed Sanders 06bccbe986 MWLiveExtensionInspector: Move event unbinding to teardown process
Change-Id: I6fae2ca3e1bc02b8edb707b4248b884a9f022c3f
2014-11-12 19:33:24 +00:00
jenkins-bot 287b2e8296 Merge "Follow redirects in the category input widget" 2014-11-12 18:59:28 +00:00
jenkins-bot 8a2b73f78f Merge "Restore selection after closing save dialog" 2014-11-12 18:29:44 +00:00
Cmcmahon 41aaaf4886 [BrowserTest] make bullets test modern
* remove unnecessary wait times
* remove unnecessary sleep() statements
* remove unused steps
* update for RSpec3.0 syntax

Change-Id: Ie76135154042834e2eb8b008872aced5ac210ee5
2014-11-12 10:55:37 -07:00
Alex Monk 581d1350e6 When saving, return the full contentSub to the client
And introduce code to make FlaggedRevs add its notices to contentSub.

Bug: 60718
Change-Id: Ibb91dc563ccf73d3b4bd1994134ccf02634fccb5
2014-11-12 17:36:59 +00:00
Cmcmahon 87bd220eed [BrowserTest] refactor for alphabetization and space only
preliminary to updating Then statements to RSpec3.0 syntax

zero change to function or syntax, just arranging things so
we can review them later.

Change-Id: Id0f006d0fcf74010c06cb7ae6386ea6bcaff0e55
2014-11-12 09:22:30 -07:00
Alex Monk ba81c45da9 Restore selection after closing save dialog
Also simplify some weird focus code in MWSaveDialog

Bug: 72911
Change-Id: Ifb8fd9be96a199f86412247211e3920a35dd22bf
2014-11-11 23:55:39 +00:00
Translation updater bot 07ea50fa7b Localisation updates from https://translatewiki.net.
Change-Id: I99f48e646c7cfefd70c15461259c68617fda001a
2014-11-11 22:15:26 +01:00
James D. Forrester 385f895980 Update VE core submodule to master (f5083c6)
New changes:
6ec286e Support for generic file drop handlers
4f2ab66 Generic progress dialog for drag and drop uploads
742e0fe Fix pasteSpecial command
87ea9e9 Fix up/down arrowing off a focusable node
643ea34 spinner.gif: Update with new version from Trevor
ffd8b1e Position the table context relative to the first section node
393776a Fix logic for ignoring (col|row)span=1
f94b10e Don't unmerge spanned cells when spanned cell is removed
3416764 TableContext: Simplify row/column overlays styles
e6c0038 Localisation updates from https://translatewiki.net.
fb1a922 Register select all as a command and perform programmatically
3c1ce93 Make caption tool available when caption selected
dd0ac7d Move disabling logic from tools to commands
8bf33a5 Bold & italic icons for Armenian
058b32c Update OOjs UI to v0.1.0-pre (05f0fefc3f)
c01d115 Create filedrophandlers folder for implementations

Local changes:
* Register new files
* Move disabling logic from tools to commands
  onUpdateState should only ever call setActive. setDisabled should
  already be determined by the command so that it can prevent itself
  being called by triggers.

Change-Id: Icdeaa4c152a0dcd839c8e7cc4e64b2215eb2de1e
2014-11-11 16:51:24 +00:00
Alex Monk 5462b5b219 Follow redirects in the category input widget
Change-Id: Ie33dc3779cb7f602949d2d1f25ebd7b60e894c97
2014-11-11 00:30:08 +00:00
Roan Kattouw 0c92ef904c Followup 5c0c117: make the edit tab work with oldid= again
After 5c0c117, clicking the VE edit tab on /wiki/Foo?oldid=123
sent you to /wiki/Foo?veaction=edit , dropping the oldid parameter
and editing the current version rather than the old version.

Fix this by only recomputing veEditUri from scratch when necessary,
and reusing the current URI when possible.

Change-Id: Iee9a745990f1a2bad40f46b8cdaaa727bb7fead8
2014-11-10 18:24:45 -05:00
Translation updater bot 0e87a70e8f Localisation updates from https://translatewiki.net.
Change-Id: I0ca8ed6ded5e577a71cb140609115fa6b8229ed7
2014-11-10 22:12:43 +01:00
jenkins-bot a8f4a5f98f Merge "Remove last usage of ve.bind() in VE-MW" 2014-11-10 20:55:02 +00:00
Roan Kattouw 9533c378ea Remove last usage of ve.bind() in VE-MW
Change-Id: Ia645e3d599da9b65b71dbe67f82b7c0fa3be1683
2014-11-10 15:45:09 -05:00
jenkins-bot ad92b977d5 Merge "Followup a054a75: don't reintroduce removed template parameters" 2014-11-10 20:44:28 +00:00
jenkins-bot c888e2b0d3 Merge "Followup c232083: use getRelativeTitle for template titles" 2014-11-10 20:34:56 +00:00
Roan Kattouw aa84df021a Followup a86d824: fix reference to this in foreach callback
Bug: 73235
Change-Id: Ib8f877f747df6c8047c7e3d2c152e0e7a9f60b8a
2014-11-10 15:22:19 -05:00
Roan Kattouw 5f1e7a651c Followup a054a75: don't reintroduce removed template parameters
Deep-extending originalData is asking for trouble, because there's
no way to delete anything that way.

Bug: 73134
Change-Id: I44d3e582e04942efceae3e0bdbbaa147095b5146
2014-11-10 15:04:42 -05:00
Roan Kattouw 2ba844a372 Followup c232083: use getRelativeTitle for template titles
Otherwise we output stuff like {{Template:Echo|hello}}

Change-Id: Ib6c3996ab40e01a5ddce84b7daffa27a74020ee5
2014-11-10 15:03:10 -05:00
Vikas S Yaligar 901b0deeed [BrowserTest] Fixed failing language screenshot browser tests
Bug: 73033
Change-Id: Iea3a03b1ec628bfe03f10b4cb2a4795d4fabb8bc
2014-11-10 11:07:49 +00:00
Translation updater bot 2addf93fa0 Localisation updates from https://translatewiki.net.
Change-Id: I1aac2fe3ad1eec132d45a7315e5e098ace57c546
2014-11-09 21:55:01 +01:00
jenkins-bot 1f4335a1e2 Merge "Show category items as red if they don't have description pages" 2014-11-09 14:10:32 +00:00
Translation updater bot aa0eab73b6 Localisation updates from https://translatewiki.net.
Change-Id: Ieb369522a74d50eef8cdea0a409abdf29d65b140
2014-11-08 22:20:26 +01:00
Alex Monk de73246ee1 Show category items as red if they don't have description pages
Also fix some lies I wrote in related code/docs

Bug: 65517
Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
2014-11-08 14:27:27 +00:00
jenkins-bot 3ebbfe6953 Merge "Fix craziness in template dialog focusing" 2014-11-08 00:54:56 +00:00
Roan Kattouw a86d824c56 Fix craziness in template dialog focusing
setMode() is called multiple times, but it didn't
check whether the mode being set was already set.
Because it's a setter, make it idempotent.

This fixes the problem where the first input will
be focused first, then blurred later, but it
introduces a new problem because the label for
the 'mode' ActionWidget is set from setMode().
To solve that, factor the setting of this label
out into its own function and call it on setup.

Bug: 73138
Change-Id: I9bb127f22f6c0b745b393c523ec42f320fc85cf3
2014-11-07 16:41:03 -08:00
Translation updater bot 6fea75bf7b Localisation updates from https://translatewiki.net.
Change-Id: I76eb90ec1ad222f5887a01a1a4abb38337b8a9ce
2014-11-07 22:15:17 +01:00
Ed Sanders 5238d06dc7 Support pre's in tables
Bug: 73100
Change-Id: I971420047026c91ed92a19a52d2fd3b6fbeac24a
2014-11-07 15:44:13 +00:00
jenkins-bot 27e70a6a21 Merge "Matching pages from suggestions in link dialog now actually work as links" 2014-11-06 21:49:07 +00:00
suchetag cb704dee84 Matching pages from suggestions in link dialog now actually work as links
* A subclass of MenuItemWidget from OOUI, MWLinkMenuItemWidget, is introduced that, when used in MWLinkTargetInputWidget for both
external and internal links, returns actual page links.

* MWInternalLinkMenuItemWidget is extended from MWLinkMenuItemWidget to support the internal links.

* LinkCache is being used in MWInternalLinkMenuItemWidet to stylize the links. Thus, getting rid of some old css classes.

Bug: 51205
Change-Id: I3ac18dabd514ca539fff1db3c67ae97931c3d4fc
2014-11-06 13:46:09 -08:00
Translation updater bot 47295b4441 Localisation updates from https://translatewiki.net.
Change-Id: I0d8f1d19fdae87a23f088dbad5e2dac413b5825a
2014-11-06 21:56:21 +01:00
jenkins-bot 613e69b2c8 Merge "Refactor out show/hide loading spinner" 2014-11-06 18:39:06 +00:00
Ed Sanders 841dfda98d Refactor out show/hide loading spinner
Change-Id: If505a46f54921ce4742ecfed598eb07a9ba5e3eb
2014-11-06 16:41:05 +00:00
jenkins-bot 1a6c46f7ee Merge "Use hasOwnProperty instead of 'key in obj'" 2014-11-06 12:37:04 +00:00
jenkins-bot 81d153b430 Merge "Disable review button while save dialog is pending" 2014-11-06 00:35:17 +00:00
jenkins-bot 209dbe2449 Merge "Allow headings in table cells" 2014-11-05 23:52:23 +00:00
Alex Monk 3628fc0ffc Disable review button while save dialog is pending
Bug: 65310
Change-Id: I7cfb5d84b91b4a20282e126b8c863c15519b5a9d
2014-11-05 23:36:33 +00:00
jenkins-bot cfed84e063 Merge "QA: sort remaining page elements that belong in the iframe" 2014-11-05 22:43:36 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
2014-11-05 15:39:10 -07:00
Ed Sanders 26f567d84f Allow headings in table cells
We possibly want to discourage this somehow but our current
functionality achieves this by doing an isolateAndUnwrap
which for a table is catastrophic.

Bug: 72990
Change-Id: I79f1348da20385dfec014afcac0fb5464580cf2f
2014-11-05 22:34:13 +00:00
Roan Kattouw e144e55972 Followup 31bafa1: forgot to rename 'data' to 'args' for citation commands
Bug: 73001
Change-Id: I8cc436cbe16955130d25b2385e3f561fd2ffb4d5
2014-11-05 13:46:54 -08:00
jenkins-bot ca7ef3be1f Merge "Remove the loading spinner at the end, not halfway through loading" 2014-11-05 21:00:53 +00:00
Ed Sanders 0efbfa7e21 Use hasOwnProperty instead of 'key in obj'
Change-Id: I48f044c547b48a97cdfb31f7b887dca0ed7e341b
2014-11-05 20:54:50 +00:00
Roan Kattouw ccd9142262 Remove the loading spinner at the end, not halfway through loading
We were attaching its removal to the wrong promise in 2 of the 3
places where it was being called.

Also this file is horrible and should be refactored. A lot.

Change-Id: If74b1629266f22e2d110305b139bef4a8e69b13b
2014-11-05 12:50:40 -08:00
Translation updater bot 58ba085453 Localisation updates from https://translatewiki.net.
Change-Id: Icaf0b9a1ce7848d97c1466cdbc1cff4d4335e54a
2014-11-05 21:50:17 +01:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
2014-11-05 10:01:55 -07:00
jenkins-bot 06387f7f54 Merge "Revert "Clear selection after tearing down surface to work around Firefox bug"" 2014-11-05 01:39:16 +00:00
Catrope c8396eb65f Revert "Clear selection after tearing down surface to work around Firefox bug"
Superseded by I051ef92eeea9 in VE core.

This reverts commit d68eae6c8d.

Change-Id: Ie5e0a6169cfe3634e20a3b88e8aeb980b4094e10
2014-11-04 17:20:30 -08:00
jenkins-bot d6c3a4aa92 Merge "Kill MWCategoryWidget#onLookupEnter" 2014-11-05 01:18:15 +00:00
Roan Kattouw a5e9e1f456 Fix indicator alignment in MWCategoryItemWidget
We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.

Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.

Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.

Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
2014-11-04 16:53:11 -08:00
jenkins-bot 309305b03e Merge "[BrowserTest] WIP adding cases to test other options under Page Settings to options.feature" 2014-11-04 23:04:40 +00:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
2014-11-04 15:01:45 -08:00
Translation updater bot f9517993de Localisation updates from https://translatewiki.net.
Change-Id: If507707479641bfd07e950f03136b46e53f3c62f
2014-11-04 23:33:19 +01:00
James D. Forrester 31bafa183d Update VE core submodule to master (a942301)
New changes:
2cc219a Update OOjs UI to v0.1.0-pre (571f26d0ab)
3543cb7 Protect against offset=-1 in insertContent()
7a3d456 [BREAKING CHANGE] Move selection restrictions from tools to commands
3d847bb Disable desktop context on table selections
41282dd Missed function rename from RangeFix change
dd6c8b8 Support toDomElements returning an empty array
9be6464 Placholder -> placeholder
9bdd0a8 Restore basic styling to toolbar in core target (only)

Local changes:
Move selection restrictions from tools to commands

Change-Id: I88f3d04946bd1d03ed001d747475a8b495a0f64c
2014-11-04 14:11:04 -08:00
Alex Monk b1e47365d0 Kill MWCategoryWidget#onLookupEnter
This code was somehow broken by Ia47bc897 (wtf, how?)
Actually removing it seems to do no harm (wtf?), as far as I've been able to tell...

Bug: 72906
Change-Id: If7eb34a20cc8060b594a567278241b02a8ee327a
2014-11-04 20:35:55 +00:00
Roan Kattouw c23208371a Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel
0165a53 overlooked the fact that 'name' is also passed to
the MWTemplateModel constructor, and there it really does
always need to be a string, not magically either a string
or an mw.Title object. Oops :(

Bug: 72961
Change-Id: I0b20f0768aae4d9cc9f7af268abd0a704b6adc3a
2014-11-04 10:58:53 -08:00
Roan Kattouw 362d0ebcdf Followup 0165a53: fix typo causing undefined to be passed to mw.Title
Bug: 72948
Change-Id: I1942f153f18c5a182de38a0e067ec5a92abeefd3
2014-11-04 10:53:58 -08:00
Cmcmahon 3b53b23fb1 [BrowserTest] no iframes for switch mode test
Change-Id: I99e4686144ded173f8d91be87f02a4c144284237
2014-11-04 08:06:33 -07:00
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
2014-11-04 07:46:24 -07:00
jenkins-bot bb96a9083f Merge "Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()" 2014-11-04 01:18:38 +00:00
suchetag 0165a53044 Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()
Now that we have .getTitle() as a method in MWTitleInputWidget, replacing the callers
of MWTitleInputWidget.getValue() with .getTitle(). This fixes a bug in the .getTitle()
method in MWTitleInputWidget which was not taking the namespaces into account before.

Also fixes: the error when entering "Talk:" as a template title. The button to add template
remains disabled when "Talk:" is given as an input to the title here.

Bug: 71998
Change-Id: I1e629a61ec8b035d93a4b7acfecab81934019166
2014-11-03 17:05:51 -08:00
Cmcmahon 666001ba1c [BrowserTest] no more iframes for transclusion
Change-Id: Ifc50a50e98de18612e6ab4b548b1cf6ec05bc825
2014-11-03 16:27:17 -07:00
Cmcmahon aab1680244 [BrowserTest] no more iframes for switch modes test
Change-Id: Ifebc458f9ff9583954226d86759753b0314db649
2014-11-03 15:51:55 -07:00
Cmcmahon 396d74053b [BrowserTest] no more iframes for References
Change-Id: I7f5cf7b991cfcfd3ebebe0f17bb594802fe7dea0
2014-11-03 15:41:38 -07:00
jenkins-bot b70f2176fa Merge "[BrowserTest] no more iframes for options" 2014-11-03 22:20:55 +00:00
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
2014-11-03 15:18:44 -07:00
jenkins-bot aab271f6e7 Merge "MWReferenceGroupInputWidget: Remove dummy call to onInputChange()" 2014-11-03 22:09:44 +00:00
Cmcmahon 6907583418 [BrowserTest] no more iframes
Change-Id: I8090f95ccd1cf2744649084c863e6034db062d87
2014-11-03 14:45:52 -07:00
Cmcmahon fcfb847276 [BrowserTest] no more iframes for Media test
Change-Id: I724e071935f383185fdc44cf1a139931f8ded557
2014-11-03 14:37:59 -07:00
Cmcmahon a51783983f [BrowserTest] no more iframes for Links test
Change-Id: I72c01981b332a32711e929543a61a780de962a2e
2014-11-03 14:18:21 -07:00
Roan Kattouw fe2895b145 MWReferenceGroupInputWidget: Remove dummy call to onInputChange()
This was needed to make the ComboBoxWidget initialize
its selection, but Idcbf38c53 makes that happen automatically.

Depends on Idcbf38c53 in oojs-ui.

Bug: 72783
Change-Id: I8d3a014f862ece7f4f201af205a8a7ca6c365eaa
2014-11-03 21:12:17 +00:00
jenkins-bot 48cfd29886 Merge "[BrowserTest] click More button, no iframes" 2014-11-03 20:59:37 +00:00
Cmcmahon 61f8cf7ca5 [BrowserTest] click More button, no iframes
Change-Id: I1426f4dcfb65d6e38be5f7e495e9600f98894525
2014-11-03 13:57:29 -07:00
James D. Forrester d0e62e1ab3 MWGalleryInspectorTool: Provide the tool in the toolbar
Now that the toolbar hides extra features by default, we don't need to
use autoAddToGroup and autoAddToCatchall over-rides.

Change-Id: I493f7d46a3f77e7c62af05f8e05ae4dde7147e4b
2014-11-03 11:19:04 -08:00
jenkins-bot 35a7931f10 Merge "[BrowserTest] no more iframes for Cite test" 2014-11-03 19:11:48 +00:00
Cmcmahon 3b57451863 [BrowserTest] no more iframes for Cite test
Change-Id: Ic31521dc8124818df1451a57ae396ca2e9c6beef
2014-11-03 11:57:55 -07:00
jenkins-bot b5e235ea85 Merge "Clean up LookupInputWidget subclasses and use new functionality" 2014-11-03 18:41:48 +00:00
Roan Kattouw a0167c08c7 Clean up LookupInputWidget subclasses and use new functionality
MWCategoryInputWidget:
* Use @inheritdoc
* Don't modify data parameter in getLookupCacheItemFromData()

MWLinkTargetInputWidget:
* Remove this.choosing in favor of setLookupsDisabled()
* Explicitly close menu on choose
* Remove manual emission of change events
** This looks ridiculous, it doesn't seem to be necessary,
   and it causes infinite event loops. But I'm very curious
   why this was added in the first place.
* Remove onLookupInputChange override that is now unnecessary
* Use {} rather than [] for fake empty result
* Prevent programmatic focus from opening the menu

MWTitleInputWidget:
* On choose, close menu and disable lookups while changing value
* Use @inheritdoc
* Remove mentions of "template" from getTitle() documentation

Bug fixed:
* When choosing a suggestion in MWTitleInputWidget,
  new suggestions would be loaded and the menu would reopen

Depends on Iecae9b582 in oojs-ui.

Change-Id: I716f99bb464a5cebd4f17701197f768e4e0e02a9
2014-11-03 10:39:03 -08:00
jenkins-bot e69bc55473 Merge "Pass $overlay to redirectTargetInput in MWSettingsPage" 2014-11-03 18:38:05 +00:00
Cmcmahon 282afbbb2f [BrowserTest] Resume Editing no longer in iframe
Also workaround for Bug 72911

Change-Id: Idbff05837dd97ace534ec732c0ba56b6b523bbe0
2014-11-03 11:02:23 -07:00
Cmcmahon df039a6ee9 [BrowserTest] stuff moved out of the iframe to the main page
step-wise update, probably more changes to come

Change-Id: Ia40c03dd59ab0b28af56176b6da4d30a1e66a195
2014-11-03 10:31:26 -07:00
Translation updater bot 3b3af61679 Localisation updates from https://translatewiki.net.
Change-Id: I13815ef4879f33268d517514dae14d4430340709
2014-11-02 22:00:55 +01:00
Translation updater bot 77454fb02a Localisation updates from https://translatewiki.net.
Change-Id: Ia873b55332f36f07e80bd384e2d10c0b51c183b1
2014-11-01 22:40:04 +01:00
Alex Monk 0dde78bd54 Pass $overlay to redirectTargetInput in MWSettingsPage
So the TOC options don't display over the top of suggestions for it

Bug: 72838
Change-Id: I73f0f9e3a44a9f641b6bed2a42cac2c8293cc5c9
2014-11-01 04:49:36 +00:00
jenkins-bot 8f8613f27b Merge "MWTransclusionDialog: Blur active input when switching modes" 2014-10-31 22:55:24 +00:00
jenkins-bot 1509e318a7 Merge "Add forgotten $overlay pass-through in MWReferenceDialog" 2014-10-31 22:54:15 +00:00
Translation updater bot b33ab8da4b Localisation updates from https://translatewiki.net.
Change-Id: Ice9530a321aba7e64d27c138569c2a7f94ec36a0
2014-10-31 21:47:26 +01:00
jenkins-bot 4df619c813 Merge "Update "page was last modified on date, at time" footer line when saving" 2014-10-31 05:24:58 +00:00
Roan Kattouw c324ed8b9a MWTransclusionDialog: Blur active input when switching modes
When show/hide options is clicked, the inputs in the main pane
move as the outline transitions in or out. This causes any dropdowns
below these inputs to become mispositioned: they don't move
because they're in an overlay.

To work around this problem, blur the active input when show/hide
options is clicked, so any dropdown attached to it is closed.
I tried blurring and immediately refocusing the active input to
force the dropdown to reposition itself, but that looks awkward
because of the transition (we'd have to wait for the transition
to complete before repositioning it, and during the transition
it'll stay open in the wrong place).

Bug: 72789
Change-Id: Ibd963690573af905066839f7276077089fa893c6
2014-10-31 04:19:41 +00:00
Alex Monk b2af92870a Update "page was last modified on date, at time" footer line when saving
Bug: 52403
Change-Id: I11e00066000e927f0551691d05fe11fe2ae125b0
2014-10-31 01:00:04 +00:00
Translation updater bot 7957ffa53c Localisation updates from https://translatewiki.net.
Change-Id: I1c44ba77871aa8807735127d04a7565acf0db6e7
2014-10-30 23:32:21 +01:00
Roan Kattouw 884aa1f243 Add forgotten $overlay pass-through in MWReferenceDialog
We were doing this for the exact same widget in
MWReferenceListDialog, but not here.

Bug: 72785
Change-Id: I4a905b944be44ec1aec5cdba7580283ec18c5c7c
2014-10-30 14:50:10 -07:00
Alex Monk b71bb51171 Remove more references to ve.bind
Seems some of them have crept back in since I1a7fc7f2 (and we missed one somehow)

Bug: 72156
Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
2014-10-30 20:55:44 +00:00
jenkins-bot c83961842c Merge "Preserve original data inside parameter objects too" 2014-10-30 20:47:32 +00:00
jenkins-bot 9a1ed3ce3d Merge "Toolbar: Make styling and insert menus collapsible" 2014-10-30 19:56:08 +00:00
James D. Forrester 6626450419 Toolbar: Make styling and insert menus collapsible
Also re-synchronise toolbar in MWMediaDialog and MWReferenceDialog.

Change-Id: I8cd5f0d9f7e188fa1a7ab8d34a2796340f5e99b7
2014-10-30 12:22:20 -07:00
Roan Kattouw a054a753be Preserve original data inside parameter objects too
Parsoid has added a "key" property to parameter objects,
so now we have to preserve that rather than regenerating
all parameter objects.

Do this by changing the existing use of this.originalData
to a deep extend.

Change-Id: Ib4d31c2e0f7b567da1a148b51c42e688a2590b8e
Bonus: avoid modifying this.originalData
2014-10-30 11:59:42 -07:00
Roan Kattouw 190ba17b74 Also add tableCaption to mwTable parentNodeTypes hack
Change-Id: Ic7e387bdb774699746e6bafb62daf9c843af77b5
2014-10-30 11:38:26 -07:00
jenkins-bot 3806a2838c Merge "Clear selection after tearing down surface to work around Firefox bug" 2014-10-29 23:21:36 +00:00
jenkins-bot 48e40fe3c2 Merge "MWTransclusionModel: Exclude parts serialising to '' from the plain object" 2014-10-29 23:20:48 +00:00
jenkins-bot 51df4d0f05 Merge "Add i18n for API module help" 2014-10-29 22:42:57 +00:00
Roan Kattouw f35d577acb Followup e0981a3: don't pass undefined to getClassAttrFromAttributes()
Change-Id: I987345cd923d1b128573f5669d4d0dd4e82db1c9
2014-10-29 14:50:50 -07:00
Translation updater bot 7ea182fa79 Localisation updates from https://translatewiki.net.
Change-Id: I21dc334f17f93a3c3d89d8d961fafda2ee288180
2014-10-29 22:08:10 +01:00
Brad Jorsch 7d4ecc09c8 Add i18n for API module help
MediaWiki core change I04b1a384 added support for i18n of API module
help. This takes advantage of that while still maintaining backwards
compatibility with earlier versions of MediaWiki.

Once support for MediaWiki before 1.25 is dropped, the methods marked
deprecated in this patch may be removed.

Change-Id: I67395aff48185f3e09da31b51a08aa2541fe6a17
2014-10-29 13:59:41 -07:00
jenkins-bot dcb14bc9bf Merge "Hide page status indicators even if they aren't :visible" 2014-10-29 20:59:00 +00:00
Bartosz Dziewoński 2a55baaef7 Hide page status indicators even if they aren't :visible
The container is zero-height and zero-width, so jQuery doesn't
consider it :visible, and yet it still takes up visual space.

Bug: 72693
Change-Id: I3bed5394a2a64a9f7f0a331f850aa412b5b11b7d
2014-10-29 21:52:38 +01:00
Ed Sanders e0981a327f Create mwTables with wikitable attribute by default
Change-Id: I094b1823248e16dd3b9a0a10ba13104f14798621
2014-10-29 12:52:24 -07:00
James D. Forrester cc8f6970a5 Update VE core submodule to master (f4ff1d6)
New changes:
d845991 Data model implementation for tables
a27c148 ContentEditable implementation for tables
3c47428 Actions and context menus for manipulating tables
543ca54 Support annotation tool on table selections
149cf3d Supporting copy paste of single table cells
25c9eee Table header/data format tools
e557e46 Merge cells tool
afcf2d9 Allow custom type and attributes when creating a table

Local changes:
Add the files and messages for table editing

Change-Id: I6e6c33b96d3089049a0fd5385191caa83df5756b
2014-10-29 11:52:09 -07:00
Ed Sanders cfee8047e4 Use ClassAttributeNode mixin in MWBlockImageNode
This functionality was factored out into core for this purpose.

Depends on I2db6563 in core.

Change-Id: I4fc42e1468a9f0860c7c13e73967204bdf5ad78d
2014-10-29 18:28:33 +00:00
suchetag c6f7f361c2 Introducing isValid() in MWTitileInputWidget
A method isValid() is added to MWTitleInputWidget which would validate the titles given as inputs

Bug: 71249
Change-Id: I7749165652bd3c0bb08ca42289a425fe8e25483d
2014-10-29 11:13:42 -07:00
suchetag 9191465039 Introducing getTitle() in MWTitleInputWidget
A method for getTitle() is added which can return the valid title,
or, it can return null, in case the value isn't a valid title

Bug: 72468
Change-Id: I8a13afc9a66c167fe25010743c0d9e1424133d96
2014-10-29 18:12:04 +00:00
Amir E. Aharoni b4e98c1490 [BrowserTest] Disable two failing scenarios
To allow other screenshots to be created.

Change-Id: I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
2014-10-29 09:44:55 +00:00
Alex Monk a982d2d3fe MWTransclusionModel: Exclude parts serialising to '' from the plain object
So we get rid of empty content nodes

Bug: 63341
Change-Id: I1d49cc709bf92cc53ba064d148a76650c5143935
2014-10-29 01:08:41 +00:00
Roan Kattouw d68eae6c8d Clear selection after tearing down surface to work around Firefox bug
Bug: 71852
Change-Id: I3b4f0f755ece5c9e5444f8abadb1950a3f4ef318
2014-10-28 11:23:06 -07:00
jenkins-bot d73a692f57 Merge "Show warning on reference dialog when editing a reference used in more than one place" 2014-10-28 17:36:07 +00:00
jenkins-bot 538c8769a6 Merge "Move core/MW messages to correct sections" 2014-10-28 17:31:50 +00:00
jenkins-bot 78b2a2885c Merge "Pass $overlay to widgets that need it" 2014-10-28 17:30:57 +00:00
Ed Sanders b89510c18b Move core/MW messages to correct sections
Also bring in visualeditor-version-label message from core.

Change-Id: I91ceba0e0550239a10329b327b5c6b5a01e460a9
2014-10-28 17:30:19 +00:00
jenkins-bot 5eb0baf55d Merge "Sprinke some child selectors around in MWTransclusionDialog.css" 2014-10-28 16:55:27 +00:00
jenkins-bot 1cc342a462 Merge "Put icons back in template parameter search" 2014-10-28 16:48:52 +00:00
Translation updater bot 47115a9e4e Localisation updates from https://translatewiki.net.
Change-Id: I84552cda584f0078f60955c1872178b820beefe7
2014-10-28 15:21:02 +01:00
Alex Monk 3846e20463 Show warning on reference dialog when editing a reference used in more than one place
Bug: 52792
Change-Id: I2b183c3867ddb601041f9989964aa6f78b5f37e4
2014-10-28 12:58:50 +00:00
jenkins-bot ef90da1484 Merge "Override overflow: hidden; for <h3>s in the command help dialog" 2014-10-28 09:58:03 +00:00
Roan Kattouw 97dcee132d Put icons back in template parameter search
These disappeared when DecoratedOptionWidget was split
out of OptionWidget in I508c1555 in oojs-ui back in July,
and apparently no one noticed.

Make MWParameterResultWidget and MWMoreParameterResultWidget
inherit DecoratedOptionWidget instead of OptionWidget so
the icon config parameter is recognized again.

Change-Id: I08d8a0466c211a29eb62043131725073dece4eb5
2014-10-28 01:32:22 +00:00
Roan Kattouw 5876014c8f Override overflow: hidden; for <h3>s in the command help dialog
When this dialog is not isolated, MediaWiki's overflow: hidden;
rules for headings cut off part of the text in the <h3>s.

Compensates for Id425c56d9d24 in VE core.

Change-Id: Id9f6bd2bdbed0c6fe57e897c2415c3eceff900a6
2014-10-27 17:51:46 -07:00
Roan Kattouw 33c5b38b64 Remove oo-ui-{ltr,rtl} special-casing for parameter icons
It works both with and without in isolated dialogs,
but styling things this way breaks in non-isolated dialogs.

Change-Id: Ia498b48d8c199f50df326ddeb61d958cbe2c520d
2014-10-27 17:49:42 -07:00
Roan Kattouw d0f273d6db Sprinke some child selectors around in MWTransclusionDialog.css
Indiscriminately styling all .oo-ui-widget elements with a
descendant selector is very evil, use a child selector instead.
The use of a descendant selector broke inline dropdowns.

Change-Id: I25c5007ef1ffab9e59c46c3b11270b8f77610327
2014-10-27 17:38:20 -07:00
Roan Kattouw 61e8115e8b Pass $overlay to widgets that need it
Also change this.$overlay (which doesn't even exist) to
config.$overlay in MWTemplatePlaceholderPage and document it.

Compensates for I39df86373ea in oojs-ui.

Change-Id: I4a233c058439d6cfb38d80ece890c8fe57d58f49
2014-10-27 17:36:19 -07:00
jenkins-bot 0dad360036 Merge "Disable parameter add icon when there's no transclusion parts" 2014-10-27 20:39:46 +00:00
Alex Monk d128378f5a Disable parameter add icon when there's no transclusion parts
Would put this code in onBookletLayoutSet, but that doesn't appear to be
getting called in this case.

Have to detect whether or not we should be changing the disabled status, rather
than just setting it straight away, which would break every other case where
onBookletLayoutSet is called.

Bug: 63158
Change-Id: I6f62479291424d9b2ee0e42481dec9d085169c63
2014-10-27 20:33:35 +00:00
Translation updater bot dfd00e83c6 Localisation updates from https://translatewiki.net.
Change-Id: I5d874f7c0cfa4bdfcca99b7336efe9de03cfb356
2014-10-27 20:21:32 +01:00
jenkins-bot 4e8cf83265 Merge "Apply pre-save transform to template previews" 2014-10-27 18:38:40 +00:00
jenkins-bot 20b20bc97c Merge "Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel" 2014-10-27 18:15:08 +00:00
jenkins-bot 1f4e77bc05 Merge "Allow removing all parts from a transclusion to remove the transclusion" 2014-10-27 18:13:08 +00:00
Ed Sanders ab365ccacc Fix selection check in wikitext warning
Change-Id: I2f084eb4ee29bd166b05163cd2d6e64e0a4f136d
2014-10-27 16:21:24 +00:00
Alex Monk 8120dac27b Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel
Also add missing MWParameterModel#getDefaultValue

Bug: 72404
Change-Id: I4bb117d419f3845f44e321f848e95bb246a24e24
2014-10-27 03:31:36 +00:00
jenkins-bot 358268be7a Merge "Make sure initialHash exists before checking its value" 2014-10-27 03:25:10 +00:00
Translation updater bot f4a5139012 Localisation updates from https://translatewiki.net.
Change-Id: Icb816a369cf513f88bc05a6792f6ed7aa484fbad
2014-10-25 22:48:51 +02:00
Alex Monk c4dfd834dd Allow removing all parts from a transclusion to remove the transclusion
Rather than make a new function to determine whether it should be apply-able or
not (and run some checks again), move the enable/disable call into a new
function to do these checks and set the result.

Bug: 72191
Change-Id: I133afa1784e1afd44054f93ed84018894f7c6400
2014-10-25 00:13:29 +01:00
Moriel Schottlender b8f96bb512 Make sure initialHash exists before checking its value
(Followup on If17b50cc4a39993)
Make sure initialHash is set before checking and changing its value
in the MWImageModel method. If a user chooses a brand new image to
insert into the document (an insertion rather than update) then the
initial hash is empty, and changing its values will fail with an
error message.

Bug: 72492
Change-Id: I3f9ea74891cc0ab77a07fa5d4e9cbc591f5b93e6
2014-10-24 16:18:06 -04:00
jenkins-bot 5d6ee06b84 Merge "Fix wikitext warning: Get range from selection before trying to find start" 2014-10-24 17:27:44 +00:00
Alex Monk 4639a1c044 Fix wikitext warning: Get range from selection before trying to find start
Bug: 72475
Change-Id: Ib43d9c6b9b46be461354b3b5bbdf9d5de90887a6
2014-10-24 17:18:08 +01:00
Marielle Volz 2ac7959849 Methods for new "maps" property in TD Root
Methods for new "maps" property in
Template Data JSON root added to
the Template Specification Model

* Added maps property to MWTemplateSpecModel
* Maps filled in extend function
* Added getter function for maps

Depends on I3bf5e002

Change-Id: Ic555093625358d8fc4cb1ca8c68793b5912e8ced
2014-10-24 14:23:46 +01:00
suchetag 0b983d9f82 Add template button remains disabled when entering space as a template
Bug: 71998
Change-Id: I69edcf7ece1ccd02df8fbae20a8149e8a1981a44
2014-10-24 06:54:00 +05:30
Translation updater bot 263f28b09d Localisation updates from https://translatewiki.net.
Change-Id: I812e93679a651cabb7cb96ee14757e2ba601be27
2014-10-23 23:27:41 +02:00
jenkins-bot 7c8931f655 Merge "Update initialHash after getting defaultDimensions in image model" 2014-10-23 20:00:20 +00:00
Roan Kattouw 36060a2782 Apply pre-save transform to template previews
Because autoValues often involve {{subst:}}

Bug: 71157
Change-Id: I2787f2595f8c4b8838a3e9ac9ba898af0b43b58e
2014-10-22 15:47:51 -07:00